summaryrefslogtreecommitdiff
path: root/src/plugins/git/gerrit
Commit message (Collapse)AuthorAgeFilesLines
* Git: Use LayoutBuilder in Gerrit options pagehjk2023-05-084-84/+78
| | | | | | | | Move towards using aspects and away from IOptionPage's QObject base. Change-Id: I07850a6b8e9fa7d2591efc6f76a23f249dfc164f Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Small simplification to Gerrit "plugin" setuphjk2023-05-082-6/+6
| | | | | | | | The indirection is not needed. It's not really stand-alone, and not touched before GitPlugin::initialize(). Change-Id: If8552dc69ff9efa18a3f1d6d998a8f28ab65e501 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Rename qtcprocess.{cpp,h} -> process.{cpp,h}Jarek Kobus2023-05-042-2/+2
| | | | | | | | Follows QtcProcess -> Process rename. Change-Id: I97235a9a40cb7fd52944515b7ab878d96528f919 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Utils: Rename QtcProcess -> ProcessJarek Kobus2023-05-042-9/+9
| | | | | | | | Task-number: QTCREATORBUG-29102 Change-Id: Ibc264f9db6a32206e4097766ee3f7d0b35225a5c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: hjk <hjk@qt.io>
* Utils: Make Layouting a top level namespacehjk2023-04-251-1/+1
| | | | | | | | | | The whole machinery is now almost only layoutbuilder.{h,cpp}, mostly independent of the rest of Utils. Idea is to finish the separation to make it stand-alone usable also outside creator. Change-Id: I958aa667d17ae26b21209f22412309c5307a579c Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Git: Use IOptionPage::setWidgetCreator() for gerrit settingshjk2023-04-202-128/+78
| | | | | Change-Id: I7402f3342bb11726ec7383c807fa98052cb38bd8 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Fix explanation in GerritPushDialogRobert Löhning2023-03-271-1/+1
| | | | | | | Change-Id: I527414dc3948a009099ec993c0f71d3501394ecd Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Proliferate Tr::tr in various placesAlessandro Portale2023-02-101-14/+16
| | | | | | | | | | This changes several tr() calls which were either missed during Tr::tr- ization or were added later. Found with regular expression: (?<!(Tr::)|([\w]))tr\( Change-Id: I1c0c03589e941614a7a8449ecfebc7d2cad396c3 Reviewed-by: hjk <hjk@qt.io>
* Translations: Remove stray Q_DECLARE_TR_FUNCTIONS(...)Alessandro Portale2023-02-101-2/+0
| | | | | | | | And handle the consequences in qmakebuildconfiguration.cpp. Change-Id: Ic24d99927254e8d16decea49b880a2446bf322e6 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Translations: Remove header includes of *tr.h in .h filesAlessandro Portale2023-02-081-2/+3
| | | | | | | | | The wrong Tr::tr could be executed by code indirectly including a *tr.h file from another module. To Translate in a header file, use QCoreApplication::tr(). Change-Id: I30e67245991d2c2f0eeb01ab356555bdb9841af0 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Translations: Fix stray QApplication::translate() callsAlessandro Portale2023-02-081-4/+2
| | | | | | | | | For references to the module-own context, use Tr::tr(). For references to other modules, use the right context name (with "::" prefix). Change-Id: I6dce8f1ceccb23c44d93f1826402cd3be8e98e5a Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* VcsBase: Proliferate use of FilePathhjk2023-01-201-1/+1
| | | | | | | ... and update user code. Change-Id: I52c08e9e07238536d31fc72f97312ac582a1e32f Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Rename QtcProcess::readAllStandard* to readAllRawStandard*hjk2023-01-102-4/+4
| | | | | | | | | | | | ... and re-use the old QtcProcess::readAllStandard* names for a QString-returning 'decoded' version. For now, only use that in 'full Utf8' cases, to stay bug-compatible, the plan is, however, to employ the QTextCodecs we have already in the channel buffers. That will be one-by-one, though. Change-Id: Id209e0671920d4ea4197918e872f441254112d52 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Utils: Rename most FilePath::{from,to}Variant uses to {from,to}Settingshjk2023-01-101-4/+4
| | | | | | | | Specifies the main purpose more clearly. The remaining ones a "true" (internal) variants in models and as action data. Change-Id: I8dd3c846e419f29d88283c2f48268ef6685b19fe Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Remove GPL-3.0+ from license identifiersKai Köhne2023-01-0620-20/+20
| | | | | | | | | | | | | | | Since we also license under GPL-3.0 WITH Qt-GPL-exception-1.0, this applies only to a hypothetical newer version of GPL, that doesn't exist yet. If such a version emerges, we can still decide to relicense... While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only Change was done by running find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR GPL-3.0 WITH Qt-GPL-exception-1.0/LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0/g" {} \; Change-Id: I5097e6ce8d10233993ee30d7e25120e2659eb10b Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* GerritModel: Reuse ProcessProgressJarek Kobus2023-01-041-28/+13
| | | | | Change-Id: I229ab2cbb8137b6e1debe86eaa462110fdcc337e Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* GerritPlugin: Reuse ProcessProgressJarek Kobus2023-01-041-99/+24
| | | | | | | | Get rid of unneeded State enum, future watcher and future interface. Change-Id: Id217d557c9051479cd3da872c1661c163cdf3a21 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git/VCS: Use ctrlc stub for process executionOrgad Shaneh2022-12-152-0/+2
| | | | | | | | | | | | | | | | This ensures that child processes are also terminated. Required specifically for Git on Windows, when running in cmd directory, which spawns a child process for usr/bin/git. On this case, if git takes long to finish and is aborted while running, the main process was killed as expected, but the child process remained alive. Task-number: QTCREATORBUG-27567 Change-Id: I40271eb42cfaefd81f2fe5af138254ab0a2c8da8 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io> Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* VcsBase & dependent: Fix const correctnessJarek Kobus2022-12-142-15/+8
| | | | | | | And some minor cleanups. Change-Id: Id0c2df6865ba84c054f0fb97c0ac42a76a128355 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsBase: Pass context object to lambda connectionsJarek Kobus2022-12-073-6/+6
| | | | | | | | Remove some unneeded lambda () brackets. Change-Id: I20e43625793401544e86efb627f5921c395026bb Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Git: GerritPushDialog: Use LayoutingJarek Kobus2022-11-183-364/+142
| | | | | Change-Id: I5b0a95680e683cf6e5b938b4a4a74bfc0c5b45e2 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Port from qAsConst() to std::as_const()Marc Mutz2022-10-072-2/+2
| | | | | | | | | | | | | | We've been requiring C++17 since Qt 6.0, and our qAsConst use finally starts to bother us (QTBUG-99313), so time to port away from it now. Since qAsConst has exactly the same semantics as std::as_const (down to rvalue treatment, constexpr'ness and noexcept'ness), there's really nothing more to it than a global search-and-replace. Task-number: QTBUG-99313 Change-Id: I88edd91395849574436299b8badda21bb93bea39 Reviewed-by: hjk <hjk@qt.io>
* Git: Fix include directiveChristian Kandeler2022-10-071-1/+1
| | | | | | | | Change-Id: I35aff37fff00f020044c84ef288234146ebd5ade Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Git: Convert to Tr::trAlessandro Portale2022-10-067-72/+81
| | | | | Change-Id: I7fb1753109a9263c70c01713f5f4895db6b73662 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* VcsBase: Move RunFlags into separate headerJarek Kobus2022-10-061-2/+2
| | | | | | | | | It is going to be used outside of VcsCommand, too. Use RunFlags enum as an argument to several functions instead of unsigned. Change-Id: I355c80a845a9b5982108fbde3412754392dce702 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsManager: Use more FilePathJarek Kobus2022-10-052-15/+12
| | | | | Change-Id: I255372c47e6d3ea55e5f8060c3c2fdd9bd155c75 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Various plugins: Limit the usage of qMakePairJarek Kobus2022-09-301-1/+1
| | | | | Change-Id: I9113dd47fb4f9026f3a732aebbd0aee31651b727 Reviewed-by: hjk <hjk@qt.io>
* VcsBase: Rename vcsFullySynchronousExec into vcsSynchronousExecJarek Kobus2022-09-021-5/+5
| | | | | | | | Get rid of original vcsSynchronousExec(), as it was calling vcsFullySynchronousExec(). Change-Id: I911dc786d54c34c211d03661c37df9b58d60a20b Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use SPDX license identifiersLucie Gérard2022-08-2620-480/+40
| | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. Task-number: QTBUG-67283 Change-Id: I708fd1f9f2b73d60f57cc3568646929117825813 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* VCS: Use qtcEnvironmentVariable* instead of qEnvironmentVariable*Eike Ziller2022-08-261-1/+2
| | | | | | | | | | | | And instead of qgetenv. Takes Qt Creator's setting at "Environment > System > Environment" into account, which makes it easier on some platforms to set them (e.g. macOS), can be configured differently in different settings paths, and potentially can be changed at runtime (depending on usage). Change-Id: I364e5b663353f37121279a58f4a9fd514cddbbf0 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: inline gerritdialog.uihjk2022-08-043-359/+146
| | | | | | Change-Id: Idefdd93a80ac87b9798bf2654413a5c78882b391 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Merge remote-tracking branch 'origin/8.0'hjk2022-08-031-1/+1
|\ | | | | | | Change-Id: I1dc664137eeecb7dd69f29af7a08164683d51077
| * Gerrit: Do not pass username to curl for REST requestsOrgad Shaneh2022-08-031-1/+1
| | | | | | | | | | | | | | | | | | | | It is set in .netrc anyway, and there is a regression in curl that causes it to fail when passing the user name. See https://github.com/curl/curl/issues/8653 Change-Id: Ic7aa2d874884db71f71d162486acf4e054eab7e9 Reviewed-by: hjk <hjk@qt.io>
* | Gerrit: Show command and failures in testConnectionOrgad Shaneh2022-08-031-2/+1
| | | | | | | | | | | | | | Can be useful when authentication fails. Change-Id: Ibd3700c4ce9cc76b0d9c4cde32730a4e1906ccd6 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | Gerrit: Refresh server details also when authenticated is changedOrgad Shaneh2022-08-031-1/+2
| | | | | | | | | | | | | | | | | | For example, if the server was not authenticated, and .netrc was edited outside Qt Creator. Change-Id: Ib28b6e924e3fab958410da49ceb45ed4269e195b Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io> Reviewed-by: hjk <hjk@qt.io>
* | Gerrit: inline authenticationdialog.uihjk2022-08-033-157/+75
| | | | | | | | | | | | | | | | | | | | | | | | Also, replace /#/settings/http-password by /#/settings/#HTTPCredentials There should probably be some stretch between the form and the buttonbox, but it wasn't there in the .ui so I left it out for now. Change-Id: Ie07a3283261a1070a489e454f9fb86c0c6dc2ca8 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* | Move ShellCommand into VcsBase pluginJarek Kobus2022-08-011-5/+7
| | | | | | | | | | | | | | | | | | | | Rename it to VcsCommand. Move also ShellCommandPage into VcsBase plugin. Change-Id: I335ac47e3090f2be497643ebcda0eaad2987ac81 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | ShellCommand: Introduce CommandResult structureJarek Kobus2022-07-291-15/+14
| | | | | | | | | | | | | | | | | | Don't require QtcProcess instance when calling ShellCommand::runCommand(). Change-Id: Ie0287d91c1807465eab12be7eaa2eac561179af7 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | Drop Qt5: VCS: Get rid of QComboBox QOverloadJarek Kobus2022-07-191-2/+2
| | | | | | | | | | Change-Id: Ib2f21f28a0ec16b817f9227c6234424001752d50 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | Remove Core::ShellCommandJarek Kobus2022-07-111-6/+4
|/ | | | | | | | Move the implementation into VcsCommand. Use Utils::ShellCommand inside coreplugin API. Change-Id: I74a34057b33832a138b05f1dfa6937565027edb4 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* QueryContext: Connect to done() signal instead of finished()Jarek Kobus2022-06-211-1/+1
| | | | | Change-Id: I642138a90c4e13fcdb4dbb065e26aa5e3d509b9e Reviewed-by: hjk <hjk@qt.io>
* Utils: use cleaned stdout all over the place againDavid Schulz2022-06-171-4/+4
| | | | | | | Amends 5ee880ce5e6998170823e6fc9afb6b6c36c6170a Change-Id: Ie0202db7d8455372c3697087d9571db6706b45a1 Reviewed-by: hjk <hjk@qt.io>
* FetchContext: Connect to done() signalJarek Kobus2022-06-161-34/+17
| | | | | | | | Instead of connecting to errorOccurred() and finished() signals. Change-Id: I16e0de8422be989bf56cc6c5b865966f97013731 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Replace QtcProcess::stopProcess() by stop() plus waitForFinishedhjk2022-06-162-2/+4
| | | | | | | ... or nothing, if the process object is destroyed immediately. Change-Id: I6a1e1928bc49fc20a1c0e0ee9b8f4f723276bbca Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* QtcProcess: Forward declare Environment in QtcProcess headerJarek Kobus2022-05-092-0/+2
| | | | | | Change-Id: If85a8a07b144c94cb6e45f66dcb06573ef07c777 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: hjk <hjk@qt.io>
* GerritModel: Connect to QtcProcess::done() signalJarek Kobus2022-04-271-23/+14
| | | | | | | | | Instead of connecting to errorOccurred() and finished() signals. Change-Id: Ibd5afa812cc9f8781984b649c9cb85a8703e9c8e Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Remove extra margins in the Gerrit DialogAlessandro Portale2022-04-041-0/+12
| | | | | | | | | The margins in the Gerrit dialog stand out compared to other ui in Qt Creator, and they occupy space. Fixes: QTCREATORBUG-27217 Change-Id: I8caf3c793741bd37580633b8829b9f96b24627aa Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Gerrit: Skip non-Gerrit remotes in Push to Gerrit dialogAndre Hartmann2022-03-282-9/+11
| | | | | | | | | In my case, I have a second remote gitlab which was always selected instead the expected remote gerrit. Change-Id: I7860ea4743dbfa5d1fd4375821474950549e0600 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* QtcProcess: Limit the inclusion of qtcprocess.hJarek Kobus2022-03-021-2/+2
| | | | | | | | | | Move the rest of QtcProcess enums to processenums.h. Move ExitCodeInterpreter into processenums.h. Remove superfluous Utils:: prefix. Change-Id: Iaa596f353d33d6930085a621b114cc15a35caa80 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Register some more windowsEike Ziller2022-02-091-0/+1
| | | | | | | | So they get an entry in the Window menu, and window related shortcuts are registered correctly. Change-Id: Ie7e882a009f928f1268fdd312e7fb5362f6a837f Reviewed-by: Christian Stenger <christian.stenger@qt.io>
View Lorry Controller Status