1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
|
/****************************************************************************
**
** Copyright (C) 2015 The Qt Company Ltd.
** Contact: http://www.qt.io/licensing/
**
** This file is part of the test suite of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:LGPL$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see http://www.qt.io/terms-conditions. For further
** information use the contact form at http://www.qt.io/contact-us.
**
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 or version 3 as published by the Free
** Software Foundation and appearing in the file LICENSE.LGPLv21 and
** LICENSE.LGPLv3 included in the packaging of this file. Please review the
** following information to ensure the GNU Lesser General Public License
** requirements will be met: https://www.gnu.org/licenses/lgpl.html and
** http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** As a special exception, The Qt Company gives you certain additional
** rights. These rights are described in The Qt Company LGPL Exception
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3.0 as published by the Free Software
** Foundation and appearing in the file LICENSE.GPL included in the
** packaging of this file. Please review the following information to
** ensure the GNU General Public License version 3.0 requirements will be
** met: http://www.gnu.org/copyleft/gpl.html.
**
** $QT_END_LICENSE$
**
****************************************************************************/
#include <QDir>
#include <QFile>
#include <QRegExp>
#include <QStringList>
#include <QTest>
#include <QSet>
#include <QProcess>
#include <QDebug>
enum FindSubdirsMode {
Flat = 0,
Recursive
};
class tst_MakeTestSelfTest: public QObject
{
Q_OBJECT
private slots:
void tests_auto_pro();
void tests_pro_files();
void tests_pro_files_data();
void naming_convention();
void naming_convention_data();
void make_check();
private:
QStringList find_subdirs(QString const&, FindSubdirsMode, QString const& = QString());
QSet<QString> all_test_classes;
};
bool looks_like_testcase(QString const&,QString*);
bool looks_like_subdirs(QString const&);
QStringList find_test_class(QString const&);
/*
Verify that auto.pro only contains other .pro files (and not directories).
We enforce this so that we can process every .pro file other than auto.pro
independently and get all the tests.
If tests were allowed to appear directly in auto.pro, we'd have the problem
that we need to somehow run these tests from auto.pro while preventing
recursion into the other .pro files.
*/
void tst_MakeTestSelfTest::tests_auto_pro()
{
QStringList subdirsList = find_subdirs(SRCDIR "/../auto.pro", Flat);
if (QTest::currentTestFailed()) {
return;
}
foreach (QString const& subdir, subdirsList) {
QVERIFY2(subdir.endsWith(".pro"), qPrintable(QString(
"auto.pro contains a subdir `%1'.\n"
"auto.pro must _only_ contain other .pro files, not actual subdirs.\n"
"Please move `%1' into some other .pro file referenced by auto.pro."
).arg(subdir)));
}
}
/* Verify that all tests are listed somewhere in one of the autotest .pro files */
void tst_MakeTestSelfTest::tests_pro_files()
{
static QStringList lines;
if (lines.isEmpty()) {
QDir dir(SRCDIR "/..");
QStringList proFiles = dir.entryList(QStringList() << "*.pro");
foreach (QString const& proFile, proFiles) {
QString filename = QString("%1/../%2").arg(SRCDIR).arg(proFile);
QFile file(filename);
if (!file.open(QIODevice::ReadOnly)) {
QFAIL(qPrintable(QString("open %1: %2").arg(filename).arg(file.errorString())));
}
while (!file.atEnd()) {
lines << file.readLine().trimmed();
}
}
}
QFETCH(QString, subdir);
QRegExp re(QString("( |=|^|#)%1( |\\\\|$)").arg(QRegExp::escape(subdir)));
foreach (const QString& line, lines) {
if (re.indexIn(line) != -1) {
return;
}
}
QFAIL(qPrintable(QString(
"Subdir `%1' is missing from tests/auto/*.pro\n"
"This means the test won't be compiled or run on any platform.\n"
"If this is intentional, please put the test name in a comment in one of the .pro files.").arg(subdir))
);
}
void tst_MakeTestSelfTest::tests_pro_files_data()
{
QTest::addColumn<QString>("subdir");
QDir dir(SRCDIR "/..");
QStringList subdirs = dir.entryList(QDir::AllDirs|QDir::NoDotAndDotDot);
foreach (const QString& subdir, subdirs) {
if (subdir == QString::fromLatin1("tmp")
|| subdir.startsWith("."))
{
continue;
}
QTest::newRow(qPrintable(subdir)) << subdir;
}
}
QString format_list(QStringList const& list)
{
if (list.count() == 1) {
return list.at(0);
}
return QString("one of (%1)").arg(list.join(", "));
}
void tst_MakeTestSelfTest::naming_convention()
{
QFETCH(QString, subdir);
QFETCH(QString, target);
QDir dir(SRCDIR "/../" + subdir);
QStringList cppfiles = dir.entryList(QStringList() << "*.h" << "*.cpp");
if (cppfiles.isEmpty()) {
// Common convention is to have test/test.pro and source files in parent dir
if (dir.dirName() == "test") {
dir.cdUp();
cppfiles = dir.entryList(QStringList() << "*.h" << "*.cpp");
}
if (cppfiles.isEmpty()) {
QSKIP("Couldn't locate source files for test", SkipSingle);
}
}
QStringList possible_test_classes;
foreach (QString const& file, cppfiles) {
possible_test_classes << find_test_class(dir.path() + "/" + file);
}
if (possible_test_classes.isEmpty()) {
QSKIP(qPrintable(QString("Couldn't locate test class in %1").arg(format_list(cppfiles))), SkipSingle);
}
QVERIFY2(possible_test_classes.contains(target), qPrintable(QString(
"TARGET is %1, while test class appears to be %2.\n"
"TARGET and test class _must_ match so that all testcase names can be accurately "
"determined even if a test fails to compile or run.")
.arg(target)
.arg(format_list(possible_test_classes))
));
QVERIFY2(!all_test_classes.contains(target), qPrintable(QString(
"It looks like there are multiple tests named %1.\n"
"This makes it impossible to separate results for these tests.\n"
"Please ensure all tests are uniquely named.")
.arg(target)
));
all_test_classes << target;
}
void tst_MakeTestSelfTest::naming_convention_data()
{
QTest::addColumn<QString>("subdir");
QTest::addColumn<QString>("target");
foreach (const QString& subdir, find_subdirs(SRCDIR "/../auto.pro", Recursive)) {
if (QFileInfo(SRCDIR "/../" + subdir).isDir()) {
QString target;
if (looks_like_testcase(SRCDIR "/../" + subdir + "/" + QFileInfo(subdir).baseName() + ".pro", &target)) {
QTest::newRow(qPrintable(subdir)) << subdir << target.toLower();
}
}
}
}
/*
Returns true if a .pro file seems to be for an autotest.
Running qmake to figure this out takes too long.
*/
bool looks_like_testcase(QString const& pro_file, QString* target)
{
QFile file(pro_file);
if (!file.open(QIODevice::ReadOnly)) {
return false;
}
*target = QString();
bool loaded_qttest = false;
do {
QByteArray line = file.readLine();
if (line.isEmpty()) {
break;
}
line = line.trimmed();
line.replace(' ', "");
if (line == "load(qttest_p4)") {
loaded_qttest = true;
}
if (line.startsWith("TARGET=")) {
*target = QString::fromLatin1(line.mid(sizeof("TARGET=")-1));
if (target->contains('/')) {
*target = target->right(target->lastIndexOf('/')+1);
}
}
if (loaded_qttest && !target->isEmpty()) {
break;
}
} while(1);
if (!loaded_qttest) {
return false;
}
if (!target->isEmpty() && !target->startsWith("tst_")) {
return false;
}
// If no target was set, default to tst_<dirname>
if (target->isEmpty()) {
*target = "tst_" + QFileInfo(pro_file).baseName();
}
return true;
}
/*
Returns true if a .pro file seems to be a subdirs project.
Running qmake to figure this out takes too long.
*/
bool looks_like_subdirs(QString const& pro_file)
{
QFile file(pro_file);
if (!file.open(QIODevice::ReadOnly)) {
return false;
}
do {
QByteArray line = file.readLine();
if (line.isEmpty()) {
break;
}
line = line.trimmed();
line.replace(' ', "");
if (line == "TEMPLATE=subdirs") {
return true;
}
} while(1);
return false;
}
/*
Returns a list of all subdirs in a given .pro file
*/
QStringList tst_MakeTestSelfTest::find_subdirs(QString const& pro_file, FindSubdirsMode mode, QString const& prefix)
{
QStringList out;
QByteArray features = qgetenv("QMAKEFEATURES");
if (features.isEmpty()) {
features = SRCDIR "/features";
}
else {
features.prepend(SRCDIR "/features"
#ifdef Q_OS_WIN32
";"
#else
":"
#endif
);
}
QStringList args;
args << pro_file << "-o" << SRCDIR "/dummy_output" << "CONFIG+=dump_subdirs";
/* Turn on every option there is, to ensure we process every single directory */
args
<< "QT_CONFIG+=dbus"
<< "QT_CONFIG+=declarative"
<< "QT_CONFIG+=egl"
<< "QT_CONFIG+=multimedia"
<< "QT_CONFIG+=OdfWriter"
<< "QT_CONFIG+=opengl"
<< "QT_CONFIG+=openvg"
<< "QT_CONFIG+=phonon"
<< "QT_CONFIG+=private_tests"
<< "QT_CONFIG+=pulseaudio"
<< "QT_CONFIG+=qt3support"
<< "QT_CONFIG+=script"
<< "QT_CONFIG+=svg"
<< "QT_CONFIG+=webkit"
<< "QT_CONFIG+=xmlpatterns"
<< "CONFIG+=mac"
<< "CONFIG+=embedded"
<< "CONFIG+=symbian"
;
QString cmd_with_args = QString("qmake %1").arg(args.join(" "));
QProcess proc;
proc.setProcessChannelMode(QProcess::MergedChannels);
QProcessEnvironment env = QProcessEnvironment::systemEnvironment();
env.insert("QMAKEFEATURES", features);
proc.setProcessEnvironment(env);
proc.start("qmake", args);
if (!proc.waitForStarted(10000)) {
QTest::qFail(qPrintable(QString("Failed to run qmake: %1\nCommand: %2")
.arg(proc.errorString())
.arg(cmd_with_args)),
__FILE__, __LINE__
);
return out;
}
if (!proc.waitForFinished(30000)) {
QTest::qFail(qPrintable(QString("qmake did not finish within 30 seconds\nCommand: %1\nOutput: %2")
.arg(proc.errorString())
.arg(cmd_with_args)
.arg(QString::fromLocal8Bit(proc.readAll()))),
__FILE__, __LINE__
);
return out;
}
if (proc.exitStatus() != QProcess::NormalExit) {
QTest::qFail(qPrintable(QString("qmake crashed\nCommand: %1\nOutput: %2")
.arg(cmd_with_args)
.arg(QString::fromLocal8Bit(proc.readAll()))),
__FILE__, __LINE__
);
return out;
}
if (proc.exitCode() != 0) {
QTest::qFail(qPrintable(QString("qmake exited with code %1\nCommand: %2\nOutput: %3")
.arg(proc.exitCode())
.arg(cmd_with_args)
.arg(QString::fromLocal8Bit(proc.readAll()))),
__FILE__, __LINE__
);
return out;
}
QList<QByteArray> lines = proc.readAll().split('\n');
if (!lines.count()) {
QTest::qFail(qPrintable(QString("qmake seems to have not output anything\nCommand: %1\n")
.arg(cmd_with_args)),
__FILE__, __LINE__
);
return out;
}
foreach (QByteArray const& line, lines) {
static const QByteArray marker = "Project MESSAGE: subdir: ";
if (line.startsWith(marker)) {
QString subdir = QString::fromLocal8Bit(line.mid(marker.size()).trimmed());
out << prefix + subdir;
if (mode == Flat) {
continue;
}
// Need full path to subdir
QString subdir_filepath = subdir;
subdir_filepath.prepend(QFileInfo(pro_file).path() + "/");
// Add subdirs recursively
if (subdir.endsWith(".pro") && looks_like_subdirs(subdir_filepath)) {
// Need full path to .pro file
out << find_subdirs(subdir_filepath, mode, prefix);
}
if (QFileInfo(subdir_filepath).isDir()) {
subdir_filepath += "/" + subdir + ".pro";
if (looks_like_subdirs(subdir_filepath)) {
out << find_subdirs(subdir_filepath, mode, prefix + subdir + "/");
}
}
}
}
return out;
}
void tst_MakeTestSelfTest::make_check()
{
/*
Run `make check' over the whole tests tree with a custom TESTRUNNER,
to verify that the TESTRUNNER mechanism works right.
*/
QString testsDir(SRCDIR "/..");
QString checktest(SRCDIR "/checktest/checktest");
#if defined(Q_OS_WIN32) || defined(Q_OS_MAC)
if (qgetenv("RUN_SLOW_TESTS").isEmpty()) {
QSKIP("This test is too slow to run by default on this OS. Set RUN_SLOW_TESTS=1 to run it.", SkipAll);
}
#endif
#ifdef Q_OS_WIN32
checktest.replace("/", "\\");
checktest += ".exe";
#endif
QProcess make;
make.setWorkingDirectory(testsDir);
QStringList arguments;
arguments << "-k";
arguments << "check";
arguments << QString("TESTRUNNER=%1").arg(checktest);
// find the right make; from externaltests.cpp
static const char makes[] =
"nmake.exe\0"
"mingw32-make.exe\0"
"gmake\0"
"make\0"
;
bool ok = false;
for (const char *p = makes; *p; p += strlen(p) + 1) {
make.start(p, arguments);
if (make.waitForStarted()) {
ok = true;
break;
}
}
if (!ok) {
QFAIL("Could not find the right make tool in PATH");
}
QVERIFY(make.waitForFinished(1000 * 60 * 10));
QCOMPARE(make.exitStatus(), QProcess::NormalExit);
int pass = 0;
QList<QByteArray> out = make.readAllStandardOutput().split('\n');
QStringList fails;
foreach (QByteArray line, out) {
while (line.endsWith("\r")) {
line.chop(1);
}
if (line.startsWith("CHECKTEST FAIL")) {
fails << QString::fromLocal8Bit(line);
}
if (line.startsWith("CHECKTEST PASS")) {
++pass;
}
}
// We can't check that the exit code of make is 0, because some tests
// may have failed to compile, but that doesn't mean `make check' is broken.
// We do assume there are at least this many unbroken tests, though.
QVERIFY2(fails.count() == 0,
qPrintable(QString("`make check' doesn't work for %1 tests:\n%2")
.arg(fails.count()).arg(fails.join("\n")))
);
QVERIFY(pass > 50);
}
QStringList find_test_class(QString const& filename)
{
QStringList out;
QFile file(filename);
if (!file.open(QIODevice::ReadOnly)) {
return out;
}
static char const* klass_indicators[] = {
"QTEST_MAIN(",
"QTEST_APPLESS_MAIN(",
"class",
"staticconstcharklass[]=\"", /* hax0r tests which define their own metaobject */
0
};
do {
QByteArray line = file.readLine();
if (line.isEmpty()) {
break;
}
line = line.trimmed();
line.replace(' ', "");
for (int i = 0; klass_indicators[i]; ++i) {
char const* prefix = klass_indicators[i];
if (!line.startsWith(prefix)) {
continue;
}
QByteArray klass = line.mid(strlen(prefix));
if (!klass.startsWith("tst_")) {
continue;
}
for (int j = 0; j < klass.size(); ++j) {
char c = klass[j];
if (c == '_'
|| (c >= '0' && c <= '9')
|| (c >= 'A' && c <= 'Z')
|| (c >= 'a' && c <= 'z')) {
continue;
}
else {
klass.truncate(j);
break;
}
}
QString klass_str = QString::fromLocal8Bit(klass).toLower();
if (!out.contains(klass_str))
out << klass_str;
break;
}
} while(1);
return out;
}
QTEST_MAIN(tst_MakeTestSelfTest)
#include "tst_maketestselftest.moc"
|