1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
|
/****************************************************************************
**
** Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies).
** Contact: http://www.qt-project.org/legal
**
** This file is part of the test suite of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:LGPL$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia. For licensing terms and
** conditions see http://qt.digia.com/licensing. For further information
** use the contact form at http://qt.digia.com/contact-us.
**
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL included in the
** packaging of this file. Please review the following information to
** ensure the GNU Lesser General Public License version 2.1 requirements
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** In addition, as a special exception, Digia gives you certain additional
** rights. These rights are described in the Digia Qt LGPL Exception
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3.0 as published by the Free Software
** Foundation and appearing in the file LICENSE.GPL included in the
** packaging of this file. Please review the following information to
** ensure the GNU General Public License version 3.0 requirements will be
** met: http://www.gnu.org/copyleft/gpl.html.
**
**
** $QT_END_LICENSE$
**
****************************************************************************/
#include <QtTest/QtTest>
#include <qapplication.h>
#include <qtoolbar.h>
#include <qcombobox.h>
#include <qwidgetaction.h>
#include <qlabel.h>
#include <qmenu.h>
#include <qmainwindow.h>
#include <qmenubar.h>
#include "../../shared/util.h"
//TESTED_CLASS=
//TESTED_FILES=
class tst_QWidgetAction : public QObject
{
Q_OBJECT
private slots:
void defaultWidget();
void visibilityUpdate();
void customWidget();
void keepOwnership();
void visibility();
void setEnabled();
void popup();
void releaseWidgetCrash();
};
void tst_QWidgetAction::defaultWidget()
{
{
QToolBar tb1;
QPointer<QComboBox> combo = new QComboBox(&tb1);
QWidgetAction *action = new QWidgetAction(0);
action->setDefaultWidget(combo);
QVERIFY(!combo->isVisible());
QVERIFY(!combo->parent());
QVERIFY(action->isVisible());
delete action;
QVERIFY(!combo);
}
{
QToolBar tb1;
QPointer<QComboBox> combo = new QComboBox(&tb1);
combo->hide();
QWidgetAction *action = new QWidgetAction(0);
action->setDefaultWidget(combo);
// explicitly hidden widgets should also set the action invisible
QVERIFY(!action->isVisible());
delete action;
}
{
QPointer<QComboBox> combo = new QComboBox(0);
combo->show();
QWidgetAction *action = new QWidgetAction(0);
action->setDefaultWidget(combo);
QVERIFY(action->isVisible());
QVERIFY(!combo->isVisible());
delete action;
}
{
QToolBar tb1;
tb1.show();
QToolBar tb2;
tb2.show();
QPointer<QComboBox> combo = new QComboBox(0);
QWidgetAction *action = new QWidgetAction(0);
action->setDefaultWidget(combo);
tb1.addAction(action);
QVERIFY(combo->parent() == &tb1);
qApp->processEvents();
qApp->processEvents();
QVERIFY(combo->isVisible());
// not supported, not supposed to work, hence the parent() check
tb2.addAction(action);
QVERIFY(combo->parent() == &tb1);
tb2.removeAction(action);
tb1.removeAction(action);
qApp->processEvents(); //the call to hide is delayd by the toolbar layout
QVERIFY(!combo->isVisible());
tb2.addAction(action);
qApp->processEvents(); //the call to hide is delayd by the toolbar layout
qApp->processEvents();
QVERIFY(combo->parent() == &tb2);
QVERIFY(combo->isVisible());
tb1.addAction(action);
QVERIFY(combo->parent() == &tb2);
delete action;
QVERIFY(!combo);
}
{
QWidgetAction *a = new QWidgetAction(0);
QVERIFY(!a->defaultWidget());
QPointer<QComboBox> combo1 = new QComboBox;
a->setDefaultWidget(combo1);
QVERIFY(a->defaultWidget() == combo1);
a->setDefaultWidget(combo1);
QVERIFY(combo1);
QVERIFY(a->defaultWidget() == combo1);
QPointer<QComboBox> combo2 = new QComboBox;
QVERIFY(combo1 != combo2);
a->setDefaultWidget(combo2);
QVERIFY(!combo1);
QVERIFY(a->defaultWidget() == combo2);
delete a;
QVERIFY(!combo2);
}
}
void tst_QWidgetAction::visibilityUpdate()
{
// actually keeping the widget's state in sync with the
// action in terms of visibility is QToolBar's responsibility.
QToolBar tb;
tb.show();
QComboBox *combo = new QComboBox(0);
QWidgetAction *action = new QWidgetAction(0);
action->setDefaultWidget(combo);
tb.addAction(action);
//the call to show is delayed by the toolbar layout
QTRY_VERIFY(combo->isVisible());
QVERIFY(action->isVisible());
action->setVisible(false);
//the call to hide is delayed by the toolbar layout
QTRY_VERIFY(!combo->isVisible());
delete action;
// action also deletes combo
}
class ComboAction : public QWidgetAction
{
public:
inline ComboAction(QObject *parent) : QWidgetAction(parent) {}
QList<QWidget *> createdWidgets() const { return QWidgetAction::createdWidgets(); }
protected:
virtual QWidget *createWidget(QWidget *parent);
};
QWidget *ComboAction::createWidget(QWidget *parent)
{
return new QComboBox(parent);
}
void tst_QWidgetAction::customWidget()
{
QToolBar tb1;
tb1.show();
QToolBar tb2;
tb2.show();
ComboAction *action = new ComboAction(0);
tb1.addAction(action);
QList<QWidget *> combos = action->createdWidgets();
QCOMPARE(combos.count(), 1);
QPointer<QComboBox> combo1 = qobject_cast<QComboBox *>(combos.at(0));
QVERIFY(combo1);
tb2.addAction(action);
combos = action->createdWidgets();
QCOMPARE(combos.count(), 2);
QVERIFY(combos.at(0) == combo1);
QPointer<QComboBox> combo2 = qobject_cast<QComboBox *>(combos.at(1));
QVERIFY(combo2);
tb2.removeAction(action);
QVERIFY(combo2);
// widget is deleted using deleteLater(), so process that posted event
QCoreApplication::sendPostedEvents(combo2, QEvent::DeferredDelete);
QVERIFY(!combo2);
delete action;
QVERIFY(!combo1);
QVERIFY(!combo2);
}
void tst_QWidgetAction::keepOwnership()
{
QPointer<QComboBox> combo = new QComboBox;
QWidgetAction *action = new QWidgetAction(0);
action->setDefaultWidget(combo);
{
QToolBar *tb = new QToolBar;
tb->addAction(action);
QVERIFY(combo->parent() == tb);
delete tb;
}
QVERIFY(combo);
delete action;
QVERIFY(!combo);
}
void tst_QWidgetAction::visibility()
{
{
QWidgetAction *a = new QWidgetAction(0);
QComboBox *combo = new QComboBox;
a->setDefaultWidget(combo);
QToolBar *tb = new QToolBar;
tb->addAction(a);
QVERIFY(!combo->isVisible());
tb->show();
QVERIFY(combo->isVisible());
delete tb;
delete a;
}
{
QWidgetAction *a = new QWidgetAction(0);
QComboBox *combo = new QComboBox;
a->setDefaultWidget(combo);
QToolBar *tb = new QToolBar;
tb->addAction(a);
QVERIFY(!combo->isVisible());
QToolBar *tb2 = new QToolBar;
tb->removeAction(a);
tb2->addAction(a);
QVERIFY(!combo->isVisible());
tb2->show();
QVERIFY(combo->isVisible());
delete tb;
delete tb2;
delete a;
}
}
void tst_QWidgetAction::setEnabled()
{
QToolBar toolbar;
QComboBox *combobox = new QComboBox;
QAction *action = toolbar.addWidget(combobox);
toolbar.show();
QVERIFY(action->isEnabled());
QVERIFY(combobox->isEnabled());
action->setEnabled(false);
QVERIFY(!action->isEnabled());
QVERIFY(!combobox->isEnabled());
action->setEnabled(true);
QVERIFY(action->isEnabled());
QVERIFY(combobox->isEnabled());
combobox->setEnabled(false);
QVERIFY(!combobox->isEnabled());
combobox->setEnabled(true);
QVERIFY(action->isEnabled());
QVERIFY(combobox->isEnabled());
QWidgetAction aw(0);
aw.setEnabled(false);
QVERIFY(!aw.isEnabled());
combobox = new QComboBox;
aw.setDefaultWidget(combobox);
QVERIFY(!aw.isEnabled());
QVERIFY(!combobox->isEnabled());
// Make sure we don't change the default widget's Qt::WA_ForceDisabled attribute
// during a normal disable/enable operation (task 207433).
{
QToolBar toolBar;
QWidget widget;
toolBar.addWidget(&widget); // creates a QWidgetAction and sets 'widget' as the default widget.
QVERIFY(!widget.testAttribute(Qt::WA_ForceDisabled));
toolBar.setEnabled(false);
QVERIFY(toolBar.testAttribute(Qt::WA_ForceDisabled));
QVERIFY(!widget.isEnabled());
QVERIFY(!widget.testAttribute(Qt::WA_ForceDisabled));
toolBar.setEnabled(true);
QVERIFY(widget.isEnabled());
QVERIFY(!widget.testAttribute(Qt::WA_ForceDisabled));
}
}
void tst_QWidgetAction::popup()
{
QPointer<QLabel> l = new QLabel("test");
QWidgetAction action(0);
action.setDefaultWidget(l);
{
QMenu menu;
menu.addAction(&action);
QTimer::singleShot(0, &menu, SLOT(close()));
menu.exec();
}
QVERIFY(!l.isNull());
delete l;
}
class CrashedAction : public QWidgetAction
{
public:
inline CrashedAction(QObject *parent) : QWidgetAction(parent) { }
virtual QWidget *createWidget(QWidget *parent) {
return new QWidget(parent);
}
};
void tst_QWidgetAction::releaseWidgetCrash()
{
// this should not crash!
QMainWindow *w = new QMainWindow;
QAction *a = new CrashedAction(w);
QMenu *menu = w->menuBar()->addMenu("Test");
menu->addAction("foo");
menu->addAction(a);
menu->addAction("bar");
delete w;
}
QTEST_MAIN(tst_QWidgetAction)
#include "tst_qwidgetaction.moc"
|