diff options
| author | Mike Pennisi <mike@mikepennisi.com> | 2017-12-03 00:06:42 -0500 |
|---|---|---|
| committer | Rick Waldron <waldron.rick@gmail.com> | 2018-01-05 15:17:50 -0500 |
| commit | 136110378bb62fefb5a9a69080067e6f126f9dae (patch) | |
| tree | 90b8d7ba0f9f1162b2edd0e74afb87382fc6f195 /CONTRIBUTING.md | |
| parent | 66df349af32c3f293936f7a947ac18bfb1ecda5c (diff) | |
| download | qtdeclarative-testsuites-136110378bb62fefb5a9a69080067e6f126f9dae.tar.gz | |
Rename negative test "phase" for parsing
Early errors may result from parsing the source text of a test file, but
they may also result from parsing some other source text as referenced
through the ES2015 module syntax. The latter form of early error is not
necessarily detectable by ECMAScript parsers, however. Because of this,
the label "early" is not sufficiently precise for all Test262 consumers
to correctly interpret all tests.
Update the "phase" name of "early" to "parse" for all those negative
tests that describe errors resulting from parsing of the file's source
text directly. A forthcoming commit will update the remaining tests to
use a "phase" name that is more specific to module resolution.
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e2544a070..582974de8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -103,14 +103,14 @@ single line comment syntax. This means the test is expected to throw an error of the given type. If no error is thrown, a test failure is reported. - **type**- If an error is thrown, it is implicitly converted to a string. In order for the test to pass, this value must match the name of the error constructor. -- **phase** - Negative tests whose **phase** value is "early" must produce the specified error prior to executing code. The value "runtime" dictates that the error is expected to be produced as a result of executing the test code. +- **phase** - Negative tests whose **phase** value is "parse" must produce the specified error prior to executing code. The value "runtime" dictates that the error is expected to be produced as a result of executing the test code. For best practices on how to use the negative tag please see [Handling Errors and Negative Test Cases](#handling-errors-and-negative-test-cases), below. For example: negative: - phase: early + phase: parse type: ReferenceError #### esid @@ -210,7 +210,7 @@ Expectations for **parsing errors** should be declared using [the `negative` fro ```javascript /*--- negative: - phase: early + phase: parse type: SyntaxError ---*/ |