summaryrefslogtreecommitdiff
path: root/src/qml/doc/snippets
diff options
context:
space:
mode:
authorEskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>2023-02-02 13:57:00 +0100
committerEskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>2023-02-08 07:26:17 +0000
commitf70844868a834fe988eb0716f6af4cbaacf89727 (patch)
tree7edf305554b8095d94ef20362df6e42e9306018e /src/qml/doc/snippets
parenta8f353747cd7098e7606fe325cebe29df5fd8fa0 (diff)
downloadqtdeclarative-f70844868a834fe988eb0716f6af4cbaacf89727.tar.gz
Avoid crash updating source of shader-less effect
When a ShaderEffect did not have any shaders, we would register a "fake" bindPoint for the 'source' property with bindPoint 0. However, when actually linking the default shader program, the actual bindPoint is 1 (also matches what is in shadereffect.frag). When the property corresponding to the source updated, we would thus register an update for binding point 0. The initial value for binding point 1, from when the shader effect was loaded, would never be overwritten and when we iterated over the variables later and tried to cast do a qobject_cast on the (initial, now dangling) pointer stored for binding point 1, it would crash. Pick-to: 6.2 6.4 6.5 Fixes: QTBUG-110111 Change-Id: I96c3e81908db8cce682b5447800fcb7a3fe5e0b9 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Diffstat (limited to 'src/qml/doc/snippets')
0 files changed, 0 insertions, 0 deletions