tools: use QStringRef more

Change-Id: I4fccbfb2b965daf3a31846d1d51d39eb74ad944d
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>

4 files changed, 12 insertions, 14 deletions

diff --git a/tools/qmleasing/splineeditor.cpp b/tools/qmleasing/splineeditor.cpp
index ab22d579f8..ee55931a46 100644
--- a/tools/qmleasing/splineeditor.cpp
+++ b/tools/qmleasing/splineeditor.cpp
@@ -673,14 +673,12 @@ void SplineEditor::setEasingCurve(const QString &code)
     if (m_block)
         return;
     if (code.startsWith(QLatin1Char('[')) && code.endsWith(QLatin1Char(']'))) {
-        QString cleanCode = code;
-        cleanCode.remove(0, 1);
-        cleanCode.chop(1);
-        const QStringList stringList = cleanCode.split(QLatin1Char(','), QString::SkipEmptyParts);
+        const QStringRef cleanCode(&code, 1, code.size() - 2);
+        const auto stringList = cleanCode.split(QLatin1Char(','), QString::SkipEmptyParts);
         if (stringList.count() >= 6 && (stringList.count() % 6 == 0)) {
             QVector<qreal> realList;
             realList.reserve(stringList.count());
-            foreach (const QString &string, stringList) {
+            for (const QStringRef &string : stringList) {
                 bool ok;
                 realList.append(string.toDouble(&ok));
                 if (!ok)
diff --git a/tools/qmlimportscanner/main.cpp b/tools/qmlimportscanner/main.cpp
index 2569d78c63..2371057878 100644
--- a/tools/qmlimportscanner/main.cpp
+++ b/tools/qmlimportscanner/main.cpp
@@ -224,11 +224,11 @@ QVariantList findPathsForModuleImports(const QVariantList &imports)
             if (plugininfo.contains(QStringLiteral("dependencies"))) {
                 QStringList dependencies = plugininfo.value(QStringLiteral("dependencies")).toStringList();
                 foreach (const QString &line, dependencies) {
-                    QList<QString> dep = line.split(QLatin1Char(' '));
+                    const auto dep = line.splitRef(QLatin1Char(' '));
                     QVariantMap depImport;
                     depImport[QStringLiteral("type")] = QStringLiteral("module");
-                    depImport[QStringLiteral("name")] = dep[0];
-                    depImport[QStringLiteral("version")] = dep[1];
+                    depImport[QStringLiteral("name")] = dep[0].toString();
+                    depImport[QStringLiteral("version")] = dep[1].toString();
                     importsCopy.append(depImport);
                 }
             }
diff --git a/tools/qmlprofiler/qmlprofilerapplication.cpp b/tools/qmlprofiler/qmlprofilerapplication.cpp
index 063e5e2961..45c32487a2 100644
--- a/tools/qmlprofiler/qmlprofilerapplication.cpp
+++ b/tools/qmlprofiler/qmlprofilerapplication.cpp
@@ -347,7 +347,7 @@ bool QmlProfilerApplication::checkOutputFile(PendingRequest pending)
 
 void QmlProfilerApplication::userCommand(const QString &command)
 {
-    QStringList args = command.split(QChar::Space, QString::SkipEmptyParts);
+    auto args = command.splitRef(QChar::Space, QString::SkipEmptyParts);
     if (args.isEmpty()) {
         prompt();
         return;
@@ -401,7 +401,7 @@ void QmlProfilerApplication::userCommand(const QString &command)
         } else if (m_profilerData.isEmpty()) {
             prompt(tr("No data was recorded so far."));
         } else {
-            m_interactiveOutputFile = args.length() > 0 ? args[0] : m_outputFile;
+            m_interactiveOutputFile = args.length() > 0 ? args.at(0).toString() : m_outputFile;
             if (checkOutputFile(REQUEST_OUTPUT_FILE))
                 output();
         }
@@ -418,7 +418,7 @@ void QmlProfilerApplication::userCommand(const QString &command)
         if (!m_recording && m_profilerData.isEmpty()) {
             prompt(tr("No data was recorded so far."));
         } else {
-            m_interactiveOutputFile = args.length() > 0 ? args[0] : m_outputFile;
+            m_interactiveOutputFile = args.length() > 0 ? args.at(0).toString() : m_outputFile;
             if (checkOutputFile(REQUEST_FLUSH_FILE))
                 flush();
         }
diff --git a/tools/qmlprofiler/qmlprofilerdata.cpp b/tools/qmlprofiler/qmlprofilerdata.cpp
index 74fa44c1d6..b651b2724f 100644
--- a/tools/qmlprofiler/qmlprofilerdata.cpp
+++ b/tools/qmlprofiler/qmlprofilerdata.cpp
@@ -248,7 +248,7 @@ void QmlProfilerData::addQmlEvent(QQmlProfilerDefinitions::RangeType type,
         eventHashStr = getHashStringForQmlEvent(eventLocation, type);
     } else {
         const QString filePath = QUrl(eventLocation.filename).path();
-        displayName = filePath.mid(
+        displayName = filePath.midRef(
                     filePath.lastIndexOf(QLatin1Char('/')) + 1) +
                     QLatin1Char(':') + QString::number(eventLocation.line);
         eventHashStr = getHashStringForQmlEvent(eventLocation, type);
@@ -327,8 +327,8 @@ void QmlProfilerData::addPixmapCacheEvent(QQmlProfilerDefinitions::PixmapEventTy
 
     QString filePath = QUrl(location).path();
 
-    QString eventHashStr = filePath.mid(filePath.lastIndexOf(QLatin1Char('/')) + 1) +
-            QStringLiteral(":") + QString::number(type);
+    const QString eventHashStr = filePath.midRef(filePath.lastIndexOf(QLatin1Char('/')) + 1)
+            + QLatin1Char(':') + QString::number(type);
     QmlRangeEventData *newEvent;
     if (d->eventDescriptions.contains(eventHashStr)) {
         newEvent = d->eventDescriptions[eventHashStr];