summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* QtQml: Use QMetaType in QQmlValueTypeWrapperUlf Hermann2023-05-173-37/+36
| | | | | | | | | | | Retrieving the QQmlValueType is expensive and there is not a single place where we need anything but its QMetaObject. Retrieving only the meta object, on the other hand, is cheap. Change-Id: I3ad5574d64f1f67a4d4cf2886dc5c396e99ec91a Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Move ScopedStackFrame into qv4stackframe_p.hUlf Hermann2023-05-1715-130/+157
| | | | | | | | | | | This is where it belongs. We need to apply some tricks to avoid cyclic includes, but that's better than what we have so far. Also, sort and clean up the includes in the affected files. Change-Id: Ia7a957d06c0ca284045d831417740c3f9920bc92 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* QQuickMaterialPlaceholderText: fix code checker complaintMitch Curtis2023-05-171-1/+1
| | | | | | | | | | | | | | The message was: result of integer division used in a floating point context; possible loss of precision Fixing it revealed a test that relied on it; removed the Math.floor() work-around the test used previously. Pick-to: 6.5 Change-Id: I7c2fde1902d2013ba9fedcadf87ae3b21987fca2 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* doc: Use part of window example for Window.flags property snippetShawn Rutledge2023-05-163-1/+60
| | | | | | Pick-to: 6.2 6.5 Change-Id: I5b5c1663f626ce3bfe4c01edbc5480729a1b91f6 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* doc: Make Window snippets testable; remove import versionsShawn Rutledge2023-05-173-19/+36
| | | | | | Pick-to: 6.2 6.5 Change-Id: I35ba013152628591d016c632828a1c4e64cf5978 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* doc: Clarify usage of palette; testable snippetsShawn Rutledge2023-05-175-17/+98
| | | | | | | | | | | | | | | | | - color groups are better shown with copyable monospace syntax rather than capitalized - clarify that using palette grouped-property syntax does not imply that you must define every color - Window has a palette property, inited from SystemPalette: it's not only ApplicationWindow - testable snippets - reuse part of the windowPalette snippet for the Window.active property (switching colors might be the main use case) - make more links Pick-to: 6.2 6.5 Change-Id: I5974351ba66fc9aeec34cb6a4aba1eb85289f536 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* Enhance Image docs about compressed formatsLaszlo Agocs2023-05-161-0/+37
| | | | | | | | Pick-to: 6.5 6.2 Fixes: QTBUG-113565 Change-Id: I6ccd0aa27a599c09a93a6c377b36697d9c60f25e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
* Doc: Fix linking and read-only status for Window.visibility propertiesTopi Reinio2023-05-161-1/+3
| | | | | | | | | | | | | | | QDoc has problems linking to a topic that has identical name to the topic the link appears in, as is the case when linking from 'visibility' property to 'visibility' attached property. Add a unique \keyword for the former and use it for linking. Explicitly set the attached property as \readonly. Pick-to: 6.5 6.2 Task-number: QTBUG-113015 Change-Id: Ia0eb99fd2436565c697ca23629134b691acecc1b Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* qt_add_qml_module: Set QT_QML_MODULE_QML_FILES correctlyFabian Kosmale2023-05-161-15/+17
| | | | | | | | | | | | | | | | | | | | A QML module might not actually contain any QML files at all (in case of a pure C++ module). In such a case, we so far ended up with QT_QML_MODULE_QML_FILES being set to "-NOTOUND", which later is problematic for qt_query_qml_module. We already have code in place to cover that issue for some variables, just not for QML_FILES. The code is now amended to handle it, too. Moreover, the code block is moved to the end of the function. This ensures that the code for setting a variable always comes before the code ensuring that it is set – which would not have been the case for QML_FILES if it had stayed at its old position. Pick-to: 6.5 Task-number: QTBUG-111946 Change-Id: Ib4501bb4a617b2174ad89e116588aa51353cb17f Reviewed-by: Alexey Edelev <alexey.edelev@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* doc: add both stretch factors to the list of attached propertiesOliver Eftevaag2023-05-162-0/+6
| | | | | | | | | | | | | The horizontalStretchFactor and verticalStretchFactor properties were both added in 6.5. Not only did we forget to mark them with a \since Qt 6.5, but we also forgot to add them to the list of attached properties that is mentioned on the RowLayout and ColumnLayout doc pages. Task-number: QTBUG-113230 Pick-to: 6.5 6.5.1 Change-Id: I8537fe5c9b5aa1389a8bfaf4e1abed3a1f0a34d5 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Carl-Lucien Armand Schwan <carl.schwan@kdab.com>
* V4: Discern between named builtins and optimizations for common typesUlf Hermann2023-05-1610-160/+239
| | | | | | | | | The named builtins include void and regexp. The optimizations for other types are useful, but should be a separate enum. Change-Id: I06220cf4a6d3449deca89a26c4f5db0e41d32765 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Doc: Replace mentions of deprecated macro Q_ENUMS()Topi Reinio2023-05-162-2/+2
| | | | | | | | | Q_ENUMS() is deprecated in favor of Q_ENUM(). Pick-to: 6.5 Task-number: QTBUG-113229 Change-Id: If562e50a88ff04d02be0aa10c975e0af84d90e44 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* QQuickWindow: Add missing break statements in event()Vlad Zahorodnii2023-05-151-0/+2
| | | | | | | | | Amends commit 1314592f41abecb6f1140d3bfe39bba8a2c4ea7e. This fixes a -Wimplicit-fallthrough compiler warning. Change-Id: I29285df5e1b2b19590dd5bcd0c50b942b668c807 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* NinePatchImage: support the compressed texture imageJaehak Lee2023-05-151-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The compressed texture image is supported by qquickimage and the qquickninepatchimage is inherited by qquickimage. But the compressed texture is not shown when the source of qquickninepatchimage is set as compressed texture because the updatePaintNode of qquickninepatchimage only consider non-compressed texture. This patch is not intended to use the HW compressed image as an actual 9-patch image, but to display them using the super class qquickimage in the case of an HW compressed image other than a normal pixmap image. If the source is HW compressed textures such as ASTC, KTX, and PKM, we have to call updatePaintNode of QQuickImage before checking the validity of the pixmap image. (because nullptr is returned if pixmap image is not valid) The containers themselves (pkm, ktx) are universally supported but the compressed texture formats is up to the underlying 3D API implementation and may vary. So, if the format is not supported by RHI, we skip the test. Refer to QTBUG-113565 for a detailed discussion on texture formats. And when using the software backend, we also skip test cases. Fixes: QTBUG-113446 Pick-to: 6.2 6.4 6.5 Change-Id: I2704f86e94b50b3c187eca359fdc1a69eb217811 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* QmlCompiler: Do check specificType on SetLookupUlf Hermann2023-05-151-2/+7
| | | | | | | | | | We may have implicitly invalidated it when shadow-checking. Amends commit b3281f123ea5a8c0e5f8c63fa1568cf7414f9c14. Change-Id: Ia5c54a3a0fa97c61e947ecb0a5b21d410e1bf19a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Update displayText and value of SpinBox (live)Matthias Rauter2023-05-142-36/+122
| | | | | | | | | | | | | | | | | | The displayText of a SpinBox is now updated and sanitized (fixup) by the validator when the user edits the text of the contentItem. The value of a SpinBox can be updated along the displayText on demand (set property live to true) when the user edits the text. [ChangeLog][Controls] The value of a SpinBox can be updated automatically (live) when the user edits the text. The displayText of a SpinBox is updated and sanitized automatically. Fixes: QTBUG-64151 Fixes: QTBUG-85739 Fixes: QTBUG-103205 Change-Id: Id82856190e36d15be2dde8e38091893171f4dad2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* qmllint: Separate logic by import type in QQmlJSImportVisitor::visitOlivier De Cannière2023-05-122-46/+69
| | | | | | | | | | | | | | This patch reorganizes the logic of the import visitor to deal with each import type (paths, qrc: urls, file: urls) separately. This reorganisation fixes QTBUG-108803 which happened because "qrc:" imports were being treated as paths leading to things like ":/untitled/qrc:/untitled/components". Fixes: QTBUG-108803 Pick-to: 6.5 Change-Id: I5af20d10c533455215895be66b5cd98a977fd18a Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Doc: Add missing \target keywords for QML macrosTopi Reinio2023-05-121-3/+5
| | | | | | | | | | | | PAST_MAJOR_VERSIONS, PLUGIN_TARGET, NO_CREATE_PLUGIN_TARGET, and CLASS_NAME are documented and elsewhere in the documentation we try to link to them, but they were missing a \target. Also, fix a link to QT_QML_SOURCE_TYPENAME. Pick-to: 6.5 Change-Id: I74ff0de558d1f43b739f64a4bab19863f8be34cb Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Doc: Document the --verbose flag to qmlcachegenUlf Hermann2023-05-121-0/+17
| | | | | | | | | Amends commit a7c92814f0ff6e9253c781b90e70ad645f8cd94e. Change-Id: I0568298aaa696036b5115f4e93ddeb1cf90c76a3 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Mike Trahearn <mtrahearn@topcon.com>
* QQmlComponent: Remove pending QProperty bindings in old createObject()Ulf Hermann2023-05-123-28/+56
| | | | | | | | | | | | | When calling the QQmlV4Function overload of createObject() we end up in a different code path. The problem is the same, though. Amends commit ef6e9f6b75848dfdacdd98cf9e7530f651b3dfca. Pick-to: 6.5 Task-number: QTBUG-99363 Change-Id: I6341243b75d9db1e0fcb80d8d73dab6932d85fd2 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Examples: Move Qml plugin example to manual testsOlivier De Cannière2023-05-121-82/+0
| | | | | | | | | Outdated documention has been removed. Task-number: QTBUG-111036 Change-Id: I8db138ff71615a6ed6ac4cebdb365c27252fa5ee Pick-to: 6.5 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Fix reset support for value typesFabian Kosmale2023-05-121-0/+6
| | | | | | | | | | | | | | Our value type refactoring in 6.5 broke reset support for value types when that write happens through virtualPut. Fix that by checking whether the value we're assinging is undefined before attempting any conversion, and reset the gadget in that case (if it is actually resettable). Task-number: QTBUG-113473 Pick-to: 6.5 Change-Id: Ifaa2d045f718fc3cb2d5e75b3626b41175ac3a3b Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Semih Yavuz <semih.yavuz@qt.io>
* QQuickText: Mark as a dirty node when its ClipRect changesPiotr Wierciński2023-05-122-12/+21
| | | | | | | | | | | Make sure that any changes to ClipRect of QQuickText are properly propagated. Fixes: QTBUG-106164 Fixes: QTBUG-106205 Pick-to: 6.5 Change-Id: Id37099811cf8e10dd510dc5f8086d1323f92af9e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Doc: improve the SpinBox floating point exampleMitch Curtis2023-05-121-9/+17
| | | | | | | | | | | | | | | | | | | | | | | Until we get a dedicated DoubleSpinBox control, we should make it easier for users to roll their own. We have a snippet for this in the docs already, but we can make it better: - Make the SpinBox editable. It's not very useful as an example if it's not, since the stepSize is an integer, so there's no way to modify the decimal component otherwise (without modifying the source, which users shouldn't have to do). - Set decimals in the validator so that it prevents entering more than 2. - Add a convenience function to convert decimals to integers. - Store the magic number 100 in a read-only property. - Use StandardNotation rather than ScientificNotation. This allows our internal fixup logic to work with the entered text. - Rename spinbox to spinBox. Task-number: QTBUG-67349 Pick-to: 6.2 6.5 Change-Id: I2b0cab086b87d668408df194440ebaf64f598241 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Replace {add,sub,mul}_overload with q{Add,Sub,Mul}OverloadMarc Mutz2023-05-113-5/+5
| | | | | | | | | | | | | | | | | | These APIs started out as private APIs in qnumeric_p.h, but have since been made pseudo-public in qnumeric.h. The qnumeric_p.h versions just forward to the qnumeric.h ones, so just use the latter. This is in preparation of removing the {add,sub,mul}_overflow versions, which, despite being defined in the unnamed namespace, don't sport the q prefix, so potentially clash with global symbols. The change is a simple textual search and replace. Picking to 6.5 to avoid cherry-pick conflicts going forward. Pick-to: 6.5 Change-Id: I2525619c14cb8eeadd08e2fa6c35968bcedd5171 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Docs: Fix "Can't link to" example warningsSafiyyah Moosa2023-05-111-3/+3
| | | | | | | Task-number: QTBUG-113160 Pick-to: 6.5 Change-Id: If79cfc61ee610f382a071d4a922ba5b73ae1391c Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* QML: Maintain invariant between QObjectMethod membersUlf Hermann2023-05-111-3/+19
| | | | | | | | | | | | | | | If the methodCount is 0, the methods have to be nullptr. Otherwise they have to point to the actual method(s). This is important for the method resolution to work correctly. In particular when cloning a method we have to check for 0. Amends commit 17bd07cbc5b6cf54716e991765ab3088a710d7b3. Pick-to: 6.5 Fixes: QTBUG-113484 Change-Id: Ic31d6e391c1d74a162820232f242a19379f5e4df Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
* QQuickWindow track changes via DevicePixelRatioChange eventDavid Edmundson2023-05-112-24/+18
| | | | | | | | | | | | | Qt core gained a new event on the window when the dpr changes. This is important as the window DPR can differ from the screen device pixel ratio, it also allows us to get rid of one level of the screen connection tracking. Fixes: QTBUG-113236 Change-Id: I43f50a0ef98653553ea177dc72e1522036452496 Reviewed-by: Aleix Pol Gonzalez <aleixpol@kde.org> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Allow a layout with width or height == 0 to resize its child itemsJan Arve Sæther2023-05-111-1/+1
| | | | | | | Fixes: QTBUG-112740 Pick-to: 6.5 Change-Id: I66327f3fa76d3f1c14b62d0ac42d3fd4c28288b2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* QML: static assert that QQmlPropertyData is trivially copyableUlf Hermann2023-05-111-0/+2
| | | | | | | It would be very, very bad if that assumption was violated. Change-Id: I0ae7391a8df93450fc881a937c5365c57c58277f Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QmlCompiler: Improve argument construction in generated codeUlf Hermann2023-05-113-28/+55
| | | | | | | | | | | | | We don't have to pass types that don't fit if we actually have the correct types in suitable wrappers. This still invokes the internal conversions of the call frame setup if we call with really generic types, for example if the same value is read multiple times with different target types. However, that is acceptable. Fixes: QTBUG-113465 Change-Id: I8ec4afeb39bbe6585e5268c0e9b0cfd2788d761a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QmlCompiler: Optimize list manipulationsUlf Hermann2023-05-103-38/+36
| | | | | | | | | | | | | | | | | We should never store a list in a wrapper type that is itself a different list. Wrapping and unwrapping requires rebuilding the list in such cases. We can, however, store lists of builtins as-is. There is no need to transform them. Other lists can still be stored in QVariant. As a result, we now need to discern between the access semantics of the stored type and the access semantics of the contained type. They are not guaranteed to be the same anymore. Furthermore, we need to reject "internal" manipulation of QVariant-wrapped lists for now. We might implement them using QMetaSequence, though. Task-number: QTBUG-113465 Change-Id: If09ea345b2fac39bf2abd62a2fce2d354df85b6b Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Material: respect background color of flat buttonsMitch Curtis2023-05-101-5/+2
| | | | | | | Fixes: QTBUG-113474 Pick-to: 6.2 6.5 6.5.1 Change-Id: I1fc39082e4cd1763bae56c512741502228b28397 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Value types: Prefer assigning bindings instead of convertingFabian Kosmale2023-05-091-10/+12
| | | | | | | | | | | | When we're assigning a QJSValue to a value type property, we must first check whether it is a binding created by Qt.binding. In that case, we should directly set that binding up. Going through the conversion code path might not necessarily fail, but might instead yield nonsense. Pick-to: 6.5 Fixes: QTBUG-113472 Change-Id: If91e0843f0caf36c96b4c811b9ce8076adfc984f Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* QmlCompiler: Re-allow conversion from QObject to QStringUlf Hermann2023-05-091-1/+1
| | | | | | | | | | | | It only worked for the console functions in 6.5. There it was suppressed by the enforcement of type conversions in the basic blocks pass in dev. We have, however, a good enough way to coerce QObject to QString these days. Task-number: QTBUG-112291 Change-Id: I025976cc7fbe430c5cdc607cae3ca48838b24f88 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Remove the 'qml-devtools' featureAlexey Edelev2023-05-092-12/+5
| | | | | | | | | | | | | | | The meaning of the feature has changed and tools that depends on this feature now need to be built unconditionally. So the feature should be removed to avoid confusing users. [ChangeLog][QtQml][Tools] The 'qml-devtools' feature is removed. All tools that depend on this feature are mandatory and need to be build unconditionally. Fixes: QTBUG-113221 Pick-to: 6.5 Change-Id: Ia026684703d847ce777d7a2916f04b3c90727695 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Properly support lists as method argumentsUlf Hermann2023-05-094-4/+21
| | | | | | | | | | | a, Teach QV4::QObjectWrapper how to convert QQmlListProperty to QObjectList. b, Parse the isList attribute from qmltypes. c, Resolve lists when resolving QQmlJSScope. Change-Id: I70c6d40507de990b45a87eb7d8c7bba279d550e8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QML: Encode "missing" line number as negated address of stack frameUlf Hermann2023-05-099-20/+42
| | | | | | | | | | | | | | | This way we can identify which entry in a stack frame to amend when processing an exception in generated code. However, negative line numbers are also used to signal the position of "Ret" instructions. Since you cannot throw an exception from a "Ret" instruction, those cannot collide, but we cannot qAbs() the line number anymore when saving it in the stack trace. We have to qAbs() it in all the places where it's read. Pick-to: 6.5 Fixes: QTBUG-112946 Change-Id: I24dc4008fb7eab38e4d24e70211c22e46f1b72a7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QML: Allow conversion from QV4::Sequence to different iterableUlf Hermann2023-05-091-11/+21
| | | | | | | Pick-to: 6.5 Fixes: QTBUG-112291 Change-Id: Idd47ea8daf9c54759af6c1feba68bd52d1163615 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QML: Don't try to convert objects with prototypes to QVariantUlf Hermann2023-05-091-4/+4
| | | | | | | | | This is likely to lose some properties. Pick-to: 6.5 Fixes: QTBUG-106266 Change-Id: Ib5a2567d61635a5cf7b3abee7cfef0c073d59e63 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QmlCompiler: Generate trace info for ConvertThisToObjectUlf Hermann2023-05-091-0/+2
| | | | | | Change-Id: I021b8bea01cfcccd062b7e23d265208ae6b3e490 Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QQuickItem: Do not synthesize replace() for data/resources/childrenUlf Hermann2023-05-092-13/+72
| | | | | | | | | | | | | Those properties are not actually sequential containers. They have some internal logic that refuses certain operations and changes the semantics of others. We should not run things like splice() on them. We can natively implement removeLast(), though. Pick-to: 6.5 Fixes: QTBUG-112949 Change-Id: Ic9fa84f98a68428df9e958ba7fc72b0987e8601f Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Material: fix clipped floating placeholder textMitch Curtis2023-05-094-4/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes to placeholder text in 20e3d1b522d1b79239e9ac4a6af47ce3648512bd and 5704741a4073ac131782c3dd73cac5cda6800a28 result in floating placeholder text (i.e. the text shown at the top of the control when it has active focus) being clipped when e.g. in a ScrollView. This is probably only an issue for TextArea in practice, since you wouldn't usually put a TextField in a ScrollView, but you can still run into it if you clip it. We don't want to unconditionally set topInset by default, because, as mentioned above, these controls are not always clipped. In most cases they are used on their own, and this issue won't affect them. Unconditionally setting topInset would ruin the layout of existing UIs. So, we set topInset only if the control itself clips (or its Flickable parent in the case of TextArea). [ChangeLog][Controls][Material] The outlined TextArea now sets topInset by default if it or its Flickable parent clips. This avoids the floating placeholder being clipped in those cases. The outlined TextField sets topInset by default only if the TextField itself clips. Fixes: QTBUG-113321 Pick-to: 6.5 Change-Id: I8555e4fc0c7a9800f76b54a84d94f4d04691bc23 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Doc: make grabToImage example snippet more usefulVolker Hilsheimer2023-05-091-2/+3
| | | | | | | | | | | | | The example doesn't work as is (when run with the qml binary) because by the time Component.onCompleted is called, there might not be a window yet. Use a key press handler instead (which then needs focus to be set). Fixes: QTBUG-113312 Change-Id: I2986334aca4ca670e206ceadf1093a87aa304e8e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* Silence signed vs unsigned warning on 32 bit VS 2022 debug buildJøger Hansegård2023-05-071-1/+1
| | | | | | | | | | | | | | The warning C4018: '<': signed/unsigned mismatch appears in a Q_ASSERT when checking a lookup index against the size of the container. Fixed by changing from unsigned to signed type for the index. Since the index is already implicitly converted to signed type when used, we can use a signed type from the start. We rely on implicit conversion from unsigned instead of static_cast to not hide other warnings in the future. Change-Id: I2b1983bdd40104e2c7135eec849a198ac074517c Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* QQmlComponent: Remove pending bindings when setting propertiesUlf Hermann2023-05-063-7/+38
| | | | | | | | Pick-to: 6.2 6.5 Fixes: QTBUG-99363 Change-Id: I2c731ec0b8c5947192accdeb5ef52903d9c7cd90 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QML: Don't crash when monitoring binding removalUlf Hermann2023-05-051-7/+19
| | | | | | | | There are more bindings kinds around. Fixes: QTBUG-113353 Change-Id: If545f56bd61c238431883be3eb013841d96b18bb Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QmlCompiler: Fix operator== of VirtualRegisterUlf Hermann2023-05-051-1/+2
| | | | | | | | | | This should not happen, but let's better be safe than sorry. Amends commit 4634b6bf54e5ba15aa2e8efc12feb156e3d9c309. Change-Id: I0bac55e8ce4518b2d90f19ea28d58ed629659778 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
* Quick: Update documentation of TapHandler to reflect renamed enumDavid Edmundson2023-05-051-1/+1
| | | | | | | | | PointerDevice.GenericPointer was the enum value in Qt5, but in Qt6 this changed to PointerDevice.Generic Pick-to: 6.2 6.5 Change-Id: Ic5e4a5fe5fd91f7478d00e0d2c643b99eaa7ab14 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* qmldom: Add more literalsSemih Yavuz2023-05-053-1/+37
| | | | | | | | | | Dom construction fails before this commit if it encounters one of null expression, true and false literals. Add dom representation for them. Change-Id: I2dbb2ebfce83b32426eb5e159fe9e4f0f68c56c3 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
View Lorry Controller Status