diff options
| author | Bartlomiej Moskal <bartlomiej.moskal@qt.io> | 2023-05-10 12:10:07 +0200 |
|---|---|---|
| committer | Bartlomiej Moskal <bartlomiej.moskal@qt.io> | 2023-05-11 07:58:18 +0000 |
| commit | 54464a09a49593ce70065d8481bb32f499348728 (patch) | |
| tree | 5dad1367d34fb868e8d9e866875ddfd5a5951bc2 | |
| parent | aeb1a894d6c3fbb045a8060d8785874f18b2790d (diff) | |
| download | qtmultimedia-54464a09a49593ce70065d8481bb32f499348728.tar.gz | |
Android-backend: fix for setting maximumZoomFactor
Before this commit, the maximum zoom factor was set locally in the
QAndroidCamera class. It was not propagated to its base QPlatformCamera
class. That cause the problem with wrong value returned by
maxZoomFactor() method.
This commit contains setting correctly m_maxZoom in QPlatformCamera and
remove not needed m_maximumZoom member from QAndroidCamera.
Fixes: QTBUG-105372
Pick-to: 6.5 6.2
Change-Id: Iaf167d03e42cb0e22ebe60862bb9dc24b1ef9173
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
| -rw-r--r-- | src/plugins/multimedia/android/mediacapture/qandroidcamera.cpp | 6 | ||||
| -rw-r--r-- | src/plugins/multimedia/android/mediacapture/qandroidcamera_p.h | 1 |
2 files changed, 2 insertions, 5 deletions
diff --git a/src/plugins/multimedia/android/mediacapture/qandroidcamera.cpp b/src/plugins/multimedia/android/mediacapture/qandroidcamera.cpp index cadd72fb6..52d2e00f6 100644 --- a/src/plugins/multimedia/android/mediacapture/qandroidcamera.cpp +++ b/src/plugins/multimedia/android/mediacapture/qandroidcamera.cpp @@ -197,13 +197,11 @@ void QAndroidCamera::onCameraOpened() if (m_cameraSession->camera()->isZoomSupported()) { m_zoomRatios = m_cameraSession->camera()->getZoomRatios(); qreal maxZoom = m_zoomRatios.last() / qreal(100); - if (m_maximumZoom != maxZoom) { - m_maximumZoom = maxZoom; - } + maximumZoomFactorChanged(maxZoom); zoomTo(1, -1); } else { m_zoomRatios.clear(); - m_maximumZoom = 1.0; + maximumZoomFactorChanged(1.0); } m_minExposureCompensationIndex = m_cameraSession->camera()->getMinExposureCompensation(); diff --git a/src/plugins/multimedia/android/mediacapture/qandroidcamera_p.h b/src/plugins/multimedia/android/mediacapture/qandroidcamera_p.h index 15ea9bf0e..77bbc3133 100644 --- a/src/plugins/multimedia/android/mediacapture/qandroidcamera_p.h +++ b/src/plugins/multimedia/android/mediacapture/qandroidcamera_p.h @@ -76,7 +76,6 @@ private: bool m_continuousVideoFocusSupported = false; bool m_focusPointSupported = false; - float m_maximumZoom; QList<int> m_zoomRatios; QList<QCamera::ExposureMode> m_supportedExposureModes; |