diff options
author | Edward Welbourne <edward.welbourne@qt.io> | 2018-02-26 18:17:04 +0100 |
---|---|---|
committer | Oswald Buddenhagen <oswald.buddenhagen@qt.io> | 2018-02-27 14:37:20 +0000 |
commit | dfb5e10927531c56d69115df1a1a8ebb494065ec (patch) | |
tree | ebecf00b2cc1dfdadca581cacbf8298c94ed6139 /git-hooks | |
parent | c112252bc2e0e35dbdc946171673fbc867a52996 (diff) | |
download | qtrepotools-dfb5e10927531c56d69115df1a1a8ebb494065ec.tar.gz |
Include the prior branch in gerrit-bot's "Moved" message
Having now seen moves using the bot in practice, I find that reviews
after a move typically give no hint to which branch they were on
*before* the move. Though usually unimportant, it's sometimes of
interest to a reviewer.
Change-Id: I2462ca2033a7f9007ff5dc226dc6674b04b4e4fb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Diffstat (limited to 'git-hooks')
-rwxr-xr-x | git-hooks/gerrit-bot | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-hooks/gerrit-bot b/git-hooks/gerrit-bot index 1227185..5ae0b74 100755 --- a/git-hooks/gerrit-bot +++ b/git-hooks/gerrit-bot @@ -272,7 +272,7 @@ sub do_move($$$) open(my $retarget, "gerrit_retarget_changes x $target $number 2>&1 |") or die "Cannot run gerrit_retarget_changes: ".$!; my @output = <$retarget>; - return "Moved" if (close($retarget)); + return "Moved from $branch" if (close($retarget)); return ($! ? "Failed to move ($!)\n" : "Move rejected ($?)\n") . join(' ', @output); } |