summaryrefslogtreecommitdiff
path: root/util
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2022-04-25 17:27:28 +0200
committerEdward Welbourne <edward.welbourne@qt.io>2022-05-03 13:28:09 +0000
commit10d4124a82b1c52dbd35639e20895bb111b58245 (patch)
tree22620928fd66cb8b8c4ddab2083bb3f45c6f6bc5 /util
parent447398a2d6f357bc381ea8464faec6226f2cfe97 (diff)
downloadqtrepotools-10d4124a82b1c52dbd35639e20895bb111b58245.tar.gz
Leave sanitize-commit's $target undefined when no branch is given
It was previously unconditionally set, either to false or to the branch passed on the command line; but code tests it using defined($target), which was thus always true. Apparently the intent was to leave it undefined when no branch was given. Exposed by configuring my local repositories for picked modules to have with-pickbot enabled. This script is used as post-commit hook, passing only one argument, without the extra arguments the Qt Sanity bot on Gerrit passes, notably the one that supplies $target's value. The with-pickbot code thus got exercised in a new way, leading to a bogus warning. Change-Id: If4e035300d6017a7398e995be96e3dee2a0969ed Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>
Diffstat (limited to 'util')
0 files changed, 0 insertions, 0 deletions