Qt Designer: introduce member initialization

Fix warnings emitted by clang, use default constructors where
applicable.

Initialize remaining member variables about which clang warns
about missing initialization in the constructor.

Change-Id: Ic23a1f36f7507dc728ca6daf0d2067727125c0a9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 

1 files changed, 10 insertions, 23 deletions

diff --git a/src/designer/src/lib/shared/iconselector.cpp b/src/designer/src/lib/shared/iconselector.cpp
index 139d61b90..d2bf33a13 100644
--- a/src/designer/src/lib/shared/iconselector.cpp
+++ b/src/designer/src/lib/shared/iconselector.cpp
@@ -176,10 +176,10 @@ static inline QPixmap emptyPixmap()
 
 class IconSelectorPrivate
 {
-    IconSelector *q_ptr;
+    IconSelector *q_ptr = nullptr;
     Q_DECLARE_PUBLIC(IconSelector)
 public:
-    IconSelectorPrivate();
+    IconSelectorPrivate() = default;
 
     void slotStateActivated();
     void slotSetActivated();
@@ -195,30 +195,17 @@ public:
     QMap<int, QPair<QIcon::Mode, QIcon::State> > m_indexToState;
 
     const QIcon m_emptyIcon;
-    QComboBox *m_stateComboBox;
-    QToolButton *m_iconButton;
-    QAction *m_resetAction;
-    QAction *m_resetAllAction;
+    QComboBox *m_stateComboBox = nullptr;
+    QToolButton *m_iconButton = nullptr;
+    QAction *m_resetAction = nullptr;
+    QAction *m_resetAllAction = nullptr;
     PropertySheetIconValue m_icon;
-    DesignerIconCache *m_iconCache;
-    DesignerPixmapCache *m_pixmapCache;
-    QtResourceModel *m_resourceModel;
-    QDesignerFormEditorInterface *m_core;
+    DesignerIconCache *m_iconCache = nullptr;
+    DesignerPixmapCache *m_pixmapCache = nullptr;
+    QtResourceModel *m_resourceModel = nullptr;
+    QDesignerFormEditorInterface *m_core = nullptr;
 };
 
-IconSelectorPrivate::IconSelectorPrivate() :
-    q_ptr(0),
-    m_emptyIcon(emptyPixmap()),
-    m_stateComboBox(0),
-    m_iconButton(0),
-    m_resetAction(0),
-    m_resetAllAction(0),
-    m_iconCache(0),
-    m_pixmapCache(0),
-    m_resourceModel(0),
-    m_core(0)
-{
-}
 void IconSelectorPrivate::slotUpdate()
 {
     QIcon icon;