summaryrefslogtreecommitdiff
path: root/src/qdoc/generator.cpp
diff options
context:
space:
mode:
authorPaul Wicking <paul.wicking@qt.io>2019-10-01 10:00:24 +0200
committerPaul Wicking <paul.wicking@qt.io>2019-10-03 09:16:25 +0200
commita7fc802e9fcdad21377a8c4967a70ffc4c050014 (patch)
treec07b695cf2556ef72da3e51a857b0e8f8a6f2608 /src/qdoc/generator.cpp
parentbe238aae25d2a8a9eed9da382f8ba769beb87be5 (diff)
downloadqttools-a7fc802e9fcdad21377a8c4967a70ffc4c050014.tar.gz
QDoc: minor cleanup in Generator and Node
Generator: * Don't sort container of QMap's keys as they're already sorted. The container can thus be made const. Node: * Make getter const * Remove qAsConst used in a ranged for loop in a const method. Both: * Remove qAsConst rendered superfluous. Change-Id: I8f65f87c0ed372573cdd17f96e95cd2732effdd7 Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/qdoc/generator.cpp')
-rw-r--r--src/qdoc/generator.cpp12
1 files changed, 4 insertions, 8 deletions
diff --git a/src/qdoc/generator.cpp b/src/qdoc/generator.cpp
index 9f7e65205..e7088c610 100644
--- a/src/qdoc/generator.cpp
+++ b/src/qdoc/generator.cpp
@@ -205,10 +205,8 @@ int Generator::appendSortedNames(Text &text, const ClassNode *cn, const QList<Re
++r;
}
- QStringList classNames = classMap.keys();
- classNames.sort();
-
- for (const auto &className : qAsConst(classNames)) {
+ const QStringList classNames = classMap.keys();
+ for (const auto &className : classNames) {
text << classMap[className];
text << comma(index++, classNames.count());
}
@@ -229,10 +227,8 @@ int Generator::appendSortedQmlNames(Text &text, const Node *base, const NodeList
}
}
- QStringList names = classMap.keys();
- names.sort();
-
- for (const auto &name : qAsConst(names)) {
+ const QStringList names = classMap.keys();
+ for (const auto &name : names) {
text << classMap[name];
text << comma(index++, names.count());
}