diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
| commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
| tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/base/README.md | |
| parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
| download | qtwebengine-chromium-85-based.tar.gz | |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/base/README.md')
| -rw-r--r-- | chromium/base/README.md | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/chromium/base/README.md b/chromium/base/README.md index da452ce9c70..7f6240c054b 100644 --- a/chromium/base/README.md +++ b/chromium/base/README.md @@ -7,10 +7,9 @@ Please add to it! Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful. -Base is pulled into many projects. For example, various ChromeOS daemons. So -the bar for adding stuff is that it must have demonstrated wide +The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. "not -base"), and pull into base only when needed. In a project our size, +base"), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable. Adding a new logging macro `DPVELOG_NE` is not more clear than just @@ -21,6 +20,13 @@ If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead. +base is written for the Chromium project and is not intended to be used +outside it. Using base outside of src.git is explicitly not supported, +and base makes no guarantees about API (or even ABI) stability (like all +other code in Chromium). New code that depends on base/ must be in +src.git. Code that's not in src.git but pulled in through DEPS (for +example, v8) cannot use base. + ## Qualifications for being in //base OWNERS * interest and ability to learn low level/high detail/complex c++ stuff * inclination to always ask why and understand everything (including external |