diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/chrome/browser/extensions/api/declarative | |
parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
download | qtwebengine-chromium-85-based.tar.gz |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/chrome/browser/extensions/api/declarative')
-rw-r--r-- | chromium/chrome/browser/extensions/api/declarative/declarative_apitest.cc | 20 | ||||
-rw-r--r-- | chromium/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc | 26 |
2 files changed, 15 insertions, 31 deletions
diff --git a/chromium/chrome/browser/extensions/api/declarative/declarative_apitest.cc b/chromium/chrome/browser/extensions/api/declarative/declarative_apitest.cc index 13265b25237..06daba2fe34 100644 --- a/chromium/chrome/browser/extensions/api/declarative/declarative_apitest.cc +++ b/chromium/chrome/browser/extensions/api/declarative/declarative_apitest.cc @@ -199,18 +199,9 @@ IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, PersistRules) { EXPECT_EQ(kTestTitle, GetTitle()); } -// Disabled for flakiness: http://crbug.com/851854 -#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER) -#define MAYBE_ExtensionLifetimeRulesHandling \ - DISABLED_ExtensionLifetimeRulesHandling -#else -#define MAYBE_ExtensionLifetimeRulesHandling ExtensionLifetimeRulesHandling -#endif - // Test that the rules are correctly persisted and (de)activated during // changing the "installed" and "enabled" status of an extension. -IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, - MAYBE_ExtensionLifetimeRulesHandling) { +IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, ExtensionLifetimeRulesHandling) { TestExtensionDir ext_dir; // 1. Install the extension. Rules should become active. @@ -276,17 +267,10 @@ IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, EXPECT_EQ(0u, NumberOfRegisteredRules(extension_id)); } -// Disabled for flakiness: http://crbug.com/851854 -#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER) -#define MAYBE_NoTracesAfterUninstalling DISABLED_NoTracesAfterUninstalling -#else -#define MAYBE_NoTracesAfterUninstalling NoTracesAfterUninstalling -#endif - // When an extension is uninstalled, the state store deletes all preferences // stored for that extension. We need to make sure we don't store anything after // that deletion occurs. -IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, MAYBE_NoTracesAfterUninstalling) { +IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, NoTracesAfterUninstalling) { TestExtensionDir ext_dir; // 1. Install the extension. Verify that rules become active and some prefs diff --git a/chromium/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc b/chromium/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc index 8b25d8e15ff..97ef56d188a 100644 --- a/chromium/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc +++ b/chromium/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc @@ -10,11 +10,11 @@ #include "base/bind.h" #include "base/run_loop.h" #include "base/strings/stringprintf.h" -#include "base/task/post_task.h" #include "chrome/test/base/testing_profile.h" #include "components/version_info/channel.h" #include "components/version_info/version_info.h" #include "content/public/browser/browser_task_traits.h" +#include "content/public/browser/browser_thread.h" #include "content/public/test/browser_task_environment.h" #include "extensions/browser/api/declarative/test_rules_registry.h" #include "extensions/browser/api/declarative_webrequest/webrequest_constants.h" @@ -84,23 +84,23 @@ TEST_F(RulesRegistryServiceTest, TestConstructionAndMultiThreading) { EXPECT_TRUE(registry_service.GetRulesRegistry(key, "io").get()); EXPECT_FALSE(registry_service.GetRulesRegistry(key, "foo").get()); - base::PostTask( - FROM_HERE, {content::BrowserThread::UI}, + content::GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(&InsertRule, registry_service.GetRulesRegistry(key, "ui"), "ui_task")); - base::PostTask( - FROM_HERE, {content::BrowserThread::IO}, + content::GetIOThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(&InsertRule, registry_service.GetRulesRegistry(key, "io"), "io_task")); - base::PostTask( - FROM_HERE, {content::BrowserThread::UI}, + content::GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(&VerifyNumberOfRules, registry_service.GetRulesRegistry(key, "ui"), 1)); - base::PostTask( - FROM_HERE, {content::BrowserThread::IO}, + content::GetIOThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(&VerifyNumberOfRules, registry_service.GetRulesRegistry(key, "io"), 1)); @@ -120,13 +120,13 @@ TEST_F(RulesRegistryServiceTest, TestConstructionAndMultiThreading) { .Build(); registry_service.SimulateExtensionUninstalled(extension.get()); - base::PostTask( - FROM_HERE, {content::BrowserThread::UI}, + content::GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(&VerifyNumberOfRules, registry_service.GetRulesRegistry(key, "ui"), 0)); - base::PostTask( - FROM_HERE, {content::BrowserThread::IO}, + content::GetIOThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(&VerifyNumberOfRules, registry_service.GetRulesRegistry(key, "io"), 0)); |