diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
| commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
| tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/chromeos/components/media_app_ui | |
| parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
| download | qtwebengine-chromium-85-based.tar.gz | |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/chromeos/components/media_app_ui')
| -rw-r--r-- | chromium/chromeos/components/media_app_ui/resources/js/BUILD.gn | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/chromium/chromeos/components/media_app_ui/resources/js/BUILD.gn b/chromium/chromeos/components/media_app_ui/resources/js/BUILD.gn index 2d9eff502cb..643bc13ac0b 100644 --- a/chromium/chromeos/components/media_app_ui/resources/js/BUILD.gn +++ b/chromium/chromeos/components/media_app_ui/resources/js/BUILD.gn @@ -4,9 +4,18 @@ import("//third_party/closure_compiler/compile_js.gni") +# Lint checks are not well documented, but pick up some useful stuff. Currently +# require it to be requested in developer builds only. +enable_lint_checks = false + # Note we compile with reportUnknownTypes while it works, but if dependencies # get more complex, we should remove it and only enable in developer builds. media_closure_flags = default_closure_args + [ + "conformance_configs " + rebase_path( + "../../../web_applications/closure_conformance_checks.txt", + root_build_dir), + "jscomp_error=conformanceViolations", + "jscomp_error=strictCheckTypes", "jscomp_error=reportUnknownTypes", "language_in=ECMASCRIPT_2018", @@ -17,6 +26,13 @@ media_closure_flags = default_closure_args + [ "hide_warnings_for=chromeos/components/media_app_ui/media_app_ui.mojom-lite-for-compile.js", ] +if (enable_lint_checks) { + media_closure_flags += [ + "jscomp_error=lintChecks", + "hide_warnings_for=mojo/public/interfaces/bindings", + ] +} + group("closure_compile") { deps = [ ":closure_compile_app", |