diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/components/arc/rotation_lock | |
parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
download | qtwebengine-chromium-85-based.tar.gz |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/components/arc/rotation_lock')
-rw-r--r-- | chromium/components/arc/rotation_lock/arc_rotation_lock_bridge.cc | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/chromium/components/arc/rotation_lock/arc_rotation_lock_bridge.cc b/chromium/components/arc/rotation_lock/arc_rotation_lock_bridge.cc index e3b073b1f82..9a7cc716baf 100644 --- a/chromium/components/arc/rotation_lock/arc_rotation_lock_bridge.cc +++ b/chromium/components/arc/rotation_lock/arc_rotation_lock_bridge.cc @@ -47,7 +47,7 @@ ArcRotationLockBridge::ArcRotationLockBridge(content::BrowserContext* context, ArcBridgeService* bridge_service) : arc_bridge_service_(bridge_service) { arc_bridge_service_->rotation_lock()->AddObserver(this); - // TODO(mash): Support this functionality without ash::Shell access in Chrome. + // ash::Shell may not exist in tests. if (ash::Shell::HasInstance()) { ash::Shell::Get()->screen_orientation_controller()->AddObserver(this); ash::Shell::Get()->tablet_mode_controller()->AddObserver(this); @@ -56,8 +56,7 @@ ArcRotationLockBridge::ArcRotationLockBridge(content::BrowserContext* context, ArcRotationLockBridge::~ArcRotationLockBridge() { arc_bridge_service_->rotation_lock()->RemoveObserver(this); - // TODO(mus): mus needs proper shutdown process. - // TODO(mash): Support this functionality without ash::Shell access in Chrome. + // ash::Shell may not exist in tests. if (ash::Shell::HasInstance()) { ash::Shell::Get()->screen_orientation_controller()->RemoveObserver(this); ash::Shell::Get()->tablet_mode_controller()->RemoveObserver(this); @@ -77,7 +76,7 @@ void ArcRotationLockBridge::OnTabletPhysicalStateChanged() { } void ArcRotationLockBridge::SendRotationLockState() { - // TODO(mash): Support this functionality without ash::Shell access in Chrome. + // ash::Shell may not exist in tests. if (!ash::Shell::HasInstance()) return; |