diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/components/autofill/content/browser | |
parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
download | qtwebengine-chromium-85-based.tar.gz |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/components/autofill/content/browser')
5 files changed, 14 insertions, 26 deletions
diff --git a/chromium/components/autofill/content/browser/content_autofill_driver.cc b/chromium/components/autofill/content/browser/content_autofill_driver.cc index 7cf16fc27ea..ed248d98c85 100644 --- a/chromium/components/autofill/content/browser/content_autofill_driver.cc +++ b/chromium/components/autofill/content/browser/content_autofill_driver.cc @@ -288,17 +288,11 @@ void ContentAutofillDriver::DidEndTextFieldEditing() { autofill_handler_->OnDidEndTextFieldEditing(); } -void ContentAutofillDriver::SetDataList( - const std::vector<base::string16>& values, - const std::vector<base::string16>& labels) { - autofill_handler_->OnSetDataList(values, labels); -} - void ContentAutofillDriver::SelectFieldOptionsDidChange(const FormData& form) { autofill_handler_->SelectFieldOptionsDidChange(form); } -void ContentAutofillDriver::DidNavigateMainFrame( +void ContentAutofillDriver::DidNavigateFrame( content::NavigationHandle* navigation_handle) { if (navigation_handle->IsSameDocument()) return; diff --git a/chromium/components/autofill/content/browser/content_autofill_driver.h b/chromium/components/autofill/content/browser/content_autofill_driver.h index 587b09f7e65..7d201fe0deb 100644 --- a/chromium/components/autofill/content/browser/content_autofill_driver.h +++ b/chromium/components/autofill/content/browser/content_autofill_driver.h @@ -115,13 +115,11 @@ class ContentAutofillDriver : public AutofillDriver, base::TimeTicks timestamp) override; void DidPreviewAutofillFormData() override; void DidEndTextFieldEditing() override; - void SetDataList(const std::vector<base::string16>& values, - const std::vector<base::string16>& labels) override; void SelectFieldOptionsDidChange(const FormData& form) override; - // Called when the main frame has navigated. Explicitely will not trigger for - // subframe navigations. See navigation_handle.h for details. - void DidNavigateMainFrame(content::NavigationHandle* navigation_handle); + // DidNavigateFrame() is called on the frame's driver, respectively, when a + // navigation occurs in that specific frame. + void DidNavigateFrame(content::NavigationHandle* navigation_handle); AutofillManager* autofill_manager() { return autofill_manager_; } AutofillHandler* autofill_handler() { return autofill_handler_.get(); } diff --git a/chromium/components/autofill/content/browser/content_autofill_driver_factory.cc b/chromium/components/autofill/content/browser/content_autofill_driver_factory.cc index 35e691af47c..2738209f51c 100644 --- a/chromium/components/autofill/content/browser/content_autofill_driver_factory.cc +++ b/chromium/components/autofill/content/browser/content_autofill_driver_factory.cc @@ -132,18 +132,13 @@ void ContentAutofillDriverFactory::RenderFrameDeleted( void ContentAutofillDriverFactory::DidFinishNavigation( content::NavigationHandle* navigation_handle) { - // For the purposes of this code, a navigation is not important if it has not - // committed yet or if it's in a subframe. - if (!navigation_handle->HasCommitted() || - !navigation_handle->IsInMainFrame()) { - return; + if (navigation_handle->HasCommitted() && + (navigation_handle->IsInMainFrame() || + navigation_handle->HasSubframeNavigationEntryCommitted())) { + NavigationFinished(); + DriverForFrame(navigation_handle->GetRenderFrameHost()) + ->DidNavigateFrame(navigation_handle); } - - // A main frame navigation has occured. We suppress the autofill popup and - // tell the autofill driver. - NavigationFinished(); - DriverForFrame(navigation_handle->GetRenderFrameHost()) - ->DidNavigateMainFrame(navigation_handle); } void ContentAutofillDriverFactory::OnVisibilityChanged( diff --git a/chromium/components/autofill/content/browser/content_autofill_driver_unittest.cc b/chromium/components/autofill/content/browser/content_autofill_driver_unittest.cc index cc75354a844..335cde6bf11 100644 --- a/chromium/components/autofill/content/browser/content_autofill_driver_unittest.cc +++ b/chromium/components/autofill/content/browser/content_autofill_driver_unittest.cc @@ -282,7 +282,7 @@ class TestContentAutofillDriver : public ContentAutofillDriver { return static_cast<MockAutofillManager*>(autofill_manager()); } - using ContentAutofillDriver::DidNavigateMainFrame; + using ContentAutofillDriver::DidNavigateFrame; }; class ContentAutofillDriverTest : public content::RenderViewHostTestHarness { @@ -316,7 +316,7 @@ class ContentAutofillDriverTest : public content::RenderViewHostTestHarness { content::MockNavigationHandle navigation_handle(GURL(), main_rfh()); navigation_handle.set_has_committed(true); navigation_handle.set_is_same_document(same_document); - driver_->DidNavigateMainFrame(&navigation_handle); + driver_->DidNavigateFrame(&navigation_handle); } protected: diff --git a/chromium/components/autofill/content/browser/risk/fingerprint.cc b/chromium/components/autofill/content/browser/risk/fingerprint.cc index 35475b3d8a0..b7aa9f45bb9 100644 --- a/chromium/components/autofill/content/browser/risk/fingerprint.cc +++ b/chromium/components/autofill/content/browser/risk/fingerprint.cc @@ -51,6 +51,7 @@ #include "ui/display/display.h" #include "ui/display/screen.h" #include "ui/gfx/geometry/rect.h" +#include "url/gurl.h" #if BUILDFLAG(ENABLE_PLUGINS) #include "content/public/browser/plugin_service.h" @@ -316,7 +317,7 @@ FingerprintDataLoader::FingerprintDataLoader( content::GetDeviceService().BindGeolocationContext( geolocation_context_.BindNewPipeAndPassReceiver()); geolocation_context_->BindGeolocation( - geolocation_.BindNewPipeAndPassReceiver()); + geolocation_.BindNewPipeAndPassReceiver(), GURL::EmptyGURL()); geolocation_->SetHighAccuracy(false); geolocation_->QueryNextPosition( base::BindOnce(&FingerprintDataLoader::OnGotGeoposition, |