summaryrefslogtreecommitdiff
path: root/chromium/components/previews/content
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2020-10-12 14:27:29 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2020-10-13 09:35:20 +0000
commitc30a6232df03e1efbd9f3b226777b07e087a1122 (patch)
treee992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/components/previews/content
parent7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff)
downloadqtwebengine-chromium-85-based.tar.gz
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/components/previews/content')
-rw-r--r--chromium/components/previews/content/BUILD.gn4
-rw-r--r--chromium/components/previews/content/DEPS2
-rw-r--r--chromium/components/previews/content/previews_decider_impl.cc80
-rw-r--r--chromium/components/previews/content/previews_decider_impl.h68
-rw-r--r--chromium/components/previews/content/previews_decider_impl_unittest.cc461
-rw-r--r--chromium/components/previews/content/previews_optimization_guide.cc5
-rw-r--r--chromium/components/previews/content/previews_optimization_guide.h5
-rw-r--r--chromium/components/previews/content/previews_optimization_guide_unittest.cc8
-rw-r--r--chromium/components/previews/content/previews_ui_service.cc38
-rw-r--r--chromium/components/previews/content/previews_ui_service.h50
-rw-r--r--chromium/components/previews/content/previews_ui_service_unittest.cc121
-rw-r--r--chromium/components/previews/content/previews_user_data.cc15
-rw-r--r--chromium/components/previews/content/previews_user_data.h57
-rw-r--r--chromium/components/previews/content/previews_user_data_unittest.cc12
14 files changed, 482 insertions, 444 deletions
diff --git a/chromium/components/previews/content/BUILD.gn b/chromium/components/previews/content/BUILD.gn
index 6e05b72df2f..1c6330e7e0e 100644
--- a/chromium/components/previews/content/BUILD.gn
+++ b/chromium/components/previews/content/BUILD.gn
@@ -17,7 +17,7 @@ static_library("content") {
deps = [
"//base",
- "//components/blacklist/opt_out_blacklist",
+ "//components/blocklist/opt_out_blocklist",
"//components/data_reduction_proxy/core/browser",
"//components/optimization_guide",
"//components/optimization_guide/proto:optimization_guide_proto",
@@ -43,7 +43,7 @@ source_set("unit_tests") {
deps = [
":content",
"//base",
- "//components/blacklist/opt_out_blacklist",
+ "//components/blocklist/opt_out_blocklist",
"//components/data_reduction_proxy/core/browser",
"//components/data_reduction_proxy/core/common",
"//components/optimization_guide",
diff --git a/chromium/components/previews/content/DEPS b/chromium/components/previews/content/DEPS
index 39e29e96860..db5594d7ff8 100644
--- a/chromium/components/previews/content/DEPS
+++ b/chromium/components/previews/content/DEPS
@@ -1,5 +1,5 @@
include_rules = [
- "+components/blacklist/opt_out_blacklist",
+ "+components/blocklist/opt_out_blocklist",
"+components/data_reduction_proxy/core/browser",
"+components/data_reduction_proxy/core/common",
"+components/keyed_service",
diff --git a/chromium/components/previews/content/previews_decider_impl.cc b/chromium/components/previews/content/previews_decider_impl.cc
index dc22202f2d6..d53bea918bc 100644
--- a/chromium/components/previews/content/previews_decider_impl.cc
+++ b/chromium/components/previews/content/previews_decider_impl.cc
@@ -19,7 +19,7 @@
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
#include "base/time/clock.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_store.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_store.h"
#include "components/previews/content/previews_ui_service.h"
#include "components/previews/content/previews_user_data.h"
#include "components/previews/core/previews_experiments.h"
@@ -94,7 +94,7 @@ bool IsCommitTimePreview(PreviewsType type) {
} // namespace
PreviewsDeciderImpl::PreviewsDeciderImpl(base::Clock* clock)
- : blacklist_ignored_(switches::ShouldIgnorePreviewsBlacklist()),
+ : blocklist_ignored_(switches::ShouldIgnorePreviewsBlocklist()),
clock_(clock),
page_id_(1u) {}
@@ -104,41 +104,41 @@ PreviewsDeciderImpl::~PreviewsDeciderImpl() {
void PreviewsDeciderImpl::Initialize(
PreviewsUIService* previews_ui_service,
- std::unique_ptr<blacklist::OptOutStore> previews_opt_out_store,
+ std::unique_ptr<blocklist::OptOutStore> previews_opt_out_store,
std::unique_ptr<PreviewsOptimizationGuide> previews_opt_guide,
const PreviewsIsEnabledCallback& is_enabled_callback,
- blacklist::BlacklistData::AllowedTypesAndVersions allowed_previews) {
+ blocklist::BlocklistData::AllowedTypesAndVersions allowed_previews) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(!is_enabled_callback.is_null());
is_enabled_callback_ = is_enabled_callback;
previews_ui_service_ = previews_ui_service;
previews_opt_guide_ = std::move(previews_opt_guide);
- previews_black_list_ = std::make_unique<PreviewsBlackList>(
+ previews_block_list_ = std::make_unique<PreviewsBlockList>(
std::move(previews_opt_out_store), clock_, this,
std::move(allowed_previews));
}
-void PreviewsDeciderImpl::OnNewBlacklistedHost(const std::string& host,
+void PreviewsDeciderImpl::OnNewBlocklistedHost(const std::string& host,
base::Time time) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- previews_ui_service_->OnNewBlacklistedHost(host, time);
+ previews_ui_service_->OnNewBlocklistedHost(host, time);
}
-void PreviewsDeciderImpl::OnUserBlacklistedStatusChange(bool blacklisted) {
+void PreviewsDeciderImpl::OnUserBlocklistedStatusChange(bool blocklisted) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- previews_ui_service_->OnUserBlacklistedStatusChange(blacklisted);
+ previews_ui_service_->OnUserBlocklistedStatusChange(blocklisted);
}
-void PreviewsDeciderImpl::OnBlacklistCleared(base::Time time) {
+void PreviewsDeciderImpl::OnBlocklistCleared(base::Time time) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- previews_ui_service_->OnBlacklistCleared(time);
+ previews_ui_service_->OnBlocklistCleared(time);
}
-void PreviewsDeciderImpl::SetPreviewsBlacklistForTesting(
- std::unique_ptr<PreviewsBlackList> previews_back_list) {
+void PreviewsDeciderImpl::SetPreviewsBlocklistForTesting(
+ std::unique_ptr<PreviewsBlockList> previews_block_list) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- previews_black_list_ = std::move(previews_back_list);
+ previews_block_list_ = std::move(previews_block_list);
}
void PreviewsDeciderImpl::LogPreviewNavigation(const GURL& url,
@@ -170,22 +170,22 @@ void PreviewsDeciderImpl::AddPreviewNavigation(const GURL& url,
uint64_t page_id) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
base::Time time =
- previews_black_list_->AddPreviewNavigation(url, opt_out, type);
+ previews_block_list_->AddPreviewNavigation(url, opt_out, type);
LogPreviewNavigation(url, opt_out, type, time, page_id);
}
-void PreviewsDeciderImpl::ClearBlackList(base::Time begin_time,
+void PreviewsDeciderImpl::ClearBlockList(base::Time begin_time,
base::Time end_time) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- previews_black_list_->ClearBlackList(begin_time, end_time);
+ previews_block_list_->ClearBlockList(begin_time, end_time);
}
-void PreviewsDeciderImpl::SetIgnorePreviewsBlacklistDecision(bool ignored) {
+void PreviewsDeciderImpl::SetIgnorePreviewsBlocklistDecision(bool ignored) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- blacklist_ignored_ = ignored;
- previews_ui_service_->OnIgnoreBlacklistDecisionStatusChanged(
- blacklist_ignored_);
+ blocklist_ignored_ = ignored;
+ previews_ui_service_->OnIgnoreBlocklistDecisionStatusChanged(
+ blocklist_ignored_);
}
bool PreviewsDeciderImpl::ShouldAllowPreviewAtNavigationStart(
@@ -319,14 +319,14 @@ PreviewsEligibilityReason PreviewsDeciderImpl::DeterminePreviewEligibility(
}
}
- // Skip blacklist checks if the blacklist is ignored or defer check until
+ // Skip blocklist checks if the blocklist is ignored or defer check until
// commit time if preview type is to be decided at commit time.
- if (!blacklist_ignored_ && !IsCommitTimePreview(type)) {
+ if (!blocklist_ignored_ && !IsCommitTimePreview(type)) {
PreviewsEligibilityReason status =
- CheckLocalBlacklist(url, type, is_drp_server_preview, passed_reasons);
+ CheckLocalBlocklist(url, type, is_drp_server_preview, passed_reasons);
if (status != PreviewsEligibilityReason::ALLOWED) {
if (type == PreviewsType::LITE_PAGE) {
- previews_data->set_black_listed_for_lite_page(true);
+ previews_data->set_block_listed_for_lite_page(true);
}
return status;
}
@@ -335,14 +335,14 @@ PreviewsEligibilityReason PreviewsDeciderImpl::DeterminePreviewEligibility(
return PreviewsEligibilityReason::ALLOWED;
}
-PreviewsEligibilityReason PreviewsDeciderImpl::CheckLocalBlacklist(
+PreviewsEligibilityReason PreviewsDeciderImpl::CheckLocalBlocklist(
const GURL& url,
PreviewsType type,
bool is_drp_server_preview,
std::vector<PreviewsEligibilityReason>* passed_reasons) const {
- if (!previews_black_list_)
- return PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE;
- passed_reasons->push_back(PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE);
+ if (!previews_block_list_)
+ return PreviewsEligibilityReason::BLOCKLIST_UNAVAILABLE;
+ passed_reasons->push_back(PreviewsEligibilityReason::BLOCKLIST_UNAVAILABLE);
// Trigger the USER_RECENTLY_OPTED_OUT rule when a reload on a preview has
// occurred recently. No need to push_back the eligibility reason as it will
@@ -353,11 +353,11 @@ PreviewsEligibilityReason PreviewsDeciderImpl::CheckLocalBlacklist(
return PreviewsEligibilityReason::USER_RECENTLY_OPTED_OUT;
}
- // The blacklist will disallow certain hosts for periods of time based on
+ // The blocklist will disallow certain hosts for periods of time based on
// user's opting out of the preview.
- return previews_black_list_->IsLoadedAndAllowed(
+ return previews_block_list_->IsLoadedAndAllowed(
url, type,
- is_drp_server_preview && ignore_long_term_blacklist_for_server_previews_,
+ is_drp_server_preview && ignore_long_term_blocklist_for_server_previews_,
passed_reasons);
}
@@ -394,11 +394,11 @@ bool PreviewsDeciderImpl::ShouldCommitPreview(
}
}
- // Check local blacklist for commit-time preview (if blacklist not ignored).
- if (!blacklist_ignored_ && IsCommitTimePreview(type)) {
+ // Check local blocklist for commit-time preview (if blocklist not ignored).
+ if (!blocklist_ignored_ && IsCommitTimePreview(type)) {
std::vector<PreviewsEligibilityReason> passed_reasons;
PreviewsEligibilityReason status =
- CheckLocalBlacklist(committed_url, type, false, &passed_reasons);
+ CheckLocalBlocklist(committed_url, type, false, &passed_reasons);
if (status != PreviewsEligibilityReason::ALLOWED) {
LogPreviewDecisionMade(status, committed_url, clock_->Now(), type,
std::move(passed_reasons), previews_data);
@@ -454,7 +454,7 @@ PreviewsDeciderImpl::ShouldCommitPreviewPerOptimizationHints(
passed_reasons->push_back(
PreviewsEligibilityReason::PAGE_LOAD_PREDICTION_NOT_PAINFUL);
- // Check if request URL is whitelisted by the optimization guide.
+ // Check if request URL is allowlisted by the optimization guide.
if (!previews_opt_guide_->CanApplyPreview(previews_data, navigation_handle,
type)) {
return PreviewsEligibilityReason::NOT_ALLOWED_BY_OPTIMIZATION_GUIDE;
@@ -495,11 +495,11 @@ uint64_t PreviewsDeciderImpl::GeneratePageId() {
return ++page_id_;
}
-void PreviewsDeciderImpl::SetIgnoreLongTermBlackListForServerPreviews(
- bool ignore_long_term_blacklist_for_server_previews) {
+void PreviewsDeciderImpl::SetIgnoreLongTermBlockListForServerPreviews(
+ bool ignore_long_term_blocklist_for_server_previews) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- ignore_long_term_blacklist_for_server_previews_ =
- ignore_long_term_blacklist_for_server_previews;
+ ignore_long_term_blocklist_for_server_previews_ =
+ ignore_long_term_blocklist_for_server_previews;
}
void PreviewsDeciderImpl::SetEffectiveConnectionType(
diff --git a/chromium/components/previews/content/previews_decider_impl.h b/chromium/components/previews/content/previews_decider_impl.h
index b9b1a0b4038..73a9178e803 100644
--- a/chromium/components/previews/content/previews_decider_impl.h
+++ b/chromium/components/previews/content/previews_decider_impl.h
@@ -18,11 +18,11 @@
#include "base/sequence_checker.h"
#include "base/single_thread_task_runner.h"
#include "base/time/time.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_blacklist_data.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_blacklist_delegate.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_blocklist_data.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_blocklist_delegate.h"
#include "components/previews/content/previews_decider.h"
#include "components/previews/content/previews_optimization_guide.h"
-#include "components/previews/core/previews_black_list.h"
+#include "components/previews/core/previews_block_list.h"
#include "components/previews/core/previews_experiments.h"
#include "components/previews/core/previews_logger.h"
#include "net/nqe/effective_connection_type.h"
@@ -32,7 +32,7 @@ namespace base {
class Clock;
}
-namespace blacklist {
+namespace blocklist {
class OptOutStore;
}
@@ -49,24 +49,24 @@ typedef base::RepeatingCallback<bool(PreviewsType)> PreviewsIsEnabledCallback;
// previews/ objects. Created on the UI thread, but used only on the IO thread
// after initialization.
class PreviewsDeciderImpl : public PreviewsDecider,
- public blacklist::OptOutBlacklistDelegate {
+ public blocklist::OptOutBlocklistDelegate {
public:
explicit PreviewsDeciderImpl(base::Clock* clock);
~PreviewsDeciderImpl() override;
- // blacklist::OptOutBlacklistDelegate:
- void OnNewBlacklistedHost(const std::string& host, base::Time time) override;
- void OnUserBlacklistedStatusChange(bool blacklisted) override;
- void OnBlacklistCleared(base::Time time) override;
+ // blocklist::OptOutBlocklistDelegate:
+ void OnNewBlocklistedHost(const std::string& host, base::Time time) override;
+ void OnUserBlocklistedStatusChange(bool blocklisted) override;
+ void OnBlocklistCleared(base::Time time) override;
- // Initializes the blacklist and and stores the passed in members.
+ // Initializes the blocklist and and stores the passed in members.
// |previews_ui_service| owns |this|, and shares the same lifetime.
virtual void Initialize(
PreviewsUIService* previews_ui_service,
- std::unique_ptr<blacklist::OptOutStore> previews_opt_out_store,
+ std::unique_ptr<blocklist::OptOutStore> previews_opt_out_store,
std::unique_ptr<PreviewsOptimizationGuide> previews_opt_guide,
const PreviewsIsEnabledCallback& is_enabled_callback,
- blacklist::BlacklistData::AllowedTypesAndVersions allowed_previews);
+ blocklist::BlocklistData::AllowedTypesAndVersions allowed_previews);
// Adds log message of the navigation asynchronously.
void LogPreviewNavigation(const GURL& url,
@@ -90,24 +90,24 @@ class PreviewsDeciderImpl : public PreviewsDecider,
std::vector<PreviewsEligibilityReason>&& passed_reasons,
PreviewsUserData* user_data) const;
- // Adds a navigation to |url| to the black list with result |opt_out|.
+ // Adds a navigation to |url| to the block list with result |opt_out|.
void AddPreviewNavigation(const GURL& url,
bool opt_out,
PreviewsType type,
uint64_t page_id);
- // Clears the history of the black list between |begin_time| and |end_time|,
+ // Clears the history of the block list between |begin_time| and |end_time|,
// both inclusive. Additional, clears the appropriate data from the hint
// cache. TODO(mcrouse): Rename to denote clearing all necessary data,
- // including the Fetched hints and the blacklist.
- void ClearBlackList(base::Time begin_time, base::Time end_time);
+ // including the Fetched hints and the blocklist.
+ void ClearBlockList(base::Time begin_time, base::Time end_time);
// Change the status of whether to ignore the decisions made by
- // PreviewsBlackList to |ignored|. Virtualized in testing.
- virtual void SetIgnorePreviewsBlacklistDecision(bool ignored);
+ // PreviewsBlockList to |ignored|. Virtualized in testing.
+ virtual void SetIgnorePreviewsBlocklistDecision(bool ignored);
- // The previews black list that decides whether a navigation can use previews.
- PreviewsBlackList* black_list() const { return previews_black_list_.get(); }
+ // The previews block list that decides whether a navigation can use previews.
+ PreviewsBlockList* block_list() const { return previews_block_list_.get(); }
// PreviewsDecider implementation:
bool ShouldAllowPreviewAtNavigationStart(
@@ -119,9 +119,9 @@ class PreviewsDeciderImpl : public PreviewsDecider,
content::NavigationHandle* navigation_handle,
PreviewsType type) const override;
- // Set whether to ignore the long term blacklist rules for server previews.
- void SetIgnoreLongTermBlackListForServerPreviews(
- bool ignore_long_term_blacklist_for_server_previews);
+ // Set whether to ignore the long term blocklist rules for server previews.
+ void SetIgnoreLongTermBlockListForServerPreviews(
+ bool ignore_long_term_blocklist_for_server_previews);
bool AreCommitTimePreviewsAvailable(
content::NavigationHandle* navigation_handle) override;
@@ -142,9 +142,9 @@ class PreviewsDeciderImpl : public PreviewsDecider,
void AddPreviewReload();
protected:
- // Sets a blacklist for testing.
- void SetPreviewsBlacklistForTesting(
- std::unique_ptr<PreviewsBlackList> previews_back_list);
+ // Sets a blocklist for testing.
+ void SetPreviewsBlocklistForTesting(
+ std::unique_ptr<PreviewsBlockList> previews_back_list);
private:
// Returns whether the preview |type| should be considered for |url|.
@@ -163,8 +163,8 @@ class PreviewsDeciderImpl : public PreviewsDecider,
bool is_drp_server_preview,
std::vector<PreviewsEligibilityReason>* passed_reasons) const;
- // Returns previews eligibility with respect to the local blacklist.
- PreviewsEligibilityReason CheckLocalBlacklist(
+ // Returns previews eligibility with respect to the local blocklist.
+ PreviewsEligibilityReason CheckLocalBlocklist(
const GURL& url,
PreviewsType type,
bool is_drp_server_preview,
@@ -192,20 +192,20 @@ class PreviewsDeciderImpl : public PreviewsDecider,
// The UI service object owns |this| and exists as long as |this| does.
PreviewsUIService* previews_ui_service_;
- std::unique_ptr<PreviewsBlackList> previews_black_list_;
+ std::unique_ptr<PreviewsBlockList> previews_block_list_;
// Holds optimization guidance from the server.
std::unique_ptr<PreviewsOptimizationGuide> previews_opt_guide_;
- // Whether the decisions made by PreviewsBlackList should be ignored or not.
+ // Whether the decisions made by PreviewsBlockList should be ignored or not.
// This can be changed by chrome://interventions-internals to test/debug the
// behavior of Previews decisions.
// This is related to a test flag and should only be true when the user has
- // set it in flags. See previews::IsPreviewsBlacklistIgnoredViaFlag.
- bool blacklist_ignored_;
+ // set it in flags. See previews::IsPreviewsBlocklistIgnoredViaFlag.
+ bool blocklist_ignored_;
- // Whether to ignore the blacklist for server previews.
- bool ignore_long_term_blacklist_for_server_previews_ = false;
+ // Whether to ignore the blocklist for server previews.
+ bool ignore_long_term_blocklist_for_server_previews_ = false;
// The estimate of how slow a user's connection is. Used for triggering
// Previews.
diff --git a/chromium/components/previews/content/previews_decider_impl_unittest.cc b/chromium/components/previews/content/previews_decider_impl_unittest.cc
index d03f79ad24f..3cdf1983e4f 100644
--- a/chromium/components/previews/content/previews_decider_impl_unittest.cc
+++ b/chromium/components/previews/content/previews_decider_impl_unittest.cc
@@ -33,10 +33,10 @@
#include "base/time/default_clock.h"
#include "base/time/time.h"
#include "build/build_config.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_blacklist_data.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_blacklist_delegate.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_blacklist_item.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_store.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_blocklist_data.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_blocklist_delegate.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_blocklist_item.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_store.h"
#include "components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h"
#include "components/optimization_guide/optimization_guide_prefs.h"
#include "components/optimization_guide/proto_database_provider_test_base.h"
@@ -44,7 +44,7 @@
#include "components/prefs/testing_pref_service.h"
#include "components/previews/content/previews_ui_service.h"
#include "components/previews/content/previews_user_data.h"
-#include "components/previews/core/previews_black_list.h"
+#include "components/previews/core/previews_block_list.h"
#include "components/previews/core/previews_experiments.h"
#include "components/previews/core/previews_features.h"
#include "components/previews/core/previews_logger.h"
@@ -62,15 +62,15 @@
// TODO(crbug.com/961023): Fix memory leaks in tests and re-enable on LSAN.
#ifdef LEAK_SANITIZER
-#define MAYBE_TestSetBlacklistBoolDueToBlackListState \
- DISABLED_TestSetBlacklistBoolDueToBlackListState
-#define MAYBE_TestDisallowPreviewBecauseOfBlackListState \
- DISABLED_TestDisallowPreviewBecauseOfBlackListState
+#define MAYBE_TestSetBlocklistBoolDueToBlockListState \
+ DISABLED_TestSetBlocklistBoolDueToBlockListState
+#define MAYBE_TestDisallowPreviewBecauseOfBlockListState \
+ DISABLED_TestDisallowPreviewBecauseOfBlockListState
#else
-#define MAYBE_TestSetBlacklistBoolDueToBlackListState \
- TestSetBlacklistBoolDueToBlackListState
-#define MAYBE_TestDisallowPreviewBecauseOfBlackListState \
- TestDisallowPreviewBecauseOfBlackListState
+#define MAYBE_TestSetBlocklistBoolDueToBlockListState \
+ TestSetBlocklistBoolDueToBlockListState
+#define MAYBE_TestDisallowPreviewBecauseOfBlockListState \
+ TestDisallowPreviewBecauseOfBlockListState
#endif
namespace previews {
@@ -109,32 +109,32 @@ bool IsPreviewFieldTrialEnabled(PreviewsType type) {
return false;
}
-// Stub class of PreviewsBlackList to control IsLoadedAndAllowed outcome when
+// Stub class of PreviewsBlockList to control IsLoadedAndAllowed outcome when
// testing PreviewsDeciderImpl.
-class TestPreviewsBlackList : public PreviewsBlackList {
+class TestPreviewsBlockList : public PreviewsBlockList {
public:
- TestPreviewsBlackList(PreviewsEligibilityReason status,
- blacklist::OptOutBlacklistDelegate* blacklist_delegate)
- : PreviewsBlackList(nullptr,
+ TestPreviewsBlockList(PreviewsEligibilityReason status,
+ blocklist::OptOutBlocklistDelegate* blocklist_delegate)
+ : PreviewsBlockList(nullptr,
base::DefaultClock::GetInstance(),
- blacklist_delegate,
+ blocklist_delegate,
{}),
status_(status) {}
- ~TestPreviewsBlackList() override {}
+ ~TestPreviewsBlockList() override = default;
- // PreviewsBlackList:
+ // PreviewsBlockList:
PreviewsEligibilityReason IsLoadedAndAllowed(
const GURL& url,
PreviewsType type,
- bool ignore_long_term_black_list_rules,
+ bool ignore_long_term_block_list_rules,
std::vector<PreviewsEligibilityReason>* passed_reasons) const override {
std::vector<PreviewsEligibilityReason> ordered_reasons = {
- PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED,
+ PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED,
PreviewsEligibilityReason::USER_RECENTLY_OPTED_OUT};
- if (!ignore_long_term_black_list_rules) {
- ordered_reasons.push_back(PreviewsEligibilityReason::USER_BLACKLISTED);
- ordered_reasons.push_back(PreviewsEligibilityReason::HOST_BLACKLISTED);
+ if (!ignore_long_term_block_list_rules) {
+ ordered_reasons.push_back(PreviewsEligibilityReason::USER_BLOCKLISTED);
+ ordered_reasons.push_back(PreviewsEligibilityReason::HOST_BLOCKLISTED);
}
for (auto reason : ordered_reasons) {
@@ -189,19 +189,19 @@ class TestPreviewsOptimizationGuide
const GURL url = navigation_handle->GetURL();
if (type == PreviewsType::NOSCRIPT) {
- return url.host().compare("whitelisted.example.com") == 0 ||
- url.host().compare("noscript_only_whitelisted.example.com") == 0;
+ return url.host().compare("allowlisted.example.com") == 0 ||
+ url.host().compare("noscript_only_allowlisted.example.com") == 0;
}
if (type == PreviewsType::RESOURCE_LOADING_HINTS ||
type == PreviewsType::DEFER_ALL_SCRIPT) {
- return url.host().compare("whitelisted.example.com") == 0;
+ return url.host().compare("allowlisted.example.com") == 0;
}
return false;
}
// Returns whether the URL associated with |navigation_handle| should be
- // blacklisted from |type|.
- bool IsBlacklisted(content::NavigationHandle* navigation_handle,
+ // blocklisted from |type|.
+ bool IsBlocklisted(content::NavigationHandle* navigation_handle,
PreviewsType type) const {
return false;
}
@@ -218,11 +218,11 @@ class TestPreviewsUIService : public PreviewsUIService {
public:
TestPreviewsUIService(
std::unique_ptr<PreviewsDeciderImpl> previews_decider_impl,
- std::unique_ptr<blacklist::OptOutStore> previews_opt_out_store,
+ std::unique_ptr<blocklist::OptOutStore> previews_opt_out_store,
std::unique_ptr<PreviewsOptimizationGuide> previews_opt_guide,
const PreviewsIsEnabledCallback& is_enabled_callback,
std::unique_ptr<PreviewsLogger> logger,
- blacklist::BlacklistData::AllowedTypesAndVersions allowed_types,
+ blocklist::BlocklistData::AllowedTypesAndVersions allowed_types,
network::NetworkQualityTracker* network_quality_tracker)
: PreviewsUIService(std::move(previews_decider_impl),
std::move(previews_opt_out_store),
@@ -231,22 +231,22 @@ class TestPreviewsUIService : public PreviewsUIService {
std::move(logger),
std::move(allowed_types),
network_quality_tracker),
- user_blacklisted_(false),
- blacklist_ignored_(false) {}
+ user_blocklisted_(false),
+ blocklist_ignored_(false) {}
// PreviewsUIService:
- void OnNewBlacklistedHost(const std::string& host, base::Time time) override {
- host_blacklisted_ = host;
- host_blacklisted_time_ = time;
+ void OnNewBlocklistedHost(const std::string& host, base::Time time) override {
+ host_blocklisted_ = host;
+ host_blocklisted_time_ = time;
}
- void OnUserBlacklistedStatusChange(bool blacklisted) override {
- user_blacklisted_ = blacklisted;
+ void OnUserBlocklistedStatusChange(bool blocklisted) override {
+ user_blocklisted_ = blocklisted;
}
- void OnBlacklistCleared(base::Time time) override {
- blacklist_cleared_time_ = time;
+ void OnBlocklistCleared(base::Time time) override {
+ blocklist_cleared_time_ = time;
}
- void OnIgnoreBlacklistDecisionStatusChanged(bool ignored) override {
- blacklist_ignored_ = ignored;
+ void OnIgnoreBlocklistDecisionStatusChanged(bool ignored) override {
+ blocklist_ignored_ = ignored;
}
// Expose passed in LogPreviewDecision parameters.
@@ -281,14 +281,14 @@ class TestPreviewsUIService : public PreviewsUIService {
return navigation_page_ids_;
}
- // Expose passed in params for hosts and user blacklist event.
- std::string host_blacklisted() const { return host_blacklisted_; }
- base::Time host_blacklisted_time() const { return host_blacklisted_time_; }
- bool user_blacklisted() const { return user_blacklisted_; }
- base::Time blacklist_cleared_time() const { return blacklist_cleared_time_; }
+ // Expose passed in params for hosts and user blocklist event.
+ std::string host_blocklisted() const { return host_blocklisted_; }
+ base::Time host_blocklisted_time() const { return host_blocklisted_time_; }
+ bool user_blocklisted() const { return user_blocklisted_; }
+ base::Time blocklist_cleared_time() const { return blocklist_cleared_time_; }
- // Expose the status of blacklist decisions ignored.
- bool blacklist_ignored() const { return blacklist_ignored_; }
+ // Expose the status of blocklist decisions ignored.
+ bool blocklist_ignored() const { return blocklist_ignored_; }
private:
// PreviewsUIService:
@@ -319,11 +319,11 @@ class TestPreviewsUIService : public PreviewsUIService {
decision_ids_.push_back(page_id);
}
- // Passed in params for blacklist status events.
- std::string host_blacklisted_;
- base::Time host_blacklisted_time_;
- bool user_blacklisted_;
- base::Time blacklist_cleared_time_;
+ // Passed in params for blocklist status events.
+ std::string host_blocklisted_;
+ base::Time host_blocklisted_time_;
+ bool user_blocklisted_;
+ base::Time blocklist_cleared_time_;
// Passed in LogPreviewDecision parameters.
std::vector<PreviewsEligibilityReason> decision_reasons_;
@@ -340,8 +340,8 @@ class TestPreviewsUIService : public PreviewsUIService {
std::vector<PreviewsType> navigation_types_;
std::vector<uint64_t> navigation_page_ids_;
- // Whether the blacklist decisions are ignored or not.
- bool blacklist_ignored_;
+ // Whether the blocklist decisions are ignored or not.
+ bool blocklist_ignored_;
};
class TestPreviewsDeciderImpl : public PreviewsDeciderImpl {
@@ -350,38 +350,38 @@ class TestPreviewsDeciderImpl : public PreviewsDeciderImpl {
: PreviewsDeciderImpl(clock) {}
~TestPreviewsDeciderImpl() override {}
- // Expose the injecting blacklist method from PreviewsDeciderImpl, and inject
- // |blacklist| into |this|.
- void InjectTestBlacklist(std::unique_ptr<PreviewsBlackList> blacklist) {
- SetPreviewsBlacklistForTesting(std::move(blacklist));
+ // Expose the injecting blocklist method from PreviewsDeciderImpl, and inject
+ // |blocklist| into |this|.
+ void InjectTestBlocklist(std::unique_ptr<PreviewsBlockList> blocklist) {
+ SetPreviewsBlocklistForTesting(std::move(blocklist));
}
};
-void RunLoadCallback(blacklist::LoadBlackListCallback callback,
- std::unique_ptr<blacklist::BlacklistData> data) {
+void RunLoadCallback(blocklist::LoadBlockListCallback callback,
+ std::unique_ptr<blocklist::BlocklistData> data) {
std::move(callback).Run(std::move(data));
}
-class TestOptOutStore : public blacklist::OptOutStore {
+class TestOptOutStore : public blocklist::OptOutStore {
public:
TestOptOutStore() {}
~TestOptOutStore() override {}
private:
- // blacklist::OptOutStore implementation:
+ // blocklist::OptOutStore implementation:
void AddEntry(bool opt_out,
const std::string& host_name,
int type,
base::Time now) override {}
- void LoadBlackList(std::unique_ptr<blacklist::BlacklistData> data,
- blacklist::LoadBlackListCallback callback) override {
+ void LoadBlockList(std::unique_ptr<blocklist::BlocklistData> data,
+ blocklist::LoadBlockListCallback callback) override {
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::BindOnce(&RunLoadCallback, std::move(callback), std::move(data)));
}
- void ClearBlackList(base::Time begin_time, base::Time end_time) override {}
+ void ClearBlockList(base::Time begin_time, base::Time end_time) override {}
};
class PreviewsDeciderImplTest
@@ -412,9 +412,9 @@ class PreviewsDeciderImplTest
ui_service_.reset();
}
- void InitializeUIServiceWithoutWaitingForBlackList(
+ void InitializeUIServiceWithoutWaitingForBlockList(
bool include_previews_opt_guide) {
- blacklist::BlacklistData::AllowedTypesAndVersions allowed_types;
+ blocklist::BlocklistData::AllowedTypesAndVersions allowed_types;
allowed_types[static_cast<int>(PreviewsType::OFFLINE)] = 0;
allowed_types[static_cast<int>(PreviewsType::LITE_PAGE)] = 0;
allowed_types[static_cast<int>(PreviewsType::NOSCRIPT)] = 0;
@@ -439,7 +439,7 @@ class PreviewsDeciderImplTest
}
void InitializeUIService(bool include_previews_opt_guide = true) {
- InitializeUIServiceWithoutWaitingForBlackList(include_previews_opt_guide);
+ InitializeUIServiceWithoutWaitingForBlockList(include_previews_opt_guide);
task_environment_.RunUntilIdle();
base::RunLoop().RunUntilIdle();
}
@@ -508,10 +508,10 @@ TEST_F(PreviewsDeciderImplTest, TestDisallowBasicAuthentication) {
}
// Tests most of the reasons that a preview could be disallowed because of the
-// state of the blacklist. Excluded values are USER_RECENTLY_OPTED_OUT,
-// USER_BLACKLISTED, HOST_BLACKLISTED. These are internal to the blacklist.
+// state of the blocklist. Excluded values are USER_RECENTLY_OPTED_OUT,
+// USER_BLOCKLISTED, HOST_BLOCKLISTED. These are internal to the blocklist.
TEST_F(PreviewsDeciderImplTest,
- MAYBE_TestDisallowPreviewBecauseOfBlackListState) {
+ MAYBE_TestDisallowPreviewBecauseOfBlockListState) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
@@ -521,46 +521,46 @@ TEST_F(PreviewsDeciderImplTest,
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com"));
- InitializeUIServiceWithoutWaitingForBlackList(
+ InitializeUIServiceWithoutWaitingForBlockList(
/*include_previews_opt_guide=*/true);
- // The blacklist is not loaded yet.
+ // The blocklist is not loaded yet.
EXPECT_FALSE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::OFFLINE));
histogram_tester.ExpectBucketCount(
"Previews.EligibilityReason",
- static_cast<int>(PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED),
+ static_cast<int>(PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED),
1);
histogram_tester.ExpectBucketCount(
"Previews.EligibilityReason.Offline",
- static_cast<int>(PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED),
+ static_cast<int>(PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED),
1);
base::RunLoop().RunUntilIdle();
histogram_tester.ExpectTotalCount("Previews.EligibilityReason.Offline", 1);
- // Return one of the failing statuses from the blacklist; cause the blacklist
- // to not be loaded by clearing the blacklist.
+ // Return one of the failing statuses from the blocklist; cause the blocklist
+ // to not be loaded by clearing the blocklist.
base::Time now = base::Time::Now();
- previews_decider_impl()->ClearBlackList(now, now);
+ previews_decider_impl()->ClearBlockList(now, now);
EXPECT_FALSE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::OFFLINE));
histogram_tester.ExpectBucketCount(
"Previews.EligibilityReason.Offline",
- static_cast<int>(PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED),
+ static_cast<int>(PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED),
2);
histogram_tester.ExpectBucketCount(
"Previews.EligibilityReason",
- static_cast<int>(PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED),
+ static_cast<int>(PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED),
2);
histogram_tester.ExpectTotalCount("Previews.EligibilityReason.NoScript", 0);
variations::testing::ClearAllVariationParams();
}
-TEST_F(PreviewsDeciderImplTest, MAYBE_TestSetBlacklistBoolDueToBlackListState) {
+TEST_F(PreviewsDeciderImplTest, MAYBE_TestSetBlocklistBoolDueToBlockListState) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
@@ -570,16 +570,16 @@ TEST_F(PreviewsDeciderImplTest, MAYBE_TestSetBlacklistBoolDueToBlackListState) {
navigation_handle.set_url(GURL("https://www.google.com"));
base::HistogramTester histogram_tester;
- InitializeUIServiceWithoutWaitingForBlackList(
+ InitializeUIServiceWithoutWaitingForBlockList(
/*include_previews_opt_guide=*/true);
base::RunLoop().RunUntilIdle();
previews_decider_impl()->AddPreviewNavigation(
GURL("https://www.google.com"), true, PreviewsType::LITE_PAGE, 1);
- EXPECT_FALSE(user_data.black_listed_for_lite_page());
+ EXPECT_FALSE(user_data.block_listed_for_lite_page());
EXPECT_FALSE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::LITE_PAGE));
- EXPECT_TRUE(user_data.black_listed_for_lite_page());
+ EXPECT_TRUE(user_data.block_listed_for_lite_page());
}
TEST_F(PreviewsDeciderImplTest,
@@ -860,22 +860,11 @@ TEST_F(PreviewsDeciderImplTest, NoScriptFeatureDefaultBehavior) {
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com"));
-#if defined(OS_ANDROID)
- // Enabled by default on Android. NOSCRIPT always allowed at navigation start
- // to handle asynchronous loading of page hints; non-whitelisted ones are
- // later blocked on commit.
- EXPECT_TRUE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
- &user_data, &navigation_handle, false, PreviewsType::NOSCRIPT));
- histogram_tester.ExpectTotalCount("Previews.EligibilityReason.NoScript", 1);
- histogram_tester.ExpectBucketCount(
- "Previews.EligibilityReason.NoScript",
- static_cast<int>(PreviewsEligibilityReason::ALLOWED), 1);
-#else // !defined(OS_ANDROID)
+
// Disabled by default on non-Android.
EXPECT_FALSE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::NOSCRIPT));
histogram_tester.ExpectTotalCount("Previews.EligibilityReason.NoScript", 0);
-#endif // defined(OS_ANDROID)
}
TEST_F(PreviewsDeciderImplTest, NoScriptNotAllowedWithoutOptimizationHints) {
@@ -904,7 +893,7 @@ TEST_F(PreviewsDeciderImplTest, NoScriptNotAllowedWithoutOptimizationHints) {
}
}
-TEST_F(PreviewsDeciderImplTest, NoScriptAllowedByFeatureWithWhitelist) {
+TEST_F(PreviewsDeciderImplTest, NoScriptAllowedByFeatureWithAllowlist) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kNoScriptPreviews}, {});
@@ -915,14 +904,14 @@ TEST_F(PreviewsDeciderImplTest, NoScriptAllowedByFeatureWithWhitelist) {
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com"));
- // First verify preview allowed for non-whitelisted url; they're always
+ // First verify preview allowed for non-allowlisted url; they're always
// allowed at navigation start to enable asynchronous loading of page hints.
EXPECT_TRUE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::NOSCRIPT));
- // Now verify preview allowed for whitelisted url.
- content::MockNavigationHandle whitelisted_navigation_handle;
- whitelisted_navigation_handle.set_url(GURL("https://www.google.com"));
+ // Now verify preview allowed for allowlisted url.
+ content::MockNavigationHandle allowlisted_navigation_handle;
+ allowlisted_navigation_handle.set_url(GURL("https://www.google.com"));
EXPECT_TRUE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::NOSCRIPT));
@@ -931,13 +920,13 @@ TEST_F(PreviewsDeciderImplTest, NoScriptAllowedByFeatureWithWhitelist) {
static_cast<int>(PreviewsEligibilityReason::ALLOWED), 2);
}
-TEST_F(PreviewsDeciderImplTest, NoScriptCommitTimeWhitelistCheck) {
+TEST_F(PreviewsDeciderImplTest, NoScriptCommitTimeAllowlistCheck) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kNoScriptPreviews}, {});
InitializeUIService();
- // First verify not allowed for non-whitelisted url.
+ // First verify not allowed for non-allowlisted url.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
base::HistogramTester histogram_tester;
@@ -954,13 +943,13 @@ TEST_F(PreviewsDeciderImplTest, NoScriptCommitTimeWhitelistCheck) {
1);
}
- // Now verify preview for whitelisted url.
+ // Now verify preview for allowlisted url.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_TRUE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::NOSCRIPT));
@@ -968,13 +957,13 @@ TEST_F(PreviewsDeciderImplTest, NoScriptCommitTimeWhitelistCheck) {
histogram_tester.ExpectTotalCount("Previews.EligibilityReason.NoScript", 0);
}
- // Verify preview not allowed for whitelisted url when network is not slow.
+ // Verify preview not allowed for allowlisted url when network is not slow.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_3G);
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_FALSE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::NOSCRIPT));
@@ -985,13 +974,13 @@ TEST_F(PreviewsDeciderImplTest, NoScriptCommitTimeWhitelistCheck) {
1);
}
- // Verify preview not allowed for whitelisted url for unknown network quality.
+ // Verify preview not allowed for allowlisted url for unknown network quality.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_UNKNOWN);
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
user_data.set_navigation_ect(net::EFFECTIVE_CONNECTION_TYPE_UNKNOWN);
EXPECT_FALSE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::NOSCRIPT));
@@ -1014,7 +1003,7 @@ TEST_F(PreviewsDeciderImplTest, NoScriptCommitTimeWhitelistCheck) {
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
user_data.set_navigation_ect(net::EFFECTIVE_CONNECTION_TYPE_UNKNOWN);
EXPECT_TRUE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::NOSCRIPT));
@@ -1022,21 +1011,21 @@ TEST_F(PreviewsDeciderImplTest, NoScriptCommitTimeWhitelistCheck) {
histogram_tester.ExpectTotalCount("Previews.EligibilityReason.NoScript", 0);
}
- // Verify preview not allowed when blacklist is unavailable.
+ // Verify preview not allowed when blocklist is unavailable.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
base::HistogramTester histogram_tester;
- previews_decider_impl()->InjectTestBlacklist(nullptr /* blacklist */);
+ previews_decider_impl()->InjectTestBlocklist(nullptr /* blocklist */);
PreviewsUserData user_data(kDefaultPageId);
user_data.set_navigation_ect(net::EFFECTIVE_CONNECTION_TYPE_2G);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_FALSE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::NOSCRIPT));
histogram_tester.ExpectUniqueSample(
"Previews.EligibilityReason.NoScript",
- static_cast<int>(PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE), 1);
+ static_cast<int>(PreviewsEligibilityReason::BLOCKLIST_UNAVAILABLE), 1);
}
}
@@ -1065,7 +1054,7 @@ TEST_F(PreviewsDeciderImplTest,
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_FALSE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false,
PreviewsType::RESOURCE_LOADING_HINTS));
@@ -1082,7 +1071,7 @@ TEST_F(PreviewsDeciderImplTest,
}
TEST_F(PreviewsDeciderImplTest,
- ResourceLoadingHintsAllowedByFeatureAndWhitelist) {
+ ResourceLoadingHintsAllowedByFeatureAndAllowlist) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kResourceLoadingHints}, {});
@@ -1096,9 +1085,9 @@ TEST_F(PreviewsDeciderImplTest,
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
- // Check whitelisted URL.
+ // Check allowlisted URL.
EXPECT_TRUE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false,
PreviewsType::RESOURCE_LOADING_HINTS));
@@ -1131,13 +1120,13 @@ TEST_F(PreviewsDeciderImplTest,
static_cast<int>(PreviewsEligibilityReason::ALLOWED), 1);
}
-TEST_F(PreviewsDeciderImplTest, ResourceLoadingHintsCommitTimeWhitelistCheck) {
+TEST_F(PreviewsDeciderImplTest, ResourceLoadingHintsCommitTimeAllowlistCheck) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kResourceLoadingHints}, {});
InitializeUIService();
- // First verify not allowed for non-whitelisted url.
+ // First verify not allowed for non-allowlisted url.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
base::HistogramTester histogram_tester;
@@ -1154,13 +1143,13 @@ TEST_F(PreviewsDeciderImplTest, ResourceLoadingHintsCommitTimeWhitelistCheck) {
1);
}
- // Now verify preview for whitelisted url.
+ // Now verify preview for allowlisted url.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_TRUE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::RESOURCE_LOADING_HINTS));
@@ -1169,13 +1158,13 @@ TEST_F(PreviewsDeciderImplTest, ResourceLoadingHintsCommitTimeWhitelistCheck) {
"Previews.EligibilityReason.ResourceLoadingHints", 0);
}
- // Verify preview not allowed for whitelisted url when network is not slow.
+ // Verify preview not allowed for allowlisted url when network is not slow.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_4G);
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_FALSE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::RESOURCE_LOADING_HINTS));
@@ -1186,13 +1175,13 @@ TEST_F(PreviewsDeciderImplTest, ResourceLoadingHintsCommitTimeWhitelistCheck) {
1);
}
- // Verify preview not allowed for whitelisted url for offline network quality.
+ // Verify preview not allowed for allowlisted url for offline network quality.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_OFFLINE);
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_FALSE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::RESOURCE_LOADING_HINTS));
@@ -1233,7 +1222,7 @@ TEST_F(PreviewsDeciderImplTest,
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_FALSE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::DEFER_ALL_SCRIPT));
histogram_tester.ExpectUniqueSample(
@@ -1248,7 +1237,7 @@ TEST_F(PreviewsDeciderImplTest,
1);
}
-TEST_F(PreviewsDeciderImplTest, DeferAllScriptAllowedByFeatureAndWhitelist) {
+TEST_F(PreviewsDeciderImplTest, DeferAllScriptAllowedByFeatureAndAllowlist) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kDeferAllScriptPreviews}, {});
@@ -1262,9 +1251,9 @@ TEST_F(PreviewsDeciderImplTest, DeferAllScriptAllowedByFeatureAndWhitelist) {
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
- // Check whitelisted URL.
+ // Check allowlisted URL.
EXPECT_TRUE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::DEFER_ALL_SCRIPT));
EXPECT_EQ(test_ect, user_data.navigation_ect());
@@ -1295,13 +1284,13 @@ TEST_F(PreviewsDeciderImplTest,
static_cast<int>(PreviewsEligibilityReason::ALLOWED), 1);
}
-TEST_F(PreviewsDeciderImplTest, DeferAllScriptCommitTimeWhitelistCheck) {
+TEST_F(PreviewsDeciderImplTest, DeferAllScriptCommitTimeAllowlistCheck) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kDeferAllScriptPreviews}, {});
InitializeUIService();
- // First verify not allowed for non-whitelisted url.
+ // First verify not allowed for non-allowlisted url.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
base::HistogramTester histogram_tester;
@@ -1318,13 +1307,13 @@ TEST_F(PreviewsDeciderImplTest, DeferAllScriptCommitTimeWhitelistCheck) {
1);
}
- // Now verify preview for whitelisted url.
+ // Now verify preview for allowlisted url.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_TRUE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::DEFER_ALL_SCRIPT));
@@ -1333,13 +1322,13 @@ TEST_F(PreviewsDeciderImplTest, DeferAllScriptCommitTimeWhitelistCheck) {
"Previews.EligibilityReason.DeferAllScript", 0);
}
- // Verify preview not allowed for whitelisted url when network is not slow.
+ // Verify preview not allowed for allowlisted url when network is not slow.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_4G);
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_FALSE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::DEFER_ALL_SCRIPT));
@@ -1350,13 +1339,13 @@ TEST_F(PreviewsDeciderImplTest, DeferAllScriptCommitTimeWhitelistCheck) {
1);
}
- // Verify preview not allowed for whitelisted url for offline network quality.
+ // Verify preview not allowed for allowlisted url for offline network quality.
{
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_OFFLINE);
base::HistogramTester histogram_tester;
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_FALSE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, PreviewsType::DEFER_ALL_SCRIPT));
@@ -1394,7 +1383,7 @@ TEST_F(PreviewsDeciderImplTest, LogPreviewDecisionMadePassInCorrectParams) {
scoped_feature_list.InitAndEnableFeature(features::kPreviews);
InitializeUIService();
const PreviewsEligibilityReason reason(
- PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE);
+ PreviewsEligibilityReason::BLOCKLIST_UNAVAILABLE);
const GURL url("http://www.url_a.com/url_a");
const base::Time time = base::Time::Now();
const PreviewsType type = PreviewsType::OFFLINE;
@@ -1429,16 +1418,16 @@ TEST_F(PreviewsDeciderImplTest, LogPreviewDecisionMadePassInCorrectParams) {
TEST_F(
PreviewsDeciderImplTest,
- LogDecisionMadeBlacklistUnavailableAtNavigationStartForNonCommitTimePreview) {
+ LogDecisionMadeBlocklistUnavailableAtNavigationStartForNonCommitTimePreview) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
InitializeUIService();
- auto expected_reason = PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE;
+ auto expected_reason = PreviewsEligibilityReason::BLOCKLIST_UNAVAILABLE;
auto expected_type = PreviewsType::OFFLINE;
- previews_decider_impl()->InjectTestBlacklist(nullptr /* blacklist */);
+ previews_decider_impl()->InjectTestBlocklist(nullptr /* blocklist */);
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com"));
@@ -1454,7 +1443,7 @@ TEST_F(
TEST_F(
PreviewsDeciderImplTest,
- LogDecisionMadeBlacklistUnavailableAtNavigationStartForCommitTimePreview) {
+ LogDecisionMadeBlocklistUnavailableAtNavigationStartForCommitTimePreview) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kNoScriptPreviews}, {});
@@ -1463,7 +1452,7 @@ TEST_F(
auto expected_reason = PreviewsEligibilityReason::ALLOWED;
auto expected_type = PreviewsType::NOSCRIPT;
- previews_decider_impl()->InjectTestBlacklist(nullptr /* blacklist */);
+ previews_decider_impl()->InjectTestBlocklist(nullptr /* blocklist */);
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com"));
@@ -1477,17 +1466,17 @@ TEST_F(
::testing::Contains(expected_type));
}
-TEST_F(PreviewsDeciderImplTest, LogDecisionMadeBlacklistStatusesDefault) {
+TEST_F(PreviewsDeciderImplTest, LogDecisionMadeBlocklistStatusesDefault) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
InitializeUIService();
PreviewsEligibilityReason expected_reasons[] = {
- PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED,
+ PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED,
PreviewsEligibilityReason::USER_RECENTLY_OPTED_OUT,
- PreviewsEligibilityReason::USER_BLACKLISTED,
- PreviewsEligibilityReason::HOST_BLACKLISTED,
+ PreviewsEligibilityReason::USER_BLOCKLISTED,
+ PreviewsEligibilityReason::HOST_BLOCKLISTED,
};
auto expected_type = PreviewsType::OFFLINE;
@@ -1496,10 +1485,10 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeBlacklistStatusesDefault) {
for (size_t i = 0; i < reasons_size; i++) {
auto expected_reason = expected_reasons[i];
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(expected_reason,
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(expected_reason,
previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
@@ -1518,7 +1507,7 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeBlacklistStatusesDefault) {
}
}
-TEST_F(PreviewsDeciderImplTest, ShouldCommitPreviewBlacklistStatuses) {
+TEST_F(PreviewsDeciderImplTest, ShouldCommitPreviewBlocklistStatuses) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kNoScriptPreviews}, {});
@@ -1527,15 +1516,15 @@ TEST_F(PreviewsDeciderImplTest, ShouldCommitPreviewBlacklistStatuses) {
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com"));
- // First verify URL is allowed for no blacklist status.
+ // First verify URL is allowed for no blocklist status.
EXPECT_TRUE(previews_decider_impl()->ShouldCommitPreview(
&user_data, &navigation_handle, expected_type));
PreviewsEligibilityReason expected_reasons[] = {
- PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED,
+ PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED,
PreviewsEligibilityReason::USER_RECENTLY_OPTED_OUT,
- PreviewsEligibilityReason::USER_BLACKLISTED,
- PreviewsEligibilityReason::HOST_BLACKLISTED,
+ PreviewsEligibilityReason::USER_BLOCKLISTED,
+ PreviewsEligibilityReason::HOST_BLOCKLISTED,
};
const size_t reasons_size = 4;
@@ -1543,10 +1532,10 @@ TEST_F(PreviewsDeciderImplTest, ShouldCommitPreviewBlacklistStatuses) {
for (size_t i = 0; i < reasons_size; i++) {
auto expected_reason = expected_reasons[i];
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(expected_reason,
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(expected_reason,
previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com"));
@@ -1564,7 +1553,7 @@ TEST_F(PreviewsDeciderImplTest, ShouldCommitPreviewBlacklistStatuses) {
}
}
-TEST_F(PreviewsDeciderImplTest, LogDecisionMadeBlacklistStatusesIgnore) {
+TEST_F(PreviewsDeciderImplTest, LogDecisionMadeBlocklistStatusesIgnore) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
@@ -1572,21 +1561,21 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeBlacklistStatusesIgnore) {
auto expected_reason = PreviewsEligibilityReason::ALLOWED;
auto expected_type = PreviewsType::OFFLINE;
- PreviewsEligibilityReason blacklist_decisions[] = {
- PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED,
+ PreviewsEligibilityReason blocklist_decisions[] = {
+ PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED,
PreviewsEligibilityReason::USER_RECENTLY_OPTED_OUT,
- PreviewsEligibilityReason::USER_BLACKLISTED,
- PreviewsEligibilityReason::HOST_BLACKLISTED,
+ PreviewsEligibilityReason::USER_BLOCKLISTED,
+ PreviewsEligibilityReason::HOST_BLOCKLISTED,
};
- previews_decider_impl()->SetIgnorePreviewsBlacklistDecision(
+ previews_decider_impl()->SetIgnorePreviewsBlocklistDecision(
true /* ignored */);
- for (auto blacklist_decision : blacklist_decisions) {
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(blacklist_decision,
+ for (auto blocklist_decision : blocklist_decisions) {
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(blocklist_decision,
previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com"));
@@ -1610,15 +1599,15 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeMediaSuffixesAreExcluded) {
auto expected_reason = PreviewsEligibilityReason::EXCLUDED_BY_MEDIA_SUFFIX;
auto expected_type = PreviewsType::RESOURCE_LOADING_HINTS;
- PreviewsEligibilityReason blacklist_decisions[] = {
- PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED,
+ PreviewsEligibilityReason blocklist_decisions[] = {
+ PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED,
};
- for (auto blacklist_decision : blacklist_decisions) {
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(blacklist_decision,
+ for (auto blocklist_decision : blocklist_decisions) {
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(blocklist_decision,
previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com/video.mp4"));
@@ -1634,14 +1623,14 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeMediaSuffixesAreExcluded) {
}
}
-TEST_F(PreviewsDeciderImplTest, IgnoreFlagDoesNotCheckBlacklist) {
+TEST_F(PreviewsDeciderImplTest, IgnoreFlagDoesNotCheckBlocklist) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
InitializeUIService();
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
- previews_decider_impl()->SetIgnorePreviewsBlacklistDecision(
+ previews_decider_impl()->SetIgnorePreviewsBlocklistDecision(
true /* ignored */);
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
@@ -1694,10 +1683,10 @@ TEST_F(PreviewsDeciderImplTest,
{features::kPreviews, features::kResourceLoadingHints}, {});
InitializeUIService();
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(
PreviewsEligibilityReason::ALLOWED, previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
auto expected_reason = PreviewsEligibilityReason::ALLOWED;
auto expected_type = PreviewsType::RESOURCE_LOADING_HINTS;
@@ -1736,10 +1725,10 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadePageLoadNotPainful) {
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
InitializeUIService(/*include_previews_opt_guide=*/true);
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(
PreviewsEligibilityReason::ALLOWED, previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_4G);
@@ -1778,10 +1767,10 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeNetworkNotSlow) {
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
InitializeUIService(/*include_previews_opt_guide=*/false);
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(
PreviewsEligibilityReason::ALLOWED, previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_4G);
@@ -1819,10 +1808,10 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeReloadDisallowed) {
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
InitializeUIService();
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(
PreviewsEligibilityReason::ALLOWED, previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
PreviewsUserData user_data(kDefaultPageId);
@@ -1858,21 +1847,21 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeReloadDisallowed) {
}
}
-TEST_F(PreviewsDeciderImplTest, IgnoreBlacklistEnabledViaFlag) {
+TEST_F(PreviewsDeciderImplTest, IgnoreBlocklistEnabledViaFlag) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithFeatures(
{features::kPreviews, features::kOfflinePreviews}, {});
base::test::ScopedCommandLine scoped_command_line;
base::CommandLine* command_line = scoped_command_line.GetProcessCommandLine();
- command_line->AppendSwitch(switches::kIgnorePreviewsBlacklist);
- ASSERT_TRUE(switches::ShouldIgnorePreviewsBlacklist());
+ command_line->AppendSwitch(switches::kIgnorePreviewsBlocklist);
+ ASSERT_TRUE(switches::ShouldIgnorePreviewsBlocklist());
InitializeUIService();
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(
- PreviewsEligibilityReason::HOST_BLACKLISTED, previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(
+ PreviewsEligibilityReason::HOST_BLOCKLISTED, previews_decider_impl());
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
@@ -1892,11 +1881,11 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeAllowClientPreviewsWithECT) {
{features::kPreviews, features::kOfflinePreviews}, {});
InitializeUIService();
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(
PreviewsEligibilityReason::ALLOWED, previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
@@ -1910,11 +1899,11 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeAllowClientPreviewsWithECT) {
PreviewsEligibilityReason::DEVICE_OFFLINE,
PreviewsEligibilityReason::PAGE_LOAD_PREDICTION_NOT_PAINFUL,
PreviewsEligibilityReason::RELOAD_DISALLOWED,
- PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE,
- PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED,
+ PreviewsEligibilityReason::BLOCKLIST_UNAVAILABLE,
+ PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED,
PreviewsEligibilityReason::USER_RECENTLY_OPTED_OUT,
- PreviewsEligibilityReason::USER_BLACKLISTED,
- PreviewsEligibilityReason::HOST_BLACKLISTED,
+ PreviewsEligibilityReason::USER_BLOCKLISTED,
+ PreviewsEligibilityReason::HOST_BLOCKLISTED,
};
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
@@ -1943,11 +1932,11 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeAllowHintPreviewWithoutECT) {
{features::kPreviews, features::kNoScriptPreviews}, {});
InitializeUIService();
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(
PreviewsEligibilityReason::ALLOWED, previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_2G);
@@ -1961,7 +1950,7 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeAllowHintPreviewWithoutECT) {
};
PreviewsUserData user_data(kDefaultPageId);
content::MockNavigationHandle navigation_handle;
- navigation_handle.set_url(GURL("https://whitelisted.example.com"));
+ navigation_handle.set_url(GURL("https://allowlisted.example.com"));
EXPECT_TRUE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, expected_type));
base::RunLoop().RunUntilIdle();
@@ -1980,53 +1969,53 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeAllowHintPreviewWithoutECT) {
}
}
-TEST_F(PreviewsDeciderImplTest, OnNewBlacklistedHostCallsUIMethodCorrectly) {
+TEST_F(PreviewsDeciderImplTest, OnNewBlocklistedHostCallsUIMethodCorrectly) {
InitializeUIService();
std::string expected_host = "example.com";
base::Time expected_time = base::Time::Now();
- previews_decider_impl()->OnNewBlacklistedHost(expected_host, expected_time);
+ previews_decider_impl()->OnNewBlocklistedHost(expected_host, expected_time);
base::RunLoop().RunUntilIdle();
- EXPECT_EQ(expected_host, ui_service()->host_blacklisted());
- EXPECT_EQ(expected_time, ui_service()->host_blacklisted_time());
+ EXPECT_EQ(expected_host, ui_service()->host_blocklisted());
+ EXPECT_EQ(expected_time, ui_service()->host_blocklisted_time());
}
-TEST_F(PreviewsDeciderImplTest, OnUserBlacklistedCallsUIMethodCorrectly) {
+TEST_F(PreviewsDeciderImplTest, OnUserBlocklistedCallsUIMethodCorrectly) {
InitializeUIService();
- previews_decider_impl()->OnUserBlacklistedStatusChange(
- true /* blacklisted */);
+ previews_decider_impl()->OnUserBlocklistedStatusChange(
+ true /* blocklisted */);
base::RunLoop().RunUntilIdle();
- EXPECT_TRUE(ui_service()->user_blacklisted());
+ EXPECT_TRUE(ui_service()->user_blocklisted());
- previews_decider_impl()->OnUserBlacklistedStatusChange(
- false /* blacklisted */);
+ previews_decider_impl()->OnUserBlocklistedStatusChange(
+ false /* blocklisted */);
base::RunLoop().RunUntilIdle();
- EXPECT_FALSE(ui_service()->user_blacklisted());
+ EXPECT_FALSE(ui_service()->user_blocklisted());
}
-TEST_F(PreviewsDeciderImplTest, OnBlacklistClearedCallsUIMethodCorrectly) {
+TEST_F(PreviewsDeciderImplTest, OnBlocklistClearedCallsUIMethodCorrectly) {
InitializeUIService();
base::Time expected_time = base::Time::Now();
- previews_decider_impl()->OnBlacklistCleared(expected_time);
+ previews_decider_impl()->OnBlocklistCleared(expected_time);
base::RunLoop().RunUntilIdle();
- EXPECT_EQ(expected_time, ui_service()->blacklist_cleared_time());
+ EXPECT_EQ(expected_time, ui_service()->blocklist_cleared_time());
}
TEST_F(PreviewsDeciderImplTest,
- OnIgnoreBlacklistDecisionStatusChangedCalledCorrect) {
+ OnIgnoreBlocklistDecisionStatusChangedCalledCorrect) {
InitializeUIService();
- previews_decider_impl()->SetIgnorePreviewsBlacklistDecision(
+ previews_decider_impl()->SetIgnorePreviewsBlocklistDecision(
true /* ignored */);
base::RunLoop().RunUntilIdle();
- EXPECT_TRUE(ui_service()->blacklist_ignored());
+ EXPECT_TRUE(ui_service()->blocklist_ignored());
- previews_decider_impl()->SetIgnorePreviewsBlacklistDecision(
+ previews_decider_impl()->SetIgnorePreviewsBlocklistDecision(
false /* ignored */);
base::RunLoop().RunUntilIdle();
- EXPECT_FALSE(ui_service()->blacklist_ignored());
+ EXPECT_FALSE(ui_service()->blocklist_ignored());
}
TEST_F(PreviewsDeciderImplTest, GeneratePageIdMakesUniqueNonZero) {
@@ -2048,10 +2037,10 @@ TEST_F(PreviewsDeciderImplTest, TestIgnoreLongTermRule) {
{features::kPreviews, features::kOfflinePreviews}, {});
InitializeUIService();
- std::unique_ptr<TestPreviewsBlackList> blacklist =
- std::make_unique<TestPreviewsBlackList>(
- PreviewsEligibilityReason::HOST_BLACKLISTED, previews_decider_impl());
- previews_decider_impl()->InjectTestBlacklist(std::move(blacklist));
+ std::unique_ptr<TestPreviewsBlockList> blocklist =
+ std::make_unique<TestPreviewsBlockList>(
+ PreviewsEligibilityReason::HOST_BLOCKLISTED, previews_decider_impl());
+ previews_decider_impl()->InjectTestBlocklist(std::move(blocklist));
// DataReductionProxy LitePage checks NQE on their own.
ReportEffectiveConnectionType(net::EFFECTIVE_CONNECTION_TYPE_3G);
@@ -2059,11 +2048,11 @@ TEST_F(PreviewsDeciderImplTest, TestIgnoreLongTermRule) {
content::MockNavigationHandle navigation_handle;
navigation_handle.set_url(GURL("https://www.google.com"));
base::HistogramTester histogram_tester;
- previews_decider_impl()->SetIgnoreLongTermBlackListForServerPreviews(false);
+ previews_decider_impl()->SetIgnoreLongTermBlockListForServerPreviews(false);
EXPECT_FALSE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::LITE_PAGE));
- previews_decider_impl()->SetIgnoreLongTermBlackListForServerPreviews(true);
+ previews_decider_impl()->SetIgnoreLongTermBlockListForServerPreviews(true);
EXPECT_TRUE(previews_decider_impl()->ShouldAllowPreviewAtNavigationStart(
&user_data, &navigation_handle, false, PreviewsType::LITE_PAGE));
}
diff --git a/chromium/components/previews/content/previews_optimization_guide.cc b/chromium/components/previews/content/previews_optimization_guide.cc
index c96480d5b8b..98f2391e699 100644
--- a/chromium/components/previews/content/previews_optimization_guide.cc
+++ b/chromium/components/previews/content/previews_optimization_guide.cc
@@ -140,7 +140,8 @@ bool PreviewsOptimizationGuide::CanApplyPreview(
optimization_guide::OptimizationMetadata optimization_metadata;
optimization_guide::OptimizationGuideDecision decision =
optimization_guide_decider_->CanApplyOptimization(
- navigation_handle, *optimization_type, &optimization_metadata);
+ navigation_handle->GetURL(), *optimization_type,
+ &optimization_metadata);
if (!ShouldApplyPreviewWithDecision(type, decision))
return false;
@@ -186,7 +187,7 @@ bool PreviewsOptimizationGuide::AreCommitTimePreviewsAvailable(
}
if (optimization_guide_decider_->CanApplyOptimization(
- navigation_handle, optimization_type,
+ navigation_handle->GetURL(), optimization_type,
/*optimization_metadata=*/nullptr) !=
optimization_guide::OptimizationGuideDecision::kFalse) {
might_have_hint = true;
diff --git a/chromium/components/previews/content/previews_optimization_guide.h b/chromium/components/previews/content/previews_optimization_guide.h
index 55710719964..2ea060fbc9b 100644
--- a/chromium/components/previews/content/previews_optimization_guide.h
+++ b/chromium/components/previews/content/previews_optimization_guide.h
@@ -32,6 +32,9 @@ class PreviewsOptimizationGuide {
public:
explicit PreviewsOptimizationGuide(
optimization_guide::OptimizationGuideDecider* optimization_guide_decider);
+ PreviewsOptimizationGuide(const PreviewsOptimizationGuide&) = delete;
+ PreviewsOptimizationGuide& operator=(const PreviewsOptimizationGuide&) =
+ delete;
virtual ~PreviewsOptimizationGuide();
// Returns whether a Preview should be shown for the current conditions.
@@ -67,8 +70,6 @@ class PreviewsOptimizationGuide {
// The optimization types registered with |optimization_guide_decider_|.
const base::flat_set<optimization_guide::proto::OptimizationType>
registered_optimization_types_;
-
- DISALLOW_COPY_AND_ASSIGN(PreviewsOptimizationGuide);
};
} // namespace previews
diff --git a/chromium/components/previews/content/previews_optimization_guide_unittest.cc b/chromium/components/previews/content/previews_optimization_guide_unittest.cc
index d78cc7b1fdd..884b40b0a1d 100644
--- a/chromium/components/previews/content/previews_optimization_guide_unittest.cc
+++ b/chromium/components/previews/content/previews_optimization_guide_unittest.cc
@@ -78,12 +78,12 @@ class TestOptimizationGuideDecider
}
optimization_guide::OptimizationGuideDecision CanApplyOptimization(
- content::NavigationHandle* navigation_handle,
+ const GURL& url,
optimization_guide::proto::OptimizationType optimization_type,
optimization_guide::OptimizationMetadata* optimization_metadata)
override {
- auto response_iter = responses_.find(
- std::make_tuple(navigation_handle->GetURL(), optimization_type));
+ auto response_iter =
+ responses_.find(std::make_tuple(url, optimization_type));
if (response_iter == responses_.end())
return optimization_guide::OptimizationGuideDecision::kFalse;
@@ -187,7 +187,7 @@ class PreviewsOptimizationGuideTest : public testing::Test {
optimization_guide_decider()->SetResponses(responses);
}
- GURL blacklisted_lpr_url() { return GURL("https://blacklistedlpr.com/123"); }
+ GURL blocklisted_lpr_url() { return GURL("https://blocklistedlpr.com/123"); }
GURL hint_not_loaded_url() { return GURL("https://hintnotloaded.com/123"); }
diff --git a/chromium/components/previews/content/previews_ui_service.cc b/chromium/components/previews/content/previews_ui_service.cc
index a4e3fe48c25..421ccc21d49 100644
--- a/chromium/components/previews/content/previews_ui_service.cc
+++ b/chromium/components/previews/content/previews_ui_service.cc
@@ -14,11 +14,11 @@ namespace previews {
PreviewsUIService::PreviewsUIService(
std::unique_ptr<PreviewsDeciderImpl> previews_decider_impl,
- std::unique_ptr<blacklist::OptOutStore> previews_opt_out_store,
+ std::unique_ptr<blocklist::OptOutStore> previews_opt_out_store,
std::unique_ptr<PreviewsOptimizationGuide> previews_opt_guide,
const PreviewsIsEnabledCallback& is_enabled_callback,
std::unique_ptr<PreviewsLogger> logger,
- blacklist::BlacklistData::AllowedTypesAndVersions allowed_previews,
+ blocklist::BlocklistData::AllowedTypesAndVersions allowed_previews,
network::NetworkQualityTracker* network_quality_tracker)
: previews_decider_impl_(std::move(previews_decider_impl)),
logger_(std::move(logger)),
@@ -66,30 +66,30 @@ void PreviewsUIService::LogPreviewDecisionMade(
std::move(passed_reasons), page_id);
}
-void PreviewsUIService::OnNewBlacklistedHost(const std::string& host,
+void PreviewsUIService::OnNewBlocklistedHost(const std::string& host,
base::Time time) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- logger_->OnNewBlacklistedHost(host, time);
+ logger_->OnNewBlocklistedHost(host, time);
}
-void PreviewsUIService::OnUserBlacklistedStatusChange(bool blacklisted) {
+void PreviewsUIService::OnUserBlocklistedStatusChange(bool blocklisted) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- logger_->OnUserBlacklistedStatusChange(blacklisted);
+ logger_->OnUserBlocklistedStatusChange(blocklisted);
}
-void PreviewsUIService::OnBlacklistCleared(base::Time time) {
+void PreviewsUIService::OnBlocklistCleared(base::Time time) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- logger_->OnBlacklistCleared(time);
+ logger_->OnBlocklistCleared(time);
}
-void PreviewsUIService::SetIgnorePreviewsBlacklistDecision(bool ignored) {
+void PreviewsUIService::SetIgnorePreviewsBlocklistDecision(bool ignored) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- previews_decider_impl_->SetIgnorePreviewsBlacklistDecision(ignored);
+ previews_decider_impl_->SetIgnorePreviewsBlocklistDecision(ignored);
}
-void PreviewsUIService::OnIgnoreBlacklistDecisionStatusChanged(bool ignored) {
+void PreviewsUIService::OnIgnoreBlocklistDecisionStatusChanged(bool ignored) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- logger_->OnIgnoreBlacklistDecisionStatusChanged(ignored);
+ logger_->OnIgnoreBlocklistDecisionStatusChanged(ignored);
}
PreviewsLogger* PreviewsUIService::previews_logger() const {
@@ -102,19 +102,19 @@ PreviewsDeciderImpl* PreviewsUIService::previews_decider_impl() const {
return previews_decider_impl_.get();
}
-// When triggering previews, prevent long term black list rules.
-void PreviewsUIService::SetIgnoreLongTermBlackListForServerPreviews(
- bool ignore_long_term_black_list_rules_allowed) {
+// When triggering previews, prevent long term block list rules.
+void PreviewsUIService::SetIgnoreLongTermBlockListForServerPreviews(
+ bool ignore_long_term_block_list_rules_allowed) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- previews_decider_impl_->SetIgnoreLongTermBlackListForServerPreviews(
- ignore_long_term_black_list_rules_allowed);
+ previews_decider_impl_->SetIgnoreLongTermBlockListForServerPreviews(
+ ignore_long_term_block_list_rules_allowed);
}
-void PreviewsUIService::ClearBlackList(base::Time begin_time,
+void PreviewsUIService::ClearBlockList(base::Time begin_time,
base::Time end_time) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
- previews_decider_impl_->ClearBlackList(begin_time, end_time);
+ previews_decider_impl_->ClearBlockList(begin_time, end_time);
}
void PreviewsUIService::OnEffectiveConnectionTypeChanged(
diff --git a/chromium/components/previews/content/previews_ui_service.h b/chromium/components/previews/content/previews_ui_service.h
index f54a2a2dd93..4ee10328911 100644
--- a/chromium/components/previews/content/previews_ui_service.h
+++ b/chromium/components/previews/content/previews_ui_service.h
@@ -14,11 +14,11 @@
#include "base/memory/weak_ptr.h"
#include "base/threading/thread_checker.h"
#include "base/time/time.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_blacklist_data.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_store.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_blocklist_data.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_store.h"
#include "components/previews/content/previews_decider_impl.h"
#include "components/previews/content/previews_optimization_guide.h"
-#include "components/previews/core/previews_black_list.h"
+#include "components/previews/core/previews_block_list.h"
#include "components/previews/core/previews_experiments.h"
#include "components/previews/core/previews_logger.h"
#include "net/nqe/effective_connection_type.h"
@@ -36,11 +36,11 @@ class PreviewsUIService
public:
PreviewsUIService(
std::unique_ptr<PreviewsDeciderImpl> previews_decider_impl,
- std::unique_ptr<blacklist::OptOutStore> previews_opt_out_store,
+ std::unique_ptr<blocklist::OptOutStore> previews_opt_out_store,
std::unique_ptr<PreviewsOptimizationGuide> previews_opt_guide,
const PreviewsIsEnabledCallback& is_enabled_callback,
std::unique_ptr<PreviewsLogger> logger,
- blacklist::BlacklistData::AllowedTypesAndVersions allowed_previews,
+ blocklist::BlocklistData::AllowedTypesAndVersions allowed_previews,
network::NetworkQualityTracker* network_quality_tracker);
~PreviewsUIService() override;
@@ -48,39 +48,39 @@ class PreviewsUIService
void OnEffectiveConnectionTypeChanged(
net::EffectiveConnectionType type) override;
- // Adds a navigation to |url| to the black list with result |opt_out|.
+ // Adds a navigation to |url| to the block list with result |opt_out|.
void AddPreviewNavigation(const GURL& url,
PreviewsType type,
bool opt_out,
uint64_t page_id);
- // Clears the history of the black list between |begin_time| and |end_time|.
- void ClearBlackList(base::Time begin_time, base::Time end_time);
+ // Clears the history of the block list between |begin_time| and |end_time|.
+ void ClearBlockList(base::Time begin_time, base::Time end_time);
- // Notifies |logger_| that |host| has been blacklisted at |time|. Virtualized
+ // Notifies |logger_| that |host| has been blocklisted at |time|. Virtualized
// in testing.
- virtual void OnNewBlacklistedHost(const std::string& host, base::Time time);
+ virtual void OnNewBlocklistedHost(const std::string& host, base::Time time);
- // Notifies |logger_| that the user blacklisted state has changed. Where
- // |blacklisted| is the new user blacklisted status. Virtualized in testing.
- virtual void OnUserBlacklistedStatusChange(bool blacklisted);
+ // Notifies |logger_| that the user blocklisted state has changed. Where
+ // |blocklisted| is the new user blocklisted status. Virtualized in testing.
+ virtual void OnUserBlocklistedStatusChange(bool blocklisted);
- // Notifies |logger_| that the blacklist is cleared at |time|. Virtualized in
+ // Notifies |logger_| that the blocklist is cleared at |time|. Virtualized in
// testing.
- virtual void OnBlacklistCleared(base::Time time);
+ virtual void OnBlocklistCleared(base::Time time);
- // Change the status of whether to ignored or consider PreviewsBlackList
+ // Change the status of whether to ignored or consider PreviewsBlockList
// decisions in |previews_decider_impl_|. This method is called when users
- // interact with the UI (i.e. click on the "Ignore Blacklist" button).
+ // interact with the UI (i.e. click on the "Ignore Blocklist" button).
// Virtualized in testing.
- virtual void SetIgnorePreviewsBlacklistDecision(bool ignored);
+ virtual void SetIgnorePreviewsBlocklistDecision(bool ignored);
- // Notifies |logger_| whether PreviewsBlackList decisions are ignored or not.
+ // Notifies |logger_| whether PreviewsBlockList decisions are ignored or not.
// This method is listening for notification from PreviewsDeciderImpl for when
- // the blacklist ignore status is changed so that |logger_| can update all
+ // the blocklist ignore status is changed so that |logger_| can update all
// PreviewsLoggerObservers so that multiple instances of the page have the
// same status. Virtualized in testing.
- virtual void OnIgnoreBlacklistDecisionStatusChanged(bool ignored);
+ virtual void OnIgnoreBlocklistDecisionStatusChanged(bool ignored);
// Log the navigation to PreviewsLogger. Virtualized in testing.
virtual void LogPreviewNavigation(const GURL& url,
@@ -120,9 +120,9 @@ class PreviewsUIService
// non-null.
PreviewsDeciderImpl* previews_decider_impl() const;
- // When triggering previews, prevent long term black list rules.
- void SetIgnoreLongTermBlackListForServerPreviews(
- bool ignore_long_term_black_list_rules_allowed);
+ // When triggering previews, prevent long term block list rules.
+ void SetIgnoreLongTermBlockListForServerPreviews(
+ bool ignore_long_term_block_list_rules_allowed);
private:
// The decision making object for Previews triggering. Guaranteed to be
@@ -130,7 +130,7 @@ class PreviewsUIService
std::unique_ptr<previews::PreviewsDeciderImpl> previews_decider_impl_;
// A log object to keep track of events such as previews navigations,
- // blacklist actions, etc.
+ // blocklist actions, etc.
std::unique_ptr<PreviewsLogger> logger_;
// Used to remove |this| from observing.
diff --git a/chromium/components/previews/content/previews_ui_service_unittest.cc b/chromium/components/previews/content/previews_ui_service_unittest.cc
index fa84e64f2c7..4066d78c0c0 100644
--- a/chromium/components/previews/content/previews_ui_service_unittest.cc
+++ b/chromium/components/previews/content/previews_ui_service_unittest.cc
@@ -12,9 +12,9 @@
#include "base/single_thread_task_runner.h"
#include "base/test/task_environment.h"
#include "base/time/default_clock.h"
-#include "components/blacklist/opt_out_blacklist/opt_out_blacklist_data.h"
+#include "components/blocklist/opt_out_blocklist/opt_out_blocklist_data.h"
#include "components/previews/content/previews_decider_impl.h"
-#include "components/previews/core/previews_black_list.h"
+#include "components/previews/core/previews_block_list.h"
#include "components/previews/core/previews_experiments.h"
#include "components/previews/core/previews_logger.h"
#include "services/network/test/test_network_quality_tracker.h"
@@ -33,7 +33,7 @@ class TestPreviewsUIService : public PreviewsUIService {
public:
TestPreviewsUIService(
std::unique_ptr<PreviewsDeciderImpl> previews_decider_impl,
- std::unique_ptr<blacklist::OptOutStore> previews_opt_out_store,
+ std::unique_ptr<blocklist::OptOutStore> previews_opt_out_store,
std::unique_ptr<PreviewsOptimizationGuide> previews_opt_guide,
std::unique_ptr<PreviewsLogger> logger,
network::TestNetworkQualityTracker* test_network_quality_tracker)
@@ -42,7 +42,7 @@ class TestPreviewsUIService : public PreviewsUIService {
std::move(previews_opt_guide),
base::BindRepeating(&MockedPreviewsIsEnabled),
std::move(logger),
- blacklist::BlacklistData::AllowedTypesAndVersions(),
+ blocklist::BlocklistData::AllowedTypesAndVersions(),
test_network_quality_tracker) {}
~TestPreviewsUIService() override {}
};
@@ -50,11 +50,7 @@ class TestPreviewsUIService : public PreviewsUIService {
// Mock class of PreviewsLogger for checking passed in parameters.
class TestPreviewsLogger : public PreviewsLogger {
public:
- TestPreviewsLogger()
- : decision_page_id_(0),
- navigation_opt_out_(false),
- user_blacklisted_(false),
- blacklist_ignored_(false) {}
+ TestPreviewsLogger() : decision_page_id_(0), navigation_opt_out_(false) {}
// PreviewsLogger:
void LogPreviewNavigation(const GURL& url,
@@ -84,21 +80,21 @@ class TestPreviewsLogger : public PreviewsLogger {
decision_page_id_ = page_id;
}
- void OnNewBlacklistedHost(const std::string& host, base::Time time) override {
- host_blacklisted_ = host;
- host_blacklisted_time_ = time;
+ void OnNewBlocklistedHost(const std::string& host, base::Time time) override {
+ host_blocklisted_ = host;
+ host_blocklisted_time_ = time;
}
- void OnUserBlacklistedStatusChange(bool blacklisted) override {
- user_blacklisted_ = blacklisted;
+ void OnUserBlocklistedStatusChange(bool blocklisted) override {
+ user_blocklisted_ = blocklisted;
}
- void OnBlacklistCleared(base::Time time) override {
- blacklist_cleared_time_ = time;
+ void OnBlocklistCleared(base::Time time) override {
+ blocklist_cleared_time_ = time;
}
- void OnIgnoreBlacklistDecisionStatusChanged(bool ignored) override {
- blacklist_ignored_ = ignored;
+ void OnIgnoreBlocklistDecisionStatusChanged(bool ignored) override {
+ blocklist_ignored_ = ignored;
}
// Return the passed in LogPreviewDecision parameters.
@@ -119,14 +115,14 @@ class TestPreviewsLogger : public PreviewsLogger {
PreviewsType navigation_type() const { return navigation_type_; }
uint64_t navigation_page_id() const { return navigation_page_id_; }
- // Return the passed in OnBlacklist events.
- std::string host_blacklisted() const { return host_blacklisted_; }
- base::Time host_blacklisted_time() const { return host_blacklisted_time_; }
- bool user_blacklisted() const { return user_blacklisted_; }
- base::Time blacklist_cleared_time() const { return blacklist_cleared_time_; }
+ // Return the passed in OnBlocklist events.
+ std::string host_blocklisted() const { return host_blocklisted_; }
+ base::Time host_blocklisted_time() const { return host_blocklisted_time_; }
+ bool user_blocklisted() const { return user_blocklisted_; }
+ base::Time blocklist_cleared_time() const { return blocklist_cleared_time_; }
- // Return the status of blacklist ignored.
- bool blacklist_ignored() const { return blacklist_ignored_; }
+ // Return the status of blocklist ignored.
+ bool blocklist_ignored() const { return blocklist_ignored_; }
private:
// Passed in LogPreviewDecision parameters.
@@ -144,34 +140,33 @@ class TestPreviewsLogger : public PreviewsLogger {
PreviewsType navigation_type_;
uint64_t navigation_page_id_;
- // Passed in OnBlacklist events.
- std::string host_blacklisted_;
- base::Time host_blacklisted_time_;
- bool user_blacklisted_;
- base::Time blacklist_cleared_time_;
+ // Passed in OnBlocklist events.
+ std::string host_blocklisted_;
+ base::Time host_blocklisted_time_;
+ bool user_blocklisted_ = false;
+ base::Time blocklist_cleared_time_;
- // Passed in blacklist ignored status.
- bool blacklist_ignored_;
+ // Passed in blocklist ignored status.
+ bool blocklist_ignored_ = false;
};
class TestPreviewsDeciderImpl : public PreviewsDeciderImpl {
public:
TestPreviewsDeciderImpl()
- : PreviewsDeciderImpl(base::DefaultClock::GetInstance()),
- blacklist_ignored_(false) {}
+ : PreviewsDeciderImpl(base::DefaultClock::GetInstance()) {}
// PreviewsDeciderImpl:
- void SetIgnorePreviewsBlacklistDecision(bool ignored) override {
- blacklist_ignored_ = ignored;
+ void SetIgnorePreviewsBlocklistDecision(bool ignored) override {
+ blocklist_ignored_ = ignored;
}
- // Exposed the status of blacklist decisions ignored for testing
+ // Exposed the status of blocklist decisions ignored for testing
// PreviewsUIService.
- bool blacklist_ignored() const { return blacklist_ignored_; }
+ bool blocklist_ignored() const { return blocklist_ignored_; }
private:
- // Whether the blacklist decisions are ignored or not.
- bool blacklist_ignored_;
+ // Whether the blocklist decisions are ignored or not.
+ bool blocklist_ignored_ = false;
};
class PreviewsUIServiceTest : public testing::Test {
@@ -256,7 +251,7 @@ TEST_F(PreviewsUIServiceTest, TestLogPreviewNavigationPassInCorrectParams) {
TEST_F(PreviewsUIServiceTest, TestLogPreviewDecisionMadePassesCorrectParams) {
PreviewsEligibilityReason reason_a =
- PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE;
+ PreviewsEligibilityReason::BLOCKLIST_UNAVAILABLE;
const GURL url_a("http://www.url_a.com/url_a");
const base::Time time_a = base::Time::Now();
PreviewsType type_a = PreviewsType::OFFLINE;
@@ -314,47 +309,47 @@ TEST_F(PreviewsUIServiceTest, TestLogPreviewDecisionMadePassesCorrectParams) {
}
}
-TEST_F(PreviewsUIServiceTest, TestOnNewBlacklistedHostPassesCorrectParams) {
+TEST_F(PreviewsUIServiceTest, TestOnNewBlocklistedHostPassesCorrectParams) {
const std::string expected_host = "example.com";
const base::Time expected_time = base::Time::Now();
- ui_service()->OnNewBlacklistedHost(expected_host, expected_time);
+ ui_service()->OnNewBlocklistedHost(expected_host, expected_time);
- EXPECT_EQ(expected_host, logger_ptr_->host_blacklisted());
- EXPECT_EQ(expected_time, logger_ptr_->host_blacklisted_time());
+ EXPECT_EQ(expected_host, logger_ptr_->host_blocklisted());
+ EXPECT_EQ(expected_time, logger_ptr_->host_blocklisted_time());
}
-TEST_F(PreviewsUIServiceTest, TestOnUserBlacklistedPassesCorrectParams) {
- ui_service()->OnUserBlacklistedStatusChange(true /* blacklisted */);
- EXPECT_TRUE(logger_ptr_->user_blacklisted());
+TEST_F(PreviewsUIServiceTest, TestOnUserBlocklistedPassesCorrectParams) {
+ ui_service()->OnUserBlocklistedStatusChange(true /* blocklisted */);
+ EXPECT_TRUE(logger_ptr_->user_blocklisted());
- ui_service()->OnUserBlacklistedStatusChange(false /* blacklisted */);
- EXPECT_FALSE(logger_ptr_->user_blacklisted());
+ ui_service()->OnUserBlocklistedStatusChange(false /* blocklisted */);
+ EXPECT_FALSE(logger_ptr_->user_blocklisted());
}
-TEST_F(PreviewsUIServiceTest, TestOnBlacklistClearedPassesCorrectParams) {
+TEST_F(PreviewsUIServiceTest, TestOnBlocklistClearedPassesCorrectParams) {
const base::Time expected_time = base::Time::Now();
- ui_service()->OnBlacklistCleared(expected_time);
+ ui_service()->OnBlocklistCleared(expected_time);
- EXPECT_EQ(expected_time, logger_ptr_->blacklist_cleared_time());
+ EXPECT_EQ(expected_time, logger_ptr_->blocklist_cleared_time());
}
TEST_F(PreviewsUIServiceTest,
- TestSetIgnorePreviewsBlacklistDecisionPassesCorrectParams) {
- ui_service()->SetIgnorePreviewsBlacklistDecision(true /* ignored */);
+ TestSetIgnorePreviewsBlocklistDecisionPassesCorrectParams) {
+ ui_service()->SetIgnorePreviewsBlocklistDecision(true /* ignored */);
base::RunLoop().RunUntilIdle();
- EXPECT_TRUE(previews_decider_impl()->blacklist_ignored());
+ EXPECT_TRUE(previews_decider_impl()->blocklist_ignored());
- ui_service()->SetIgnorePreviewsBlacklistDecision(false /* ignored */);
+ ui_service()->SetIgnorePreviewsBlocklistDecision(false /* ignored */);
base::RunLoop().RunUntilIdle();
- EXPECT_FALSE(previews_decider_impl()->blacklist_ignored());
+ EXPECT_FALSE(previews_decider_impl()->blocklist_ignored());
}
-TEST_F(PreviewsUIServiceTest, TestOnIgnoreBlacklistDecisionStatusChanged) {
- ui_service()->OnIgnoreBlacklistDecisionStatusChanged(true /* ignored */);
- EXPECT_TRUE(logger_ptr_->blacklist_ignored());
+TEST_F(PreviewsUIServiceTest, TestOnIgnoreBlocklistDecisionStatusChanged) {
+ ui_service()->OnIgnoreBlocklistDecisionStatusChanged(true /* ignored */);
+ EXPECT_TRUE(logger_ptr_->blocklist_ignored());
- ui_service()->OnIgnoreBlacklistDecisionStatusChanged(false /* ignored */);
- EXPECT_FALSE(logger_ptr_->blacklist_ignored());
+ ui_service()->OnIgnoreBlocklistDecisionStatusChanged(false /* ignored */);
+ EXPECT_FALSE(logger_ptr_->blocklist_ignored());
}
} // namespace previews
diff --git a/chromium/components/previews/content/previews_user_data.cc b/chromium/components/previews/content/previews_user_data.cc
index 626cf485665..7730f58f76e 100644
--- a/chromium/components/previews/content/previews_user_data.cc
+++ b/chromium/components/previews/content/previews_user_data.cc
@@ -5,6 +5,7 @@
#include "components/previews/content/previews_user_data.h"
#include "base/rand_util.h"
+#include "content/public/browser/render_frame_host.h"
namespace previews {
@@ -24,7 +25,7 @@ PreviewsUserData::PreviewsUserData(const PreviewsUserData& other)
cache_control_no_transform_directive_(
other.cache_control_no_transform_directive_),
offline_preview_used_(other.offline_preview_used_),
- black_listed_for_lite_page_(other.black_listed_for_lite_page_),
+ block_listed_for_lite_page_(other.block_listed_for_lite_page_),
committed_previews_type_without_holdback_(
other.committed_previews_type_without_holdback_),
allowed_previews_state_without_holdback_(
@@ -34,6 +35,17 @@ PreviewsUserData::PreviewsUserData(const PreviewsUserData& other)
coin_flip_holdback_result_(other.coin_flip_holdback_result_),
preview_eligibility_reasons_(other.preview_eligibility_reasons_) {}
+PreviewsUserData::DocumentDataHolder::DocumentDataHolder(
+ content::RenderFrameHost* render_frame_host) {
+ // PreviewsUserData and DocumentDataHolder should only be made for main
+ // frames.
+ // TODO(crbug.com/1090679): This should be page-associated instead of just
+ // document-associated. Use PageUserData when it's available.
+ DCHECK(!render_frame_host->GetParent());
+}
+
+PreviewsUserData::DocumentDataHolder::~DocumentDataHolder() = default;
+
void PreviewsUserData::SetCommittedPreviewsType(
previews::PreviewsType previews_type) {
DCHECK(committed_previews_type_without_holdback_ == PreviewsType::NONE);
@@ -106,4 +118,5 @@ content::PreviewsState PreviewsUserData::CommittedPreviewsState() const {
return committed_previews_state_without_holdback_;
}
+RENDER_DOCUMENT_HOST_USER_DATA_KEY_IMPL(PreviewsUserData::DocumentDataHolder)
} // namespace previews
diff --git a/chromium/components/previews/content/previews_user_data.h b/chromium/components/previews/content/previews_user_data.h
index bf0c0d6e497..d6e46cb631d 100644
--- a/chromium/components/previews/content/previews_user_data.h
+++ b/chromium/components/previews/content/previews_user_data.h
@@ -13,13 +13,25 @@
#include "base/macros.h"
#include "base/optional.h"
#include "base/time/time.h"
-#include "components/previews/core/previews_black_list.h"
+#include "components/previews/core/previews_block_list.h"
#include "components/previews/core/previews_experiments.h"
+#include "content/public/browser/render_document_host_user_data.h"
#include "content/public/common/previews_state.h"
namespace previews {
-// A representation of previews information related to a navigation.
+// A representation of previews information related to a navigation. We create
+// a PreviewsUserData on every navigation, and when the navigation finishes, we
+// make a copy of it and hold it in DocumentDataHolder so that the lifetime
+// is tied to the document.
+// For normal navigations, we will use the PreviewsUserData we made during the
+// navigation.
+// For navigations where we restore the page from the back-forward cache, we
+// should instead used the cached PreviewsUserData that's associated with the
+// document (the PreviewsUserData that's made during the original navigation
+// the page, instead of the back navigation that triggers the restoration of
+// the page so that the Previews UI will be consistent with the preserved
+// page contents).
// TODO(ryansturm): rename this to remove UserData.
class PreviewsUserData {
public:
@@ -72,12 +84,12 @@ class PreviewsUserData {
}
// Whether a lite page preview was prevented from being shown due to the
- // blacklist.
- bool black_listed_for_lite_page() const {
- return black_listed_for_lite_page_;
+ // blocklist.
+ bool block_listed_for_lite_page() const {
+ return block_listed_for_lite_page_;
}
- void set_black_listed_for_lite_page(bool black_listed_for_lite_page) {
- black_listed_for_lite_page_ = black_listed_for_lite_page;
+ void set_block_listed_for_lite_page(bool block_listed_for_lite_page) {
+ block_listed_for_lite_page_ = block_listed_for_lite_page;
}
// Returns whether the Cache-Control:no-transform directive has been
@@ -150,6 +162,33 @@ class PreviewsUserData {
coin_flip_holdback_result_ = coin_flip_holdback_result;
}
+ void CopyData(const PreviewsUserData& other);
+
+ class DocumentDataHolder
+ : public content::RenderDocumentHostUserData<DocumentDataHolder> {
+ public:
+ ~DocumentDataHolder() override;
+ PreviewsUserData* GetPreviewsUserData() {
+ return previews_user_data_.get();
+ }
+ void SetPreviewsUserData(
+ std::unique_ptr<PreviewsUserData> previews_user_data) {
+ previews_user_data_ = std::move(previews_user_data);
+ }
+
+ using content::RenderDocumentHostUserData<
+ DocumentDataHolder>::GetOrCreateForCurrentDocument;
+ using content::RenderDocumentHostUserData<
+ DocumentDataHolder>::GetForCurrentDocument;
+
+ private:
+ explicit DocumentDataHolder(content::RenderFrameHost* render_frame_host);
+ friend class content::RenderDocumentHostUserData<DocumentDataHolder>;
+
+ std::unique_ptr<PreviewsUserData> previews_user_data_;
+ RENDER_DOCUMENT_HOST_USER_DATA_KEY_DECL();
+ };
+
private:
// A session unique ID related to this navigation.
const uint64_t page_id_;
@@ -176,8 +215,8 @@ class PreviewsUserData {
bool offline_preview_used_ = false;
// Whether a lite page preview was prevented from being shown due to the
- // blacklist.
- bool black_listed_for_lite_page_ = false;
+ // blocklist.
+ bool block_listed_for_lite_page_ = false;
// The committed previews type, if any. Is not influenced by the coin flip
// holdback.
diff --git a/chromium/components/previews/content/previews_user_data_unittest.cc b/chromium/components/previews/content/previews_user_data_unittest.cc
index 54b3103f628..4dfda8c5e90 100644
--- a/chromium/components/previews/content/previews_user_data_unittest.cc
+++ b/chromium/components/previews/content/previews_user_data_unittest.cc
@@ -23,14 +23,14 @@ TEST(PreviewsUserDataTest, TestSetEligibilityReason) {
data.EligibilityReasonForPreview(PreviewsType::OFFLINE));
data.SetEligibilityReasonForPreview(
- PreviewsType::NOSCRIPT, PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE);
+ PreviewsType::NOSCRIPT, PreviewsEligibilityReason::BLOCKLIST_UNAVAILABLE);
data.SetEligibilityReasonForPreview(
PreviewsType::NOSCRIPT,
- PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED);
+ PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED);
EXPECT_EQ(base::nullopt,
data.EligibilityReasonForPreview(PreviewsType::OFFLINE));
- EXPECT_EQ(PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED,
+ EXPECT_EQ(PreviewsEligibilityReason::BLOCKLIST_DATA_NOT_LOADED,
data.EligibilityReasonForPreview(PreviewsType::NOSCRIPT));
}
@@ -43,14 +43,14 @@ TEST(PreviewsUserDataTest, DeepCopy) {
EXPECT_EQ(0, data->data_savings_inflation_percent());
EXPECT_FALSE(data->cache_control_no_transform_directive());
EXPECT_EQ(previews::PreviewsType::NONE, data->CommittedPreviewsType());
- EXPECT_FALSE(data->black_listed_for_lite_page());
+ EXPECT_FALSE(data->block_listed_for_lite_page());
EXPECT_FALSE(data->offline_preview_used());
data->set_data_savings_inflation_percent(123);
data->set_cache_control_no_transform_directive();
data->SetCommittedPreviewsType(previews::PreviewsType::NOSCRIPT);
data->set_offline_preview_used(true);
- data->set_black_listed_for_lite_page(true);
+ data->set_block_listed_for_lite_page(true);
PreviewsUserData data_copy(*data);
EXPECT_EQ(id, data_copy.page_id());
@@ -59,7 +59,7 @@ TEST(PreviewsUserDataTest, DeepCopy) {
EXPECT_TRUE(data_copy.cache_control_no_transform_directive());
EXPECT_EQ(previews::PreviewsType::NOSCRIPT,
data_copy.CommittedPreviewsType());
- EXPECT_TRUE(data_copy.black_listed_for_lite_page());
+ EXPECT_TRUE(data_copy.block_listed_for_lite_page());
EXPECT_TRUE(data_copy.offline_preview_used());
}