diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/content/browser/notifications | |
parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
download | qtwebengine-chromium-85-based.tar.gz |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/content/browser/notifications')
5 files changed, 83 insertions, 83 deletions
diff --git a/chromium/content/browser/notifications/blink_notification_service_impl_unittest.cc b/chromium/content/browser/notifications/blink_notification_service_impl_unittest.cc index 619ad99bb52..a3deeb43eb3 100644 --- a/chromium/content/browser/notifications/blink_notification_service_impl_unittest.cc +++ b/chromium/content/browser/notifications/blink_notification_service_impl_unittest.cc @@ -9,6 +9,7 @@ #include <vector> #include "base/bind.h" +#include "base/bind_helpers.h" #include "base/callback_forward.h" #include "base/callback_helpers.h" #include "base/macros.h" @@ -32,9 +33,9 @@ #include "content/public/test/test_utils.h" #include "content/test/mock_platform_notification_service.h" #include "content/test/test_content_browser_client.h" -#include "mojo/core/embedder/embedder.h" #include "mojo/public/cpp/bindings/pending_remote.h" #include "mojo/public/cpp/bindings/remote.h" +#include "mojo/public/cpp/system/functions.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/blink/public/common/notifications/notification_constants.h" @@ -147,14 +148,13 @@ class BlinkNotificationServiceImplTest : public ::testing::Test { browser_context_.SetPermissionControllerDelegate( std::make_unique<testing::NiceMock<MockPermissionManager>>()); - mojo::core::SetDefaultProcessErrorCallback(base::AdaptCallbackForRepeating( + mojo::SetDefaultProcessErrorHandler(base::AdaptCallbackForRepeating( base::BindOnce(&BlinkNotificationServiceImplTest::OnMojoError, base::Unretained(this)))); } void TearDown() override { - mojo::core::SetDefaultProcessErrorCallback( - mojo::core::ProcessErrorCallback()); + mojo::SetDefaultProcessErrorHandler(base::NullCallback()); embedded_worker_helper_.reset(); diff --git a/chromium/content/browser/notifications/notification_database.cc b/chromium/content/browser/notifications/notification_database.cc index 3d0746f0e3e..adb50ac7888 100644 --- a/chromium/content/browser/notifications/notification_database.cc +++ b/chromium/content/browser/notifications/notification_database.cc @@ -12,7 +12,6 @@ #include "base/metrics/histogram_macros.h" #include "base/strings/string_number_conversions.h" #include "base/strings/stringprintf.h" -#include "base/task/post_task.h" #include "content/browser/notifications/notification_database_conversions.h" #include "content/public/browser/browser_task_traits.h" #include "content/public/browser/browser_thread.h" @@ -350,8 +349,8 @@ NotificationDatabase::Status NotificationDatabase::DeleteNotificationData( NotificationDatabaseData data; Status status = ReadNotificationData(notification_id, origin, &data); if (status == STATUS_OK && record_notification_to_ukm_callback_) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(record_notification_to_ukm_callback_, data)); + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(record_notification_to_ukm_callback_, data)); } leveldb::WriteBatch batch; @@ -506,8 +505,8 @@ NotificationDatabase::DeleteAllNotificationDataInternal( } if (record_notification_to_ukm_callback_) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(record_notification_to_ukm_callback_, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(record_notification_to_ukm_callback_, notification_database_data)); } diff --git a/chromium/content/browser/notifications/notification_event_dispatcher_impl.cc b/chromium/content/browser/notifications/notification_event_dispatcher_impl.cc index 75efdaab5bd..9b770a802fc 100644 --- a/chromium/content/browser/notifications/notification_event_dispatcher_impl.cc +++ b/chromium/content/browser/notifications/notification_event_dispatcher_impl.cc @@ -9,7 +9,6 @@ #include "base/callback.h" #include "base/callback_helpers.h" #include "base/optional.h" -#include "base/task/post_task.h" #include "build/build_config.h" #include "content/browser/notifications/devtools_event_logging.h" #include "content/browser/notifications/platform_notification_context_impl.h" @@ -149,8 +148,8 @@ void DispatchNotificationEventOnRegistration( break; } - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(dispatch_complete_callback), status)); + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(dispatch_complete_callback), status)); } // Finds the ServiceWorkerRegistration associated with the |origin| and diff --git a/chromium/content/browser/notifications/platform_notification_context_impl.cc b/chromium/content/browser/notifications/platform_notification_context_impl.cc index 2d76a71e57e..d221f274708 100644 --- a/chromium/content/browser/notifications/platform_notification_context_impl.cc +++ b/chromium/content/browser/notifications/platform_notification_context_impl.cc @@ -12,7 +12,6 @@ #include "base/files/file_util.h" #include "base/metrics/histogram_macros.h" #include "base/stl_util.h" -#include "base/task/post_task.h" #include "base/task/thread_pool.h" #include "content/browser/notifications/blink_notification_service_impl.h" #include "content/browser/notifications/notification_database.h" @@ -244,8 +243,8 @@ void PlatformNotificationContextImpl::DoReadAllNotificationOrigins( DCHECK(task_runner_->RunsTasksInCurrentSequence()); std::set<GURL> origins; if (!initialized) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, std::move(origins))); return; } @@ -265,8 +264,8 @@ void PlatformNotificationContextImpl::DoReadAllNotificationOrigins( if (status == NotificationDatabase::STATUS_ERROR_CORRUPTED) DestroyDatabase(); - base::PostTask( - FROM_HERE, {BrowserThread::UI}, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), success, std::move(origins))); } @@ -311,8 +310,8 @@ void PlatformNotificationContextImpl::DoDeleteAllNotificationDataForOrigins( bool initialized) { DCHECK(task_runner_->RunsTasksInCurrentSequence()); if (!initialized) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, /* deleted_count= */ 0)); return; } @@ -344,8 +343,8 @@ void PlatformNotificationContextImpl::DoDeleteAllNotificationDataForOrigins( service_proxy_->CloseNotification(notification_id); } - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), success, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), success, deleted_notification_ids.size())); } @@ -368,8 +367,8 @@ void PlatformNotificationContextImpl::DoReadNotificationData( bool initialized) { DCHECK(task_runner_->RunsTasksInCurrentSequence()); if (!initialized) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, NotificationDatabaseData())); return; } @@ -383,8 +382,8 @@ void PlatformNotificationContextImpl::DoReadNotificationData( NotificationDatabase::STATUS_COUNT); if (status == NotificationDatabase::STATUS_OK) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ true, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ true, database_data)); return; } @@ -393,8 +392,8 @@ void PlatformNotificationContextImpl::DoReadNotificationData( if (status == NotificationDatabase::STATUS_ERROR_CORRUPTED) DestroyDatabase(); - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, NotificationDatabaseData())); } @@ -472,8 +471,8 @@ void PlatformNotificationContextImpl::DoWriteNotificationResources( bool initialized) { DCHECK(task_runner_->RunsTasksInCurrentSequence()); if (!initialized) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false)); + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false)); return; } @@ -504,8 +503,8 @@ void PlatformNotificationContextImpl::DoWriteNotificationResources( } if (status == NotificationDatabase::STATUS_OK) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ true)); + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ true)); return; } @@ -513,8 +512,8 @@ void PlatformNotificationContextImpl::DoWriteNotificationResources( if (status == NotificationDatabase::STATUS_ERROR_CORRUPTED) DestroyDatabase(); - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false)); + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false)); } void PlatformNotificationContextImpl::ReDisplayNotifications( @@ -536,8 +535,8 @@ void PlatformNotificationContextImpl::DoReDisplayNotifications( DCHECK(task_runner_->RunsTasksInCurrentSequence()); size_t display_count = 0; if (!initialized) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), display_count)); + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), display_count)); return; } @@ -579,9 +578,8 @@ void PlatformNotificationContextImpl::DoReDisplayNotifications( if (status == NotificationDatabase::STATUS_ERROR_CORRUPTED) DestroyDatabase(); - base::PostTask(FROM_HERE, - {BrowserThread::UI, base::TaskPriority::USER_VISIBLE}, - base::BindOnce(std::move(callback), display_count)); + GetUIThreadTaskRunner({base::TaskPriority::USER_VISIBLE}) + ->PostTask(FROM_HERE, base::BindOnce(std::move(callback), display_count)); } void PlatformNotificationContextImpl::ReadNotificationResources( @@ -601,8 +599,8 @@ void PlatformNotificationContextImpl::DoReadNotificationResources( bool initialized) { DCHECK(task_runner_->RunsTasksInCurrentSequence()); if (!initialized) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, blink::NotificationResources())); return; } @@ -615,8 +613,8 @@ void PlatformNotificationContextImpl::DoReadNotificationResources( status, NotificationDatabase::STATUS_COUNT); if (status == NotificationDatabase::STATUS_OK) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ true, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ true, notification_resources)); return; } @@ -625,8 +623,8 @@ void PlatformNotificationContextImpl::DoReadNotificationResources( if (status == NotificationDatabase::STATUS_ERROR_CORRUPTED) DestroyDatabase(); - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, blink::NotificationResources())); } @@ -686,8 +684,8 @@ void PlatformNotificationContextImpl:: bool initialized) { DCHECK(task_runner_->RunsTasksInCurrentSequence()); if (!initialized) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, std::vector<NotificationDatabaseData>())); return; } @@ -720,8 +718,8 @@ void PlatformNotificationContextImpl:: } } - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ true, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ true, notification_datas)); // Remove notifications that are not actually on display anymore. @@ -734,8 +732,8 @@ void PlatformNotificationContextImpl:: if (status == NotificationDatabase::STATUS_ERROR_CORRUPTED) DestroyDatabase(); - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, std::vector<NotificationDatabaseData>())); } @@ -784,8 +782,8 @@ void PlatformNotificationContextImpl::DoWriteNotificationData( DCHECK(task_runner_->RunsTasksInCurrentSequence()); DCHECK(database_data.notification_id.empty()); if (!initialized || !service_proxy_) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, /* notification_id= */ "")); return; } @@ -819,8 +817,8 @@ void PlatformNotificationContextImpl::DoWriteNotificationData( if (delete_status == NotificationDatabase::STATUS_ERROR_CORRUPTED) { DestroyDatabase(); - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, /* notification_id= */ "")); return; } @@ -834,8 +832,8 @@ void PlatformNotificationContextImpl::DoWriteNotificationData( if (CanTrigger(write_database_data) && !DoCheckNotificationTriggerQuota(origin)) { // TODO(knollr): Reply with a custom error so developers can handle this. - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, /* notification_id= */ "")); return; } @@ -859,8 +857,8 @@ void PlatformNotificationContextImpl::DoWriteNotificationData( service_proxy_->ScheduleNotification(std::move(write_database_data)); // Respond with success as this notification got scheduled successfully. - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ true, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ true, notification_id)); return; } @@ -877,8 +875,8 @@ void PlatformNotificationContextImpl::DoWriteNotificationData( if (status == NotificationDatabase::STATUS_ERROR_CORRUPTED) DestroyDatabase(); - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), /* success= */ false, + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), /* success= */ false, /* notification_id= */ "")); } @@ -909,8 +907,8 @@ void PlatformNotificationContextImpl::DoDeleteNotificationData( bool initialized) { DCHECK(task_runner_->RunsTasksInCurrentSequence()); if (!initialized) { - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), false)); + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), false)); return; } @@ -939,8 +937,8 @@ void PlatformNotificationContextImpl::DoDeleteNotificationData( success = true; } - base::PostTask(FROM_HERE, {BrowserThread::UI}, - base::BindOnce(std::move(callback), success)); + GetUIThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), success)); } void PlatformNotificationContextImpl::OnRegistrationDeleted( diff --git a/chromium/content/browser/notifications/platform_notification_service_proxy.cc b/chromium/content/browser/notifications/platform_notification_service_proxy.cc index ebc3405d8c2..56d40d3b5f1 100644 --- a/chromium/content/browser/notifications/platform_notification_service_proxy.cc +++ b/chromium/content/browser/notifications/platform_notification_service_proxy.cc @@ -12,6 +12,7 @@ #include "content/browser/notifications/devtools_event_logging.h" #include "content/browser/service_worker/service_worker_context_wrapper.h" #include "content/public/browser/browser_task_traits.h" +#include "content/public/browser/browser_thread.h" #include "content/public/browser/content_browser_client.h" #include "content/public/browser/notification_database_data.h" #include "content/public/browser/platform_notification_service.h" @@ -77,9 +78,8 @@ void PlatformNotificationServiceProxy::VerifyServiceWorkerScope( if (ServiceWorkerContextWrapper::IsServiceWorkerOnUIEnabled()) { std::move(task).Run(); } else { - base::PostTask(FROM_HERE, - {BrowserThread::UI, base::TaskPriority::USER_VISIBLE}, - std::move(task)); + GetUIThreadTaskRunner({base::TaskPriority::USER_VISIBLE}) + ->PostTask(FROM_HERE, std::move(task)); } } @@ -87,9 +87,10 @@ void PlatformNotificationServiceProxy::DisplayNotification( const NotificationDatabaseData& data, DisplayResultCallback callback) { if (!service_worker_context_) { - base::PostTask( - FROM_HERE, {BrowserThread::UI, base::TaskPriority::USER_VISIBLE}, - base::BindOnce(&PlatformNotificationServiceProxy::DoDisplayNotification, + GetUIThreadTaskRunner({base::TaskPriority::USER_VISIBLE}) + ->PostTask(FROM_HERE, + base::BindOnce( + &PlatformNotificationServiceProxy::DoDisplayNotification, AsWeakPtr(), data, GURL(), std::move(callback))); return; } @@ -111,10 +112,11 @@ void PlatformNotificationServiceProxy::CloseNotification( const std::string& notification_id) { if (!notification_service_) return; - base::PostTask( - FROM_HERE, {BrowserThread::UI, base::TaskPriority::USER_VISIBLE}, - base::BindOnce(&PlatformNotificationServiceProxy::DoCloseNotification, - AsWeakPtr(), notification_id)); + GetUIThreadTaskRunner({base::TaskPriority::USER_VISIBLE}) + ->PostTask( + FROM_HERE, + base::BindOnce(&PlatformNotificationServiceProxy::DoCloseNotification, + AsWeakPtr(), notification_id)); } void PlatformNotificationServiceProxy::DoCloseNotification( @@ -126,10 +128,11 @@ void PlatformNotificationServiceProxy::DoCloseNotification( void PlatformNotificationServiceProxy::ScheduleTrigger(base::Time timestamp) { if (!notification_service_) return; - base::PostTask( - FROM_HERE, {BrowserThread::UI, base::TaskPriority::USER_VISIBLE}, - base::BindOnce(&PlatformNotificationServiceProxy::DoScheduleTrigger, - AsWeakPtr(), timestamp)); + GetUIThreadTaskRunner({base::TaskPriority::USER_VISIBLE}) + ->PostTask( + FROM_HERE, + base::BindOnce(&PlatformNotificationServiceProxy::DoScheduleTrigger, + AsWeakPtr(), timestamp)); } void PlatformNotificationServiceProxy::DoScheduleTrigger(base::Time timestamp) { @@ -142,9 +145,10 @@ void PlatformNotificationServiceProxy::ScheduleNotification( DCHECK(data.notification_data.show_trigger_timestamp.has_value()); if (!notification_service_) return; - base::PostTask( - FROM_HERE, {BrowserThread::UI, base::TaskPriority::USER_VISIBLE}, - base::BindOnce(&PlatformNotificationServiceProxy::DoScheduleNotification, + GetUIThreadTaskRunner({base::TaskPriority::USER_VISIBLE}) + ->PostTask(FROM_HERE, + base::BindOnce( + &PlatformNotificationServiceProxy::DoScheduleNotification, AsWeakPtr(), data)); } @@ -181,8 +185,8 @@ bool PlatformNotificationServiceProxy::ShouldLogClose(const GURL& origin) { void PlatformNotificationServiceProxy::LogClose( const NotificationDatabaseData& data) { - base::PostTask(FROM_HERE, - {BrowserThread::UI, base::TaskPriority::BEST_EFFORT}, + GetUIThreadTaskRunner({base::TaskPriority::BEST_EFFORT}) + ->PostTask(FROM_HERE, base::BindOnce(&PlatformNotificationServiceProxy::DoLogClose, AsWeakPtr(), data)); } |