summaryrefslogtreecommitdiff
path: root/chromium/docs/accessibility/brltty.md
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2020-10-12 14:27:29 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2020-10-13 09:35:20 +0000
commitc30a6232df03e1efbd9f3b226777b07e087a1122 (patch)
treee992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/docs/accessibility/brltty.md
parent7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff)
downloadqtwebengine-chromium-85-based.tar.gz
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/docs/accessibility/brltty.md')
-rw-r--r--chromium/docs/accessibility/brltty.md32
1 files changed, 30 insertions, 2 deletions
diff --git a/chromium/docs/accessibility/brltty.md b/chromium/docs/accessibility/brltty.md
index 32c95be70b4..e05f1d7ad73 100644
--- a/chromium/docs/accessibility/brltty.md
+++ b/chromium/docs/accessibility/brltty.md
@@ -65,8 +65,8 @@ To upload a change, use repo, something like this:
```
repo start <branch_name> .
git commit -a
- Bug:chromium:12345
- Test:Write what you tested here
+ Bug: chromium:12345
+ Test: Write what you tested here
repo upload .
```
@@ -119,6 +119,11 @@ Next, you will need to uprev the ebuild. Do this by renaming all files from the
E.g.
Brltty-5.4.ebuild -> brltty-5.6.ebuild
+Start a build with your changes by doing
+
+emerge brltty
+(or emerge{$BOARD} brltty).
+
Note: Manifest has various checksums computed based on the release you uploaded to GCS. Each of these will need to be replaced/updated.
This should be enough to kick off a build. It is likely patches won’t apply cleanly.
@@ -141,6 +146,29 @@ commits to the file containing the conflict
then understanding the history since the last release. If the patch is already
upstreamed, you can remove it from the Chrome OS repo.
+### Chrome side changes
+
+Chrome communicates with brltty using libbrlapi.
+libbrlapi resides at //third_party/libbrlapi.
+
+Chrome loads this library dynamically and hard-codes the expected version of the api so in
+chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc
+
+which should match up with the header in
+third_party/libbrlapi/brlapi.h.
+
+During uppreving, if brltty increments its api version, it will be necessary to update the header for libbrlapi, as well as incrementing the supported api version of the libbrlapi shared object.
+
+First, grab the generated header from your Chrome OS build above.
+cp <chromeos root>/build/$BOARD/usr/include/brlapi.h <chrome_root>/third_party/libbrlapi/brlapi.h
+
+This header contains the specific socket path for Chrome OS which differs from brltty defaults.
+
+Next, ensure the version in
+chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc
+
+matches the one in the new brltty.
+
### Testing
Firstly, try to test against brltty on linux. This involves building brltty at