diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
| commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
| tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/docs/sheriff.md | |
| parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
| download | qtwebengine-chromium-85-based.tar.gz | |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/docs/sheriff.md')
| -rw-r--r-- | chromium/docs/sheriff.md | 27 |
1 files changed, 26 insertions, 1 deletions
diff --git a/chromium/docs/sheriff.md b/chromium/docs/sheriff.md index 2a9b6801766..9dd6e746ab8 100644 --- a/chromium/docs/sheriff.md +++ b/chromium/docs/sheriff.md @@ -302,7 +302,10 @@ If yes: * Find the relevant Slack thread or start a new one * Investigate the bug and see what needs to happen - ping the owner, see if the priority & assignment are right, or try fixing it yourself. Check if it still - needs to be in the queue! + needs to be in the queue! If it doesn't need to be in the queue, remove the + `Sheriff-Chromium` label. Do this when + * the test has been disabled or marked flaky + * the problem is no longer impacting any of the builders ### 5. All's well? @@ -387,6 +390,27 @@ find the right owner for a test, feel free to TBR your CL to one of the other sheriffs on your rotation and kick it into the Blink triage queue (ie: mark the bug as Untriaged with component Blink). +#### Skia Gold Outage + +This is a special case of a failed test. The following test suites rely on the +Skia Gold image diffing service: + +* `*pixel_skia_gold_test` +* `*maps_pixel_test` +* `chrome_public_test_apk` +* `chrome_public_test_vr_apk` +* `pixel_browser_tests` + +In the unlikely event of a Gold outage, **all** of those suites will begin +failing with errors related to Gold/`goldctl`. If this occurs, the best way to +prevent failures from breaking bots is to uncomment the +`--bypass-skia-gold-functionality` argument in the `skia_gold_test` mixin in +[`//testing/buildbot/mixins.pyl`][mixins]. + +This should only be used when you are sure that the failures are caused by an +outage, as it will cause all pixel tests that use Skia Gold to no longer +perform any actual pixel testing. + ### Infra Breakage If a bot turns purple rather than red, that indicates an infra failure of some @@ -420,3 +444,4 @@ it out. [slack #sheriffing]: https://chromium.slack.com/messages/CGJ5WKRUH/ [slack]: https://chromium.slack.com [tree status page]: https://chromium-status.appspot.com/ +[mixins]: https://source.chromium.org/chromium/chromium/src/+/master:testing/buildbot/mixins.pyl |