summaryrefslogtreecommitdiff
path: root/chromium/media/mp3
diff options
context:
space:
mode:
authorAndras Becsi <andras.becsi@digia.com>2014-03-18 13:16:26 +0100
committerFrederik Gladhorn <frederik.gladhorn@digia.com>2014-03-20 15:55:39 +0100
commit3f0f86b0caed75241fa71c95a5d73bc0164348c5 (patch)
tree92b9fb00f2e9e90b0be2262093876d4f43b6cd13 /chromium/media/mp3
parente90d7c4b152c56919d963987e2503f9909a666d2 (diff)
downloadqtwebengine-chromium-3f0f86b0caed75241fa71c95a5d73bc0164348c5.tar.gz
Update to new stable branch 1750
This also includes an updated ninja and chromium dependencies needed on Windows. Change-Id: Icd597d80ed3fa4425933c9f1334c3c2e31291c42 Reviewed-by: Zoltan Arvai <zarvai@inf.u-szeged.hu> Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
Diffstat (limited to 'chromium/media/mp3')
-rw-r--r--chromium/media/mp3/mp3_stream_parser.cc7
-rw-r--r--chromium/media/mp3/mp3_stream_parser.h1
-rw-r--r--chromium/media/mp3/mp3_stream_parser_unittest.cc22
3 files changed, 9 insertions, 21 deletions
diff --git a/chromium/media/mp3/mp3_stream_parser.cc b/chromium/media/mp3/mp3_stream_parser.cc
index 0688d99fcc9..b20756cd228 100644
--- a/chromium/media/mp3/mp3_stream_parser.cc
+++ b/chromium/media/mp3/mp3_stream_parser.cc
@@ -10,6 +10,7 @@
#include "media/base/bit_reader.h"
#include "media/base/buffers.h"
#include "media/base/stream_parser_buffer.h"
+#include "media/base/text_track_config.h"
#include "media/base/video_decoder_config.h"
#include "net/http/http_util.h"
@@ -96,7 +97,6 @@ static const int kSampleRateMap[4][4] = {
};
// Frame header field constants.
-static const int kVersion1 = 3;
static const int kVersion2 = 2;
static const int kVersionReserved = 1;
static const int kVersion2_5 = 0;
@@ -120,7 +120,6 @@ void MP3StreamParser::Init(const InitCB& init_cb,
const NewBuffersCB& new_buffers_cb,
const NewTextBuffersCB& text_cb,
const NeedKeyCB& need_key_cb,
- const AddTextTrackCB& add_text_track_cb,
const NewMediaSegmentCB& new_segment_cb,
const base::Closure& end_of_segment_cb,
const LogCB& log_cb) {
@@ -164,7 +163,7 @@ bool MP3StreamParser::Parse(const uint8* buf, int size) {
int data_size;
queue_.Peek(&data, &data_size);
- if (size < 4)
+ if (data_size < 4)
break;
uint32 start_code = data[0] << 24 | data[1] << 16 | data[2] << 8 | data[3];
@@ -411,7 +410,7 @@ int MP3StreamParser::ParseMP3Frame(const uint8* data,
timestamp_helper_->SetBaseTimestamp(base_timestamp);
VideoDecoderConfig video_config;
- bool success = config_cb_.Run(config_, video_config);
+ bool success = config_cb_.Run(config_, video_config, TextTrackConfigMap());
if (!init_cb_.is_null())
base::ResetAndReturn(&init_cb_).Run(success, kInfiniteDuration());
diff --git a/chromium/media/mp3/mp3_stream_parser.h b/chromium/media/mp3/mp3_stream_parser.h
index 97730ae6e82..1e2e8c6f5b3 100644
--- a/chromium/media/mp3/mp3_stream_parser.h
+++ b/chromium/media/mp3/mp3_stream_parser.h
@@ -30,7 +30,6 @@ class MEDIA_EXPORT MP3StreamParser : public StreamParser {
const NewBuffersCB& new_buffers_cb,
const NewTextBuffersCB& text_cb,
const NeedKeyCB& need_key_cb,
- const AddTextTrackCB& add_text_track_cb,
const NewMediaSegmentCB& new_segment_cb,
const base::Closure& end_of_segment_cb,
const LogCB& log_cb) OVERRIDE;
diff --git a/chromium/media/mp3/mp3_stream_parser_unittest.cc b/chromium/media/mp3/mp3_stream_parser_unittest.cc
index 9d309544af6..f565093cd5b 100644
--- a/chromium/media/mp3/mp3_stream_parser_unittest.cc
+++ b/chromium/media/mp3/mp3_stream_parser_unittest.cc
@@ -7,6 +7,7 @@
#include "media/base/decoder_buffer.h"
#include "media/base/stream_parser_buffer.h"
#include "media/base/test_data_util.h"
+#include "media/base/text_track_config.h"
#include "media/base/video_decoder_config.h"
#include "media/mp3/mp3_stream_parser.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -44,7 +45,8 @@ class MP3StreamParserTest : public testing::Test {
}
bool OnNewConfig(const AudioDecoderConfig& audio_config,
- const VideoDecoderConfig& video_config) {
+ const VideoDecoderConfig& video_config,
+ const StreamParser::TextTrackConfigMap& text_config) {
DVLOG(1) << __FUNCTION__ << "(" << audio_config.IsValidConfig() << ", "
<< video_config.IsValidConfig() << ")";
EXPECT_TRUE(audio_config.IsValidConfig());
@@ -79,22 +81,11 @@ class MP3StreamParserTest : public testing::Test {
return true;
}
- bool OnNewTextBuffers(TextTrack* text_track,
- const StreamParser::BufferQueue& buffers) {
- return true;
- }
-
void OnKeyNeeded(const std::string& type,
const std::vector<uint8>& init_data) {
DVLOG(1) << __FUNCTION__ << "(" << type << ", " << init_data.size() << ")";
}
- scoped_ptr<TextTrack> OnAddTextTrack(TextKind kind,
- const std::string& label,
- const std::string& language) {
- return scoped_ptr<TextTrack>();
- }
-
void OnNewSegment() {
DVLOG(1) << __FUNCTION__;
results_stream_ << "NewSegment";
@@ -110,11 +101,8 @@ class MP3StreamParserTest : public testing::Test {
base::Bind(&MP3StreamParserTest::OnInitDone, base::Unretained(this)),
base::Bind(&MP3StreamParserTest::OnNewConfig, base::Unretained(this)),
base::Bind(&MP3StreamParserTest::OnNewBuffers, base::Unretained(this)),
- base::Bind(&MP3StreamParserTest::OnNewTextBuffers,
- base::Unretained(this)),
+ StreamParser::NewTextBuffersCB(),
base::Bind(&MP3StreamParserTest::OnKeyNeeded, base::Unretained(this)),
- base::Bind(&MP3StreamParserTest::OnAddTextTrack,
- base::Unretained(this)),
base::Bind(&MP3StreamParserTest::OnNewSegment, base::Unretained(this)),
base::Bind(&MP3StreamParserTest::OnEndOfSegment,
base::Unretained(this)),
@@ -165,6 +153,8 @@ TEST_F(MP3StreamParserTest, UnalignedAppend512) {
"NewSegment"
"{ 0K }"
"{ 26K 52K 78K 104K }"
+ "EndOfSegment"
+ "NewSegment"
"{ 130K 156K 182K }"
"{ 208K 235K 261K 287K }"
"{ 313K }"