diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-11-20 15:06:40 +0100 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-11-22 11:48:58 +0000 |
| commit | daa093eea7c773db06799a13bd7e4e2e2a9f8f14 (patch) | |
| tree | 96cc5e7b9194c1b29eab927730bfa419e7111c25 /chromium/styleguide/java/java.md | |
| parent | be59a35641616a4cf23c4a13fa0632624b021c1b (diff) | |
| download | qtwebengine-chromium-daa093eea7c773db06799a13bd7e4e2e2a9f8f14.tar.gz | |
BASELINE: Update Chromium to 63.0.3239.58
Change-Id: Ia93b322a00ba4dd4004f3bcf1254063ba90e1605
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'chromium/styleguide/java/java.md')
| -rw-r--r-- | chromium/styleguide/java/java.md | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/chromium/styleguide/java/java.md b/chromium/styleguide/java/java.md index 76d5f753353..24f98a3b3c1 100644 --- a/chromium/styleguide/java/java.md +++ b/chromium/styleguide/java/java.md @@ -94,7 +94,7 @@ try { somethingThatThrowsIOException(); somethingThatThrowsParseException(); } catch (IOException | ParseException e) { - Log.e(TAG, "Failed to do something with exception: ", e) + Log.e(TAG, "Failed to do something with exception: ", e); } ``` @@ -111,16 +111,15 @@ where C++ DCHECK()s make sense. For multi-statement asserts, use Example assert: ```java -assert someCallWithSideEffects() : "assert description"; +assert someCallWithoutSideEffects() : "assert description"; ``` Example use of `DCHECK_IS_ON`: ```java if (org.chromium.base.BuildConfig.DCHECK_IS_ON) { - if (!someCallWithSideEffects()) { - throw new AssertionError("assert description"); - } + // Any code here will be stripped in Release by ProGuard. + ... } ``` |