diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
| commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
| tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/tools/translation | |
| parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
| download | qtwebengine-chromium-85-based.tar.gz | |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/tools/translation')
| -rw-r--r-- | chromium/tools/translation/helper/grd_helper.py | 5 | ||||
| -rw-r--r-- | chromium/tools/translation/helper/grd_helper_unittest.py | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/chromium/tools/translation/helper/grd_helper.py b/chromium/tools/translation/helper/grd_helper.py index 5740e354eae..96b78f8acb7 100644 --- a/chromium/tools/translation/helper/grd_helper.py +++ b/chromium/tools/translation/helper/grd_helper.py @@ -34,7 +34,9 @@ TAGS_TO_IGNORE = ( def GetGrdMessages(grd_path_or_string, dir_path): - """Load the grd file and return a dict of message ids to messages.""" + """Load the grd file and return a dict of message ids to messages. + + Ignores non-translateable messages.""" doc = grit.grd_reader.Parse( grd_path_or_string, dir_path, @@ -46,6 +48,7 @@ def GetGrdMessages(grd_path_or_string, dir_path): return { msg.attrs['name']: msg for msg in doc.GetChildrenOfType(grit.node.message.MessageNode) + if msg.IsTranslateable() } diff --git a/chromium/tools/translation/helper/grd_helper_unittest.py b/chromium/tools/translation/helper/grd_helper_unittest.py index 1aac24792a7..69be76376ca 100644 --- a/chromium/tools/translation/helper/grd_helper_unittest.py +++ b/chromium/tools/translation/helper/grd_helper_unittest.py @@ -33,7 +33,7 @@ class GrdHelperTest(unittest.TestCase): # listed here. self.assertTrue('IDS_TEST_STRING1' in messages) self.assertTrue('IDS_TEST_STRING2' in messages) - self.assertTrue('IDS_TEST_STRING_NON_TRANSLATEABLE' in messages) + self.assertFalse('IDS_TEST_STRING_NON_TRANSLATEABLE' in messages) def testReadGrdpMessages(self): messages = grd_helper.GetGrdpMessagesFromString( |