diff options
Diffstat (limited to 'chromium/content/browser/loader/loader_browsertest.cc')
-rw-r--r-- | chromium/content/browser/loader/loader_browsertest.cc | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/chromium/content/browser/loader/loader_browsertest.cc b/chromium/content/browser/loader/loader_browsertest.cc index a229d260140..a3f7d53794c 100644 --- a/chromium/content/browser/loader/loader_browsertest.cc +++ b/chromium/content/browser/loader/loader_browsertest.cc @@ -27,7 +27,6 @@ #include "content/public/browser/web_contents.h" #include "content/public/common/content_client.h" #include "content/public/common/network_service_util.h" -#include "content/public/common/previews_state.h" #include "content/public/common/url_constants.h" #include "content/public/test/browser_test.h" #include "content/public/test/browser_test_utils.h" @@ -50,6 +49,7 @@ #include "net/test/url_request/url_request_mock_http_job.h" #include "services/network/public/cpp/features.h" #include "testing/gmock/include/gmock/gmock.h" +#include "third_party/blink/public/common/loader/previews_state.h" #include "third_party/blink/public/common/loader/url_loader_throttle.h" #include "url/gurl.h" @@ -240,7 +240,7 @@ IN_PROC_BROWSER_TEST_F(LoaderBrowserTest, SyncXMLHttpRequest_Disallowed) { // downloadable) would trigger download and hang the renderer process, // if executed while navigating to a new page. // Disabled on Mac: see http://crbug.com/56264 -#if defined(OS_MACOSX) +#if defined(OS_MAC) #define MAYBE_SyncXMLHttpRequest_DuringUnload \ DISABLED_SyncXMLHttpRequest_DuringUnload #else @@ -291,7 +291,13 @@ std::unique_ptr<net::test_server::HttpResponse> CancelOnRequest( // Tests the case where the request is cancelled by a layer above the // URLRequest, which passes the error on ResourceLoader teardown, rather than in // response to call to AsyncResourceHandler::OnResponseComplete. -IN_PROC_BROWSER_TEST_F(LoaderBrowserTest, SyncXMLHttpRequest_Cancelled) { +// Failed on Android M builder. See crbug/1111427. +#if defined(OS_ANDROID) +#define MAYBE_SyncXMLHttpRequest_Cancelled DISABLED_SyncXMLHttpRequest_Cancelled +#else +#define MAYBE_SyncXMLHttpRequest_Cancelled SyncXMLHttpRequest_Cancelled +#endif +IN_PROC_BROWSER_TEST_F(LoaderBrowserTest, MAYBE_SyncXMLHttpRequest_Cancelled) { // If network service is running in-process, we can't simulate a crash. if (IsInProcessNetworkService()) return; @@ -401,7 +407,7 @@ IN_PROC_BROWSER_TEST_F(LoaderBrowserTest, CrossSiteNoUnloadOn204) { // app isn't stripped of debug symbols, this takes about five minutes to // complete and isn't conducive to quick turnarounds. As we don't currently // strip the app on the build bots, this is bad times. -#if defined(OS_MACOSX) +#if defined(OS_MAC) #define MAYBE_CrossSiteAfterCrash DISABLED_CrossSiteAfterCrash #else #define MAYBE_CrossSiteAfterCrash CrossSiteAfterCrash @@ -925,7 +931,7 @@ IN_PROC_BROWSER_TEST_F(RequestDataBrowserTest, SameOriginAuxiliary) { &success)); EXPECT_TRUE(success); Shell* new_shell = new_shell_observer.GetShell(); - WaitForLoadStop(new_shell->web_contents()); + EXPECT_TRUE(WaitForLoadStop(new_shell->web_contents())); auto requests = data(); EXPECT_EQ(2u, requests.size()); @@ -969,7 +975,7 @@ IN_PROC_BROWSER_TEST_F(RequestDataBrowserTest, CrossOriginAuxiliary) { &success)); EXPECT_TRUE(success); Shell* new_shell = new_shell_observer.GetShell(); - WaitForLoadStop(new_shell->web_contents()); + EXPECT_TRUE(WaitForLoadStop(new_shell->web_contents())); auto requests = data(); EXPECT_EQ(2u, requests.size()); |