1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
|
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/bookmarks/browser/url_index.h"
#include <iterator>
#include "base/containers/adapters.h"
#include "base/guid.h"
#include "components/bookmarks/browser/url_and_title.h"
namespace bookmarks {
namespace {
// Computes and aggregates into |*stats| metrics corresponding to a particular
// group of bookmarks with the same URL, listed in |*bookmarks_with_same_url|.
// The caller is responsible to guarantee that these provided bookmarks all
// share the same URL. Upon completion of this function, the state of
// |*bookmarks_with_same_url| is unspecified, because the implementation is free
// to modify its state desirable to avoid additional memory allocations on the
// calling site.
void AddStatsForBookmarksWithSameUrl(
std::vector<const BookmarkNode*>* bookmarks_with_same_url,
UrlIndex::Stats* stats) {
if (bookmarks_with_same_url->size() <= 1)
return;
stats->duplicate_url_bookmark_count += bookmarks_with_same_url->size() - 1;
// Sort only if there are 3 or more bookmarks. With exactly two (which is
// believed to be a common case) the precise ordering is irrelevant for the
// logic that follows.
if (bookmarks_with_same_url->size() > 2) {
std::sort(bookmarks_with_same_url->begin(), bookmarks_with_same_url->end(),
[](const BookmarkNode* a, const BookmarkNode* b) {
DCHECK_EQ(a->url(), b->url());
if (a->GetTitle() != b->GetTitle())
return a->GetTitle() < b->GetTitle();
return a->parent() < b->parent();
});
}
size_t duplicate_title_count = 0;
size_t duplicate_title_and_parent_count = 0;
auto prev_i = bookmarks_with_same_url->begin();
for (auto i = std::next(prev_i); i != bookmarks_with_same_url->end();
++i, ++prev_i) {
DCHECK_EQ((*prev_i)->url(), (*i)->url());
if ((*prev_i)->GetTitle() == (*i)->GetTitle()) {
++duplicate_title_count;
if ((*prev_i)->parent() == (*i)->parent())
++duplicate_title_and_parent_count;
}
}
DCHECK_LT(duplicate_title_count, bookmarks_with_same_url->size());
DCHECK_LE(duplicate_title_and_parent_count, duplicate_title_count);
stats->duplicate_url_and_title_bookmark_count += duplicate_title_count;
stats->duplicate_url_and_title_and_parent_bookmark_count +=
duplicate_title_and_parent_count;
}
} // namespace
UrlIndex::UrlIndex(std::unique_ptr<BookmarkNode> root)
: root_(std::move(root)) {
base::AutoLock url_lock(url_lock_);
AddImpl(root_.get());
}
void UrlIndex::Add(BookmarkNode* parent,
size_t index,
std::unique_ptr<BookmarkNode> node) {
base::AutoLock url_lock(url_lock_);
AddImpl(parent->Add(std::move(node), index));
}
std::unique_ptr<BookmarkNode> UrlIndex::Remove(BookmarkNode* node,
std::set<GURL>* removed_urls) {
base::AutoLock url_lock(url_lock_);
RemoveImpl(node, removed_urls);
BookmarkNode* parent = node->parent();
return parent->Remove(size_t{parent->GetIndexOf(node)});
}
void UrlIndex::SetUrl(BookmarkNode* node, const GURL& url) {
base::AutoLock url_lock(url_lock_);
RemoveImpl(node, nullptr);
node->set_url(url);
AddImpl(node);
}
void UrlIndex::SetTitle(BookmarkNode* node, const base::string16& title) {
// Acquiring the lock is necessary to avoid races with
// UrlIndex::GetBookmarks().
base::AutoLock url_lock(url_lock_);
node->SetTitle(title);
}
void UrlIndex::GetNodesWithIconUrl(const GURL& icon_url,
std::set<const BookmarkNode*>* nodes) {
base::AutoLock url_lock(url_lock_);
for (const BookmarkNode* node : nodes_ordered_by_url_set_) {
if (node->icon_url() && icon_url == *node->icon_url())
nodes->insert(node);
}
}
void UrlIndex::GetNodesByUrl(const GURL& url,
std::vector<const BookmarkNode*>* nodes) {
base::AutoLock url_lock(url_lock_);
BookmarkNode tmp_node(/*id=*/0, base::GenerateGUID(), url);
auto i = nodes_ordered_by_url_set_.find(&tmp_node);
while (i != nodes_ordered_by_url_set_.end() && (*i)->url() == url) {
nodes->push_back(*i);
++i;
}
}
bool UrlIndex::HasBookmarks() const {
base::AutoLock url_lock(url_lock_);
return !nodes_ordered_by_url_set_.empty();
}
UrlIndex::Stats UrlIndex::ComputeStats() const {
base::AutoLock url_lock(url_lock_);
UrlIndex::Stats stats;
stats.total_url_bookmark_count = nodes_ordered_by_url_set_.size();
if (stats.total_url_bookmark_count <= 1)
return stats;
std::vector<const BookmarkNode*> bookmarks_with_same_url;
auto prev_i = nodes_ordered_by_url_set_.begin();
for (auto i = std::next(prev_i); i != nodes_ordered_by_url_set_.end();
++i, ++prev_i) {
if ((*prev_i)->url() != (*i)->url()) {
AddStatsForBookmarksWithSameUrl(&bookmarks_with_same_url, &stats);
bookmarks_with_same_url.clear();
}
bookmarks_with_same_url.push_back(*i);
}
AddStatsForBookmarksWithSameUrl(&bookmarks_with_same_url, &stats);
return stats;
}
bool UrlIndex::IsBookmarked(const GURL& url) {
base::AutoLock url_lock(url_lock_);
return IsBookmarkedNoLock(url);
}
void UrlIndex::GetBookmarks(std::vector<UrlAndTitle>* bookmarks) {
base::AutoLock url_lock(url_lock_);
const GURL* last_url = nullptr;
for (auto i = nodes_ordered_by_url_set_.begin();
i != nodes_ordered_by_url_set_.end(); ++i) {
const GURL* url = &((*i)->url());
// Only add unique URLs.
if (!last_url || *url != *last_url) {
UrlAndTitle bookmark;
bookmark.url = *url;
bookmark.title = (*i)->GetTitle();
bookmarks->push_back(bookmark);
}
last_url = url;
}
}
UrlIndex::~UrlIndex() = default;
bool UrlIndex::IsBookmarkedNoLock(const GURL& url) {
url_lock_.AssertAcquired();
BookmarkNode tmp_node(/*id=*/0, base::GenerateGUID(), url);
return (nodes_ordered_by_url_set_.find(&tmp_node) !=
nodes_ordered_by_url_set_.end());
}
void UrlIndex::AddImpl(BookmarkNode* node) {
url_lock_.AssertAcquired();
if (node->is_url())
nodes_ordered_by_url_set_.insert(node);
for (const auto& child : node->children())
AddImpl(child.get());
}
void UrlIndex::RemoveImpl(BookmarkNode* node, std::set<GURL>* removed_urls) {
url_lock_.AssertAcquired();
if (node->is_url()) {
auto i = nodes_ordered_by_url_set_.find(node);
DCHECK(i != nodes_ordered_by_url_set_.end());
// i points to the first node with the URL, advance until we find the
// node we're removing.
while (*i != node)
++i;
nodes_ordered_by_url_set_.erase(i);
if (removed_urls && !IsBookmarkedNoLock(node->url()))
removed_urls->insert(node->url());
}
for (const auto& child : base::Reversed(node->children()))
RemoveImpl(child.get(), removed_urls);
}
} // namespace bookmarks
|
