blob: 670a23d6cd2f305cb4a31a3b01a2b61c33a3d384 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
|
# Copyright 2018 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Content public presubmit script
See https://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into gcl.
"""
def _CheckConstInterfaces(input_api, output_api):
# Matches 'virtual...const = 0;', 'virtual...const;' or 'virtual...const {}'
pattern = input_api.re.compile(r'virtual[^;]*const\s*(=\s*0)?\s*({}|;)',
input_api.re.MULTILINE)
files = []
for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
if not f.LocalPath().endswith('.h'):
continue
contents = input_api.ReadFile(f)
if pattern.search(contents):
files.append(f)
if len(files):
return [output_api.PresubmitError(
'Do not add const to content/public '
'interfaces. See '
'https://www.chromium.org/developers/content-module/content-api',
files) ]
return []
def CheckChangeOnUpload(input_api, output_api):
results = []
results.extend(_CheckConstInterfaces(input_api, output_api))
return results
def CheckChangeOnCommit(input_api, output_api):
results = []
results.extend(_CheckConstInterfaces(input_api, output_api))
return results
|
