summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2022-04-20 20:00:44 +0200
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2022-04-23 10:23:22 +0000
commit6b1ee57fc293a755b3cbeb55e67cadf90ce74904 (patch)
tree95c5346b32baabdb7460d0009d627bceec89d0ee
parentdccae219425e8964b4c267e114d222a26b953091 (diff)
downloadqtwebengine-6b1ee57fc293a755b3cbeb55e67cadf90ce74904.tar.gz
Support setting page to nullptr to unset
Worked in 5.15, and now crashed. This patch returns 5.15 behavior. Change-Id: Ib50dca96d9e90312cd2ee55aaf3205f5b848dd15 Reviewed-by: Michael BrĂ¼ning <michael.bruning@qt.io> (cherry picked from commit b76a7dd5eabc04c06494769ccae685cf581f52c4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r--src/webenginewidgets/api/qwebengineview.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/webenginewidgets/api/qwebengineview.cpp b/src/webenginewidgets/api/qwebengineview.cpp
index 889a6be76..44d661753 100644
--- a/src/webenginewidgets/api/qwebengineview.cpp
+++ b/src/webenginewidgets/api/qwebengineview.cpp
@@ -652,7 +652,10 @@ void QWebEngineView::setPage(QWebEnginePage *newPage)
disconnect(d->m_pageConnection);
d->m_pageConnection = {};
}
+
QWebEngineViewPrivate::bindPageAndView(newPage, this);
+ if (!newPage)
+ return;
d->m_pageConnection = connect(newPage, &QWebEnginePage::_q_aboutToDelete, this,
[newPage]() { QWebEngineViewPrivate::bindPageAndView(newPage, nullptr); });
auto profile = newPage->profile();