diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-04-05 09:27:08 +0200 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2023-04-05 12:19:25 +0000 |
commit | f353c92cc326cfd93d8ecc54d52524c1a9079443 (patch) | |
tree | 216a623bb8c3ee209b5792c9a9c719a63f75fee8 /examples/webenginewidgets/simplebrowser/browserwindow.cpp | |
parent | 4c9f9e4d305cd9a8e4e123d25cc6d8ecbc0990ad (diff) | |
download | qtwebengine-f353c92cc326cfd93d8ecc54d52524c1a9079443.tar.gz |
Simple browser example: Fix up the code
- Remove duplicated unused helper questionForFeature()
- Replace lambdas by slots where possible
- Fix clang warning about using multiple arguments to QString::arg()
- Remove dead code in WebView::contextMenuEvent() which checks on
inspectElement == actions.cend(), but is within an "if" checking
the same condition.
Change-Id: Ie85a3811f4f5a8c3fa9550d4eb2ca5bf79e39084
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit 88ef502099d535823156c31e77251dd2a723ad1c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'examples/webenginewidgets/simplebrowser/browserwindow.cpp')
-rw-r--r-- | examples/webenginewidgets/simplebrowser/browserwindow.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/examples/webenginewidgets/simplebrowser/browserwindow.cpp b/examples/webenginewidgets/simplebrowser/browserwindow.cpp index 7a72b4a6f..7f30d2e92 100644 --- a/examples/webenginewidgets/simplebrowser/browserwindow.cpp +++ b/examples/webenginewidgets/simplebrowser/browserwindow.cpp @@ -355,9 +355,8 @@ QToolBar *BrowserWindow::createToolBar() downloadsAction->setIcon(QIcon(u":go-bottom.png"_s)); downloadsAction->setToolTip(tr("Show downloads")); navigationBar->addAction(downloadsAction); - connect(downloadsAction, &QAction::triggered, [this]() { - m_browser->downloadManagerWidget().show(); - }); + connect(downloadsAction, &QAction::triggered, + &m_browser->downloadManagerWidget(), &QWidget::show); return navigationBar; } |