WebUI example: Reduce duplications

Declare scheme name and about URL in one place.

Change-Id: Id8eb69f2a8516dd21e6abedc2adda828a5a9e18c
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>

1 files changed, 9 insertions, 5 deletions

diff --git a/examples/webenginewidgets/webui/webuihandler.cpp b/examples/webenginewidgets/webui/webuihandler.cpp
index 42446b88e..246af9d07 100644
--- a/examples/webenginewidgets/webui/webuihandler.cpp
+++ b/examples/webenginewidgets/webui/webuihandler.cpp
@@ -55,6 +55,11 @@
 #include <QWebEngineUrlRequestJob>
 #include <QWebEngineUrlScheme>
 
+#define SCHEMENAME "webui"
+
+const QByteArray WebUiHandler::schemeName = QByteArrayLiteral(SCHEMENAME);
+const QUrl WebUiHandler::aboutUrl = QUrl(QStringLiteral(SCHEMENAME ":about"));
+
 WebUiHandler::WebUiHandler(QObject *parent)
     : QWebEngineUrlSchemeHandler(parent)
 {
@@ -62,8 +67,7 @@ WebUiHandler::WebUiHandler(QObject *parent)
 
 void WebUiHandler::requestStarted(QWebEngineUrlRequestJob *job)
 {
-    static const QUrl webuiAboutUrl(QStringLiteral("webui:about"));
-    static const QUrl webUiOrigin(QStringLiteral("webui:"));
+    static const QUrl webUiOrigin(QStringLiteral(SCHEMENAME ":"));
     static const QByteArray GET(QByteArrayLiteral("GET"));
     static const QByteArray POST(QByteArrayLiteral("POST"));
 
@@ -71,11 +75,11 @@ void WebUiHandler::requestStarted(QWebEngineUrlRequestJob *job)
     QUrl url = job->requestUrl();
     QUrl initiator = job->initiator();
 
-    if (method == GET && url == webuiAboutUrl) {
+    if (method == GET && url == aboutUrl) {
         QFile *file = new QFile(QStringLiteral(":/about.html"), job);
         file->open(QIODevice::ReadOnly);
         job->reply(QByteArrayLiteral("text/html"), file);
-    } else if (method == POST && url == webuiAboutUrl && initiator == webUiOrigin) {
+    } else if (method == POST && url == aboutUrl && initiator == webUiOrigin) {
         job->fail(QWebEngineUrlRequestJob::RequestAborted);
         QApplication::exit();
     } else {
@@ -86,7 +90,7 @@ void WebUiHandler::requestStarted(QWebEngineUrlRequestJob *job)
 // static
 void WebUiHandler::registerUrlScheme()
 {
-    QWebEngineUrlScheme webUiScheme(QByteArrayLiteral("webui"));
+    QWebEngineUrlScheme webUiScheme(schemeName);
     webUiScheme.setFlags(QWebEngineUrlScheme::Secure |
                          QWebEngineUrlScheme::Local |
                          QWebEngineUrlScheme::LocalAccessAllowed);