summaryrefslogtreecommitdiff
path: root/src/core/api/qwebengineurlscheme.h
diff options
context:
space:
mode:
authorJüri Valdmann <juri.valdmann@qt.io>2019-07-09 09:42:39 +0200
committerJüri Valdmann <juri.valdmann@qt.io>2019-07-15 17:04:39 +0200
commit1f699db3d71a0afcb961466bcc6b1a8ed6f72468 (patch)
tree4825360ad986123d730b38501b245db91a33c206 /src/core/api/qwebengineurlscheme.h
parent2227f9086f856223c90e7cca0637853d45b848f2 (diff)
downloadqtwebengine-1f699db3d71a0afcb961466bcc6b1a8ed6f72468.tar.gz
Ignore persisted spellchecking preferences
Ignore on-disk values of spellCheckEnabled and spellCheckLanguages prefs to preserve backwards compatibility. Fixes deterministic failure in second run of tst_spellchecking because the first run disabled spellchecking. Put all settings-related tests in tst_spellchecking into one test and pretend to check that settings are not persisted. Since settings are currently read and written on independent task sequences without guaranteed ordering, the test would succeed even if settings were persisted. Specifically, in code like this profile = new QWebEngineProfile("MyProf"); // 1 delete profile; // 2 profile = new QWebEngineProfile("MyProf"); // 3 the write from line 2 will usually happen after the read from line 3. Once persistence becomes a public feature we probably should add some way to guarantee the proper ordering of reads and writes. Change-Id: Icb2290417049848dbe68b7f991bbe2d52756f295 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'src/core/api/qwebengineurlscheme.h')
0 files changed, 0 insertions, 0 deletions