diff options
author | Michal Klocek <michal.klocek@qt.io> | 2023-04-20 11:06:18 +0200 |
---|---|---|
committer | Michal Klocek <michal.klocek@qt.io> | 2023-05-03 12:35:32 +0200 |
commit | 4aca44bbf6d63c6a73cb9c3220055a39c4cbd2b1 (patch) | |
tree | bf07aa6d82ab140c291900b04641ff0c9c457b4b /src/pdf | |
parent | bd1d854d03f169f005511b2204d124dc05213571 (diff) | |
download | qtwebengine-4aca44bbf6d63c6a73cb9c3220055a39c4cbd2b1.tar.gz |
Fix build race condition between data_dep and WebEngineCore.stamp
For v8 context generator data_dep race condition occurs
on universal builds. As data_dep is runtime dependency,
it will be not included into our linker WebEngineCore.stamp,
changing the behavior in gn would look ugly as it would require
introducing another flag to just to handle this case to force
this dependency for build time. Therefore add extra
v8_context_snapshot.stamp to cmake to cover that case.
Change-Id: Ia8b2320fc8e615235bde483d282dfca73a38f215
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'src/pdf')
-rw-r--r-- | src/pdf/CMakeLists.txt | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/pdf/CMakeLists.txt b/src/pdf/CMakeLists.txt index e84248b6a..f4b03e33a 100644 --- a/src/pdf/CMakeLists.txt +++ b/src/pdf/CMakeLists.txt @@ -226,6 +226,13 @@ endforeach() get_architectures(archs) list(GET archs 0 arch) target_include_directories(Pdf PRIVATE ${buildDir}/$<CONFIG>/${arch}/gen) -add_gn_build_aritfacts_to_target(Pdf QtPdf pdf ${buildDir} TRUE) +add_gn_build_aritfacts_to_target( + CMAKE_TARGET Pdf + NINJA_TARGET QtPdf + MODULE pdf + BUILDDIR ${buildDir} + COMPLETE_STATIC TRUE + NINJA_STAMP QtPdf.stamp +) add_dependencies(Pdf run_pdf_NinjaDone) |