| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
The current limit is often hit by incremental builds when working on
webengine, and it costs us nothing to enable it.
Pick-to: 6.5
Change-Id: I3aa96b789e0949637b174be31b5f36315718e201
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For v8 context generator data_dep race condition occurs
on universal builds. As data_dep is runtime dependency,
it will be not included into our linker WebEngineCore.stamp,
changing the behavior in gn would look ugly as it would require
introducing another flag to just to handle this case to force
this dependency for build time. Therefore add extra
v8_context_snapshot.stamp to cmake to cover that case.
Change-Id: Ia8b2320fc8e615235bde483d282dfca73a38f215
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should provide v8 snapshot toolchain only in case of cross
compilation, otherwise gn can simply use current toolchain for
creating v8 snapshot generator.
This prevents triggering second pointless build of v8 and blink
to generate snapshot of v8 context for desktop builds.
Pick-to: 6.5
Change-Id: I214b8b802c6827fbece3b2158f206b65fb768288
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
It is no longer necessary to build successfully, and improves loading times in debug mode.
Pick-to: 6.5
Task-number: QTBUG-110504
Change-Id: If2a49fc96aaa113a90d5573371069754da354f7a
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To save some typing when doing 3rdparty udpate introduce
'update-chromium' target, which creates commit with nicely
formated commit message with shas, it can be used for example
with following steps:
* qtwebengine repo is at the origin HEAD with nothing stagged
* there are some new commits in 3rdparty
* code compiles and there are no issues
* make update commit by typing in <build_dir>
* ninja update-chromium
or
* cmake --build . --target update-chromium
* push the commit
You can also create the commit from <source_dir> with:
cmake -P cmake/SubmoduleUpdate.cmake
Pick-to: 6.5
Change-Id: Ia6b051cd2df0646707c2cc88175245841728794f
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Yigit Akcay <yigit.akcay@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Webengine fails to build with 32bit Nodejs.
It crashes on devtools-frontend/src/scripts/build/compress_files.js.
Add configure time check for node binary.
Task-number: QTBUG-111852
Change-Id: I80844e36d5ae4621e2dae6fe61de883580b56a57
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure gn is build before doc target, otherwise
parallel top level build might not succeed.
As configure runs the gn binary is not compiled
so use scripting mode to execute gn call during
build time.
Pick-to: 6.5
Task-number: QTBUG-108751
Change-Id: I7e851de90e2a3ec52f5259d51f677b23d8245bcb
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
Use gn_target for code attributions generation.
Task-number: QTBUG-88482
Pick-to: 6.5
Change-Id: I4e5d063dec2347c10eb715a467bdd376e39e60af
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generate a new rsp file for each cmake target
containing '-L' flags and pass them to cmake.
Task-number: QTBUG-105053
Task-number: QTBUG-111225
Change-Id: Ib25c009795b776bc5f0f6e07fb89b932ef30b484
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit a21742ef6064c1e84ebc43468d253dd14d86bf02)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
| |
Task-number: QTBUG-83459
Change-Id: I39915206859f031dd78798eeb7b2b49f4f148452
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
To do so, we need to deal with the macros a bit differently, so here, I
replaced the macros with available utility functions, and added one for
the QTWEBENGINEPROCESS_NAME.
Fixes: QTBUG-110873
Task-number: QTBUG-99238
Change-Id: I29b41ffb8059511d2d93bfc01d40308aedaa8ad4
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Pick-to: 6.5
Fixes: QTBUG-105147
Change-Id: I0022964903f3443cc97843c62468ab9be8ae2ed8
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When trying to cross-build from one 32 bit host architecture to another the
"Unsupported architecture:" case was hit, in which case the result of
get_v8_arch() was empty. This would lead to configure_gn_toolchain() being
called with a missing argument, which gave a totally unhelpful error message.
Fix this by just accepting valid 32 bit architectures from the internal list,
and raise the debug message to a FATAL_ERROR to get immediate feedback.
Pick-to: 6.4 6.3
Change-Id: I8e0c757ad13e2acff67827bd9063c493e9d84444
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should delay some dll loads as MediaFoundation is not available
on Windows N. Chromium already uses that option when compiling
components, however we use only response file to track dependencies,
and those libs were never linked with DELAYLAD flags by (qt)cmake.
There is currently no nice way to set those base on gn dependencies as
those are generated on bulid time and we need linker flags on configure time.
As workaround simply hardcode those 3 required libs, as side effect
when linking QtPdf module there will be warning that there are no
references to mentioned media foundation libs.
Pick-to: 6.4 6.4.0 6.3
Fixes: QTBUG-100391
Change-Id: I06e4bffdf8bc6803a4f2b1437679628b9a733299
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
It could be that 300 seconds is not enough on some machines.
Amends dfa58067e31e77e20f0cd25f408e248c8ff82cf4
Pick-to: 6.4
Fixes: QTBUG-105168
Change-Id: Ice3fe6a68fe1969c21e001169bfba2d9dbdec770
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-105718
Change-Id: I2ad190e5536cdbdc8d2656e61892545d66911a02
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
| |
We need --long-plt for arm debug builds.
Pick-to: 6.4 6.3
Change-Id: I99fa6a2f8ec803cc399509d02a5cc9ad22fd0f87
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
| |
do note that chromium itself still needs additional patches to compile
on RISC-V 64, but on the Qt side, this is enough.
Change-Id: I3b214fc5f4a286a665c85556892e553258b52cf5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.4
Change-Id: I7ef0ad616f2ea0fae482253335e95998aa2d360e
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.4
Change-Id: I217c87657f544a2e868de7291353ff1143e20902
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.4 6.3
Change-Id: If92ff1afdaee5096bc3ce8e53332542b8c4375b6
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
| |
CMakeLists.txt and .cmake files of significant size
(more than 2 lines according to our check in tst_license.pl)
now have the copyright and license header.
Existing copyright statements remain intact
Task-number: QTBUG-88621
Change-Id: I118bd63694cfe2c9a413af4a38828a31727f8e86
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Create intermediate object file and use it as
imported object library.
Fixes: QTBUG-103579
Change-Id: I2ff7d57509ab1f071876de3b6fdc5ed9874c4697
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 88a91f8b30df1b95cf9adebacb13a8c0fc3f06c9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In ci 'gn' can crash making it hard to integrate, if there
is high load crashes occur more frequently sometimes even
blocking integrations for few days.
Limit number of worker threads for gn as this improves situation
however increases time for generating ninja files from 2s to 7s.
Note this will not prevent crashes however significantly reduces the
issue (when running in loop from 1 per ~10min to 1 per ~3days)
Compilation with address or thread sanitizer does not lead to meaningful
traces. Moreover running gn with sanitizer creates deadlocks for
unknown reason every few runs.
Current assumptions is that macos vms are unstable as crashes also occur
for sscache calls (compiler) and python calls.
Pick-to: 6.3 6.2
Change-Id: I1c488796eb0547eedd20101606f18ed55718e9c2
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
| |
Fixes undefined feature when compiling against 6.2.
Pick-to: 6.3
Change-Id: I186d0a0905bfb7d03cff07c2dd6316172efebc04
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So far we only supported a cross-compiling with universal builds,
however qmake also supports 'regular' cross compilation (by setting
'-device-option'). This is semi-supported with qt-cmake as we need to
provide additional configure defines like:
* CMAKE_OSX_ARCHITECTURES=arm64
* CMAKE_SYSTEM_NAME=Darwin
* CMAKE_OSX_DEPLOYMENT_TARGET=10.14
It might seem to be a far fetched issue, however in case of webengine
doing the cross compilation for only one architecture allows to save
compile times when testing only arm64 builds.
Note we do not need to create gn toolchains for that case, however
unlike universal builds it requires host qt build for tools.
Pick-to: 6.3 6.2
Change-Id: Ica8470fdd4cad4866c1470e0403ffd019eaf39a6
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
| |
Previously if Gn.cmake was touched, GN was not reran.
Pick-to: 6.2 6.3
Change-Id: I39a070319c5af2a78a8f4e75f2f56ed87cdcb7da
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using USES_TERMINAL causes ninja to print the stdout of running GN as
it comes in, rather than once GN has finished running.
This causes extremely confusing logs in the CI when the GN run fails.
The output becomes interleaved with execution of other parallel
commands and the Ninja 'FAILED:' message is nowhere near the actual
failure GN failure message.
Remove USES_TERMINAL so that the GN failure message appears
immediately after ninja's "FAILED:" message.
Recursive ninja output is not affected.
Pick-to: 6.2 6.3
Change-Id: Ibbfe5527cf291d9295ae19d988ee1fa83224b38b
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix build with libc++ on linux by adding missing use_libcxx
parameter.
Check if re2 and poppler can be used as they use std::string in
their api. Add compiler test to check that.
Pick-to: 6.3 6.2
Change-Id: I74bf79b8443ad470621c1a2e0c9dc768d4cca1f1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way the python scripts configured by gn_configure will use the
same python version detected by the initial configure_submodule.
This is useful when configuring separately and under different
environment than the build itself, and the different python executables
possibly used in the two phases cause issues, like modules not found.
Pick-to: 6.3 6.2
Change-Id: Iab7cc48c2bb4f8c7fb4af7965c1183388a53527b
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add 3rdparty installed headers so static builds can
use bundled qt libs.
Fix static gn and archiver/librarian setup.
Updates 3rdparty:
* 5d88de975 Fix static build with qt3rdparty libs
Task-number: QTBUG-87154
Task-number: QTBUG-88614
Pick-to: 6.3 6.2
Change-Id: Iad7682da92b558b500140f415acc0bc9c9a1c22e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
We get sometimes GN_FAILED on mac, unfortunately it is not clear
what had failed, therefore log cmake error and add timeout.
Pick-to: 6.3 6.2
Change-Id: I69beaa971de4a5848d73613783db94940be91e68
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtPDf iOS builds must support fat libs builds. Compared
to 5.15 however this is done differently. Before we tweaked gn
to compile multi arch with 'Xarch' parameter. This had few
downsides as we could not determine which arch/cpu compiles
given file as compilation was opaque to gn. The current approach is
to follow mac universal builds, compile builds separately for each
architecture and lipo the outcome. However, this introduces some
issues as ios builds are static builds and creating lipo archive
will gather object files, which should end up in final QtPdf lib
instead. Therefore create multi arch object file instead of archive
and use this one.
Note the compiler now uses arch triple for Pdfium as Chromium does,
however qt files still use 'arch' and '*-version-min' combination.
Task-number: QTBUG-88614
Pick-to: 6.3 6.2
Change-Id: I7775c8b4d1554df497eb61fa6187f12c00b9032d
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With 6.x we have gn-cmake integration which allows now
in case of static builds to switch gn target output to
static_library with 'complete static' option instead of
shared_library. This way we can avoid installing dependencies
in form of internal static Chromium archives as it was done
in 5.15 in case of static builds.
Unfortunately 'complete static' option can not be used with
QtWebEngineCore build as it will exceed 4Gb static archive
limitation on Windows, however it will work fine with QtPdf.
Note the qtbase 3rdparty static libs have to be still installed
in case of qt static build, this patch only eliminates need for
Chromium specific ones.
Task-number: QTBUG-88614
Pick-to: 6.3 6.2
Change-Id: I6fc4ce48c79a1631b013d0b29c190c62280f7304
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix typo config -> configs.
Add checks for configs and archs, otherwise we silently do
not set right dependencies and continue the build.
This can end up in weird looking errors.
Task-number: QTBUG-99511
Pick-to: 6.3 6.2 6.2.3
Change-Id: Ief727033e7b3ac32ab9f42bd96babd9be97f63a6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Pick-to: 6.3 6.2 6.2.3
Fixes: QTBUG-99511
Change-Id: I8b9550c8a7e331e319fc7784224571beef0410b1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.3 6.2
Change-Id: Ic075eaff01c6536ce9d6a12bab7ee0cd8d5764bd
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
GN doesn't use them currently, but I will need them to build ANGLE.
Pick-to: 6.3
Change-Id: Ide4d9b93d822abbfff9af4dba1e2f4e6a5cd4cde
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: If9de5a87ff7c398a198a31fd4fd20858e82bec7e
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
This is the version available on RHEL, and appears to work.
Change-Id: I150138cc64b5a796acaeed838a8ec685d4a38c86
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: I9fb8998a3a7762b0aea70993ca231f0bbf4f7761
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QT_SUPERBUILD is never cached and user can run
only qtbase as super build and compile any other
module as separate module build, moreover this can be
also 'no prefix' build.
Fix missing checks to support that case and clean up
install of resources.
For mac framework builds copy bundle to right place
in case of 'no-prefix' builds.
Fixes: QTBUG-94604
Task-number: QTBUG-96375
Pick-to: 6.2
Change-Id: I4ab7d4fed2c2be93f2a048a510419849361883ba
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since coin does not support doing matrix projects,
add primitive way to automate features builds.
Add self build launcher in form of external projects
to do few builds one after the other which test
some of our features.
These are just compilation tests and could also run in
coin as scheduled build.
Usage:
/path/to/qt-cmake-private /path/to/webenginesources -DMATRIX_BUILD=ON
Created currently builds:
* webengine_extensions-OFF
* webengine_printing_and_pdf-OFF
* webengine_proprietary_codecs-ON
* webengine_spellchecker-OFF
* webengine_webrtc-OFF
* qtwebengine_build-OFF
Pick-to: 6.2
Change-Id: Ie1bbc2cf9b01cb2e5089832d8f1cd6171e31b6fe
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In 53e99bd we used genex to get moc path, this works well,
but not for mulitconifg build where genex will output path
to debug moc in case of superbuild.
To fix issues like that cmake 3.20 introduces
$<OUTPUT_CONFIG:...> and $<COMMAND_CONFIG:...>
generator-expressions, however it will not help much since
they do not work with file(GENERATE), moreover minimal
current version is 3.19
Use target property to query moc location or recreate
path in case of superbuild.
Fixes: QTBUG-96375
Pick-to: 6.2
Change-Id: Ief0fc32d57a36191694102ed010314b5d3395334
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
LIST(APPEND cflags ...) separates appended elements with a semicolon.
This may break parsing cflags and can result invalid args.gn. Remove
semicolons from cflags before parsing it.
Pick-to: 6.2
Change-Id: I3898bcad2051276d44953ae72d87cf4f91516012
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
We need to set the cmake base path, when not controlling
the toolchain like on Linux.
Pick-to: 6.2
Change-Id: I0e2f1ea76d9c52bb9bf867daa8fa2feceff3707e
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
The check was reverted putting more memory pressure on low levels,
and less on greater ones.
Pick-to: 6.2
Change-Id: I1d0afeb0b96ff2d4ccd6249e7dd7312375c2fad4
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since 9f4914248 we have poor man workaround for
broken rsp files on windows with cmake. It requires
copy of rsp files to directory where the linker call
takes place. Adjust the output directory for
super build.
Pick-to: 6.2 6.2.0
Fixes: QTBUG-96266
Change-Id: Ib09add2d6069782ba25a820e950759932eefc457
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resolves an error on gn_config_cxx.cmake include:
CMake Error at src/pdf/RelWithDebInfo/x86_64/gn_config_cxx.cmake:4:
Parse error. Function missing ending ")". End of file reached.
Lists for config vars may contain values, like -Wno-error=#warning
for GN_CXX_COMPILE_OPTIONS, which cause parsing errors and should be quoted.
Pick-to: 6.2 6.2.0
Change-Id: I983f5b23c9013d55f728ffe4354f6abbb0db1911
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support flags passed to main 'configure' and separate
'qt-configure-module' scripts with flags like '-no-build-qtpdf',
'-webengine-full-debug-info', '-no-webengine-jumbo-build', etc.
Fixes: QTBUG-95717
Pick-to: 6.2 6.2.0
Change-Id: Ia12602e9a9b31f4f2256f983f6c1e3fbe50cb9e3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|