1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
|
2013-07-17 Kangil Han <kangil.han@samsung.com>
Use toHTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=118727
Reviewed by Ryosuke Niwa.
To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
2013-07-16 Kangil Han <kangil.han@samsung.com>
Use toHTMLSelectElement and dismiss isHTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=118714
Reviewed by Ryosuke Niwa.
To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
Additionally, this patch removes isHTMLSelectElement because not all element subclasses can be checked by a combination of tag names.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndex):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
2013-07-08 Jacky Jiang <zhajiang@blackberry.com>
[BlackBerry] Block Zoom does not zoom in on narrow paragraphs properly
https://bugs.webkit.org/show_bug.cgi?id=118472
Reviewed by Rob Buis.
Internally reviewed Arvid Nilsson and Genevieve Mak.
JIRA 114653
For the narrow paragraphs on www.nytimes.com, the first best node for
block zoom under the point is deprecated due to the limits of maximum
block zoom scale(3) and default maximum WebPage zoom scale(4) and instead
it picks up an ancestor node which is wider so that it looks like doesn't
zoom in properly.
To fix that, enlarge the default maximum WebPage zoom scale slightly
and use maximumScale() instead of maxBlockZoomScale() so that we can
accept more nodes. And also we'll still clamp the new scale by
maxBlockZoomScale() when we block zoom the WebPage, in which way those
nodes can be showed in the center of the viewport and surrounded by a
few other nodes within the viewport which shows better user experience.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::maximumScale):
(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):
2013-07-01 Jochen Eisinger <jochen@chromium.org>
Remove support for consumable user gestures
https://bugs.webkit.org/show_bug.cgi?id=118247
Reviewed by Geoffrey Garen.
* WebKitSupport/NotificationManager.cpp:
(BlackBerry::WebKit::NotificationManager::notificationClicked):
2013-07-01 Kangil Han <kangil.han@samsung.com>
Adopt toHTMLTextAreaElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118226
Reviewed by Andreas Kling.
To enhance readability, this patch adopts toHTMLTextAreaElement.
This also helps out to reduce duplicated use of static_cast.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
2013-06-29 Kangil Han <kangil.han@samsung.com>
Adopt is/toHTMLOptGroupElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118213
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLOptGroupElement.
This also helps out to reduce duplicated use of static_cast.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):
2013-06-29 Kangil Han <kangil.han@samsung.com>
Adopt is/toHTMLOptionElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118212
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLOptionElement.
This also helps out to reduce duplicated use of static_cast.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::openSelectPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
* WebKitSupport/SelectPopupClient.cpp:
(BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
2013-06-28 Kangil Han <kangil.han@samsung.com>
Adopt is/toHTMLImageElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118182
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLImageElement.
This also helps out to reduce duplicated use of static_cast.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPage::blockZoom):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
2013-06-27 Kangil Han <kangil.han@samsung.com>
Adopt is/toHTMLInputElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118130
Reviewed by Antti Koivisto.
To enhance readability, this patch adopts is/toHTMLInputElement.
This also helps out to reduce duplicated use of static_cast.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
(BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
(BlackBerry::WebKit::DOMSupport::isColorInputField):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesNoAutocomplete):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::setInputValue):
(BlackBerry::WebKit::InputHandler::extractedTextRequest):
(BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
2013-06-27 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] We should clear all markers when input changes a word
https://bugs.webkit.org/show_bug.cgi?id=118136
JIRA115313.
For the case where a letter is added to the middle of a misspelled word, we were
sending incorrect offsets to clear spelling markers. However, since this
expanded the current word, it overlaps entirely the previous spelling marker so
no issue is found. However, if the keypress is backspace, the incorrect range
is smaller, causing an overlap which recreates the marker over the last character.
Setting shouldEraseMarkersAfterChangeSelection to follow continuous spell checking,
which will clear all markers regardless of overlap.
This patch also sustains spelling markers after the user taps to move the caret onto
the word, which is a nice gain as it was asked for previously.
Reviewed by Rob Buis.
Internally Reviewed by Mike Fenton
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
2013-06-26 Carlos Garcia Campos <cargarcia@blackberry.com>
[BlackBerry] Handle testRunner.setCustomPolicyDelegate()
https://bugs.webkit.org/show_bug.cgi?id=117982
Reviewed by Rob Buis.
Take custom policy into account when deciding the policy for
navigation actions.
Fixes test fast/loader/onload-policy-ignore-for-frame.html.
* Api/DumpRenderTreeClient.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
If custom policy is enabled ignore the navigation action when it's
not permissive.
2013-06-26 Kangil Han <kangil.han@samsung.com>
Adopt is/toHTMLAreaElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117980
Reviewed by Antonio Gomes.
To enhance readibility, this patch adopts is/toHTMLAreaElement.
This also helps out to reduce duplicated use of static_cast.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::elementForTapHighlight):
2013-06-26 Jacky Jiang <zhajiang@blackberry.com>
[BlackBerry] ASSERT(!m_tileMatrixNeedsUpdate) in BackingStorePrivate::render()
https://bugs.webkit.org/show_bug.cgi?id=118062
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
JIRA426949
requestLayoutIfNeeded() can cause zoomAboutPoint() when the layout
is finished and make the tile matrix stale. We need requestLayoutIfNeeded()
before we updateTileMatrixIfNeeded() so that we can fix the ASSERT and
also pass the valid TileIndexList to render().
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::render):
2013-06-25 Kangil Han <kangil.han@samsung.com>
Adopt is/toHTMLAnchorElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117973
Reviewed by Andreas Kling.
To enhance readibility, this patch adopts is/toHTMLAnchorElement.
This also helps out to reduce duplicated use of static_cast.
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
2013-06-24 Kangil Han <kangil.han@samsung.com>
Adopt is/toHTMLFormElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117937
Reviewed by Andreas Kling.
This refers to http://src.chromium.org/viewvc/blink?view=revision&revision=152859
To enhance readibility, this patch adopts is/toHTMLFormElement.
This also helps out to reduce duplicated use of static_cast.
* WebCoreSupport/CredentialManager.cpp:
(WebCore::CredentialManager::autofillPasswordForms):
2013-06-24 Jakob Petsovits <jpetsovits@blackberry.com>
[BlackBerry] Only resume root layer commits for visible WebPages
https://bugs.webkit.org/show_bug.cgi?id=117956
https://jira.bbqnx.net/browse/BRWSR-12047
JIRA428381
Reviewed by George Staikos.
In r150629, the code from that change introduced to
suspend and resume root layer commits would not take into
account whether the page is actually visible.
Because application activation state is usually conveyed
to all or any WebPages, this would mean on transitioning
into an active application state, we were resuming
root layer commits that might have previously been
disabled for visibility reasons.
Fix this by going through a single function that knows
by itself whether to suspend or resume root layer commits,
so the calling code doesn't have a chance to get it wrong.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::updateRootLayerCommitEnabled):
* Api/WebPage_p.h:
(WebPagePrivate):
2013-06-20 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Send the correct offsets for misspelled words.
https://bugs.webkit.org/show_bug.cgi?id=117846
JIRA116916.
When the caret is placed after a word, the offsets were calculated around
the proceeding space. As such, words that end a sentence worked correctly, but
midsentence words did not. The 'startOfWord' was calculated for the space ahead
and not for the word before it. Now finding the start of the word correctly and
calculating the end from there.
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
2013-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
https://bugs.webkit.org/show_bug.cgi?id=117827
Reviewed by Rob Buis.
Add DumpRenderTreeClient::willSendRequestForFrame() to handle
dispatchWillSendRequest() in DRT.
Fixes tests
fast/loader/onload-willSendRequest-null-for-script.html and
fast/loader/willSendRequest-null-for-preload.html.
* Api/DumpRenderTreeClient.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
2013-06-19 Jakob Petsovits <jpetsovits@blackberry.com>
[BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
https://bugs.webkit.org/show_bug.cgi?id=117799
https://jira.bbqnx.net/browse/BRWSR-11712
JIRA413289
Reviewed by Carlos Garcia Campos.
Discovered by Xuefei Ren.
If, in rare cases, renderContents() returns false,
the for() loop in render() will take a tile buffer from
the surface pool but due to aborting the iteration early,
won't put it into the new tile map. In order to prevent
losing the buffer, we need to put it back into the
surface pool before continuing.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):
2013-06-17 Tiancheng Jiang <tijiang@rim.com>
Cache FatFinger Text Result.
https://bugs.webkit.org/show_bug.cgi?id=107403.
Reviewed by Rob Buis.
Internally Reviewed by Genevieve Mak.
Cache the FatFinger text result for later use in TouchEventHandler.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::contextNode):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
* WebKitSupport/TouchEventHandler.h:
(BlackBerry::WebKit::TouchEventHandler::cacheTextResult):
(TouchEventHandler):
2013-06-14 Alberto Garcia <agarcia@igalia.com>
[BlackBerry] Remove implementation of ContextMenu classes
https://bugs.webkit.org/show_bug.cgi?id=114860
Reviewed by Rob Buis.
This code is not being used so we can safely remove it.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
* WebCoreSupport/ContextMenuClientBlackBerry.cpp: Removed.
* WebCoreSupport/ContextMenuClientBlackBerry.h: Removed.
2013-06-14 Arvid Nilsson <anilsson@rim.com>
[BlackBerry] LayerTiler fails to tile really big layers
https://bugs.webkit.org/show_bug.cgi?id=117211
Reviewed by Carlos Garcia Campos.
PR 273550
Adapt to changes in LayerCompositingThreadClient interface.
* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
* Api/WebOverlay_p.h:
(WebOverlayLayerCompositingThreadClient):
2013-06-12 Leo Yang <leoyang@rim.com>
[BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData
https://bugs.webkit.org/show_bug.cgi?id=117553
Reviewed by Carlos Garcia Campos.
In CredentialTransformData we should use RefPtr for
m_userNameElement, m_passwordElement and m_oldPasswordElement
because otherwise the elements could go away when the form
elements get destroyed.
Also add *const* for the parameter of CredentialTransformData::findPasswordFormFields().
No functionalities changed no new tests.
* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
(WebCore::CredentialTransformData::locateSpecificPasswords):
* WebCoreSupport/CredentialTransformData.h:
2013-06-12 Alberto Garcia <agarcia@igalia.com>
[BlackBerry] Remove dead WebDOM code
https://bugs.webkit.org/show_bug.cgi?id=113370
Reviewed by Anders Carlsson.
BlackBerry PR 347565
Internally reviewed by Charles Wei.
* Api/WebPage.cpp:
* Api/WebPage.h:
* WebCoreSupport/AboutDataEnableFeatures.in:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2013-06-12 Jakob Petsovits <jpetsovits@blackberry.com>
[BlackBerry] Smarter algorithm to determine the backingstore rect
https://bugs.webkit.org/show_bug.cgi?id=117451
JIRA115644
https://jira.bbqnx.net/browse/BRWSR-7028
Reviewed by Rob Buis.
So far, the backingstore tile geometry allocation was
pretty straightforward: We would start off from the
current viewport and append all available tiles into
the current scrolling direction from there.
This will usually work well enough, but has the downside
of discarding all the tiles in the opposite direction.
Also, tiles very close to the viewport will often get
discarded even if the user only scrolls very slowly.
This patch completely revamps the algorithm for
determining where the backingstore should be positioned.
The general idea is that we construct a "desired rect"
based on the viewport and inflate it into all four
directions according to the current scroll momentum.
This rectangle will be similarly large as a backingstore
tile geometry rectangle might be, by using the
approximate number of pixels that are available in the
given number of tiles.
The proportions for extending the rectangle from the
viewport are influenced by different factors, including
scroll momentum, viewport ratio, available space in the
overall contents rectangle, and natural bias for the
"down" direction.
In practice, this results in a backingstore that is
roughly evenly distributed around the viewport when no
movement is happening, and will gradually narrow down
and extend into the scroll direction at a higher momentum.
The final tile geometry is constructed by trying fit
the tiles into the desired rect in a way that maximizes
the area of its intersection. There are a few parameters
that can be tweaked, the ones in this patch seem to
handle most cases well enough to minimize checkerboarding.
As an additional bonus, a rectangle-based tiling strategy
can more easily be adopted for accelerated compositing,
which currently operates on a simpler algorithm that also
inflates the viewport but does not take scrolling into
account.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::nonOverscrolled):
(BlackBerry::WebKit::BackingStorePrivate::enclosingTileRect):
(BlackBerry::WebKit::BackingStorePrivate::desiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::mergeDesiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::largestTileRectForDesiredRect):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
* Api/BackingStore_p.h:
(BackingStorePrivate):
2013-06-12 Zan Dobersek <zdobersek@igalia.com>
Remove memoryInfoEnabled, quantizedMemoryInfoEnabled settings
https://bugs.webkit.org/show_bug.cgi?id=117512
Reviewed by Darin Adler.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.
2013-06-06 Genevieve Mak <gmak@rim.com>
[BlackBerry] Crash in InRegionScrollerPrivate::clearDocumentData
https://bugs.webkit.org/show_bug.cgi?id=117317
Reviewed by Rob Buis.
PR #348994
Need to check the scrollableArea instead of asserting because in this case for the
selection subframe it is allowed to be null.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
2013-06-05 Bear Travis <betravis@adobe.com>
[CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
https://bugs.webkit.org/show_bug.cgi?id=117172
Reviewed by Alexandru Chiculita.
Adding the CSS_SHAPES compile flag.
* WebCoreSupport/AboutDataEnableFeatures.in:
2013-06-05 Genevieve Mak <gmak@rim.com>
[BlackBerry] Deleting the pendingSelectionCandidate on the wrong thread causes an assert.
https://bugs.webkit.org/show_bug.cgi?id=117276
Reviewed by Rob Buis.
Reviewed Internally by Nima Ghanavatian.
PR #342399
Store and delete the selectionScrollView in webkit which is what we already do for
scrolling subframes.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
(BlackBerry::WebKit::InRegionScrollerPrivate::resetSelectionScrollView):
(WebKit):
(BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
(BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
* Api/InRegionScroller_p.h:
(InRegionScrollerPrivate):
2013-06-05 Tiancheng Jiang <tijiang@rim.com>
[BlackBerry] Make image clickable when it has anchor as parent node.
https://bugs.webkit.org/show_bug.cgi?id=117271
Reviewed by Rob Buis.
BlackBerry PR 345995
Internally Reviewed by Genevieve Mak.
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
2013-06-05 Mike Fenton <mifenton@rim.com>
[BlackBerry] Selection handles are inverted on directional selections
https://bugs.webkit.org/show_bug.cgi?id=117269
Reviewed by Rob Buis.
PR 336178
Don't invert the handles leave them in the visual order.
Internally Reviewed by Nima Ghanavatian.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
2013-06-03 Andrew Lo <anlo@rim.com>
[BlackBerry] Expose show debug borders setting through BlackBerry::WebKit::WebPage
https://bugs.webkit.org/show_bug.cgi?id=117167
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
Add WebKit::WebPage API for setting whether to show accelerated compositing
debug borders.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setShowDebugBorders):
(WebKit):
* Api/WebPage.h:
2013-06-03 Mike Fenton <mifenton@rim.com>
[BlackBerry] Selection handles are not cleared when displaying error pages.
https://bugs.webkit.org/show_bug.cgi?id=117158
Reviewed by Carlos Garcia Campos.
PR 342159.
Add explicit cancel of selection state when loading an error page
as it is not always cleared.
Internally Reviewed by Nima Ghanavatian.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
2013-06-03 Mike Fenton <mifenton@rim.com>
[BlackBerry] ROI details are not always cleared when using back navigation.
https://bugs.webkit.org/show_bug.cgi?id=117159
Reviewed by Carlos Garcia Campos.
PR 328557.
Secondary change to ensure when restoreViewState is triggered
ROI is reset.
Internally Reviewed by Nima Ghanavatian.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::restoreViewState):
2013-05-29 Otto Derek Cheung <otcheung@rim.com>
[BlackBerry] Add more cellular technologies into the NetworkInfo enum
https://bugs.webkit.org/show_bug.cgi?id=116982
PR 340189
Reviewed by Rob Buis.
Provide more specific bandwidth speeds on different network
services our devices provide.
* WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
(WebCore):
(WebCore::NetworkInfoClientBlackBerry::bandwidth):
2013-05-29 Yong Li <yoli@rim.com>
[BlackBerry] about:memory should use malloc_stats instead of mallinfo
https://bugs.webkit.org/show_bug.cgi?id=96420
Reviewed by Rob Buis.
PR 206297
Use mallopt to get malloc_stats.
* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::mallocStats):
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
2013-05-29 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Notify client of selection deletion
https://bugs.webkit.org/show_bug.cgi?id=116843
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR342106
Our change guard was preventing caret change notification to be sent to IMF.
This put us out of state when a selection was deleted because it is not a simple
single character deletion. Ensure that selection deletions always send a caret
update.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::deleteSelection):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::deleteText):
2013-05-29 Rob Buis <rbuis@rim.com>
[BlackBerry] Use StringBuilder instead of + operator to build strings in AboutData
https://bugs.webkit.org/show_bug.cgi?id=116954
Reviewed by Carlos Garcia Campos.
PR 206152
Internally reviewed by Konrad Piascik
* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):
(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
(BlackBerry::WebKit::mallocStats):
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::memoryPeaksToHtmlTable):
(BlackBerry::WebKit::memoryLivePage):
2013-05-29 Jakob Petsovits <jpetsovits@blackberry.com>
[BlackBerry] Use lazily-backed backingstore tiles
https://bugs.webkit.org/show_bug.cgi?id=116879
Internal PR 344523
Reviewed by Carlos Garcia Campos.
Informally reviewed by Arvid Nilsson and Mike Lattanzio.
As a consequence, also don't use fixed-size
shared pixmap buffers for these tiles anymore.
* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):
* WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
* WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::initialize):
* WebKitSupport/SurfacePool.h:
(SurfacePool):
2013-05-29 Kent Tamura <tkent@chromium.org>
Remove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
https://bugs.webkit.org/show_bug.cgi?id=116796
Reviewed by Ryosuke Niwa.
* WebCoreSupport/AboutDataEnableFeatures.in:
2013-05-28 Arvid Nilsson <anilsson@rim.com>
[BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
https://bugs.webkit.org/show_bug.cgi?id=116604
Reviewed by Carlos Garcia Campos.
Adapt to the removal of "get" prefix from getters in the WebKit- and
compositing-thread layer classes.
* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
(BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
2013-05-28 Andreas Kling <akling@apple.com>
Document::setFocusedNode() should be setFocusedElement().
<http://webkit.org/b/116857>
Reviewed by Antti Koivisto.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
(BlackBerry::WebKit::WebPage::setNodeFocus):
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
2013-05-28 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix BlackBerry debug build after r150756.
* WebKitSupport/PagePopup.cpp:
(BlackBerry::WebKit::PagePopup::writeDocument): Fix typo in
assert.
2013-05-27 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Clear supression flag when caret changes aren't propogated through
https://bugs.webkit.org/show_bug.cgi?id=116840
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR339965
We set and clear the flag upon every use. This leaves us vulnerable if
1. midway through processing the selection change event is dismissed and
2. we don't receive a TouchRelease event
One example of this is while dragging the FCC handle we start typing. To
safeguard against this, if the process change guard is set during a
selection change event, we send out to clear the flag status before returning.
* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::selectionChanged):
2013-05-27 Andy Chen <andchen@blackberry.com>
[BlackBerry] Find-on-page should be able to convert the active match to selection when clearing all matches
https://bugs.webkit.org/show_bug.cgi?id=116837
Reviewed by Rob Buis.
PR 291903
Internally reviewed by Mike Fenton.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::findNextString):
* Api/WebPage.h:
* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
* WebKitSupport/InPageSearchManager.h:
(InPageSearchManager):
2013-05-27 Eli Fidler <efidler@rim.com>
[BlackBerry] Fix subframe target added to new requests
https://bugs.webkit.org/show_bug.cgi?id=116602
Reviewed by Rob Buis.
In some cases we might be adding TargetIsMainFrame to a subframe
request causing an isMainFrame assert.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
Check we are actually loading the main frame before setting
ResourceRequest::TargetIsMainFrame target.
2013-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms
https://bugs.webkit.org/show_bug.cgi?id=116724
Reviewed by Rob Buis.
Add another bool variable m_previousFrameDone to make sure we
don't start a new frame until the previous one has been done. Also
make sure we pass the animation start time to
serviceScriptedAnimations().
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
m_previousFrameDone and m_monotonicAnimationStartTime.
(BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
Return early if previous frame is not done. Otherwise set
m_previousFrameDone to false and save the animation start time.
(BlackBerry::WebKit::WebPagePrivate::serviceAnimations): Call
serviceScriptedAnimations() passing the saved animation start time
and reset m_animationScheduled and m_previousFrameDone.
(BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
Call WebPagePrivate::serviceAnimations().
* Api/WebPage_p.h:
(WebPagePrivate):
2013-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] Remove encoding parameter from FrameLoaderClientBlackBerry::receivedData()
https://bugs.webkit.org/show_bug.cgi?id=116598
Reviewed by Rob Buis.
It's no longer needed since the encoder now checks the override encoding.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::committedLoad): Call
receivedData() passing the DocumentLoader instead of the text
encoding.
(WebCore::FrameLoaderClientBlackBerry::receivedData): Call
DocumentLoader::commitData() directly.
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
2013-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] Move PagePopup implementation to WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=116824
Reviewed by Rob Buis.
After r150434 PagePopup implementation in BlackBerry port is
independent from WebCore. The classes are now in the
BlackBerry::WebKit namespace so they can be moved from
WebCoresupport to WebKitSupport and renamed to remove the
BlackBerry suffix which is now redundant. Also, now that the
implementation is not shared, it can be simplified a bit more.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Update to
API changes.
(BlackBerry::WebKit::WebPage::initPopupWebView): Ditto.
(BlackBerry::WebKit::WebPagePrivate::openPagePopup): Ditto.
(BlackBerry::WebKit::WebPagePrivate::closePagePopup): Ditto.
(BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Ditto.
* Api/WebPage.h:
(WebKit): Ditto.
* Api/WebPage_p.h:
(WebKit): Ditto.
(WebPagePrivate): Rename m_selectPopup as m_pagePopup, since it
can also point to a color picker or date picker page popup. Also
use RefPtr instead of raw pointer.
* WebKitSupport/ColorPickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp.
(BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
(BlackBerry::WebKit::ColorPickerClient::generateHTML):
(BlackBerry::WebKit::ColorPickerClient::setValueAndClosePopup):
Return early if popup has been closed already.
(BlackBerry::WebKit::ColorPickerClient::didClosePopup):
* WebKitSupport/ColorPickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h.
* WebKitSupport/DatePickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp.
(BlackBerry::WebKit::DatePickerClient::DatePickerClient):
(BlackBerry::WebKit::DatePickerClient::~DatePickerClient):
(BlackBerry::WebKit::DatePickerClient::generateHTML):
(BlackBerry::WebKit::DatePickerClient::setValueAndClosePopup):
Return early if popup has been closed already.
(BlackBerry::WebKit::DatePickerClient::didClosePopup):
(BlackBerry::WebKit::DatePickerClient::generateDateLabels):
* WebKitSupport/DatePickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h.
* WebKitSupport/PagePopup.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp.
(BlackBerry::WebKit::PagePopup::PagePopup):
(BlackBerry::WebKit::PagePopup::~PagePopup):
(BlackBerry::WebKit::PagePopup::initialize): Renamed as initialize
and made void, since it always returned true and the callers
ignored the return value.
(BlackBerry::WebKit::PagePopup::writeDocument): Renamed from
generateHTML for consistency with PagePopupClient::writeDocument()
and to avoid confusion with generateHTML method in the clients
that create the HTML contents but they don't write the document.
(BlackBerry::WebKit::PagePopup::setValueAndClosePopupCallback):
Make it static member of PagePopup since the JS object now holds a
reference of PagePopup instance as private data.
(BlackBerry::WebKit::popUpExtensionInitialize): Take a reference
of the PagePopup instance saved as private data of the JS object.
(BlackBerry::WebKit::popUpExtensionFinalize): Unref the PagePopup
instance saved as private data of the JS object.
(BlackBerry::WebKit::PagePopup::installDOMFunction): Instead of
saving the client as private data of the JS object using a wrapper
refcounted object, save the PagePopup instance that is now
refcounted and access the client from the PagePopup instance in
the callback.
(BlackBerry::WebKit::PagePopup::close): Renamed from closePagePopup
since PagePopup::closePagePopup was a bit redundant.
* WebKitSupport/PagePopup.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.h.
(BlackBerry::WebKit::PagePopup::create): Static member to create
instances of PagePopup now that it's refcounted.
* WebKitSupport/PagePopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.cpp.
(BlackBerry::WebKit::PagePopupClient::PagePopupClient):
(BlackBerry::WebKit::PagePopupClient::closePopup):
(BlackBerry::WebKit::PagePopupClient::didClosePopup):
(BlackBerry::WebKit::PagePopupClient::contentSize):
(BlackBerry::WebKit::PagePopupClient::writeDocument):
* WebKitSupport/PagePopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h.
* WebKitSupport/SelectPopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp.
(BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
(BlackBerry::WebKit::SelectPopupClient::~SelectPopupClient):
(BlackBerry::WebKit::SelectPopupClient::generateHTML):
(BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
Return early if popup has been closed already.
(BlackBerry::WebKit::SelectPopupClient::didClosePopup):
(BlackBerry::WebKit::SelectPopupClient::notifySelectionChange):
* WebKitSupport/SelectPopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h.
2013-05-26 Jakob Petsovits <jpetsovits@blackberry.com>
[BlackBerry] Make screen updates dependent on the existence of a drawing buffer.
https://bugs.webkit.org/show_bug.cgi?id=116539
Internal PR 330917
Reviewed by Carlos Garcia Campos.
Internally reviewed by Xiaobo Wang and Arvid Nilsson.
This reduces complexity by relying on the current state,
rather than the suspend counter, which in turn makes it
possible to simplify the code in setCompositor().
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
2013-05-26 Kent Tamura <tkent@chromium.org>
Remove ENABLE_CALENDAR_PICKER
https://bugs.webkit.org/show_bug.cgi?id=116795
Reviewed by Ryosuke Niwa.
* WebCoreSupport/AboutDataEnableFeatures.in:
The list was wrong. Blackberry port doesn't use CALENDAR_PICKER code.
2013-05-26 Andreas Kling <akling@apple.com>
FocusController::setFocusedNode() should be setFocusedElement().
<http://webkit.org/b/116780>
Reviewed by Antti Koivisto.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
(BlackBerry::WebKit::WebPage::setNodeFocus):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectObject):
2013-05-24 Anders Carlsson <andersca@apple.com>
Remove PagePopup code
https://bugs.webkit.org/show_bug.cgi?id=116732
Reviewed by Andreas Kling.
* WebCoreSupport/AboutDataEnableFeatures.in:
Remove PAGE_POPUP.
2013-05-24 Mike Fenton <mifenton@rim.com>
[BlackBerry] Fix bad type warning in InputHandler log.
https://bugs.webkit.org/show_bug.cgi?id=116720
Reviewed by Carlos Garcia Campos.
Fix warning in inputLog string.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
2013-05-24 Mike Fenton <mifenton@rim.com>
[BlackBerry] Respect tabindex when using form controls.
https://bugs.webkit.org/show_bug.cgi?id=116676
Reviewed by Xan Lopez.
PR 337419.
Update form control navigation tracking to take tabindex
order into account when calculating next and previous nodes.
The order to follow is tab index 1 - N, followed by all items
without a tab index or tab index 0 in rendering order to match
with standard desktop behavior.
Internally Reviewed by Genevieve Mak and Nima Ghanavatian.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
2013-05-24 Jeff Rogers <jrogers@rim.com>
[BlackBerry] Remove SKIA leftovers from WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=116656
Reviewed by Rob Buis.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
2013-05-23 Xiaobo Wang <xiaobwang@blackberry.com>
[BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
https://bugs.webkit.org/show_bug.cgi?id=115245
Reviewed by Rob Buis.
PR 330917.
Internally reviewed by Arvid Nilsson.
1. Suspend/resumeRootLayerCommit when notified app activation state
change.
2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
start root layer commit timer, so that there's a commit even if
BackingStore got disabled/removed.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
2013-05-23 Andy Chen <andchen@blackberry.com>
[BlackBerry] Need to forward the opener frame url to client when creating a new window
https://bugs.webkit.org/show_bug.cgi?id=116566
Reviewed by Rob Buis.
PR 337935
Internally reviewed by Arvid Nilsson.
When creating a new window, forward the opener frame url to client.
* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
2013-05-23 Jakob Petsovits <jpetsovits@blackberry.com>
[BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter.
https://bugs.webkit.org/show_bug.cgi?id=116545
Internal PR 189775
Reviewed by Rob Buis.
Also change the name of the "documentContents" parameter
to the more descriptive "documentSrcRect".
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositor::render):
* Api/WebPageCompositor.h:
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
2013-05-23 Ed Baker <edbaker@blackberry.com>
[BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
https://bugs.webkit.org/show_bug.cgi?id=116627
Reviewed by Xan Lopez.
PR #341084
If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.
Internally Reviewed by Gen Mak.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
2013-05-23 Mike Fenton <mifenton@rim.com>
[BlackBerry] Validate form data before doing direct submission.
https://bugs.webkit.org/show_bug.cgi?id=116674
Reviewed by Xan Lopez.
PR 314202.
Check validation of the input form before triggering direct submission.
Internally Reviewed by Nima Ghanavatian.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::submitForm):
2013-05-23 Rob Buis <rbuis@rim.com>
[BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
https://bugs.webkit.org/show_bug.cgi?id=116603
Reviewed by Xan Lopez.
PR 119789
Internally reviewed by Yong Li.
Provide a domain value for this ResourceError instance. Note that
this does not change behavior.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
2013-05-21 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] Make PagePopup implementation independent from WebCore
https://bugs.webkit.org/show_bug.cgi?id=116448
Reviewed by Anders Carlsson.
Add our own implementation of PagePopupClient and make all the
pickers inherit from it. Unused methods have been removed and
common implementation have been moved from the pickers to the
parent class.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate): Destroy the
popup if there's one active.
(BlackBerry::WebKit::WebPagePrivate::setVisible): Call
closePagePopup() directly.
(BlackBerry::WebKit::WebPagePrivate::openPagePopup): Create a new
PagePopupBlackBerry for the given client.
(BlackBerry::WebKit::WebPagePrivate::closePagePopup): Close the
active popup if there's one.
(BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Return
whether there's an active popup.
* Api/WebPage.h:
* Api/WebPage_p.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::chromeDestroyed): Remove
closePagePopup() call since this is now handled by
WebPagePrivate.
(WebCore::ChromeClientBlackBerry::hasOpenedPopup): Call
WebPagePrivate::hasOpenedPopup().
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
* WebCoreSupport/ColorPickerClient.cpp:
(BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
(BlackBerry::WebKit::ColorPickerClient::didClosePopup):
* WebCoreSupport/ColorPickerClient.h:
(ColorPickerClient):
* WebCoreSupport/DatePickerClient.cpp:
(BlackBerry::WebKit::DatePickerClient::DatePickerClient):
(BlackBerry::WebKit::DatePickerClient::didClosePopup):
* WebCoreSupport/DatePickerClient.h:
(DatePickerClient):
* WebCoreSupport/PagePopupBlackBerry.cpp:
(BlackBerry::WebKit::PagePopupBlackBerry::PagePopupBlackBerry):
(BlackBerry::WebKit::PagePopupBlackBerry::closePopup):
* WebCoreSupport/PagePopupBlackBerry.h:
(PagePopupBlackBerry):
(BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
(BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::get):
(SharedClientPointer):
* WebCoreSupport/PagePopupBlackBerryClient.cpp: Added.
(BlackBerry::WebKit::PagePopupBlackBerryClient::PagePopupBlackBerryClient):
(BlackBerry::WebKit::PagePopupBlackBerryClient::closePopup):
(BlackBerry::WebKit::PagePopupBlackBerryClient::didClosePopup):
(BlackBerry::WebKit::PagePopupBlackBerryClient::contentSize):
(BlackBerry::WebKit::PagePopupBlackBerryClient::writeDocument):
* WebCoreSupport/PagePopupBlackBerryClient.h: Added.
(PagePopupBlackBerryClient):
(BlackBerry::WebKit::PagePopupBlackBerryClient::~PagePopupBlackBerryClient):
* WebCoreSupport/SelectPopupClient.cpp:
(BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
(BlackBerry::WebKit::SelectPopupClient::didClosePopup):
* WebCoreSupport/SelectPopupClient.h:
(SelectPopupClient):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup): Do not call
closePagePopup() since this is already done by openPagePopup() and
use openPagePopup() from WebPagePrivate directly.
(BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.
(BlackBerry::WebKit::InputHandler::openSelectPopup): Ditto.
2013-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] Do not use skia in FrameLoaderClientBlackBerry::dispatchDidReceiveIcon()
https://bugs.webkit.org/show_bug.cgi?id=116302
Reviewed by Rob Buis.
TiledImage is now the NativeImage of the BlackBerry port.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
2013-05-19 Anders Carlsson <andersca@apple.com>
Remove link prerendering code
https://bugs.webkit.org/show_bug.cgi?id=116415
Reviewed by Darin Adler.
This code was only used by Chromium and is dead now.
* WebCoreSupport/AboutDataEnableFeatures.in:
2013-05-19 Anders Carlsson <andersca@apple.com>
Remove ChromeClient::webView()
https://bugs.webkit.org/show_bug.cgi?id=116054
Reviewed by Andreas Kling.
This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
2013-05-17 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] REGRESSION(r150060): Crash in LayerWebKitThread::updateTextureContents
https://bugs.webkit.org/show_bug.cgi?id=116305
Reviewed by Rob Buis.
PR 340537.
Internally reviewed by Arvid Nilsson.
Use updateLayoutAndStyleIfNeededRecursive() instead of
layoutIfNeeded() since we are about to draw in
rootLayerCommitTimerFired().
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
2013-05-17 Mike Fenton <mifenton@rim.com>
[BlackBerry] Remove stale comment for select mouse handling.
https://bugs.webkit.org/show_bug.cgi?id=116309
Reviewed by Rob Buis.
PR 135935.
Remove a FIXME that has been invalidated by a change
to our touch -> mouse model.
Internally Rubberstamped by Genevieve Mak.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
2013-05-17 Alberto Garcia <agarcia@igalia.com>
[BlackBerry] DumpRenderTreeSupport: fix build in setMockDeviceOrientation()
https://bugs.webkit.org/show_bug.cgi?id=116298
Reviewed by Carlos Garcia Campos.
Pass the correct parameter to toDeviceOrientationClientMock()
* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setMockDeviceOrientation):
2013-05-16 Mike Fenton <mifenton@rim.com>
[BlackBerry] Optimize caret bounds calculation when leaving an input field.
https://bugs.webkit.org/show_bug.cgi?id=116224
Reviewed by Rob Buis.
PR 340132.
If the caret is no longer active in the field, do not allow it
to go into the single line input logic and calculate the node
bounding box.
Internally Reviewed By Gen Mak
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
2013-05-16 Mary Wu <mary.wu@torchmobile.com.cn>
[BlackBerry] Unable to download blob resource
https://bugs.webkit.org/show_bug.cgi?id=115888
Reviewed by Benjamin Poulain.
For blob resource (blob:http....), it's not suitable to go to NetworkStream
which don't handle "blob" protocol at all. since blob data already handled
in BlobResourceHandle, simply get the data out to download stream.
RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
2013-05-16 Andreas Kling <akling@apple.com>
Page::chrome() should return a reference.
<http://webkit.org/b/116185>
Reviewed by Anders Carlsson.
2013-05-13 Anders Carlsson <andersca@apple.com>
Frame::editor() should return a reference
https://bugs.webkit.org/show_bug.cgi?id=116037
Reviewed by Darin Adler.
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectedText):
2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
Remove WTF_USE_PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=114431
Reviewed by Darin Adler.
* WebCoreSupport/AboutDataUseFeatures.in:
2013-05-14 Tiancheng Jiang <tijiang@rim.com>
[BlackBerry] Improve Fatfinger phase.
https://bugs.webkit.org/show_bug.cgi?id=107403
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak.
BlackBerry PR 324965.
Cache and reuse intersected nodes as long as hit position has not been
changed.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
* WebKitSupport/FatFingers.h:
2013-05-14 Andrew Lo <anlo@rim.com>
[BlackBerry] Hook up frame render begin/end in PerformanceMonitor
https://bugs.webkit.org/show_bug.cgi?id=116110
Reviewed by Rob Buis.
Internally reviewed by Jeff Rogers, Jonathan Jiang.
Internal PR 299155.
Mark frame render begin & end for BlackBerry performance monitoring
in blitVisibleContents.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] Use requestAnimationFrame for animations
https://bugs.webkit.org/show_bug.cgi?id=115896
Reviewed by Rob Buis.
Make WebPagePrivate a
BlackBerry::Platform::AnimationFrameRateClient and use it to
schedule animations.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
(BlackBerry::WebKit::WebPagePrivate::scheduleAnimation):
(BlackBerry::WebKit::WebPagePrivate::startRefreshAnimationClient):
(BlackBerry::WebKit::WebPagePrivate::stopRefreshAnimationClient):
(BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::scheduleAnimation):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] Implement platform strategies
https://bugs.webkit.org/show_bug.cgi?id=112162
Reviewed by Rob Buis.
* Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize): Initialize platform
strategies.
* WebCoreSupport/PlatformStrategiesBlackBerry.cpp: Added.
(PlatformStrategiesBlackBerry::initialize):
(PlatformStrategiesBlackBerry::PlatformStrategiesBlackBerry):
(PlatformStrategiesBlackBerry::createCookiesStrategy):
(PlatformStrategiesBlackBerry::createDatabaseStrategy):
(PlatformStrategiesBlackBerry::createLoaderStrategy):
(PlatformStrategiesBlackBerry::createPasteboardStrategy):
(PlatformStrategiesBlackBerry::createPluginStrategy):
(PlatformStrategiesBlackBerry::createSharedWorkerStrategy):
(PlatformStrategiesBlackBerry::createStorageStrategy):
(PlatformStrategiesBlackBerry::createVisitedLinkStrategy):
(PlatformStrategiesBlackBerry::cookiesForDOM):
(PlatformStrategiesBlackBerry::setCookiesFromDOM):
(PlatformStrategiesBlackBerry::cookiesEnabled):
(PlatformStrategiesBlackBerry::cookieRequestHeaderFieldValue):
(PlatformStrategiesBlackBerry::getRawCookies):
(PlatformStrategiesBlackBerry::deleteCookie):
(PlatformStrategiesBlackBerry::refreshPlugins):
(PlatformStrategiesBlackBerry::getPluginInfo):
(PlatformStrategiesBlackBerry::isLinkVisited):
(PlatformStrategiesBlackBerry::addVisitedLink):
* WebCoreSupport/PlatformStrategiesBlackBerry.h: Added.
(PlatformStrategiesBlackBerry):
2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
[BlackBerry] Crash due to an assert in FrameView::doDeferredRepaints
https://bugs.webkit.org/show_bug.cgi?id=115412
Reviewed by Rob Buis.
PR 115412
The problem is that we are calling
updateLayoutAndStyleIfNeededRecursive() (because of
zoomToInitialScaleOnLoad) from ChomeClient::layoutUpdated()
callback which is not expected. It's expected to be called right
before painting, and not right after painting. Even if a new
layout is not done, updateLayoutAndStyleIfNeededRecursive() calls
flushDeferredRepaints() and it's possible that this is called in
the middle of a beginDeferredRepaints() and endDeferredRepaints()
apparently.
In general only BackingStore should call
updateLayoutAndStyleIfNeededRecursive before painting, and a simple
layout is enough in all other cases like resizing. This patch renames
requestLayoutIfNeeded as updateLayoutAndStyleIfNeededRecursive to
make more obvious what it does, and adds layoutIfNeeded that calls
layout. The former is used by the BackingStore and the latter by
WebPage.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::requestLayoutIfNeeded):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::updateLayoutAndStyleIfNeededRecursive):
(BlackBerry::WebKit::WebPagePrivate::layoutIfNeeded):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
* Api/WebPage_p.h:
(WebPagePrivate):
2013-05-10 Laszlo Gombos <l.gombos@samsung.com>
Remove USE(OS_RANDOMNESS)
https://bugs.webkit.org/show_bug.cgi?id=108095
Reviewed by Darin Adler.
Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
ports.
* WebCoreSupport/AboutDataUseFeatures.in:
2013-05-10 Jacky Jiang <zhajiang@blackberry.com>
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Rob Buis.
Fix the following warnings for BlackBerry:
BackingStore.cpp:852:60: warning: suggest parentheses around '&&' within
'||' [-Wparentheses].
WebPage.cpp:2858:40: warning: suggest parentheses around assignment used
as truth value [-Wparentheses].
WebPage.cpp:2880:42: warning: suggest parentheses around assignment used
as truth value [-Wparentheses]
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
to match check-webkit-style updates.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
* Api/InRegionScroller_p.h:
* Api/WebKitTextCodec.cpp:
(BlackBerry::WebKit::transcode):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::render):
* Api/WebPageCompositor.h:
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
* Api/WebSettings_p.h:
2013-05-09 Max Feil <mfeil@rim.com>
shouldUsePluginDocument() needs to be respected when a document is created
https://bugs.webkit.org/show_bug.cgi?id=110308
Reviewed by Rob Buis.
This patch implements shouldAlwaysUsePluginDocument() in the
BlackBerry frame loader client. It is called in several places
within WebCore to determine whether a PluginDocument should
be created.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
(WebCore):
(WebCore::FrameLoaderClientBlackBerry::createPlugin):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update SelectionHandler to match check-webkit-style updates.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::regionRectListContainsPoint):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update WebPage and WebPageClient to match check-webkit-style updates.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::addVisitedLink):
(BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
(BlackBerry::WebKit::WebPage::notifySwipeEvent):
(BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update BackingStore to match check-webkit-style updates.
Internally reviewed by Jakob Petsovits.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::bestDivisor):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
(BlackBerry::WebKit::BackingStore::repaint):
* Api/BackingStore_p.h:
(BackingStoreGeometry):
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
match check-webkit-style updates.
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
* WebCoreSupport/CredentialManager.h:
(CredentialManager):
* WebCoreSupport/CredentialTransformData.cpp:
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):
* WebCoreSupport/GeolocationClientBlackBerry.cpp:
(GeolocationClientBlackBerry::onLocationUpdate):
* WebCoreSupport/GeolocationClientBlackBerry.h:
(GeolocationClientBlackBerry):
* WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
2013-05-09 Jacky Jiang <zhajiang@blackberry.com>
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Rob Buis.
Fix the following warnings for BlackBerry:
InRegionScroller.cpp:286:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:349:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'
within '||' [-Wparentheses].
InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
avoid ambiguous 'else' [-Wparentheses].
SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'
within '||' [-Wparentheses].
SelectionOverlay.cpp:56:47: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare].
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
* WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::draw):
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update ColorPickerClient and PagePopupBlackBerry
to match check-webkit-style updates.
* WebCoreSupport/ColorPickerClient.cpp:
(WebCore::ColorPickerClient::generateHTML):
* WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::setValueAndClosePopupCallback):
(WebCore::PagePopupBlackBerry::installDOMFunction):
2013-05-09 Alberto Garcia <agarcia@igalia.com>
[BlackBerry] Upstream the input popups
https://bugs.webkit.org/show_bug.cgi?id=114608
Reviewed by Rob Buis.
This patch contains contributions from many members of the
BlackBerry WebKit team, including:
Chris Hutten-Czapski
David Hoon
Jessica Cao
Rob Buis
Tiancheng Jiang
* WebCoreSupport/ColorPickerClient.cpp:
(WebCore):
(WebCore::ColorPickerClient::generateHTML):
* WebCoreSupport/DatePickerClient.cpp:
(WebCore):
(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::generateDateLabels):
* WebCoreSupport/DatePickerClient.h:
(DatePickerClient):
* WebCoreSupport/SelectPopupClient.cpp:
(WebCore):
(WebCore::SelectPopupClient::generateHTML):
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update DOMSupport to match check-webkit-style updates.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::convertPointToFrame):
2013-05-09 Xuefei Ren <xren@blackberry.com>
[BLACKBERRY]fix regression in Webpage
and FrameLoaderClientBlackberry
https://bugs.webkit.org/show_bug.cgi?id=115843
Reviewed by Rob Buis.
Internally reviewed by Mary Wu.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::loadFile):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::startDownload):
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update FatFingers to match check-webkit-style updates.
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::checkForClickableElement):
* WebKitSupport/FatFingers.h:
(FatFingersResult):
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update InRegionScrollableArea, TileIndexHash
and TouchEventHandler to match check-webkit-style updates.
* WebKitSupport/InRegionScrollableArea.cpp:
* WebKitSupport/TileIndexHash.h:
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
2013-05-09 Mike Fenton <mifenton@rim.com>
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Styles fixes required for InputHandler based on updated
check-webkit-style.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
(BlackBerry::WebKit::InputHandler::firstSpanInString):
(BlackBerry::WebKit::InputHandler::setTextAttributes):
* WebKitSupport/InputHandler.h:
2013-05-08 Eli Fidler <efidler@blackberry.com>
[BlackBerry] Fix usage of BlackBerry::Platform::String
https://bugs.webkit.org/show_bug.cgi?id=115781
Reviewed by Rob Buis.
BlackBerry PRs 304193 and 327181
Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
We currently have a problem where we're passing UTF-8 encoded data into
the char* constructors of BlackBerry::Platform::String. This means the string
thinks its data is not UTF-8.
* Api/JavaScriptVariant.cpp:
(BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
* Api/WebKitTextCodec.cpp:
(BlackBerry::WebKit::base64Encode):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::textHasAttribute):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
* Api/WebPage.h:
* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
* WebKitSupport/DefaultTapHighlight.cpp:
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):
2013-05-08 Rob Buis <rbuis@rim.com>
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Philip Rogers.
Get rid of the following warning for BlackBerry:
BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]
by using ASSERT_UNUSED instead of ASSERT.
* WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::create):
2013-05-07 Xuefei Ren <xren@blackberry.com>
Clean up load interface in WebPage
https://bugs.webkit.org/show_bug.cgi?id=115622
Reviewed by Rob Buis.
Internal PR:315535
Internal reviewed by Mary Wu
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::load):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::startDownload):
2013-05-07 Mike Fenton <mifenton@rim.com>
[BlackBerry] Increase the padding size for caret based scrolling.
https://bugs.webkit.org/show_bug.cgi?id=115749
Reviewed by Rob Buis.
PR 322670.
Increasing the padding size for scrolling in order to optimize the
number of scrolls required during typing.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
2013-05-07 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Maintain touch event state throughout processing
https://bugs.webkit.org/show_bug.cgi?id=115663
Reviewed by Rob Buis.
Internally reviewed by Otto Cheung and Genevieve Mak.
PR 297691
By maintaining our touch event state, we can get a better idea
of what triggered an update to selection and respond appropriately.
On touch press we set userTouchTriggered to give the UI thread
some context.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
2013-05-07 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Read-only fields should not get keyboard focus
https://bugs.webkit.org/show_bug.cgi?id=115725
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR332887
Prevent keyboard focus and FCC from displaying when the user taps on a
read-only field. Further, ensure form controls skip over these fields
with the next/previous buttons.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
(DOMSupport):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::setInputModeEnabled):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::isActiveTextEdit):
(WebKit):
* WebKitSupport/InputHandler.h:
2013-05-07 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Expand spellcheck logging
https://bugs.webkit.org/show_bug.cgi?id=115482
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Fix some build errors when SpellingLog was turned on and expand on the debug
statements to be more verbose. Set up timers and print the duration of each
iteration as we traverse the text to create a range to send out for checking.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
* WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
2013-05-06 Mike Lattanzio <mlattanzio@blackberry.com>
[BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
https://bugs.webkit.org/show_bug.cgi?id=113808
Reviewed by Rob Buis.
Create a WebSetting for text autosizing. The default is off.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isTextAutosizingEnabled):
(BlackBerry::WebKit::WebSettings::setTextAutosizingEnabled):
* Api/WebSettings.h:
2013-05-06 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Ensure document is attached before accessing its FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=115565
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR 312101
We need to make sure that the node and document
are attached before accessing the FrameSelection. This was
handled earlier but not all call paths were covered.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::isActiveTextEdit):
(WebKit):
* WebKitSupport/InputHandler.h:
2013-05-06 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Do not spellcheck when composition is active.
https://bugs.webkit.org/show_bug.cgi?id=115562
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR331344
Typing can trigger rechecking since layout changes. Ensure
extra work is only done when we need it, and that it won't
be triggered when composition is active. If the user hasn't
finished a word yet, it is likely future key events will be
arriving, so checking the string at this point is extraneous.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
2013-05-06 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Reduce the spellcheck checking range
https://bugs.webkit.org/show_bug.cgi?id=115479
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR332773
Previously we were spellchecking the entire field on focus. If relayouting
occurred we rechecked this region, which is very costly. Switch to check
only a small region around the caret in both cases, which should alleviate
much of the delays experienced in very large contenteditable fields. This
allows for faster key input response and less time processing these requests
on the WebKit thread.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
* WebKitSupport/SpellingHandler.cpp:
(WebKit):
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
* WebKitSupport/SpellingHandler.h:
(SpellingHandler):
2013-05-06 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Use a more descriptive timer name
https://bugs.webkit.org/show_bug.cgi?id=115481
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Changing m_timer to m_iterationDelayTimer.
* WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::SpellingHandler):
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
* WebKitSupport/SpellingHandler.h:
(SpellingHandler):
2013-05-04 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Clean up unused spellcheck code
https://bugs.webkit.org/show_bug.cgi?id=115560
Reviewed by Benjamin Poulain.
Internally reviewed by Mike Lattanzio
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
* Api/WebPage.h:
* WebKitSupport/InputHandler.cpp:
* WebKitSupport/InputHandler.h:
(InputHandler):
2013-05-03 Jacky Jiang <zhajiang@blackberry.com>
[BlackBerry] Page rendering scale is changed after go back and forward
https://bugs.webkit.org/show_bug.cgi?id=115573
Reviewed by Rob Buis.
Internally reviewed by Jeff Rogers.
PR: 326886
When navigating back from page A with viewport to page B without
viewport, we didn't call setViewMode(); therefore, we didn't change
the fixed layout size which was set by page A. In that case, WebCore
would just pick up page A's fixed layout size to layout page B which
caused this issue.
Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
later is not a good way, because zoomToInitialScaleOnLoad() has never
been called in this case. So we should always call setViewMode() to set
fixed layout size when a new page is committed.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
2013-05-02 Genevieve Mak <gmak@rim.com>
[BlackBerry] Cannot touch scroll readonly text input.
https://bugs.webkit.org/show_bug.cgi?id=115378
Reviewed by Rob Buis.
PR #332902
Reviewed Internally by Mike Fenton.
Forgot half the patch.
Node::rendererIsEditable() returns false if the input element has the readonly tag set.
Check the node type instead.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
2013-05-02 Iris Wu <shuwu@blackberry.com>
[BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
https://bugs.webkit.org/show_bug.cgi?id=115178
Reviewed by Rob Buis.
PR 308796
Debug build fix.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
2013-05-01 Iris Wu <shuwu@blackberry.com>
[BlackBerry] Upstream smart selection
https://bugs.webkit.org/show_bug.cgi?id=111226
Reviewed by Rob Buis.
Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
caused crash.
But viewport from webkitThreadViewportAccessor uses unadjusted size which is
wrong for email.
The solution here is to get actual viewport size on UI thread and then pass it
to WebKit::SelectionHandler.
PR 333763
Reviewed Internally By Jakob Petsovits.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
(WebKit):
* Api/WebPage.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
* WebKitSupport/SelectionHandler.h:
(BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
(BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
(SelectionHandler):
2013-04-30 Genevieve Mak <gmak@rim.com>
[BlackBerry] Cannot touch scroll readonly text input.
https://bugs.webkit.org/show_bug.cgi?id=115378
Reviewed by Rob Buis.
PR #332902
Reviewed Internally by Mike Fenton.
Node::rendererIsEditable() returns false if the input element has the readonly tag set.
Check the node type instead.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isShadowHostTextInputElement):
(DOMSupport):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
2013-04-29 Jakob Petsovits <jpetsovits@blackberry.com>
[BlackBerry] Replace disappearing fillBuffer() API with graphics context drawing
https://bugs.webkit.org/show_bug.cgi?id=115360
Internal PR 303048.
Reviewed by Rob Buis.
Instead of using fillBuffer() to draw directly to the
target buffer, we now lock a Drawable on it and fill it
with PlatformGraphicsContext::addPredefinedPattern().
As a bonus, this also includes related clean-ups -
simpler checkerboard painting code, removal of
fillWindow(), clearWindow() and paintDefaultBackground(),
as well as getting rid of the DEBUG_CHECKERBOARD define
which has been useless for performance tracing purposes
for a while now.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
* Api/BackingStore_p.h:
2013-04-26 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Check for valid element in elementTouched
https://bugs.webkit.org/show_bug.cgi?id=115205
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak.
PR 331546
We might receive a null ptr from nodeAsElementIfApplicable which
is passed in here. Check to make sure it's valid before using.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementTouched):
2013-04-26 Martin Robinson <mrobinson@igalia.com>
Remove the remaining Skia #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=114886
Reviewed by Benjamin Poulain.
* Api/WebPage.cpp: Remove Skia #ifdef references.
* WebCoreSupport/AboutDataUseFeatures.in: Ditto.
2013-04-26 Mary Wu <mary.wu@torchmobile.com.cn>
[BlackBerry] Should check if it's cached resource before download
https://bugs.webkit.org/show_bug.cgi?id=115101
Reviewed by Rob Buis.
Since main resource maybe cached, if user want to save the resource, we first check
if it's cached. If yes, don't need to initiate a fresh load again, but get the
cached resource data out to save.
RIM bug# 324003, internally reviewed by Charles Wei.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
2013-04-26 Mary Wu <mary.wu@torchmobile.com.cn>
[BlackBerry] Clean up load interface in WebPage
https://bugs.webkit.org/show_bug.cgi?id=113267
Reviewed by Rob Buis.
Remove unused loadExtended(), combine load() and download() api in WebPage.
RIM Bug# 315535, internally reviewed by Joe Mason.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::load):
* Api/WebPage.h:
2013-04-25 Andrew Lo <anlo@rim.com>
[BlackBerry] Selection overlay on non-composited iframes are incorrectly positioned.
https://bugs.webkit.org/show_bug.cgi?id=115197
Reviewed by Rob Buis.
When drawing the selection overlay, the rects to
paint when selecting text on non-composited sub-frames
need to be adjusted by the frame position.
* WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::paintContents):
2013-04-25 Andreas Kling <akling@apple.com>
Remove ENABLE(PARSED_STYLE_SHEET_CACHING) and make it always-on.
Rubber-stamped by Anders Koivisto.
* WebCoreSupport/AboutDataEnableFeatures.in:
2013-04-25 Iris Wu <shuwu@blackberry.com>
[BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
https://bugs.webkit.org/show_bug.cgi?id=115178
Reviewed by Rob Buis.
PR 308796
Currently the position WebPage::adjustDocumentScrollPosition adjusts is the top
left point of the viewport.
On the page with fixed position elements, we want it to adjust the position beneath
the fixed elements so it can be always visible.
The basic idea is:
1. Detect if there are fixed position elements before going through ProximityDetector.
2. If the fixed element exists, calculate its the size and the actual visible position
beneath it.
3. Pass the position to ProximityDetector. Then according to the new position we get,
calculate the top left position of the viewport (final scroll position).
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
(WebKit):
* Api/WebPage.h:
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
(WebKit):
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
2013-04-25 Mike Lattanzio <mlattanzio@blackberry.com>
[BlackBerry] Enable balanced page group load deferrer behaviour.
https://bugs.webkit.org/show_bug.cgi?id=115189
Reviewed by Rob Buis.
Prevent a possible deadlock by enabling balanced deferrers.
Internally reviewed by: Joe Mason
PR 329986
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
2013-04-25 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: ConsoleMessage should include line and column number where possible
https://bugs.webkit.org/show_bug.cgi?id=114929
Reviewed by Timothy Hatcher.
* Api/DumpRenderTreeClient.h:
* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::addMessageToConsole):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
2013-04-25 Konrad Piascik <kpiascik@blackberry.com>
[BlackBerry] Get rid of return in void method
https://bugs.webkit.org/show_bug.cgi?id=115186
Reviewed by Rob Buis.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setForcedTextEncoding):
2013-04-24 Nima Ghanavatian <nghanavatian@blackberry.com>
[BlackBerry] Do not clear focus on a node when tapping on form controls
https://bugs.webkit.org/show_bug.cgi?id=115055
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak.
PR316069
To allow for rich text editors to apply styles on an input field
or highlighted text, we must maintain focus on the current element
when tapping on form elements. Moving the code that clears this
context to trigger off TouchHold instead of TouchPress.
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::doFatFingers):
== Rolled over to ChangeLog-2013-04-24 ==
|