summaryrefslogtreecommitdiff
path: root/src/xmlpatterns/schema/qxsdschemahelper.cpp
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2019-08-20 11:15:22 +0200
committerUlf Hermann <ulf.hermann@qt.io>2019-12-04 11:17:46 +0100
commit089bdc0fcc1d87c6f5fe0835a4f723a6677e9a01 (patch)
treed4e3c15a9f44e4b7dcbd8efa1a1cc3f3aa3aae09 /src/xmlpatterns/schema/qxsdschemahelper.cpp
parent9e7745d7e283570ca8504909d20c39d3aca18cf7 (diff)
downloadqtxmlpatterns-089bdc0fcc1d87c6f5fe0835a4f723a6677e9a01.tar.gz
Catch invalid simple type that was causing a crash
Although the type passes a check that's supposed to find all types with a simple type, and appears to be of a simple type, its primitive type is apparently null. This was causing a segmentation fault. Apparently the code fails to correctly set the primitive type of a pattern-type instance of a union type. Document the known limitation by a QEXPECT_FAIL() in the test; I was unable to find where the primitive type should be set. Task-number: QTBUG-77620 Change-Id: I56b95ed815366c508f71b8af03b6f2a653d338c5 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'src/xmlpatterns/schema/qxsdschemahelper.cpp')
-rw-r--r--src/xmlpatterns/schema/qxsdschemahelper.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/xmlpatterns/schema/qxsdschemahelper.cpp b/src/xmlpatterns/schema/qxsdschemahelper.cpp
index cdaa1c2..ce99ea7 100644
--- a/src/xmlpatterns/schema/qxsdschemahelper.cpp
+++ b/src/xmlpatterns/schema/qxsdschemahelper.cpp
@@ -518,7 +518,7 @@ bool XsdSchemaHelper::constructAndCompare(const DerivedString<TypeString>::Ptr &
const ReportContext::Ptr &context,
const SourceLocationReflection *const sourceLocationReflection)
{
- Q_ASSERT_X(type->category() == SchemaType::SimpleTypeAtomic, Q_FUNC_INFO,
+ Q_ASSERT_X(type && type->category() == SchemaType::SimpleTypeAtomic, Q_FUNC_INFO,
"We can only compare atomic values.");
// we can not cast a xs:String to a xs:QName, so lets go the safe way