summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Klishin <klishinm@vmware.com>2023-04-05 20:35:53 +0400
committerGitHub <noreply@github.com>2023-04-05 20:35:53 +0400
commit673bfce1e204a00e30a6ca9753e19727522ef0a6 (patch)
tree9ab40292902c7a60fcbcae0869087cb324051171
parent4fcf757834ad1b06e859130cdf47d0335bbca52e (diff)
parent67058097c80d53d7895cac4c35924f6f99776f06 (diff)
downloadrabbitmq-server-git-3.12.0-beta.6.tar.gz
Merge pull request #7854 from rabbitmq/mergify/bp/v3.12.x/pr-7853v3.12.0-beta.6
Quorum queues: warn when policy command was not successful (backport #7853)
-rw-r--r--deps/rabbit/src/rabbit_quorum_queue.erl11
1 files changed, 9 insertions, 2 deletions
diff --git a/deps/rabbit/src/rabbit_quorum_queue.erl b/deps/rabbit/src/rabbit_quorum_queue.erl
index 5e5b5d2dcb..aeceae7caf 100644
--- a/deps/rabbit/src/rabbit_quorum_queue.erl
+++ b/deps/rabbit/src/rabbit_quorum_queue.erl
@@ -976,8 +976,15 @@ maybe_delete_data_dir(UId) ->
policy_changed(Q) ->
QPid = amqqueue:get_pid(Q),
- _ = rabbit_fifo_client:update_machine_state(QPid, ra_machine_config(Q)),
- ok.
+ case rabbit_fifo_client:update_machine_state(QPid, ra_machine_config(Q)) of
+ ok ->
+ ok;
+ Err ->
+ FormattedQueueName = rabbit_misc:rs(amqqueue:get_name(Q)),
+ rabbit_log:warning("~s: policy may not have been successfully applied. Error: ~p",
+ [FormattedQueueName, Err]),
+ ok
+ end.
-spec cluster_state(Name :: atom()) -> 'down' | 'recovering' | 'running'.