1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
|
%% The contents of this file are subject to the Mozilla Public License
%% Version 1.1 (the "License"); you may not use this file except in
%% compliance with the License. You may obtain a copy of the License
%% at https://www.mozilla.org/MPL/
%%
%% Software distributed under the License is distributed on an "AS IS"
%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
%% the License for the specific language governing rights and
%% limitations under the License.
%%
%% The Original Code is RabbitMQ.
%%
%% The Initial Developer of the Original Code is GoPivotal, Inc.
%% Copyright (c) 2018-2019 Pivotal Software, Inc. All rights reserved.
%%
%% @author The RabbitMQ team
%% @copyright 2018-2019 Pivotal Software, Inc.
%%
%% @doc
%% This module offers a framework to declare capabilities a RabbitMQ node
%% supports and therefore a way to determine if multiple RabbitMQ nodes in
%% a cluster are compatible and can work together.
%%
%% == What a feature flag is ==
%%
%% A <strong>feature flag</strong> is a name and several properties given
%% to a change in RabbitMQ which impacts its communication with other
%% RabbitMQ nodes. This kind of change can be:
%% <ul>
%% <li>an update to an Erlang record</li>
%% <li>a modification to a replicated Mnesia table schema</li>
%% <li>a modification to Erlang messages exchanged between Erlang processes
%% which might run on remote nodes</li>
%% </ul>
%%
%% A feature flag is qualified by:
%% <ul>
%% <li>a <strong>name</strong></li>
%% <li>a <strong>description</strong> (optional)</li>
%% <li>a list of other <strong>feature flags this feature flag depends on
%% </strong> (optional). This can be useful when the change builds up on
%% top of a previous change. For instance, it expands a record which was
%% already modified by a previous feature flag.</li>
%% <li>a <strong>migration function</strong> (optional). If provided, this
%% function is called when the feature flag is enabled. It is responsible
%% for doing all the data conversion, if any, and confirming the feature
%% flag can be enabled.</li>
%% <li>a level of stability (stable or experimental). For now, this is only
%% informational. But it might be used for specific purposes in the
%% future.</li>
%% </ul>
%%
%% == How to declare a feature flag ==
%%
%% To define a new feature flag, you need to use the
%% `rabbitmq_feature_flag()' module attribute:
%%
%% ```
%% -rabitmq_feature_flag(FeatureFlag).
%% '''
%%
%% `FeatureFlag' is a {@type feature_flag_modattr()}.
%%
%% == How to enable a feature flag ==
%%
%% To enable a supported feature flag, you have the following solutions:
%%
%% <ul>
%% <li>Using this module API:
%% ```
%% rabbit_feature_flags:enable(FeatureFlagName).
%% '''
%% </li>
%% <li>Using the `rabbitmqctl' CLI:
%% ```
%% rabbitmqctl enable_feature_flag "$feature_flag_name"
%% '''
%% </li>
%% </ul>
%%
%% == How to disable a feature flag ==
%%
%% Once enabled, there is <strong>currently no way to disable</strong> a
%% feature flag.
-module(rabbit_feature_flags).
-export([list/0,
list/1,
list/2,
enable/1,
enable_all/0,
disable/1,
disable_all/0,
is_supported/1,
is_supported/2,
is_supported_locally/1,
is_supported_remotely/1,
is_supported_remotely/2,
is_supported_remotely/3,
is_enabled/1,
is_enabled/2,
is_disabled/1,
is_disabled/2,
info/0,
info/1,
init/0,
get_state/1,
get_stability/1,
check_node_compatibility/1,
check_node_compatibility/2,
is_node_compatible/1,
is_node_compatible/2,
sync_feature_flags_with_cluster/2,
sync_feature_flags_with_cluster/3,
refresh_feature_flags_after_app_load/1,
enabled_feature_flags_list_file/0
]).
%% RabbitMQ internal use only.
-export([initialize_registry/0,
initialize_registry/1,
mark_as_enabled_locally/2,
remote_nodes/0,
running_remote_nodes/0,
does_node_support/3,
merge_feature_flags_from_unknown_apps/1,
do_sync_feature_flags_with_node/1]).
-ifdef(TEST).
-export([initialize_registry/3,
query_supported_feature_flags/0,
mark_as_enabled_remotely/2,
mark_as_enabled_remotely/4]).
-endif.
%% Default timeout for operations on remote nodes.
-define(TIMEOUT, 60000).
-define(FF_REGISTRY_LOADING_LOCK, {feature_flags_registry_loading, self()}).
-define(FF_STATE_CHANGE_LOCK, {feature_flags_state_change, self()}).
-type feature_flag_modattr() :: {feature_name(),
feature_props()}.
%% The value of a `-rabbitmq_feature_flag()' module attribute used to
%% declare a new feature flag.
-type feature_name() :: atom().
%% The feature flag's name. It is used in many places to identify a
%% specific feature flag. In particular, this is how an end-user (or
%% the CLI) can enable a feature flag. This is also the only bit which
%% is persisted so a node remember which feature flags are enabled.
-type feature_props() :: #{desc => string(),
doc_url => string(),
stability => stability(),
depends_on => [feature_name()],
migration_fun => migration_fun_name()}.
%% The feature flag properties.
%%
%% All properties are optional.
%%
%% The properties are:
%% <ul>
%% <li>`desc': a description of the feature flag</li>
%% <li>`doc_url': a URL pointing to more documentation about the feature
%% flag</li>
%% <li>`stability': the level of stability</li>
%% <li>`depends_on': a list of feature flags name which must be enabled
%% before this one</li>
%% <li>`migration_fun': a migration function specified by its module and
%% function names</li>
%% </ul>
%%
%% Note that the `migration_fun' is a {@type migration_fun_name()},
%% not a {@type migration_fun()}. However, the function signature
%% must conform to the {@type migration_fun()} signature. The reason
%% is that we must be able to represent it as an Erlang term when
%% we regenerate the registry module source code (using {@link
%% erl_syntax:abstract/1}).
-type feature_flags() :: #{feature_name() => feature_props_extended()}.
%% The feature flags map as returned or accepted by several functions in
%% this module. In particular, this what the {@link list/0} function
%% returns.
-type feature_props_extended() :: #{desc => string(),
doc_url => string(),
stability => stability(),
migration_fun => migration_fun_name(),
depends_on => [feature_name()],
provided_by => atom()}.
%% The feature flag properties, once expanded by this module when feature
%% flags are discovered.
%%
%% The new properties compared to {@type feature_props()} are:
%% <ul>
%% <li>`provided_by': the name of the application providing the feature flag</li>
%% </ul>
-type feature_state() :: boolean() | state_changing.
%% The state of the feature flag: enabled if `true', disabled if `false'
%% or `state_changing'.
-type feature_states() :: #{feature_name() => feature_state()}.
-type stability() :: stable | experimental.
%% The level of stability of a feature flag. Currently, only informational.
-type migration_fun_name() :: {Module :: atom(), Function :: atom()}.
%% The name of the module and function to call when changing the state of
%% the feature flag.
-type migration_fun() :: fun((feature_name(),
feature_props_extended(),
migration_fun_context())
-> ok | {error, any()} | % context = enable
boolean() | undefined). % context = is_enabled
%% The migration function signature.
%%
%% It is called with context `enable' when a feature flag is being enabled.
%% The function is responsible for this feature-flag-specific verification
%% and data conversion. It returns `ok' if RabbitMQ can mark the feature
%% flag as enabled an continue with the next one, if any. Otherwise, it
%% returns `{error, any()}' if there is an error and the feature flag should
%% remain disabled. The function must be idempotent: if the feature flag is
%% already enabled on another node and the local node is running this function
%% again because it is syncing its feature flags state, it should succeed.
%%
%% It is called with the context `is_enabled' to check if a feature flag
%% is actually enabled. It is useful on RabbitMQ startup, just in case
%% the previous instance failed to write the feature flags list file.
-type migration_fun_context() :: enable | is_enabled.
-export_type([feature_flag_modattr/0,
feature_props/0,
feature_name/0,
feature_flags/0,
feature_props_extended/0,
feature_state/0,
feature_states/0,
stability/0,
migration_fun_name/0,
migration_fun/0,
migration_fun_context/0]).
-on_load(on_load/0).
-spec list() -> feature_flags().
%% @doc
%% Lists all supported feature flags.
%%
%% @returns A map of all supported feature flags.
list() -> list(all).
-spec list(Which :: all | enabled | disabled) -> feature_flags().
%% @doc
%% Lists all, enabled or disabled feature flags, depending on the argument.
%%
%% @param Which The group of feature flags to return: `all', `enabled' or
%% `disabled'.
%% @returns A map of selected feature flags.
list(all) -> rabbit_ff_registry:list(all);
list(enabled) -> rabbit_ff_registry:list(enabled);
list(disabled) -> maps:filter(
fun(FeatureName, _) -> is_disabled(FeatureName) end,
list(all)).
-spec list(all | enabled | disabled, stability()) -> feature_flags().
%% @doc
%% Lists all, enabled or disabled feature flags, depending on the first
%% argument, only keeping those having the specified stability.
%%
%% @param Which The group of feature flags to return: `all', `enabled' or
%% `disabled'.
%% @param Stability The level of stability used to filter the map of feature
%% flags.
%% @returns A map of selected feature flags.
list(Which, Stability)
when Stability =:= stable orelse Stability =:= experimental ->
maps:filter(fun(_, FeatureProps) ->
Stability =:= get_stability(FeatureProps)
end, list(Which)).
-spec enable(feature_name() | [feature_name()]) -> ok |
{error, Reason :: any()}.
%% @doc
%% Enables the specified feature flag or set of feature flags.
%%
%% @param FeatureName The name or the list of names of feature flags to
%% enable.
%% @returns `ok' if the feature flags (and all the feature flags they
%% depend on) were successfully enabled, or `{error, Reason}' if one
%% feature flag could not be enabled (subsequent feature flags in the
%% dependency tree are left unchanged).
enable(FeatureName) when is_atom(FeatureName) ->
rabbit_log:debug("Feature flag `~s`: REQUEST TO ENABLE",
[FeatureName]),
case is_enabled(FeatureName) of
true ->
rabbit_log:debug("Feature flag `~s`: already enabled",
[FeatureName]),
ok;
false ->
rabbit_log:debug("Feature flag `~s`: not enabled, "
"check if supported by cluster",
[FeatureName]),
%% The feature flag must be supported locally and remotely
%% (i.e. by all members of the cluster).
case is_supported(FeatureName) of
true ->
rabbit_log:info("Feature flag `~s`: supported, "
"attempt to enable...",
[FeatureName]),
do_enable(FeatureName);
false ->
rabbit_log:error("Feature flag `~s`: not supported",
[FeatureName]),
{error, unsupported}
end
end;
enable(FeatureNames) when is_list(FeatureNames) ->
with_feature_flags(FeatureNames, fun enable/1).
-spec enable_all() -> ok | {error, any()}.
%% @doc
%% Enables all supported feature flags.
%%
%% @returns `ok' if the feature flags were successfully enabled,
%% or `{error, Reason}' if one feature flag could not be enabled
%% (subsequent feature flags in the dependency tree are left
%% unchanged).
enable_all() ->
with_feature_flags(maps:keys(list(all)), fun enable/1).
-spec disable(feature_name() | [feature_name()]) -> ok | {error, any()}.
%% @doc
%% Disables the specified feature flag or set of feature flags.
%%
%% @param FeatureName The name or the list of names of feature flags to
%% disable.
%% @returns `ok' if the feature flags (and all the feature flags they
%% depend on) were successfully disabled, or `{error, Reason}' if one
%% feature flag could not be disabled (subsequent feature flags in the
%% dependency tree are left unchanged).
disable(FeatureName) when is_atom(FeatureName) ->
{error, unsupported};
disable(FeatureNames) when is_list(FeatureNames) ->
with_feature_flags(FeatureNames, fun disable/1).
-spec disable_all() -> ok | {error, any()}.
%% @doc
%% Disables all supported feature flags.
%%
%% @returns `ok' if the feature flags were successfully disabled,
%% or `{error, Reason}' if one feature flag could not be disabled
%% (subsequent feature flags in the dependency tree are left
%% unchanged).
disable_all() ->
with_feature_flags(maps:keys(list(all)), fun disable/1).
-spec with_feature_flags([feature_name()],
fun((feature_name()) -> ok | {error, any()})) ->
ok | {error, any()}.
%% @private
with_feature_flags([FeatureName | Rest], Fun) ->
case Fun(FeatureName) of
ok -> with_feature_flags(Rest, Fun);
Error -> Error
end;
with_feature_flags([], _) ->
ok.
-spec is_supported(feature_name() | [feature_name()]) -> boolean().
%% @doc
%% Returns if a single feature flag or a set of feature flags is
%% supported by the entire cluster.
%%
%% This is the same as calling both {@link is_supported_locally/1} and
%% {@link is_supported_remotely/1} with a logical AND.
%%
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @returns `true' if the set of feature flags is entirely supported, or
%% `false' if one of them is not or the RPC timed out.
is_supported(FeatureNames) ->
is_supported_locally(FeatureNames) andalso
is_supported_remotely(FeatureNames).
-spec is_supported(feature_name() | [feature_name()], timeout()) ->
boolean().
%% @doc
%% Returns if a single feature flag or a set of feature flags is
%% supported by the entire cluster.
%%
%% This is the same as calling both {@link is_supported_locally/1} and
%% {@link is_supported_remotely/2} with a logical AND.
%%
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @param Timeout Time in milliseconds after which the RPC gives up.
%% @returns `true' if the set of feature flags is entirely supported, or
%% `false' if one of them is not or the RPC timed out.
is_supported(FeatureNames, Timeout) ->
is_supported_locally(FeatureNames) andalso
is_supported_remotely(FeatureNames, Timeout).
-spec is_supported_locally(feature_name() | [feature_name()]) -> boolean().
%% @doc
%% Returns if a single feature flag or a set of feature flags is
%% supported by the local node.
%%
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @returns `true' if the set of feature flags is entirely supported, or
%% `false' if one of them is not.
is_supported_locally(FeatureName) when is_atom(FeatureName) ->
rabbit_ff_registry:is_supported(FeatureName);
is_supported_locally(FeatureNames) when is_list(FeatureNames) ->
lists:all(fun(F) -> rabbit_ff_registry:is_supported(F) end, FeatureNames).
-spec is_supported_remotely(feature_name() | [feature_name()]) -> boolean().
%% @doc
%% Returns if a single feature flag or a set of feature flags is
%% supported by all remote nodes.
%%
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @returns `true' if the set of feature flags is entirely supported, or
%% `false' if one of them is not or the RPC timed out.
is_supported_remotely(FeatureNames) ->
is_supported_remotely(FeatureNames, ?TIMEOUT).
-spec is_supported_remotely(feature_name() | [feature_name()], timeout()) -> boolean().
%% @doc
%% Returns if a single feature flag or a set of feature flags is
%% supported by all remote nodes.
%%
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @param Timeout Time in milliseconds after which the RPC gives up.
%% @returns `true' if the set of feature flags is entirely supported, or
%% `false' if one of them is not or the RPC timed out.
is_supported_remotely(FeatureName, Timeout) when is_atom(FeatureName) ->
is_supported_remotely([FeatureName], Timeout);
is_supported_remotely([], _) ->
rabbit_log:debug("Feature flags: skipping query for feature flags "
"support as the given list is empty",
[]),
true;
is_supported_remotely(FeatureNames, Timeout) when is_list(FeatureNames) ->
case running_remote_nodes() of
[] ->
rabbit_log:debug("Feature flags: isolated node; "
"skipping remote node query "
"=> consider `~p` supported",
[FeatureNames]),
true;
RemoteNodes ->
rabbit_log:debug("Feature flags: about to query these remote nodes "
"about support for `~p`: ~p",
[FeatureNames, RemoteNodes]),
is_supported_remotely(RemoteNodes, FeatureNames, Timeout)
end.
-spec is_supported_remotely([node()],
feature_name() | [feature_name()],
timeout()) -> boolean().
%% @doc
%% Returns if a single feature flag or a set of feature flags is
%% supported by specified remote nodes.
%%
%% @param RemoteNodes The list of remote nodes to query.
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @param Timeout Time in milliseconds after which the RPC gives up.
%% @returns `true' if the set of feature flags is entirely supported by
%% all nodes, or `false' if one of them is not or the RPC timed out.
is_supported_remotely(_, [], _) ->
rabbit_log:debug("Feature flags: skipping query for feature flags "
"support as the given list is empty",
[]),
true;
is_supported_remotely([Node | Rest], FeatureNames, Timeout) ->
case does_node_support(Node, FeatureNames, Timeout) of
true ->
is_supported_remotely(Rest, FeatureNames, Timeout);
false ->
rabbit_log:debug("Feature flags: stopping query "
"for support for `~p` here",
[FeatureNames]),
false
end;
is_supported_remotely([], FeatureNames, _) ->
rabbit_log:info("Feature flags: all running remote nodes support `~p`",
[FeatureNames]),
true.
-spec is_enabled(feature_name() | [feature_name()]) -> boolean().
%% @doc
%% Returns if a single feature flag or a set of feature flags is
%% enabled.
%%
%% This is the same as calling {@link is_enabled/2} as a `blocking'
%% call.
%%
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @returns `true' if the set of feature flags is enabled, or
%% `false' if one of them is not.
is_enabled(FeatureNames) ->
is_enabled(FeatureNames, blocking).
-spec is_enabled
(feature_name() | [feature_name()], blocking) ->
boolean();
(feature_name() | [feature_name()], non_blocking) ->
feature_state().
%% @doc
%% Returns if a single feature flag or a set of feature flags is
%% enabled.
%%
%% When `blocking' is passed, the function waits (blocks) for the
%% state of a feature flag being disabled or enabled stabilizes before
%% returning its final state.
%%
%% When `non_blocking' is passed, the function returns immediately with
%% the state of the feature flag (`true' if enabled, `false' otherwise)
%% or `state_changing' is the state is being changed at the time of the
%% call.
%%
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @returns `true' if the set of feature flags is enabled,
%% `false' if one of them is not, or `state_changing' if one of them
%% is being worked on. Note that `state_changing' has precedence over
%% `false', so if one is `false' and another one is `state_changing',
%% `state_changing' is returned.
is_enabled(FeatureNames, non_blocking) ->
is_enabled_nb(FeatureNames);
is_enabled(FeatureNames, blocking) ->
case is_enabled_nb(FeatureNames) of
state_changing ->
global:set_lock(?FF_STATE_CHANGE_LOCK),
global:del_lock(?FF_STATE_CHANGE_LOCK),
is_enabled(FeatureNames, blocking);
IsEnabled ->
IsEnabled
end.
is_enabled_nb(FeatureName) when is_atom(FeatureName) ->
rabbit_ff_registry:is_enabled(FeatureName);
is_enabled_nb(FeatureNames) when is_list(FeatureNames) ->
lists:foldl(
fun
(_F, state_changing = Acc) ->
Acc;
(F, false = Acc) ->
case rabbit_ff_registry:is_enabled(F) of
state_changing -> state_changing;
_ -> Acc
end;
(F, _) ->
rabbit_ff_registry:is_enabled(F)
end,
true, FeatureNames).
-spec is_disabled(feature_name() | [feature_name()]) -> boolean().
%% @doc
%% Returns if a single feature flag or one feature flag in a set of
%% feature flags is disabled.
%%
%% This is the same as negating the result of {@link is_enabled/1}.
%%
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @returns `true' if one of the feature flags is disabled, or
%% `false' if they are all enabled.
is_disabled(FeatureNames) ->
is_disabled(FeatureNames, blocking).
-spec is_disabled
(feature_name() | [feature_name()], blocking) ->
boolean();
(feature_name() | [feature_name()], non_blocking) ->
feature_state().
%% @doc
%% Returns if a single feature flag or one feature flag in a set of
%% feature flags is disabled.
%%
%% This is the same as negating the result of {@link is_enabled/2},
%% except that `state_changing' is returned as is.
%%
%% See {@link is_enabled/2} for a description of the `blocking' and
%% `non_blocking' modes.
%%
%% @param FeatureNames The name or a list of names of the feature flag(s)
%% to be checked.
%% @returns `true' if one feature flag in the set of feature flags is
%% disabled, `false' if they are all enabled, or `state_changing' if
%% one of them is being worked on. Note that `state_changing' has
%% precedence over `true', so if one is `true' (i.e. disabled) and
%% another one is `state_changing', `state_changing' is returned.
%%
%% @see is_enabled/2
is_disabled(FeatureName, Blocking) ->
case is_enabled(FeatureName, Blocking) of
state_changing -> state_changing;
IsEnabled -> not IsEnabled
end.
-spec info() -> ok.
%% @doc
%% Displays a table on stdout summing up the supported feature flags,
%% their state and various informations about them.
info() ->
info(#{}).
-spec info(#{color => boolean(),
lines => boolean(),
verbose => non_neg_integer()}) -> ok.
%% @doc
%% Displays a table on stdout summing up the supported feature flags,
%% their state and various informations about them.
%%
%% Supported options are:
%% <ul>
%% <li>`color': a boolean to indicate if colors should be used to
%% highlight some elements.</li>
%% <li>`lines': a boolean to indicate if table borders should be drawn
%% using ASCII lines instead of regular characters.</li>
%% <li>`verbose': a non-negative integer to specify the level of
%% verbosity.</li>
%% </ul>
%%
%% @param Options A map of various options to tune the displayed table.
info(Options) when is_map(Options) ->
rabbit_ff_extra:info(Options).
-spec get_state(feature_name()) -> enabled | disabled | unavailable.
%% @doc
%% Returns the state of a feature flag.
%%
%% The possible states are:
%% <ul>
%% <li>`enabled': the feature flag is enabled.</li>
%% <li>`disabled': the feature flag is supported by all nodes in the
%% cluster but currently disabled.</li>
%% <li>`unavailable': the feature flag is unsupported by at least one
%% node in the cluster and can not be enabled for now.</li>
%% </ul>
%%
%% @param FeatureName The name of the feature flag to check.
%% @returns `enabled', `disabled' or `unavailable'.
get_state(FeatureName) when is_atom(FeatureName) ->
IsEnabled = rabbit_feature_flags:is_enabled(FeatureName),
IsSupported = rabbit_feature_flags:is_supported(FeatureName),
case IsEnabled of
true -> enabled;
false -> case IsSupported of
true -> disabled;
false -> unavailable
end
end.
-spec get_stability(feature_name() | feature_props_extended()) -> stability().
%% @doc
%% Returns the stability of a feature flag.
%%
%% The possible stability levels are:
%% <ul>
%% <li>`stable': the feature flag is stable and will not change in future
%% releases: it can be enabled in production.</li>
%% <li>`experimental': the feature flag is experimental and may change in
%% the future (without a guaranteed upgrade path): enabling it in
%% production is not recommended.</li>
%% <li>`unavailable': the feature flag is unsupported by at least one
%% node in the cluster and can not be enabled for now.</li>
%% </ul>
%%
%% @param FeatureName The name of the feature flag to check.
%% @returns `stable' or `experimental'.
get_stability(FeatureName) when is_atom(FeatureName) ->
case rabbit_ff_registry:get(FeatureName) of
undefined -> undefined;
FeatureProps -> get_stability(FeatureProps)
end;
get_stability(FeatureProps) when is_map(FeatureProps) ->
maps:get(stability, FeatureProps, stable).
%% -------------------------------------------------------------------
%% Feature flags registry.
%% -------------------------------------------------------------------
-spec init() -> ok | no_return().
%% @private
init() ->
%% We want to make sure the `feature_flags` file exists once
%% RabbitMQ was started at least once. This is not required by
%% this module (it works fine if the file is missing) but it helps
%% external tools.
_ = ensure_enabled_feature_flags_list_file_exists(),
%% We also "list" supported feature flags. We are not interested in
%% that list, however, it triggers the first initialization of the
%% registry.
_ = list(all),
ok.
-spec initialize_registry() -> ok | {error, any()} | no_return().
%% @private
%% @doc
%% Initializes or reinitializes the registry.
%%
%% The registry is an Erlang module recompiled at runtime to hold the
%% state of all supported feature flags.
%%
%% That Erlang module is called {@link rabbit_ff_registry}. The initial
%% source code of this module simply calls this function so it is
%% replaced by a proper registry.
%%
%% Once replaced, the registry contains the map of all supported feature
%% flags and their state. This is makes it very efficient to query a
%% feature flag state or property.
%%
%% The registry is local to all RabbitMQ nodes.
initialize_registry() ->
initialize_registry(#{}).
-spec initialize_registry(feature_flags()) ->
ok | {error, any()} | no_return().
%% @private
%% @doc
%% Initializes or reinitializes the registry.
%%
%% See {@link initialize_registry/0} for a description of the registry.
%%
%% This function takes a map of new supported feature flags (so their
%% name and extended properties) to add to the existing known feature
%% flags.
initialize_registry(NewSupportedFeatureFlags) ->
%% The first step is to get the feature flag states: if this is the
%% first time we initialize it, we read the list from disk (the
%% `feature_flags` file). Otherwise we query the existing registry
%% before it is replaced.
RegistryInitialized = rabbit_ff_registry:is_registry_initialized(),
FeatureStates = case RegistryInitialized of
true ->
rabbit_ff_registry:states();
false ->
EnabledFeatureNames =
read_enabled_feature_flags_list(),
list_of_enabled_feature_flags_to_feature_states(
EnabledFeatureNames)
end,
%% We also record if the feature flags state was correctly written
%% to disk. Currently we don't use this information, but in the
%% future, we might want to retry the write if it failed so far.
%%
%% TODO: Retry to write the feature flags state if the first try
%% failed.
WrittenToDisk = case RegistryInitialized of
true ->
rabbit_ff_registry:is_registry_written_to_disk();
false ->
true
end,
initialize_registry(NewSupportedFeatureFlags,
FeatureStates,
WrittenToDisk).
-spec list_of_enabled_feature_flags_to_feature_states([feature_name()]) ->
feature_states().
list_of_enabled_feature_flags_to_feature_states(FeatureNames) ->
maps:from_list([{FeatureName, true} || FeatureName <- FeatureNames]).
-spec initialize_registry(feature_flags(),
feature_states(),
boolean()) ->
ok | {error, any()} | no_return().
%% @private
%% @doc
%% Initializes or reinitializes the registry.
%%
%% See {@link initialize_registry/0} for a description of the registry.
%%
%% This function takes a map of new supported feature flags (so their
%% name and extended properties) to add to the existing known feature
%% flags, a map of the new feature flag states (whether they are
%% enabled, disabled or `state_changing'), and a flag to indicate if the
%% feature flag states was recorded to disk.
%%
%% The latter is used to block callers asking if a feature flag is
%% enabled or disabled while its state is changing.
initialize_registry(NewSupportedFeatureFlags,
NewFeatureStates,
WrittenToDisk) ->
%% We take the feature flags already registered.
RegistryInitialized = rabbit_ff_registry:is_registry_initialized(),
KnownFeatureFlags1 = case RegistryInitialized of
true -> rabbit_ff_registry:list(all);
false -> #{}
end,
%% Query the list (it's a map to be exact) of known
%% supported feature flags. That list comes from the
%% `-rabbitmq_feature_flag().` module attributes exposed by all
%% currently loaded Erlang modules.
KnownFeatureFlags2 = query_supported_feature_flags(),
%% We merge the feature flags we already knew about
%% (KnownFeatureFlags1), those found in the loaded applications
%% (KnownFeatureFlags2) and those specified in arguments
%% (NewSupportedFeatureFlags). The latter come from remote nodes
%% usually: for example, they can come from plugins loaded on remote
%% node but the plugins are missing locally. In this case, we
%% consider those feature flags supported because there is no code
%% locally which would cause issues.
%%
%% It means that the list of feature flags only grows. we don't try
%% to clean it at some point because we want to remember about the
%% feature flags we saw (and their state). It should be fine because
%% that list should remain small.
KnownFeatureFlags = maps:merge(KnownFeatureFlags1,
KnownFeatureFlags2),
AllFeatureFlags = maps:merge(KnownFeatureFlags,
NewSupportedFeatureFlags),
%% Next we want to update the feature states, based on the new
%% states passed as arguments.
FeatureStates0 = case RegistryInitialized of
true ->
maps:merge(rabbit_ff_registry:states(),
NewFeatureStates);
false ->
NewFeatureStates
end,
FeatureStates = maps:filter(
fun(_, true) -> true;
(_, state_changing) -> true;
(_, false) -> false
end, FeatureStates0),
Proceed = does_registry_need_refresh(AllFeatureFlags,
FeatureStates,
WrittenToDisk),
case Proceed of
true ->
rabbit_log:debug("Feature flags: (re)initialize registry", []),
do_initialize_registry(AllFeatureFlags,
FeatureStates,
WrittenToDisk);
false ->
rabbit_log:debug("Feature flags: registry already up-to-date, "
"skipping init", []),
ok
end.
-spec does_registry_need_refresh(feature_flags(),
feature_states(),
boolean()) ->
boolean().
does_registry_need_refresh(AllFeatureFlags,
FeatureStates,
WrittenToDisk) ->
case rabbit_ff_registry:is_registry_initialized() of
true ->
%% Before proceeding with the actual
%% (re)initialization, let's see if there are any
%% changes.
CurrentAllFeatureFlags = rabbit_ff_registry:list(all),
CurrentFeatureStates = rabbit_ff_registry:states(),
CurrentWrittenToDisk = rabbit_ff_registry:is_registry_written_to_disk(),
AllFeatureFlags =/= CurrentAllFeatureFlags orelse
FeatureStates =/= CurrentFeatureStates orelse
WrittenToDisk =/= CurrentWrittenToDisk;
false ->
true
end.
-spec do_initialize_registry(feature_flags(),
feature_states(),
boolean()) ->
ok | {error, any()} | no_return().
%% @private
do_initialize_registry(AllFeatureFlags,
FeatureStates,
WrittenToDisk) ->
%% We log the state of those feature flags.
rabbit_log:info("Feature flags: list of feature flags found:", []),
lists:foreach(
fun(FeatureName) ->
rabbit_log:info(
"Feature flags: [~s] ~s",
[case maps:is_key(FeatureName, FeatureStates) of
true ->
case maps:get(FeatureName, FeatureStates) of
true -> "x";
state_changing -> "~"
end;
false ->
" "
end,
FeatureName])
end, lists:sort(maps:keys(AllFeatureFlags))),
rabbit_log:info("Feature flags: feature flag states written to disk: ~s",
[case WrittenToDisk of
true -> "yes";
false -> "no"
end]),
%% We request the registry to be regenerated and reloaded with the
%% new state.
regen_registry_mod(AllFeatureFlags,
FeatureStates,
WrittenToDisk).
-spec query_supported_feature_flags() -> feature_flags().
%% @private
-ifdef(TEST).
module_attributes_from_testsuite() ->
try
throw(force_exception)
catch
throw:force_exception:Stacktrace ->
Modules = lists:filter(
fun({Mod, _, _, _}) ->
ModS = atom_to_list(Mod),
re:run(ModS, "_SUITE$", [{capture, none}])
=:=
match
end, Stacktrace),
case Modules of
[{Module, _, _, _} | _] ->
ModInfo = Module:module_info(attributes),
Attrs = lists:append(
[Attr || {Name, Attr} <- ModInfo,
Name =:= rabbit_feature_flag]),
case Attrs of
[] -> [];
_ -> [{Module, Module, Attrs}]
end;
_ ->
[]
end
end.
query_supported_feature_flags() ->
rabbit_log:debug(
"Feature flags: query feature flags in loaded applications + test "
"module"),
AttributesPerApp = rabbit_misc:all_module_attributes(rabbit_feature_flag),
AttributesFromTestsuite = module_attributes_from_testsuite(),
AllAttributes = AttributesPerApp ++ AttributesFromTestsuite,
prepare_queried_feature_flags(AllAttributes, #{}).
-else.
query_supported_feature_flags() ->
rabbit_log:debug(
"Feature flags: query feature flags in loaded applications"),
AttributesPerApp = rabbit_misc:all_module_attributes(rabbit_feature_flag),
prepare_queried_feature_flags(AttributesPerApp, #{}).
-endif.
prepare_queried_feature_flags([{App, _Module, Attributes} | Rest],
AllFeatureFlags) ->
rabbit_log:debug("Feature flags: application `~s` "
"has ~b feature flags",
[App, length(Attributes)]),
AllFeatureFlags1 = lists:foldl(
fun({FeatureName, FeatureProps}, AllFF) ->
merge_new_feature_flags(AllFF,
App,
FeatureName,
FeatureProps)
end, AllFeatureFlags, Attributes),
prepare_queried_feature_flags(Rest, AllFeatureFlags1);
prepare_queried_feature_flags([], AllFeatureFlags) ->
AllFeatureFlags.
-spec merge_new_feature_flags(feature_flags(),
atom(),
feature_name(),
feature_props()) -> feature_flags().
%% @private
merge_new_feature_flags(AllFeatureFlags, App, FeatureName, FeatureProps)
when is_atom(FeatureName) andalso is_map(FeatureProps) ->
%% We expand the feature flag properties map with:
%% - the name of the application providing it: only informational
%% for now, but can be handy to understand that a feature flag
%% comes from a plugin.
FeatureProps1 = maps:put(provided_by, App, FeatureProps),
maps:merge(AllFeatureFlags,
#{FeatureName => FeatureProps1}).
-spec regen_registry_mod(feature_flags(),
feature_states(),
boolean()) -> ok | {error, any()} | no_return().
%% @private
regen_registry_mod(AllFeatureFlags,
FeatureStates,
WrittenToDisk) ->
%% Here, we recreate the source code of the `rabbit_ff_registry`
%% module from scratch.
%%
%% IMPORTANT: We want both modules to have the exact same public
%% API in order to simplify the life of developers and their tools
%% (Dialyzer, completion, and so on).
%% -module(rabbit_ff_registry).
ModuleAttr = erl_syntax:attribute(
erl_syntax:atom(module),
[erl_syntax:atom(rabbit_ff_registry)]),
ModuleForm = erl_syntax:revert(ModuleAttr),
%% -export([...]).
ExportAttr = erl_syntax:attribute(
erl_syntax:atom(export),
[erl_syntax:list(
[erl_syntax:arity_qualifier(
erl_syntax:atom(F),
erl_syntax:integer(A))
|| {F, A} <- [{get, 1},
{list, 1},
{states, 0},
{is_supported, 1},
{is_enabled, 1},
{is_registry_initialized, 0},
{is_registry_written_to_disk, 0}]]
)
]
),
ExportForm = erl_syntax:revert(ExportAttr),
%% get(_) -> ...
GetClauses = [erl_syntax:clause(
[erl_syntax:atom(FeatureName)],
[],
[erl_syntax:abstract(maps:get(FeatureName,
AllFeatureFlags))])
|| FeatureName <- maps:keys(AllFeatureFlags)
],
GetUnknownClause = erl_syntax:clause(
[erl_syntax:variable("_")],
[],
[erl_syntax:atom(undefined)]),
GetFun = erl_syntax:function(
erl_syntax:atom(get),
GetClauses ++ [GetUnknownClause]),
GetFunForm = erl_syntax:revert(GetFun),
%% list(_) -> ...
ListAllBody = erl_syntax:abstract(AllFeatureFlags),
ListAllClause = erl_syntax:clause([erl_syntax:atom(all)],
[],
[ListAllBody]),
EnabledFeatureFlags = maps:filter(
fun(FeatureName, _) ->
maps:is_key(FeatureName,
FeatureStates)
andalso
maps:get(FeatureName, FeatureStates)
=:=
true
end, AllFeatureFlags),
ListEnabledBody = erl_syntax:abstract(EnabledFeatureFlags),
ListEnabledClause = erl_syntax:clause(
[erl_syntax:atom(enabled)],
[],
[ListEnabledBody]),
DisabledFeatureFlags = maps:filter(
fun(FeatureName, _) ->
not maps:is_key(FeatureName,
FeatureStates)
end, AllFeatureFlags),
ListDisabledBody = erl_syntax:abstract(DisabledFeatureFlags),
ListDisabledClause = erl_syntax:clause(
[erl_syntax:atom(disabled)],
[],
[ListDisabledBody]),
StateChangingFeatureFlags = maps:filter(
fun(FeatureName, _) ->
maps:is_key(FeatureName,
FeatureStates)
andalso
maps:get(FeatureName, FeatureStates)
=:=
state_changing
end, AllFeatureFlags),
ListStateChangingBody = erl_syntax:abstract(StateChangingFeatureFlags),
ListStateChangingClause = erl_syntax:clause(
[erl_syntax:atom(state_changing)],
[],
[ListStateChangingBody]),
ListFun = erl_syntax:function(
erl_syntax:atom(list),
[ListAllClause,
ListEnabledClause,
ListDisabledClause,
ListStateChangingClause]),
ListFunForm = erl_syntax:revert(ListFun),
%% states() -> ...
StatesBody = erl_syntax:abstract(FeatureStates),
StatesClause = erl_syntax:clause([], [], [StatesBody]),
StatesFun = erl_syntax:function(
erl_syntax:atom(states),
[StatesClause]),
StatesFunForm = erl_syntax:revert(StatesFun),
%% is_supported(_) -> ...
IsSupportedClauses = [erl_syntax:clause(
[erl_syntax:atom(FeatureName)],
[],
[erl_syntax:atom(true)])
|| FeatureName <- maps:keys(AllFeatureFlags)
],
NotSupportedClause = erl_syntax:clause(
[erl_syntax:variable("_")],
[],
[erl_syntax:atom(false)]),
IsSupportedFun = erl_syntax:function(
erl_syntax:atom(is_supported),
IsSupportedClauses ++ [NotSupportedClause]),
IsSupportedFunForm = erl_syntax:revert(IsSupportedFun),
%% is_enabled(_) -> ...
IsEnabledClauses = [erl_syntax:clause(
[erl_syntax:atom(FeatureName)],
[],
[case maps:is_key(FeatureName, FeatureStates) of
true ->
erl_syntax:atom(
maps:get(FeatureName, FeatureStates));
false ->
erl_syntax:atom(false)
end])
|| FeatureName <- maps:keys(AllFeatureFlags)
],
NotEnabledClause = erl_syntax:clause(
[erl_syntax:variable("_")],
[],
[erl_syntax:atom(false)]),
IsEnabledFun = erl_syntax:function(
erl_syntax:atom(is_enabled),
IsEnabledClauses ++ [NotEnabledClause]),
IsEnabledFunForm = erl_syntax:revert(IsEnabledFun),
%% is_registry_initialized() -> ...
IsInitializedClauses = [erl_syntax:clause(
[],
[],
[erl_syntax:atom(true)])
],
IsInitializedFun = erl_syntax:function(
erl_syntax:atom(is_registry_initialized),
IsInitializedClauses),
IsInitializedFunForm = erl_syntax:revert(IsInitializedFun),
%% is_registry_written_to_disk() -> ...
IsWrittenToDiskClauses = [erl_syntax:clause(
[],
[],
[erl_syntax:atom(WrittenToDisk)])
],
IsWrittenToDiskFun = erl_syntax:function(
erl_syntax:atom(is_registry_written_to_disk),
IsWrittenToDiskClauses),
IsWrittenToDiskFunForm = erl_syntax:revert(IsWrittenToDiskFun),
%% Compilation!
Forms = [ModuleForm,
ExportForm,
GetFunForm,
ListFunForm,
StatesFunForm,
IsSupportedFunForm,
IsEnabledFunForm,
IsInitializedFunForm,
IsWrittenToDiskFunForm],
maybe_log_registry_source_code(Forms),
CompileOpts = [return_errors,
return_warnings],
case compile:forms(Forms, CompileOpts) of
{ok, Mod, Bin, _} ->
load_registry_mod(Mod, Bin);
{error, Errors, Warnings} ->
rabbit_log:error("Feature flags: registry compilation:~n"
"Errors: ~p~n"
"Warnings: ~p",
[Errors, Warnings]),
{error, {compilation_failure, Errors, Warnings}}
end.
-ifdef(TEST).
maybe_log_registry_source_code(Forms) ->
case os:getenv("LOG_FF_REGISTRY") of
false ->
ok;
_ ->
rabbit_log:debug(
"== FEATURE FLAGS REGISTRY ==~n"
"~s~n"
"== END ==~n",
[erl_prettypr:format(erl_syntax:form_list(Forms))])
end.
-else.
maybe_log_registry_source_code(_) ->
ok.
-endif.
-spec load_registry_mod(atom(), binary()) ->
ok | {error, any()} | no_return().
%% @private
load_registry_mod(Mod, Bin) ->
rabbit_log:debug("Feature flags: registry module ready, loading it..."),
FakeFilename = "Compiled and loaded by " ++ ?MODULE_STRING,
%% Time to load the new registry, replacing the old one. We use a
%% lock here to synchronize concurrent reloads.
global:set_lock(?FF_REGISTRY_LOADING_LOCK, [node()]),
_ = code:soft_purge(Mod),
_ = code:delete(Mod),
Ret = code:load_binary(Mod, FakeFilename, Bin),
global:del_lock(?FF_REGISTRY_LOADING_LOCK, [node()]),
case Ret of
{module, _} ->
rabbit_log:debug("Feature flags: registry module loaded"),
ok;
{error, Reason} ->
rabbit_log:error("Feature flags: failed to load registry "
"module: ~p", [Reason]),
throw({feature_flag_registry_reload_failure, Reason})
end.
%% -------------------------------------------------------------------
%% Feature flags state storage.
%% -------------------------------------------------------------------
-spec ensure_enabled_feature_flags_list_file_exists() -> ok | {error, any()}.
%% @private
ensure_enabled_feature_flags_list_file_exists() ->
File = enabled_feature_flags_list_file(),
case filelib:is_regular(File) of
true -> ok;
false -> write_enabled_feature_flags_list([])
end.
-spec read_enabled_feature_flags_list() ->
[feature_name()] | no_return().
%% @private
read_enabled_feature_flags_list() ->
case try_to_read_enabled_feature_flags_list() of
{error, Reason} ->
File = enabled_feature_flags_list_file(),
throw({feature_flags_file_read_error, File, Reason});
Ret ->
Ret
end.
-spec try_to_read_enabled_feature_flags_list() ->
[feature_name()] | {error, any()}.
%% @private
try_to_read_enabled_feature_flags_list() ->
File = enabled_feature_flags_list_file(),
case file:consult(File) of
{ok, [List]} ->
List;
{error, enoent} ->
%% If the file is missing, we consider the list of enabled
%% feature flags to be empty.
[];
{error, Reason} = Error ->
rabbit_log:error(
"Feature flags: failed to read the `feature_flags` "
"file at `~s`: ~s",
[File, file:format_error(Reason)]),
Error
end.
-spec write_enabled_feature_flags_list([feature_name()]) ->
ok | no_return().
%% @private
write_enabled_feature_flags_list(FeatureNames) ->
case try_to_write_enabled_feature_flags_list(FeatureNames) of
{error, Reason} ->
File = enabled_feature_flags_list_file(),
throw({feature_flags_file_write_error, File, Reason});
Ret ->
Ret
end.
-spec try_to_write_enabled_feature_flags_list([feature_name()]) ->
ok | {error, any()}.
%% @private
try_to_write_enabled_feature_flags_list(FeatureNames) ->
%% Before writing the new file, we read the existing one. If there
%% are unknown feature flags in that file, we want to keep their
%% state, even though they are unsupported at this time. It could be
%% that a plugin was disabled in the meantime.
PreviouslyEnabled = case try_to_read_enabled_feature_flags_list() of
{error, _} -> [];
List -> List
end,
FeatureNames1 = lists:foldl(
fun(Name, Acc) ->
case is_supported_locally(Name) of
true -> Acc;
false -> [Name | Acc]
end
end, FeatureNames, PreviouslyEnabled),
FeatureNames2 = lists:sort(FeatureNames1),
File = enabled_feature_flags_list_file(),
Content = io_lib:format("~p.~n", [FeatureNames2]),
%% TODO: If we fail to write the the file, we should spawn a process
%% to retry the operation.
case file:write_file(File, Content) of
ok ->
ok;
{error, Reason} = Error ->
rabbit_log:error(
"Feature flags: failed to write the `feature_flags` "
"file at `~s`: ~s",
[File, file:format_error(Reason)]),
Error
end.
-spec enabled_feature_flags_list_file() -> file:filename().
%% @doc
%% Returns the path to the file where the state of feature flags is stored.
%%
%% @returns the path to the file.
enabled_feature_flags_list_file() ->
case application:get_env(rabbit, feature_flags_file) of
{ok, Val} -> Val;
undefined -> throw(feature_flags_file_not_set)
end.
%% -------------------------------------------------------------------
%% Feature flags management: enabling.
%% -------------------------------------------------------------------
-spec do_enable(feature_name()) -> ok | {error, any()} | no_return().
%% @private
do_enable(FeatureName) ->
%% We mark this feature flag as "state changing" before doing the
%% actual state change. We also take a global lock: this permits
%% to block callers asking about a feature flag changing state.
global:set_lock(?FF_STATE_CHANGE_LOCK),
Ret = case mark_as_enabled(FeatureName, state_changing) of
ok ->
case enable_dependencies(FeatureName, true) of
ok ->
case run_migration_fun(FeatureName, enable) of
ok ->
mark_as_enabled(FeatureName, true);
{error, no_migration_fun} ->
mark_as_enabled(FeatureName, true);
Error ->
Error
end;
Error ->
Error
end;
Error ->
Error
end,
case Ret of
ok -> ok;
_ -> mark_as_enabled(FeatureName, false)
end,
global:del_lock(?FF_STATE_CHANGE_LOCK),
Ret.
-spec enable_locally(feature_name()) -> ok | {error, any()} | no_return().
%% @private
enable_locally(FeatureName) when is_atom(FeatureName) ->
case is_enabled(FeatureName) of
true ->
ok;
false ->
rabbit_log:debug(
"Feature flag `~s`: enable locally (as part of feature "
"flag states synchronization)",
[FeatureName]),
do_enable_locally(FeatureName)
end.
-spec do_enable_locally(feature_name()) -> ok | {error, any()} | no_return().
%% @private
do_enable_locally(FeatureName) ->
case enable_dependencies(FeatureName, false) of
ok ->
case run_migration_fun(FeatureName, enable) of
ok ->
mark_as_enabled_locally(FeatureName, true);
{error, no_migration_fun} ->
mark_as_enabled_locally(FeatureName, true);
Error ->
Error
end;
Error ->
Error
end.
-spec enable_dependencies(feature_name(), boolean()) ->
ok | {error, any()} | no_return().
%% @private
enable_dependencies(FeatureName, Everywhere) ->
FeatureProps = rabbit_ff_registry:get(FeatureName),
DependsOn = maps:get(depends_on, FeatureProps, []),
rabbit_log:debug("Feature flag `~s`: enable dependencies: ~p",
[FeatureName, DependsOn]),
enable_dependencies(FeatureName, DependsOn, Everywhere).
-spec enable_dependencies(feature_name(), [feature_name()], boolean()) ->
ok | {error, any()} | no_return().
%% @private
enable_dependencies(TopLevelFeatureName, [FeatureName | Rest], Everywhere) ->
Ret = case Everywhere of
true -> enable(FeatureName);
false -> enable_locally(FeatureName)
end,
case Ret of
ok -> enable_dependencies(TopLevelFeatureName, Rest, Everywhere);
Error -> Error
end;
enable_dependencies(_, [], _) ->
ok.
-spec run_migration_fun(feature_name(), any()) ->
any() | {error, any()}.
%% @private
run_migration_fun(FeatureName, Arg) ->
FeatureProps = rabbit_ff_registry:get(FeatureName),
run_migration_fun(FeatureName, FeatureProps, Arg).
run_migration_fun(FeatureName, FeatureProps, Arg) ->
case maps:get(migration_fun, FeatureProps, none) of
{MigrationMod, MigrationFun}
when is_atom(MigrationMod) andalso is_atom(MigrationFun) ->
rabbit_log:debug("Feature flag `~s`: run migration function ~p "
"with arg: ~p",
[FeatureName, MigrationFun, Arg]),
try
erlang:apply(MigrationMod,
MigrationFun,
[FeatureName, FeatureProps, Arg])
catch
_:Reason:Stacktrace ->
rabbit_log:error("Feature flag `~s`: migration function "
"crashed: ~p~n~p",
[FeatureName, Reason, Stacktrace]),
{error, {migration_fun_crash, Reason, Stacktrace}}
end;
none ->
{error, no_migration_fun};
Invalid ->
rabbit_log:error("Feature flag `~s`: invalid migration "
"function: ~p",
[FeatureName, Invalid]),
{error, {invalid_migration_fun, Invalid}}
end.
-spec mark_as_enabled(feature_name(), feature_state()) ->
any() | {error, any()} | no_return().
%% @private
mark_as_enabled(FeatureName, IsEnabled) ->
case mark_as_enabled_locally(FeatureName, IsEnabled) of
ok ->
mark_as_enabled_remotely(FeatureName, IsEnabled);
Error ->
Error
end.
-spec mark_as_enabled_locally(feature_name(), feature_state()) ->
any() | {error, any()} | no_return().
%% @private
mark_as_enabled_locally(FeatureName, IsEnabled) ->
rabbit_log:info("Feature flag `~s`: mark as enabled=~p",
[FeatureName, IsEnabled]),
EnabledFeatureNames = maps:keys(list(enabled)),
NewEnabledFeatureNames = case IsEnabled of
true ->
[FeatureName | EnabledFeatureNames];
false ->
EnabledFeatureNames -- [FeatureName];
state_changing ->
EnabledFeatureNames
end,
WrittenToDisk = case NewEnabledFeatureNames of
EnabledFeatureNames ->
rabbit_ff_registry:is_registry_written_to_disk();
_ ->
ok =:= try_to_write_enabled_feature_flags_list(
NewEnabledFeatureNames)
end,
initialize_registry(#{},
#{FeatureName => IsEnabled},
WrittenToDisk).
-spec mark_as_enabled_remotely(feature_name(), feature_state()) ->
any() | {error, any()} | no_return().
%% @private
mark_as_enabled_remotely(FeatureName, IsEnabled) ->
Nodes = running_remote_nodes(),
mark_as_enabled_remotely(Nodes, FeatureName, IsEnabled, ?TIMEOUT).
-spec mark_as_enabled_remotely([node()],
feature_name(),
feature_state(),
timeout()) ->
any() | {error, any()} | no_return().
%% @private
mark_as_enabled_remotely([], _FeatureName, _IsEnabled, _Timeout) ->
ok;
mark_as_enabled_remotely(Nodes, FeatureName, IsEnabled, Timeout) ->
T0 = erlang:timestamp(),
Rets = [{Node, rpc:call(Node,
?MODULE,
mark_as_enabled_locally,
[FeatureName, IsEnabled],
Timeout)}
|| Node <- Nodes],
FailedNodes = [Node || {Node, Ret} <- Rets, Ret =/= ok],
case FailedNodes of
[] ->
rabbit_log:debug(
"Feature flags: `~s` successfully marked as enabled=~p on all "
"nodes", [FeatureName, IsEnabled]),
ok;
_ ->
T1 = erlang:timestamp(),
rabbit_log:error(
"Feature flags: failed to mark feature flag `~s` as enabled=~p "
"on the following nodes:", [FeatureName, IsEnabled]),
[rabbit_log:error(
"Feature flags: - ~s: ~p",
[Node, Ret])
|| {Node, Ret} <- Rets,
Ret =/= ok],
NewTimeout = Timeout - (timer:now_diff(T1, T0) div 1000),
if
NewTimeout > 0 ->
rabbit_log:debug(
"Feature flags: retrying with a timeout of ~b "
"milliseconds", [NewTimeout]),
mark_as_enabled_remotely(FailedNodes,
FeatureName,
IsEnabled,
NewTimeout);
true ->
rabbit_log:debug(
"Feature flags: not retrying; RPC went over the "
"~b milliseconds timeout", [Timeout]),
%% FIXME: Is crashing the process the best solution here?
throw(
{failed_to_mark_feature_flag_as_enabled_on_remote_nodes,
FeatureName, IsEnabled, FailedNodes})
end
end.
%% -------------------------------------------------------------------
%% Coordination with remote nodes.
%% -------------------------------------------------------------------
-spec remote_nodes() -> [node()].
%% @private
remote_nodes() ->
mnesia:system_info(db_nodes) -- [node()].
-spec running_remote_nodes() -> [node()].
%% @private
running_remote_nodes() ->
mnesia:system_info(running_db_nodes) -- [node()].
query_running_remote_nodes(Node, Timeout) ->
case rpc:call(Node, mnesia, system_info, [running_db_nodes], Timeout) of
{badrpc, _} = Error -> Error;
Nodes -> Nodes -- [node()]
end.
-spec does_node_support(node(), [feature_name()], timeout()) -> boolean().
%% @private
does_node_support(Node, FeatureNames, Timeout) ->
rabbit_log:debug("Feature flags: querying `~p` support on node ~s...",
[FeatureNames, Node]),
Ret = case node() of
Node ->
is_supported_locally(FeatureNames);
_ ->
run_feature_flags_mod_on_remote_node(
Node, is_supported_locally, [FeatureNames], Timeout)
end,
case Ret of
{error, pre_feature_flags_rabbitmq} ->
%% See run_feature_flags_mod_on_remote_node/4 for
%% an explanation why we consider this node a 3.7.x
%% pre-feature-flags node.
rabbit_log:debug(
"Feature flags: no feature flags support on node `~s`, "
"consider the feature flags unsupported: ~p",
[Node, FeatureNames]),
false;
{error, Reason} ->
rabbit_log:error("Feature flags: error while querying `~p` "
"support on node ~s: ~p",
[FeatureNames, Node, Reason]),
false;
true ->
rabbit_log:debug("Feature flags: node `~s` supports `~p`",
[Node, FeatureNames]),
true;
false ->
rabbit_log:debug("Feature flags: node `~s` does not support `~p`; "
"stopping query here",
[Node, FeatureNames]),
false
end.
-spec check_node_compatibility(node()) -> ok | {error, any()}.
%% @doc
%% Checks if a node is compatible with the local node.
%%
%% To be compatible, the following two conditions must be met:
%% <ol>
%% <li>feature flags enabled on the local node must be supported by the
%% remote node</li>
%% <li>feature flags enabled on the remote node must be supported by the
%% local node</li>
%% </ol>
%%
%% @param Node the name of the remote node to test.
%% @returns `ok' if they are compatible, `{error, Reason}' if they are not.
check_node_compatibility(Node) ->
check_node_compatibility(Node, ?TIMEOUT).
-spec check_node_compatibility(node(), timeout()) -> ok | {error, any()}.
%% @doc
%% Checks if a node is compatible with the local node.
%%
%% See {@link check_node_compatibility/1} for the conditions required to
%% consider two nodes compatible.
%%
%% @param Node the name of the remote node to test.
%% @param Timeout Time in milliseconds after which the RPC gives up.
%% @returns `ok' if they are compatible, `{error, Reason}' if they are not.
%%
%% @see check_node_compatibility/1
check_node_compatibility(Node, Timeout) ->
%% Before checking compatibility, we exchange feature flags from
%% unknown Erlang applications. So we fetch remote feature flags
%% from applications which are not loaded locally, and the opposite.
%%
%% The goal is that such feature flags are not blocking the
%% communication between nodes because the code (which would
%% break) is missing on those nodes. Therefore they should not be
%% considered when determinig compatibility.
exchange_feature_flags_from_unknown_apps(Node, Timeout),
%% FIXME FIXME FIXME
%% Quand on tente de mettre deux nœuds en cluster, on a :
%% Feature flags: starting an unclustered node: all feature flags
%% will be enabled by default
%% Ça ne devrait sans doute pas être le cas...
%% We can now proceed with the actual compatibility check.
rabbit_log:debug("Feature flags: node `~s` compatibility check, part 1/2",
[Node]),
Part1 = local_enabled_feature_flags_is_supported_remotely(Node, Timeout),
rabbit_log:debug("Feature flags: node `~s` compatibility check, part 2/2",
[Node]),
Part2 = remote_enabled_feature_flags_is_supported_locally(Node, Timeout),
case {Part1, Part2} of
{true, true} ->
rabbit_log:debug("Feature flags: node `~s` is compatible", [Node]),
ok;
{false, _} ->
rabbit_log:error("Feature flags: node `~s` is INCOMPATIBLE: "
"feature flags enabled locally are not "
"supported remotely",
[Node]),
{error, incompatible_feature_flags};
{_, false} ->
rabbit_log:error("Feature flags: node `~s` is INCOMPATIBLE: "
"feature flags enabled remotely are not "
"supported locally",
[Node]),
{error, incompatible_feature_flags}
end.
-spec is_node_compatible(node()) -> boolean().
%% @doc
%% Returns if a node is compatible with the local node.
%%
%% This function calls {@link check_node_compatibility/2} and returns
%% `true' the latter returns `ok'. Therefore this is the same code,
%% except that this function returns a boolean, but not the reason of
%% the incompatibility if any.
%%
%% @param Node the name of the remote node to test.
%% @returns `true' if they are compatible, `false' otherwise.
is_node_compatible(Node) ->
is_node_compatible(Node, ?TIMEOUT).
-spec is_node_compatible(node(), timeout()) -> boolean().
%% @doc
%% Returns if a node is compatible with the local node.
%%
%% This function calls {@link check_node_compatibility/2} and returns
%% `true' the latter returns `ok'. Therefore this is the same code,
%% except that this function returns a boolean, but not the reason
%% of the incompatibility if any. If the RPC times out, nodes are
%% considered incompatible.
%%
%% @param Node the name of the remote node to test.
%% @param Timeout Time in milliseconds after which the RPC gives up.
%% @returns `true' if they are compatible, `false' otherwise.
is_node_compatible(Node, Timeout) ->
check_node_compatibility(Node, Timeout) =:= ok.
-spec local_enabled_feature_flags_is_supported_remotely(node(),
timeout()) ->
boolean().
%% @private
local_enabled_feature_flags_is_supported_remotely(Node, Timeout) ->
LocalEnabledFeatureNames = maps:keys(list(enabled)),
is_supported_remotely([Node], LocalEnabledFeatureNames, Timeout).
-spec remote_enabled_feature_flags_is_supported_locally(node(),
timeout()) ->
boolean().
%% @private
remote_enabled_feature_flags_is_supported_locally(Node, Timeout) ->
case query_remote_feature_flags(Node, enabled, Timeout) of
{error, _} ->
false;
RemoteEnabledFeatureFlags when is_map(RemoteEnabledFeatureFlags) ->
RemoteEnabledFeatureNames = maps:keys(RemoteEnabledFeatureFlags),
is_supported_locally(RemoteEnabledFeatureNames)
end.
-spec run_feature_flags_mod_on_remote_node(node(),
atom(),
[term()],
timeout()) ->
term() | {error, term()}.
%% @private
run_feature_flags_mod_on_remote_node(Node, Function, Args, Timeout) ->
case rpc:call(Node, ?MODULE, Function, Args, Timeout) of
{badrpc, {'EXIT',
{undef,
[{?MODULE, Function, Args, []}
| _]}}} ->
%% If rabbit_feature_flags:Function() is undefined
%% on the remote node, we consider it to be a 3.7.x
%% pre-feature-flags node.
%%
%% Theoretically, it could be an older version (3.6.x and
%% older). But the RabbitMQ version consistency check
%% (rabbit_misc:version_minor_equivalent/2) called from
%% rabbit_mnesia:check_rabbit_consistency/2 already blocked
%% this situation from happening before we reach this point.
rabbit_log:debug(
"Feature flags: ~s:~s~p unavailable on node `~s`: "
"assuming it is a RabbitMQ 3.7.x pre-feature-flags node",
[?MODULE, Function, Args, Node]),
{error, pre_feature_flags_rabbitmq};
{badrpc, Reason} = Error ->
rabbit_log:error(
"Feature flags: error while running ~s:~s~p "
"on node `~s`: ~p",
[?MODULE, Function, Args, Node, Reason]),
{error, Error};
Ret ->
Ret
end.
-spec query_remote_feature_flags(node(),
Which :: all | enabled | disabled,
timeout()) ->
feature_flags() | {error, any()}.
%% @private
query_remote_feature_flags(Node, Which, Timeout) ->
rabbit_log:debug("Feature flags: querying ~s feature flags "
"on node `~s`...",
[Which, Node]),
case run_feature_flags_mod_on_remote_node(Node, list, [Which], Timeout) of
{error, pre_feature_flags_rabbitmq} ->
%% See run_feature_flags_mod_on_remote_node/4 for
%% an explanation why we consider this node a 3.7.x
%% pre-feature-flags node.
rabbit_log:debug(
"Feature flags: no feature flags support on node `~s`, "
"consider the list of feature flags empty", [Node]),
#{};
{error, Reason} = Error ->
rabbit_log:error(
"Feature flags: error while querying ~s feature flags "
"on node `~s`: ~p",
[Which, Node, Reason]),
Error;
RemoteFeatureFlags when is_map(RemoteFeatureFlags) ->
RemoteFeatureNames = maps:keys(RemoteFeatureFlags),
rabbit_log:debug("Feature flags: querying ~s feature flags "
"on node `~s` done; ~s features: ~p",
[Which, Node, Which, RemoteFeatureNames]),
RemoteFeatureFlags
end.
-spec merge_feature_flags_from_unknown_apps(feature_flags()) ->
ok | {error, any()}.
%% @private
merge_feature_flags_from_unknown_apps(FeatureFlags)
when is_map(FeatureFlags) ->
LoadedApps = [App || {App, _, _} <- application:loaded_applications()],
FeatureFlagsFromUnknownApps =
maps:fold(
fun(FeatureName, FeatureProps, UnknownFF) ->
case is_supported_locally(FeatureName) of
true ->
UnknownFF;
false ->
FeatureProvider = maps:get(provided_by, FeatureProps),
case lists:member(FeatureProvider, LoadedApps) of
true -> UnknownFF;
false -> maps:put(FeatureName, FeatureProps,
UnknownFF)
end
end
end,
#{},
FeatureFlags),
rabbit_log:debug(
"Feature flags: register feature flags provided by applications "
"unknown locally: ~p",
[maps:keys(FeatureFlagsFromUnknownApps)]),
initialize_registry(FeatureFlagsFromUnknownApps).
exchange_feature_flags_from_unknown_apps(Node, Timeout) ->
%% The first step is to fetch feature flags from Erlang applications
%% we don't know locally (they are loaded remotely, but not
%% locally).
fetch_remote_feature_flags_from_apps_unknown_locally(Node, Timeout),
%% The next step is to do the opposite: push feature flags to remote
%% nodes so they can register those from applications they don't
%% know.
push_local_feature_flags_from_apps_unknown_remotely(Node, Timeout).
fetch_remote_feature_flags_from_apps_unknown_locally(Node, Timeout) ->
RemoteFeatureFlags = query_remote_feature_flags(Node, all, Timeout),
merge_feature_flags_from_unknown_apps(RemoteFeatureFlags).
push_local_feature_flags_from_apps_unknown_remotely(Node, Timeout) ->
LocalFeatureFlags = list(all),
push_local_feature_flags_from_apps_unknown_remotely(
Node, LocalFeatureFlags, Timeout).
push_local_feature_flags_from_apps_unknown_remotely(
Node, FeatureFlags, Timeout)
when map_size(FeatureFlags) > 0 ->
case query_running_remote_nodes(Node, Timeout) of
{badrpc, Reason} ->
{error, Reason};
Nodes ->
lists:foreach(
fun(N) ->
run_feature_flags_mod_on_remote_node(
N,
merge_feature_flags_from_unknown_apps,
[FeatureFlags],
Timeout)
end, Nodes)
end;
push_local_feature_flags_from_apps_unknown_remotely(_, _, _) ->
ok.
-spec sync_feature_flags_with_cluster([node()], boolean()) ->
ok | {error, any()} | no_return().
%% @private
sync_feature_flags_with_cluster(Nodes, NodeIsVirgin) ->
sync_feature_flags_with_cluster(Nodes, NodeIsVirgin, ?TIMEOUT).
-spec sync_feature_flags_with_cluster([node()], boolean(), timeout()) ->
ok | {error, any()} | no_return().
%% @private
sync_feature_flags_with_cluster([], NodeIsVirgin, _) ->
verify_which_feature_flags_are_actually_enabled(),
case NodeIsVirgin of
true ->
FeatureNames = get_forced_feature_flag_names(),
case remote_nodes() of
[] when FeatureNames =:= undefined ->
rabbit_log:debug(
"Feature flags: starting an unclustered node "
"for the first time: all feature flags will be "
"enabled by default"),
enable_all();
[] ->
case FeatureNames of
[] ->
rabbit_log:debug(
"Feature flags: starting an unclustered "
"node for the first time: all feature "
"flags are forcibly left disabled from "
"the RABBITMQ_FEATURE_FLAGS environment "
"variable"),
ok;
_ ->
rabbit_log:debug(
"Feature flags: starting an unclustered "
"node for the first time: only the "
"following feature flags specified in "
"the RABBITMQ_FEATURE_FLAGS environment "
"variable will be enabled: ~p",
[FeatureNames]),
enable(FeatureNames)
end;
_ ->
ok
end;
false ->
rabbit_log:debug(
"Feature flags: starting an unclustered node which is "
"already initialized: all feature flags left in their "
"current state"),
ok
end;
sync_feature_flags_with_cluster(Nodes, _, Timeout) ->
verify_which_feature_flags_are_actually_enabled(),
RemoteNodes = Nodes -- [node()],
sync_feature_flags_with_cluster1(RemoteNodes, Timeout).
sync_feature_flags_with_cluster1([], _) ->
ok;
sync_feature_flags_with_cluster1(RemoteNodes, Timeout) ->
RandomRemoteNode = pick_one_node(RemoteNodes),
rabbit_log:debug("Feature flags: SYNCING FEATURE FLAGS with node `~s`...",
[RandomRemoteNode]),
case query_remote_feature_flags(RandomRemoteNode, enabled, Timeout) of
{error, _} = Error ->
Error;
RemoteFeatureFlags ->
RemoteFeatureNames = maps:keys(RemoteFeatureFlags),
rabbit_log:debug(
"Feature flags: enabling locally feature flags already "
"enabled on node `~s`...",
[RandomRemoteNode]),
case do_sync_feature_flags_with_node(RemoteFeatureNames) of
ok ->
sync_feature_flags_with_cluster2(
RandomRemoteNode, Timeout);
Error ->
Error
end
end.
sync_feature_flags_with_cluster2(RandomRemoteNode, Timeout) ->
LocalFeatureNames = maps:keys(list(enabled)),
rabbit_log:debug(
"Feature flags: enabling on node `~s` feature flags already "
"enabled locally...",
[RandomRemoteNode]),
Ret = run_feature_flags_mod_on_remote_node(
RandomRemoteNode,
do_sync_feature_flags_with_node,
[LocalFeatureNames],
Timeout),
case Ret of
{error, pre_feature_flags_rabbitmq} -> ok;
_ -> Ret
end.
pick_one_node(Nodes) ->
RandomIndex = rand:uniform(length(Nodes)),
lists:nth(RandomIndex, Nodes).
do_sync_feature_flags_with_node([FeatureFlag | Rest]) ->
case enable_locally(FeatureFlag) of
ok -> do_sync_feature_flags_with_node(Rest);
Error -> Error
end;
do_sync_feature_flags_with_node([]) ->
ok.
-spec get_forced_feature_flag_names() -> [feature_name()] | undefined.
%% @private
%% @doc
%% Returns the (possibly empty) list of feature flags the user want
%% to enable out-of-the-box when starting a node for the first time.
%%
%% Without this, the default is to enable all the supported feature
%% flags.
%%
%% There are two ways to specify that list:
%% <ol>
%% <li>Using the `$RABBITMQ_FEATURE_FLAGS' environment variable; for
%% instance `RABBITMQ_FEATURE_FLAGS=quorum_queue,mnevis'.</li>
%% <li>Using the `forced_feature_flags_on_init' configuration parameter;
%% for instance
%% `{rabbit, [{forced_feature_flags_on_init, [quorum_queue, mnevis]}]}'.</li>
%% </ol>
%%
%% The environment variable has precedence over the configuration
%% parameter.
get_forced_feature_flag_names() ->
Ret = case get_forced_feature_flag_names_from_env() of
undefined -> get_forced_feature_flag_names_from_config();
List -> List
end,
case Ret of
undefined -> ok;
[] -> rabbit_log:info("Feature flags: automatic enablement "
"of feature flags disabled (i.e. none "
"will be enabled automatically)", []);
_ -> rabbit_log:info("Feature flags: automatic enablement "
"of feature flags limited to the "
"following list: ~p", [Ret])
end,
Ret.
-spec get_forced_feature_flag_names_from_env() -> [feature_name()] | undefined.
%% @private
get_forced_feature_flag_names_from_env() ->
case os:getenv("RABBITMQ_FEATURE_FLAGS") of
false -> undefined;
Value -> [list_to_atom(V) ||V <- string:lexemes(Value, ",")]
end.
-spec get_forced_feature_flag_names_from_config() -> [feature_name()] | undefined.
%% @private
get_forced_feature_flag_names_from_config() ->
Value = application:get_env(rabbit,
forced_feature_flags_on_init,
undefined),
case Value of
undefined ->
Value;
_ when is_list(Value) ->
case lists:all(fun is_atom/1, Value) of
true -> Value;
false -> undefined
end;
_ ->
undefined
end.
-spec verify_which_feature_flags_are_actually_enabled() ->
ok | {error, any()} | no_return().
%% @private
verify_which_feature_flags_are_actually_enabled() ->
AllFeatureFlags = list(all),
EnabledFeatureNames = read_enabled_feature_flags_list(),
rabbit_log:debug("Feature flags: double-checking feature flag states..."),
%% In case the previous instance of the node failed to write the
%% feature flags list file, we want to double-check the list of
%% enabled feature flags read from disk. For each feature flag,
%% we call the migration function to query if the feature flag is
%% actually enabled.
%%
%% If a feature flag doesn't provide a migration function (or if the
%% function fails), we keep the current state of the feature flag.
List1 = maps:fold(
fun(Name, Props, Acc) ->
Ret = run_migration_fun(Name, Props, is_enabled),
case Ret of
true ->
[Name | Acc];
false ->
Acc;
_ ->
MarkedAsEnabled = is_enabled(Name),
case MarkedAsEnabled of
true -> [Name | Acc];
false -> Acc
end
end
end,
[], AllFeatureFlags),
RepairedEnabledFeatureNames = lists:sort(List1),
%% We log the list of feature flags for which the state changes
%% after the check above.
WereEnabled = RepairedEnabledFeatureNames -- EnabledFeatureNames,
WereDisabled = EnabledFeatureNames -- RepairedEnabledFeatureNames,
case {WereEnabled, WereDisabled} of
{[], []} -> ok;
_ -> rabbit_log:warning(
"Feature flags: the previous instance of this node "
"must have failed to write the `feature_flags` "
"file at `~s`:",
[enabled_feature_flags_list_file()])
end,
case WereEnabled of
[] -> ok;
_ -> rabbit_log:warning(
"Feature flags: - list of previously enabled "
"feature flags now marked as such: ~p", [WereEnabled])
end,
case WereDisabled of
[] -> ok;
_ -> rabbit_log:warning(
"Feature flags: - list of previously disabled "
"feature flags now marked as such: ~p", [WereDisabled])
end,
%% Finally, if the new list of enabled feature flags is different
%% than the one on disk, we write the new list and re-initialize the
%% registry.
case RepairedEnabledFeatureNames of
EnabledFeatureNames ->
ok;
_ ->
rabbit_log:debug(
"Feature flags: write the repaired list of enabled feature "
"flags"),
WrittenToDisk = ok =:= try_to_write_enabled_feature_flags_list(
RepairedEnabledFeatureNames),
initialize_registry(
#{},
list_of_enabled_feature_flags_to_feature_states(
RepairedEnabledFeatureNames),
WrittenToDisk)
end.
-spec refresh_feature_flags_after_app_load([atom()]) ->
ok | {error, any()} | no_return().
refresh_feature_flags_after_app_load([]) ->
ok;
refresh_feature_flags_after_app_load(Apps) ->
rabbit_log:debug(
"Feature flags: new apps loaded: ~p -> refreshing feature flags",
[Apps]),
FeatureFlags0 = list(all),
FeatureFlags1 = query_supported_feature_flags(),
%% The following list contains all the feature flags this node
%% learned about only because remote nodes have them. Now, the
%% applications providing them are loaded locally as well.
%% Therefore, we may run their migration function in case the state
%% of this node needs it.
AlreadySupportedFeatureNames = maps:keys(
maps:filter(
fun(_, #{provided_by := App}) ->
lists:member(App, Apps)
end, FeatureFlags0)),
case AlreadySupportedFeatureNames of
[] ->
ok;
_ ->
rabbit_log:debug(
"Feature flags: new apps loaded: feature flags already "
"supported: ~p",
[lists:sort(AlreadySupportedFeatureNames)])
end,
%% The following list contains all the feature flags no nodes in the
%% cluster knew about before: this is the first time we see them in
%% this instance of the cluster. We need to register them on all
%% nodes.
NewSupportedFeatureFlags = maps:filter(
fun(FeatureName, _) ->
not maps:is_key(FeatureName,
FeatureFlags0)
end, FeatureFlags1),
case maps:keys(NewSupportedFeatureFlags) of
[] ->
ok;
NewSupportedFeatureNames ->
rabbit_log:debug(
"Feature flags: new apps loaded: new feature flags (unseen so "
"far): ~p ",
[lists:sort(NewSupportedFeatureNames)])
end,
case initialize_registry() of
ok ->
Ret = maybe_enable_locally_after_app_load(
AlreadySupportedFeatureNames),
case Ret of
ok ->
share_new_feature_flags_after_app_load(
NewSupportedFeatureFlags, ?TIMEOUT);
Error ->
Error
end;
Error ->
Error
end.
maybe_enable_locally_after_app_load([]) ->
ok;
maybe_enable_locally_after_app_load([FeatureName | Rest]) ->
case is_enabled(FeatureName) of
true ->
case do_enable_locally(FeatureName) of
ok -> maybe_enable_locally_after_app_load(Rest);
Error -> Error
end;
false ->
maybe_enable_locally_after_app_load(Rest)
end.
share_new_feature_flags_after_app_load(FeatureFlags, Timeout) ->
push_local_feature_flags_from_apps_unknown_remotely(
node(), FeatureFlags, Timeout).
on_load() ->
%% The goal of this `on_load()` code server hook is to prevent this
%% module from being loaded in an already running RabbitMQ node if
%% the running version does not have the feature flags subsystem.
%%
%% This situation happens when an upgrade overwrites RabbitMQ files
%% with the node still running. This is the case with many packages:
%% files are updated on disk, then a post-install step takes care of
%% restarting the service.
%%
%% The problem is that if many nodes in a cluster are updated at the
%% same time, one node running the newer version might query feature
%% flags on an old node where this module is already available
%% (because files were already overwritten). This causes the query
%% to report an unexpected answer and the newer node to refuse to
%% start.
%%
%% However, when the module is executed outside of RabbitMQ (for
%% debugging purpose or in the context of EUnit for instance), we
%% want to allow the load. That's why we first check if RabbitMQ is
%% actually running.
case rabbit:is_running() of
true ->
%% RabbitMQ is running.
%%
%% Now we want to differenciate a pre-feature-flags node
%% from one having the subsystem.
%%
%% To do that, we verify if the `feature_flags_file`
%% application environment variable is defined. With a
%% feature-flags-enabled node, this application environment
%% variable is defined by rabbitmq-server(8).
case application:get_env(rabbit, feature_flags_file) of
{ok, _} ->
%% This is a feature-flags-enabled version. Loading
%% the module is permitted.
ok;
_ ->
%% This is a pre-feature-flags version. We deny the
%% load and report why, possibly specifying the
%% version of RabbitMQ.
Vsn = case application:get_key(rabbit, vsn) of
{ok, V} -> V;
undefined -> "unknown version"
end,
"Refusing to load '" ?MODULE_STRING "' on this "
"node. It appears to be running a pre-feature-flags "
"version of RabbitMQ (" ++ Vsn ++ "). This is fine: "
"a newer version of RabbitMQ was deployed on this "
"node, but it was not restarted yet. This warning "
"is probably caused by a remote node querying this "
"node for its feature flags."
end;
false ->
%% RabbitMQ is not running. Loading the module is permitted
%% because this Erlang node will never be queried for its
%% feature flags.
ok
end.
|