summaryrefslogtreecommitdiff
path: root/.github
diff options
context:
space:
mode:
authorOran Agra <oran@redislabs.com>2020-09-13 13:50:23 +0300
committerGitHub <noreply@github.com>2020-09-13 13:50:23 +0300
commited9bfe226289759756126f35583394e5db93048f (patch)
tree1ab7e53b6894d6cc632d6a54fdc35ecf3fbafe7c /.github
parent86511bbbefaeca7be4c7c39d65fd15e4549939ec (diff)
downloadredis-ed9bfe226289759756126f35583394e5db93048f.tar.gz
fix broken PEXPIREAT test (#7791)
This test was nearly always failing on MacOS github actions. This is because of bugs in the test that caused it to nearly always run all 3 attempts and just look at the last one as the pass/fail creteria. i.e. the test was nearly always running all 3 attempts and still sometimes succeed. this is because the break condition was different than the test completion condition. The reason the test succeeded is because the break condition tested the results of all 3 tests (PSETEX/PEXPIRE/PEXPIREAT), but the success check at the end was only testing the result of PSETEX. The reason the PEXPIREAT test nearly always failed is because it was getting the current time wrong: getting the current second and loosing the sub-section time, so the only chance for it to succeed is if it run right when a certain second started. Because i now get the time from redis, adding another round trip, i added another 100ms to the PEXPIRE test to make it less fragile, and also added many more attempts. Adding many more attempts before failure to account for slow platforms, github actions and valgrind
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions