diff options
| author | antirez <antirez@gmail.com> | 2016-12-19 08:53:25 +0100 |
|---|---|---|
| committer | antirez <antirez@gmail.com> | 2016-12-19 08:53:29 +0100 |
| commit | 90a6f7fc98df849a9890ab6e0da4485457bf60cd (patch) | |
| tree | 9731ce7cf0ce5365c2e1bcc24cbb142cf40b36f1 | |
| parent | 2988889db141b5d691ac94e0b64b37884030dea8 (diff) | |
| download | redis-90a6f7fc98df849a9890ab6e0da4485457bf60cd.tar.gz | |
adjustOpenFilesLimit() comment made hopefully more clear.
| -rw-r--r-- | src/server.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/server.c b/src/server.c index 3d5e29bed..aa5b65862 100644 --- a/src/server.c +++ b/src/server.c @@ -1576,7 +1576,10 @@ void adjustOpenFilesLimit(void) { if (bestlimit < maxfiles) { unsigned int old_maxclients = server.maxclients; - server.maxclients = bestlimit-CONFIG_MIN_RESERVED_FDS; /* NOTICE: server.maxclients is unsigned */ + server.maxclients = bestlimit-CONFIG_MIN_RESERVED_FDS; + /* maxclients is unsigned so may overflow: in order + * to check if maxclients is now logically less than 1 + * we test indirectly via bestlimit. */ if (bestlimit <= CONFIG_MIN_RESERVED_FDS) { serverLog(LL_WARNING,"Your current 'ulimit -n' " "of %llu is not enough for the server to start. " |