diff options
author | Binbin <binloveplay1314@qq.com> | 2022-01-17 16:42:13 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-01-17 10:42:13 +0200 |
commit | 26ef5132a6d8866639b9a2bfb27e631e51aa5c2f (patch) | |
tree | c3d999ca4d0c9304d3a553e53a422892d9105d43 /redis.conf | |
parent | d7aeb2ce5f7c1ae8640fd24538393672600b7607 (diff) | |
download | redis-26ef5132a6d8866639b9a2bfb27e631e51aa5c2f.tar.gz |
Fix timing issue in PSETEX/PEXPIRE sub-second expire tests (#10121)
These two tests have a high probability of failure
on MacOS. Or it takes many retries to succeed.
Keys often expire before we can access them.
So this time we try to avoid this by reducing the time
of the first `after`, or removeing the first `after`.
The results of doing `20/81` and `0/101` are:
- PEXPIRE (20/81): 1069/1949
- PEXPIREAT (20/81): 1093/1949
- PEXPIRE (0/101): 31936 / 31936
- PEXPIREAT (0/101): 31936 / 31936
The first number is the number of times that the
test succeeded without any retries.
The second number is the total number of executions.
And we can see that `0/101` doesn't even need an extra
retries. Also reduces the time required for testing.
So in the end we chose `0/100`, i.e. remove the first `after`.
As for `PEXPIREAT`, there is no failure, but we still changed
it together, using `0/201`, after 2W tests, none of them failed.
Diffstat (limited to 'redis.conf')
0 files changed, 0 insertions, 0 deletions