summaryrefslogtreecommitdiff
path: root/src/acl.c
diff options
context:
space:
mode:
authorOran Agra <oran@redislabs.com>2021-07-20 21:48:43 +0300
committerGitHub <noreply@github.com>2021-07-20 21:48:43 +0300
commit32e61ee295beb8a45b66c4488937f17d0cd0fca7 (patch)
tree8354b99dfbd8b27ca38a94319bdf8b8cdf962820 /src/acl.c
parent1895e134a77efd789b1a6daee76a6ba5ec90e516 (diff)
downloadredis-32e61ee295beb8a45b66c4488937f17d0cd0fca7.tar.gz
Fix ACL category for SELECT, WAIT, ROLE, LASTSAVE, READONLY, READWRITE, ASKING (#9208)
- SELECT and WAIT don't read or write from the keyspace (unlike DEL, EXISTS, EXPIRE, DBSIZE, KEYS, etc). they're more similar to AUTH and HELLO (and maybe PING and COMMAND). they only affect the current connection, not the server state, so they should be `@connection`, not `@keyspace` - ROLE, like LASTSAVE is `@admin` (and `@dangerous` like INFO) - ASKING, READONLY, READWRITE are `@connection` too (not `@keyspace`) - Additionally, i'm now documenting the exact meaning of each ACL category so it's clearer which commands belong where.
Diffstat (limited to 'src/acl.c')
-rw-r--r--src/acl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/acl.c b/src/acl.c
index 32c1f5dc3..f52b520dd 100644
--- a/src/acl.c
+++ b/src/acl.c
@@ -60,7 +60,7 @@ static unsigned long nextid = 0; /* Next command id that has not been assigned *
struct ACLCategoryItem {
const char *name;
uint64_t flag;
-} ACLCommandCategories[] = {
+} ACLCommandCategories[] = { /* See redis.conf for details on each category. */
{"keyspace", CMD_CATEGORY_KEYSPACE},
{"read", CMD_CATEGORY_READ},
{"write", CMD_CATEGORY_WRITE},