summaryrefslogtreecommitdiff
path: root/src/aof.c
diff options
context:
space:
mode:
authorBinbin <binloveplay1314@qq.com>2022-07-03 13:34:39 +0800
committerGitHub <noreply@github.com>2022-07-03 08:34:39 +0300
commit2ab6767744a3b31db9cba7445ae6cc94f33b6d51 (patch)
tree65407830780fc8f81ff33ea8ccd17e07ca983433 /src/aof.c
parent35e836c26d40447f337979a61bb8cb3ed0575796 (diff)
downloadredis-2ab6767744a3b31db9cba7445ae6cc94f33b6d51.tar.gz
Always set server.aof_last_write_errno in aof write error (#10917)
The `can_log` variable prevents us from outputting too many error logs. But it should not include the modification of server.aof_last_write_errno. We are doing this because: 1. In the short write case, we always set aof_last_write_errno to ENOSPC, we don't care the `can_log` flag. 2. And we always set aof_last_write_status to C_ERR in aof write error (except for FSYNC_ALWAYS, we exit). So there may be a chance that `aof_last_write_errno` is not right. An innocent bug or just a code cleanup.
Diffstat (limited to 'src/aof.c')
-rw-r--r--src/aof.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/aof.c b/src/aof.c
index c7bde0ac5..dad9c84bf 100644
--- a/src/aof.c
+++ b/src/aof.c
@@ -1132,8 +1132,8 @@ void flushAppendOnlyFile(int force) {
if (can_log) {
serverLog(LL_WARNING,"Error writing to the AOF file: %s",
strerror(errno));
- server.aof_last_write_errno = errno;
}
+ server.aof_last_write_errno = errno;
} else {
if (can_log) {
serverLog(LL_WARNING,"Short write while writing to "