diff options
| author | Roshan Khatri <117414976+roshkhatri@users.noreply.github.com> | 2023-02-02 12:12:16 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-02 12:12:16 -0800 |
| commit | ac3129543882bdb6e17c2953ec2be7c98ef840ba (patch) | |
| tree | f5cfc74e209fcd7141b02d5edfe19eba28a4532c /src/commands.c | |
| parent | 3b260149e0996b8ee12510b0b9508bca56743269 (diff) | |
| download | redis-ac3129543882bdb6e17c2953ec2be7c98ef840ba.tar.gz | |
Added fields to ACL LOG error entries for precise time logging (#11477)
Added 3 fields to the ACL LOG - adds entry_id, timestamp_created and timestamp_last_updated, which updates similar existing log error entries. The pair - entry_id, timestamp_created is a unique identifier of this entry, in case the node dies and is restarted, it can detect that if it's a new series.
The primary use case of Unique id is to uniquely identify the error messages and not to detect if the server has restarted.
entry-id is the sequence number of the entry (starting at 0) since the server process started. Can also be used to check if items were "lost" if they fell between periods.
timestamp-created is the unix-time in ms at the time the entry was first created.
timestamp-last-updated is the unix-time in ms at the time the entry was last updated
Time_created gives the absolute time which better accounts for network time as compared to time since. It can also be older than 60 secs and presently there is no field that can display the original time of creation once the error entry is updated.
The reason of timestamp_last_updated field is that it provides a more precise value for the “last time” an error was seen where as, presently it is only in the 60 second period.
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Diffstat (limited to 'src/commands.c')
| -rw-r--r-- | src/commands.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/commands.c b/src/commands.c index 6eb633114..5db70b487 100644 --- a/src/commands.c +++ b/src/commands.c @@ -4106,7 +4106,10 @@ struct redisCommandArg ACL_GETUSER_Args[] = { /********** ACL LOG ********************/ /* ACL LOG history */ -#define ACL_LOG_History NULL +commandHistory ACL_LOG_History[] = { +{"7.2.0","Added entry ID, timestamp created, and timestamp last updated."}, +{0} +}; /* ACL LOG tips */ #define ACL_LOG_tips NULL |