summaryrefslogtreecommitdiff
path: root/src/debug.c
diff options
context:
space:
mode:
authorBinbin <binloveplay1314@qq.com>2023-02-19 22:33:19 +0800
committerGitHub <noreply@github.com>2023-02-19 16:33:19 +0200
commit521e54f551386eaec3e84ddad052add391059e5e (patch)
treedbac88c48791fb08e04353a133fc24f0ad21c722 /src/debug.c
parent5b61b0dc6d2579ee484fa6cf29bfac59513f84ab (diff)
downloadredis-521e54f551386eaec3e84ddad052add391059e5e.tar.gz
Demoting some of the non-warning messages to notice (#10715)
We have cases where we print information (might be important but by no means an error indicator) with the LL_WARNING level. Demoting these to LL_NOTICE: - oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo - User requested shutdown... This is also true for cases that we encounter a rare but normal situation. Demoting to LL_NOTICE. Examples: - AOF was enabled but there is already another background operation. An AOF background was scheduled to start when possible. - Connection with master lost. base on yoav-steinberg's https://github.com/redis/redis/pull/10650#issuecomment-1112280554 and yossigo's https://github.com/redis/redis/pull/10650#pullrequestreview-967677676
Diffstat (limited to 'src/debug.c')
-rw-r--r--src/debug.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/debug.c b/src/debug.c
index 5a6612223..7a02c332b 100644
--- a/src/debug.c
+++ b/src/debug.c
@@ -575,7 +575,7 @@ NULL
addReplyError(c,"Error trying to load the RDB dump, check server logs.");
return;
}
- serverLog(LL_WARNING,"DB reloaded by DEBUG RELOAD");
+ serverLog(LL_NOTICE,"DB reloaded by DEBUG RELOAD");
addReply(c,shared.ok);
} else if (!strcasecmp(c->argv[1]->ptr,"loadaof")) {
if (server.aof_state != AOF_OFF) flushAppendOnlyFile(1);
@@ -591,7 +591,7 @@ NULL
return;
}
server.dirty = 0; /* Prevent AOF / replication */
- serverLog(LL_WARNING,"Append Only File loaded by DEBUG LOADAOF");
+ serverLog(LL_NOTICE,"Append Only File loaded by DEBUG LOADAOF");
addReply(c,shared.ok);
} else if (!strcasecmp(c->argv[1]->ptr,"drop-cluster-packet-filter") && c->argc == 3) {
long packet_type;
@@ -933,7 +933,7 @@ NULL
addReplyVerbatim(c,buf,strlen(buf),"txt");
}
} else if (!strcasecmp(c->argv[1]->ptr,"change-repl-id") && c->argc == 2) {
- serverLog(LL_WARNING,"Changing replication IDs after receiving DEBUG change-repl-id");
+ serverLog(LL_NOTICE,"Changing replication IDs after receiving DEBUG change-repl-id");
changeReplicationId();
clearReplicationId2();
addReply(c,shared.ok);
@@ -1826,7 +1826,7 @@ void logServerInfo(void) {
decrRefCount(argv[0]);
}
-/* Log certain config values, which can be used for debuggin */
+/* Log certain config values, which can be used for debugging */
void logConfigDebugInfo(void) {
sds configstring;
configstring = getConfigDebugInfo();