summaryrefslogtreecommitdiff
path: root/src/eval.c
diff options
context:
space:
mode:
authorBinbin <binloveplay1314@qq.com>2023-02-19 22:33:19 +0800
committerGitHub <noreply@github.com>2023-02-19 16:33:19 +0200
commit521e54f551386eaec3e84ddad052add391059e5e (patch)
treedbac88c48791fb08e04353a133fc24f0ad21c722 /src/eval.c
parent5b61b0dc6d2579ee484fa6cf29bfac59513f84ab (diff)
downloadredis-521e54f551386eaec3e84ddad052add391059e5e.tar.gz
Demoting some of the non-warning messages to notice (#10715)
We have cases where we print information (might be important but by no means an error indicator) with the LL_WARNING level. Demoting these to LL_NOTICE: - oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo - User requested shutdown... This is also true for cases that we encounter a rare but normal situation. Demoting to LL_NOTICE. Examples: - AOF was enabled but there is already another background operation. An AOF background was scheduled to start when possible. - Connection with master lost. base on yoav-steinberg's https://github.com/redis/redis/pull/10650#issuecomment-1112280554 and yossigo's https://github.com/redis/redis/pull/10650#pullrequestreview-967677676
Diffstat (limited to 'src/eval.c')
-rw-r--r--src/eval.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/eval.c b/src/eval.c
index 84f2bc45e..8ae3061ca 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -790,7 +790,7 @@ int ldbStartSession(client *c) {
/* Log the creation of the child and close the listening
* socket to make sure if the parent crashes a reset is sent
* to the clients. */
- serverLog(LL_WARNING,"Redis forked for debugging eval");
+ serverLog(LL_NOTICE,"Redis forked for debugging eval");
} else {
/* Parent */
listAddNodeTail(ldb.children,(void*)(unsigned long)cp);
@@ -798,7 +798,7 @@ int ldbStartSession(client *c) {
return 0;
}
} else {
- serverLog(LL_WARNING,
+ serverLog(LL_NOTICE,
"Redis synchronous debugging eval session started");
}
@@ -832,10 +832,10 @@ void ldbEndSession(client *c) {
/* If it's a fork()ed session, we just exit. */
if (ldb.forked) {
writeToClient(c,0);
- serverLog(LL_WARNING,"Lua debugging session child exiting");
+ serverLog(LL_NOTICE,"Lua debugging session child exiting");
exitFromChild(0);
} else {
- serverLog(LL_WARNING,
+ serverLog(LL_NOTICE,
"Redis synchronous debugging eval session ended");
}
@@ -879,7 +879,7 @@ void ldbKillForkedSessions(void) {
listRewind(ldb.children,&li);
while((ln = listNext(&li))) {
pid_t pid = (unsigned long) ln->value;
- serverLog(LL_WARNING,"Killing debugging session %ld",(long)pid);
+ serverLog(LL_NOTICE,"Killing debugging session %ld",(long)pid);
kill(pid,SIGKILL);
}
listRelease(ldb.children);