Sanitize dump payload: performance optimizations and tuning

First, if the ziplist header is surely inside the ziplist, do fast path
decoding rather than the careful one.

In that case, streamline the encoding if-else chain to be executed only
once, and the encoding validity tested at the end.

encourage inlining

likely / unlikely hints for speculative execution

Assertion used _exit(1) to tell the compiler that the code after them is
not reachable and get rid of warnings.

But in some cases assertions are placed inside tight loops, and any
piece of code in them can slow down execution (code cache and other
reasons), instead using either abort() or better yet, unreachable
builtin.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/redisassert.h b/src/redisassert.h
index 61ab35a14..dd7920554 100644
--- a/src/redisassert.h
+++ b/src/redisassert.h
@@ -38,10 +38,10 @@
 #ifndef __REDIS_ASSERT_H__
 #define __REDIS_ASSERT_H__
 
-#include <unistd.h> /* for _exit() */
+#include "config.h"
 
-#define assert(_e) ((_e)?(void)0 : (_serverAssert(#_e,__FILE__,__LINE__),_exit(1)))
-#define panic(...) _serverPanic(__FILE__,__LINE__,__VA_ARGS__),_exit(1)
+#define assert(_e) (likely((_e))?(void)0 : (_serverAssert(#_e,__FILE__,__LINE__),redis_unreachable()))
+#define panic(...) _serverPanic(__FILE__,__LINE__,__VA_ARGS__),redis_unreachable()
 
 void _serverAssert(char *estr, char *file, int line);
 void _serverPanic(const char *file, int line, const char *msg, ...);