diff options
| author | perryitay <85821686+perryitay@users.noreply.github.com> | 2022-01-20 09:05:53 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-20 09:05:53 +0200 |
| commit | c4b788230ca034761a0e9f6ca35b4aee4b15d340 (patch) | |
| tree | 50b89484548307841d799786a75e6cc79a5d39d8 /src/script.c | |
| parent | 22172a4aa648374d7076b179dab18de09f72fd52 (diff) | |
| download | redis-c4b788230ca034761a0e9f6ca35b4aee4b15d340.tar.gz | |
Adding module api for processing commands during busy jobs and allow flagging the commands that should be handled at this status (#9963)
Some modules might perform a long-running logic in different stages of Redis lifetime, for example:
* command execution
* RDB loading
* thread safe context
During this long-running logic Redis is not responsive.
This PR offers
1. An API to process events while a busy command is running (`RM_Yield`)
2. A new flag (`ALLOW_BUSY`) to mark the commands that should be handled during busy
jobs which can also be used by modules (`allow-busy`)
3. In slow commands and thread safe contexts, this flag will start rejecting commands with -BUSY only
after `busy-reply-threshold`
4. During loading (`rdb_load` callback), it'll process events right away (not wait for `busy-reply-threshold`),
but either way, the processing is throttled to the server hz rate.
5. Allow modules to Yield to redis background tasks, but not to client commands
* rename `script-time-limit` to `busy-reply-threshold` (an alias to the pre-7.0 `lua-time-limit`)
Co-authored-by: Oran Agra <oran@redislabs.com>
Diffstat (limited to 'src/script.c')
| -rw-r--r-- | src/script.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/script.c b/src/script.c index 8b1545b1a..d99c928ce 100644 --- a/src/script.c +++ b/src/script.c @@ -85,7 +85,7 @@ int scriptInterrupt(scriptRunCtx *run_ctx) { } long long elapsed = elapsedMs(run_ctx->start_time); - if (elapsed < server.script_time_limit) { + if (elapsed < server.busy_reply_threshold) { return SCRIPT_CONTINUE; } |