diff options
author | Oran Agra <oran@redislabs.com> | 2020-08-14 16:05:34 +0300 |
---|---|---|
committer | Oran Agra <oran@redislabs.com> | 2020-12-06 14:54:34 +0200 |
commit | c31055db617a7fedb20c28c245ddad8ed2b11931 (patch) | |
tree | 26a99ffd2567164ec0316252d577964b25103659 /src/t_list.c | |
parent | 01c13bddea6c09e0a60678fa48becd42b0913515 (diff) | |
download | redis-c31055db617a7fedb20c28c245ddad8ed2b11931.tar.gz |
Sanitize dump payload: fuzz tester and fixes for segfaults and leaks it exposed
The test creates keys with various encodings, DUMP them, corrupt the payload
and RESTORES it.
It utilizes the recently added use-exit-on-panic config to distinguish between
asserts and segfaults.
If the restore succeeds, it runs random commands on the key to attempt to
trigger a crash.
It runs in two modes, one with deep sanitation enabled and one without.
In the first one we don't expect any assertions or segfaults, in the second one
we expect assertions, but no segfaults.
We also check for leaks and invalid reads using valgrind, and if we find them
we print the commands that lead to that issue.
Changes in the code (other than the test):
- Replace a few NPD (null pointer deference) flows and division by zero with an
assertion, so that it doesn't fail the test. (since we set the server to use
`exit` rather than `abort` on assertion).
- Fix quite a lot of flows in rdb.c that could have lead to memory leaks in
RESTORE command (since it now responds with an error rather than panic)
- Add a DEBUG flag for SET-SKIP-CHECKSUM-VALIDATION so that the test don't need
to bother with faking a valid checksum
- Remove a pile of code in serverLogObjectDebugInfo which is actually unsafe to
run in the crash report (see comments in the code)
- fix a missing boundary check in lzf_decompress
test suite infra improvements:
- be able to run valgrind checks before the process terminates
- rotate log files when restarting servers
Diffstat (limited to 'src/t_list.c')
-rw-r--r-- | src/t_list.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/t_list.c b/src/t_list.c index acabe7be2..42b4f92df 100644 --- a/src/t_list.c +++ b/src/t_list.c @@ -728,6 +728,7 @@ void lmoveGenericCommand(client *c, int wherefrom, int whereto) { if (checkType(c,dobj,OBJ_LIST)) return; value = listTypePop(sobj,wherefrom); + serverAssert(value); /* assertion for valgrind (avoid NPD) */ /* We saved touched key, and protect it, since lmoveHandlePush * may change the client command argument vector (it does not * currently). */ |