diff options
author | sundb <sundbcn@gmail.com> | 2021-08-10 14:18:49 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-08-10 09:18:49 +0300 |
commit | 02fd76b97cbc5b8ad6f4c81c8538f02c76cbed46 (patch) | |
tree | 7b40fbf03f5003c9993451dfe5b8fd902570ac51 /src/t_stream.c | |
parent | cbda492909cd2fff25263913cd2e1f00bc48a541 (diff) | |
download | redis-02fd76b97cbc5b8ad6f4c81c8538f02c76cbed46.tar.gz |
Replace all usage of ziplist with listpack for t_hash (#8887)
Part one of implementing #8702 (taking hashes first before other types)
## Description of the feature
1. Change ziplist encoded hash objects to listpack encoding.
2. Convert existing ziplists on RDB loading time. an O(n) operation.
## Rdb format changes
1. Add RDB_TYPE_HASH_LISTPACK rdb type.
2. Bump RDB_VERSION to 10
## Interface changes
1. New `hash-max-listpack-entries` config is an alias for `hash-max-ziplist-entries` (same with `hash-max-listpack-value`)
2. OBJECT ENCODING will return `listpack` instead of `ziplist`
## Listpack improvements:
1. Support direct insert, replace integer element (rather than convert back and forth from string)
3. Add more listpack capabilities to match the ziplist ones (like `lpFind`, `lpRandomPairs` and such)
4. Optimize element length fetching, avoid multiple calculations
5. Use inline to avoid function call overhead.
## Tests
1. Add a new test to the RDB load time conversion
2. Adding the listpack unit tests. (based on the one in ziplist.c)
3. Add a few "corrupt payload: fuzzer findings" tests, and slightly modify existing ones.
Co-authored-by: Oran Agra <oran@redislabs.com>
Diffstat (limited to 'src/t_stream.c')
-rw-r--r-- | src/t_stream.c | 20 |
1 files changed, 1 insertions, 19 deletions
diff --git a/src/t_stream.c b/src/t_stream.c index 1b0d012e4..d1b144a8f 100644 --- a/src/t_stream.c +++ b/src/t_stream.c @@ -241,24 +241,6 @@ robj *streamDup(robj *o) { return sobj; } -/* This is just a wrapper for lpAppend() to directly use a 64 bit integer - * instead of a string. */ -unsigned char *lpAppendInteger(unsigned char *lp, int64_t value) { - char buf[LONG_STR_SIZE]; - int slen = ll2string(buf,sizeof(buf),value); - return lpAppend(lp,(unsigned char*)buf,slen); -} - -/* This is just a wrapper for lpReplace() to directly use a 64 bit integer - * instead of a string to replace the current element. The function returns - * the new listpack as return value, and also updates the current cursor - * by updating '*pos'. */ -unsigned char *lpReplaceInteger(unsigned char *lp, unsigned char **pos, int64_t value) { - char buf[LONG_STR_SIZE]; - int slen = ll2string(buf,sizeof(buf),value); - return lpInsert(lp, (unsigned char*)buf, slen, *pos, LP_REPLACE, pos); -} - /* This is a wrapper function for lpGet() to directly get an integer value * from the listpack (that may store numbers as a string), converting * the string if needed. @@ -3577,7 +3559,7 @@ int streamValidateListpackIntegrity(unsigned char *lp, size_t size, int deep) { /* Since we don't want to run validation of all records twice, we'll * run the listpack validation of just the header and do the rest here. */ - if (!lpValidateIntegrity(lp, size, 0)) + if (!lpValidateIntegrity(lp, size, 0, NULL, NULL)) return 0; /* In non-deep mode we just validated the listpack header (encoded size) */ |