diff options
author | Oran Agra <oran@redislabs.com> | 2020-11-03 14:56:57 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-11-03 14:56:57 +0200 |
commit | 9122379abc3b15dfd2af3624586cc1e3f826eb55 (patch) | |
tree | 89013f2bb56f4fc0521f074f4efb5d662f55b073 /src/t_string.c | |
parent | 1a91a2700b24211e90c695d3fdbbfe7e8d75dbe4 (diff) | |
download | redis-9122379abc3b15dfd2af3624586cc1e3f826eb55.tar.gz |
Propagate GETSET and SET-GET as SET (#7957)
- Generates a more backwards compatible command stream
- Slightly more efficient execution in replica/AOF
- Add a test for coverage
Diffstat (limited to 'src/t_string.c')
-rw-r--r-- | src/t_string.c | 25 |
1 files changed, 24 insertions, 1 deletions
diff --git a/src/t_string.c b/src/t_string.c index 188f27dc0..e8b37663d 100644 --- a/src/t_string.c +++ b/src/t_string.c @@ -90,7 +90,7 @@ void setGenericCommand(client *c, int flags, robj *key, robj *val, robj *expire, } if (flags & OBJ_SET_GET) { - getGenericCommand(c); + getGenericCommand(c); } genericSetKey(c,c->db,key,val,flags & OBJ_SET_KEEPTTL,1); @@ -160,6 +160,24 @@ void setCommand(client *c) { c->argv[2] = tryObjectEncoding(c->argv[2]); setGenericCommand(c,flags,c->argv[1],c->argv[2],expire,unit,NULL,NULL); + + /* Propagate without the GET argument */ + if (flags & OBJ_SET_GET) { + int argc = 0; + robj **argv = zmalloc((c->argc-1)*sizeof(robj*)); + for (j=0; j < c->argc; j++) { + char *a = c->argv[j]->ptr; + /* Skip GET which may be repeated multiple times. */ + if (j >= 3 && + (a[0] == 'g' || a[0] == 'G') && + (a[1] == 'e' || a[1] == 'E') && + (a[2] == 't' || a[2] == 'T') && a[3] == '\0') + continue; + argv[argc++] = c->argv[j]; + incrRefCount(c->argv[j]); + } + replaceClientCommandVector(c, argc, argv); + } } void setnxCommand(client *c) { @@ -201,6 +219,11 @@ void getsetCommand(client *c) { setKey(c,c->db,c->argv[1],c->argv[2]); notifyKeyspaceEvent(NOTIFY_STRING,"set",c->argv[1],c->db->id); server.dirty++; + + /* Propagate as SET command */ + robj *setcmd = createStringObject("SET",3); + rewriteClientCommandArgument(c,0,setcmd); + decrRefCount(setcmd); } void setrangeCommand(client *c) { |